@riddledc/riddle-proof 0.5.32 → 0.5.34

package/dist/engine-harness.cjs

@@ -81,6 +81,11 @@ function ensureAction(action) {
 function workflowFile(riddleProofDir, action) {
   return import_node_path.default.join(riddleProofDir, "pipelines", `riddle-proof-${action}.lobster`);
 }
+function asJsonString(value) {
+  if (value === void 0 || value === null || value === "") return "";
+  if (typeof value === "string") return value;
+  return JSON.stringify(value);
+}
 function buildSetupArgs(params, config) {
   if (!params.repo) throw new Error("repo is required for setup/run");
   if (!params.change_request) throw new Error("change_request is required for setup/run");
@@ -96,8 +101,13 @@ function buildSetupArgs(params, config) {
     prod_url: params.prod_url || "",
     capture_script: captureScript,
     success_criteria: params.success_criteria || "",
-    assertions_json: params.assertions_json || "",
+    assertions_json: params.assertions_json || asJsonString(params.assertions),
     verification_mode: params.verification_mode || "proof",
+    resume_session: params.resume_session || "",
+    target_image_url: params.target_image_url || "",
+    target_image_hash: params.target_image_hash || "",
+    viewport_matrix_json: params.viewport_matrix_json || asJsonString(params.viewport_matrix),
+    deterministic_setup_json: params.deterministic_setup_json || asJsonString(params.deterministic_setup),
     reference: requestedReference,
     base_branch: params.base_branch || "main",
     before_ref: params.before_ref || "",
@@ -340,6 +350,44 @@ function normalizedProofAssessment(state = {}) {
     source: source || null
   };
 }
+function objectValue(value) {
+  return value && typeof value === "object" && !Array.isArray(value) ? value : {};
+}
+function normalizedVerificationMode(state = {}) {
+  const bundle = objectValue(state?.evidence_bundle);
+  const bundleMode = String(bundle.verification_mode || "").trim().toLowerCase();
+  if (bundleMode) return bundleMode;
+  return String(state?.verification_mode || "proof").trim().toLowerCase() || "proof";
+}
+function visualDeltaRequiredForState(state = {}) {
+  const bundle = objectValue(state?.evidence_bundle);
+  const contract = objectValue(bundle.artifact_contract);
+  const required = objectValue(contract.required);
+  return required.visual_delta === true || VISUAL_FIRST_MODES.has(normalizedVerificationMode(state));
+}
+function visualDeltaForState(state = {}) {
+  const bundle = objectValue(state?.evidence_bundle);
+  const after = objectValue(bundle.after);
+  const afterDelta = objectValue(after.visual_delta);
+  if (Object.keys(afterDelta).length) return afterDelta;
+  const request = objectValue(state?.proof_assessment_request);
+  return objectValue(request.visual_delta);
+}
+function visualDeltaShipGateReason(state = {}) {
+  if (!visualDeltaRequiredForState(state)) return null;
+  const visualDelta = visualDeltaForState(state);
+  if (visualDelta.status === "measured" && visualDelta.passed === true) return null;
+  const status = String(visualDelta.status || "missing");
+  if (status === "unmeasured") {
+    return "visual_delta.status=unmeasured blocks ready_to_ship for visual/UI proof";
+  }
+  if (status === "measured" && visualDelta.passed === false) {
+    return "visual_delta.status=measured but visual_delta.passed=false blocks ready_to_ship for visual/UI proof";
+  }
+  const reason = String(visualDelta.reason || "").trim();
+  if (reason) return `visual_delta.status=${status} blocks ready_to_ship for visual/UI proof: ${reason}`;
+  return `visual_delta.status=${status} blocks ready_to_ship for visual/UI proof`;
+}
 function requiredBaselineLabelsForState(state = {}) {
   const reference = normalizedReference(state);
   const labels = [];
@@ -355,6 +403,10 @@ function validateShipGate(state = {}) {
   const afterCdn = String(state?.after_cdn || "").trim();
   const verifyStatus = String(state?.verify_status || "").trim();
   const proofAssessment = normalizedProofAssessment(state);
+  const verificationMode = normalizedVerificationMode(state);
+  const visualDelta = visualDeltaForState(state);
+  const visualDeltaRequired = visualDeltaRequiredForState(state);
+  const visualDeltaBlocker = visualDeltaShipGateReason(state);
   const reasons = [];
   if (!["before", "prod", "both"].includes(reference)) {
     reasons.push(`reference must be before, prod, or both; got ${reference}`);
@@ -383,19 +435,26 @@ function validateShipGate(state = {}) {
   if (proofAssessment.decision !== "ready_to_ship") {
     reasons.push("proof_assessment.decision must be ready_to_ship before ship");
   }
+  if (visualDeltaBlocker) {
+    reasons.push(visualDeltaBlocker);
+  }
   return {
     ok: reasons.length === 0,
     reasons,
     required_baselines: requiredBaselines,
     evidence: {
       reference,
+      verification_mode: verificationMode || null,
       prod_url: prodUrl || null,
       before_cdn: beforeCdn || null,
       prod_cdn: prodCdn || null,
       after_cdn: afterCdn || null,
       verify_status: verifyStatus || null,
       proof_assessment_decision: proofAssessment.decision,
-      proof_assessment_source: proofAssessment.source
+      proof_assessment_source: proofAssessment.source,
+      visual_delta_required: visualDeltaRequired,
+      visual_delta_status: typeof visualDelta.status === "string" ? visualDelta.status : null,
+      visual_delta_passed: typeof visualDelta.passed === "boolean" ? visualDelta.passed : null
     }
   };
 }
@@ -440,6 +499,11 @@ function mergeStateFromParams(statePath, params) {
     "success_criteria",
     "assertions_json",
     "verification_mode",
+    "resume_session",
+    "target_image_url",
+    "target_image_hash",
+    "viewport_matrix_json",
+    "deterministic_setup_json",
     "base_branch",
     "before_ref",
     "context",
@@ -541,23 +605,36 @@ function mergeStateFromParams(statePath, params) {
       state.proof_assessment_source = null;
     } else {
       const parsed = JSON.parse(raw);
-      state.proof_assessment = {
+      const assessment = {
         ...parsed,
         source: (parsed?.source || "supervising_agent").toString()
       };
+      const readyBlocker = assessment?.decision === "ready_to_ship" ? visualDeltaShipGateReason({ ...state, proof_assessment: assessment, proof_assessment_source: assessment.source }) : null;
+      if (readyBlocker) {
+        assessment.blocked_decision = assessment.decision;
+        assessment.decision = "needs_richer_proof";
+        if (assessment.recommended_stage === "ship") assessment.recommended_stage = "verify";
+        if (assessment.continue_with_stage === "ship") assessment.continue_with_stage = "verify";
+        const blockers = Array.isArray(assessment.blockers) ? assessment.blockers : [];
+        assessment.blockers = [...blockers, readyBlocker];
+      }
+      state.proof_assessment = assessment;
       state.proof_assessment_source = state.proof_assessment.source;
-      if (typeof parsed?.decision === "string") {
-        state.proof_decision = parsed.decision;
+      if (typeof state.proof_assessment?.decision === "string") {
+        state.proof_decision = state.proof_assessment.decision;
       }
       if (typeof parsed?.summary === "string") {
         state.proof_assessment_summary = normalizeOptionalString(parsed.summary) || null;
       }
-      if (parsed?.decision === "ready_to_ship") {
+      if (state.proof_assessment?.decision === "ready_to_ship") {
         state.merge_recommendation = "ready-to-ship";
-      } else if (typeof parsed?.decision === "string" && parsed.decision.trim()) {
+      } else if (typeof state.proof_assessment?.decision === "string" && state.proof_assessment.decision.trim()) {
         state.merge_recommendation = "do-not-merge";
       }
       appendProofSummaryLine(state, `Supervising proof assessment: ${state.proof_assessment.decision || "unknown"}`);
+      if (readyBlocker) {
+        appendProofSummaryLine(state, `Ready-to-ship assessment blocked: ${readyBlocker}`);
+      }
       if (state.proof_assessment_summary) {
         appendProofSummaryLine(state, `Assessment summary: ${state.proof_assessment_summary}`);
       }
@@ -658,7 +735,10 @@ function summarizeState(state) {
     explicit_stage_gate: Boolean(state.explicit_stage_gate),
     last_requested_advance_stage: state.last_requested_advance_stage || null,
     recon_results: state.recon_results || null,
-    verify_results: state.verify_results || null
+    verify_results: state.verify_results || null,
+    proof_session: state.proof_session || null,
+    parent_proof_session: state.parent_proof_session || null,
+    proof_session_artifact_url: state.proof_session_artifact_url || null
   };
   const parts = [
     state.workspace_ready ? "workspace ready" : "workspace not ready",
@@ -679,7 +759,7 @@ function summarizeState(state) {
     state: selected
   };
 }
-var import_node_fs, import_node_crypto, import_node_path, import_node_url, import_meta, WORKFLOW_STAGE_ORDER, CHECKPOINT_CONTRACT_VERSION, BUNDLED_RIDDLE_PROOF_DIR, RIDDLE_PROOF_DIR_CANDIDATES, CHECKPOINT_CONTRACT_SPECS;
+var import_node_fs, import_node_crypto, import_node_path, import_node_url, import_meta, WORKFLOW_STAGE_ORDER, CHECKPOINT_CONTRACT_VERSION, BUNDLED_RIDDLE_PROOF_DIR, RIDDLE_PROOF_DIR_CANDIDATES, VISUAL_FIRST_MODES, CHECKPOINT_CONTRACT_SPECS;
 var init_proof_run_core = __esm({
   "src/proof-run-core.ts"() {
     "use strict";
@@ -698,6 +778,16 @@ var init_proof_run_core = __esm({
     RIDDLE_PROOF_DIR_CANDIDATES = [
       BUNDLED_RIDDLE_PROOF_DIR
     ];
+    VISUAL_FIRST_MODES = /* @__PURE__ */ new Set([
+      "visual",
+      "render",
+      "interaction",
+      "ui",
+      "layout",
+      "screenshot",
+      "canvas",
+      "animation"
+    ]);
     CHECKPOINT_CONTRACT_SPECS = {
       setup_review: {
         purpose: "Inspect prepared workspace state before moving into recon."
@@ -1624,6 +1714,9 @@ async function executeWorkflow(params, pluginConfig, resolvedConfig) {
     if (reasons.some((reason) => reason.includes("proof_assessment"))) {
       return "resume with riddle_proof_review using decision=ready_to_ship only after the screenshots and semantic evidence visibly prove the request; otherwise choose needs_implementation or needs_richer_proof";
     }
+    if (reasons.some((reason) => reason.includes("visual_delta"))) {
+      return "rerun verify with a measured before/after visual delta, or choose needs_richer_proof instead of ready_to_ship for this visual proof";
+    }
     if (reasons.some((reason) => reason.includes("after_cdn") || reason.includes("verify_status"))) {
       return "rerun verify with stronger proof framing so after evidence is captured before shipping";
     }
@@ -2852,6 +2945,7 @@ function createRunResult(input) {
     merge_recommendation: state.merge_recommendation,
     finalized: state.finalized,
     blocker: state.blocker,
+    proof_session: state.proof_session,
     evidence_bundle: input.evidence_bundle,
     raw: input.raw
   });
@@ -2899,6 +2993,11 @@ function normalizeRunParams(input) {
     success_criteria: input.success_criteria,
     assertions: input.assertions,
     verification_mode: input.verification_mode,
+    resume_session: input.resume_session,
+    target_image_url: input.target_image_url,
+    target_image_hash: input.target_image_hash,
+    viewport_matrix: input.viewport_matrix,
+    deterministic_setup: input.deterministic_setup,
     reference: input.reference,
     base_branch: input.base_branch,
     before_ref: input.before_ref,
@@ -3028,6 +3127,7 @@ function setRunStatus(state, status, at = timestamp()) {
 }
 
 // src/engine-harness.ts
+init_proof_run_core();
 var DEFAULT_MAX_ITERATIONS = 12;
 var DEFAULT_STAGE_ITERATION_LIMITS = {
   setup: 2,
@@ -3292,6 +3392,26 @@ function proofAssessmentContinuation(result, payload) {
   const proof_assessment_json = jsonParam(payload);
   return { ...baseContinuation(result), proof_assessment_json };
 }
+function proofAssessmentVisualBlocker(state, payload) {
+  if (!proofAssessmentRequestsShip(payload)) return null;
+  const source = nonEmptyString(payload.source) || "supervising_agent";
+  return visualDeltaShipGateReason({
+    ...state || {},
+    proof_assessment: { ...payload, source },
+    proof_assessment_source: source
+  });
+}
+function blockedProofAssessmentPayload(payload, blocker) {
+  const blockers = Array.isArray(payload.blockers) ? payload.blockers.filter((item) => typeof item === "string") : [];
+  return {
+    ...payload,
+    blocked_decision: payload.decision || "ready_to_ship",
+    decision: "needs_richer_proof",
+    recommended_stage: payload.recommended_stage === "ship" ? "verify" : payload.recommended_stage || "verify",
+    continue_with_stage: payload.continue_with_stage === "ship" ? "verify" : payload.continue_with_stage || "verify",
+    blockers: [...blockers, blocker]
+  };
+}
 function contextFor(request, state, result) {
   return {
     request,
@@ -3661,6 +3781,20 @@ async function routeCheckpoint(request, state, result, agent, input) {
       summary: assessment.summary,
       details: { payload }
     });
+    const visualBlocker = proofAssessmentVisualBlocker({
+      ...context.fullRiddleState || {},
+      verification_mode: context.fullRiddleState?.verification_mode || request.verification_mode
+    }, payload);
+    if (visualBlocker) {
+      recordEvent(state, {
+        kind: "agent.proof_assessment.blocked",
+        checkpoint,
+        stage: "verify",
+        summary: visualBlocker,
+        details: { payload }
+      });
+      return { next: proofAssessmentContinuation(result, blockedProofAssessmentPayload(payload, visualBlocker)) };
+    }
     if (effectiveShipMode(request, input.config) !== "ship" && proofAssessmentRequestsShip(payload)) {
       return {
         terminal: terminalResult(

package/dist/engine-harness.js

@@ -2,9 +2,10 @@ import {
   createDisabledRiddleProofAgentAdapter,
   readRiddleProofRunStatus,
   runRiddleProofEngineHarness
-} from "./chunk-LIDYNU7Q.js";
-import "./chunk-7ZJAUEUN.js";
-import "./chunk-TMMKRKY5.js";
+} from "./chunk-7R6ZQE3X.js";
+import "./chunk-OASB3CYU.js";
+import "./chunk-4YCWZVBN.js";
+import "./chunk-J2MERROF.js";
 export {
   createDisabledRiddleProofAgentAdapter,
   readRiddleProofRunStatus,