@riddledc/riddle-proof 0.5.27 → 0.5.28

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@riddledc/riddle-proof",
-  "version": "0.5.27",
+  "version": "0.5.28",
   "description": "Reusable Riddle Proof contracts and helpers for evidence-backed agent changes.",
   "license": "MIT",
   "author": "RiddleDC",

package/runtime/lib/ship.py

@@ -82,6 +82,24 @@ def git_stdout(args, repo_dir, timeout=30):
     return result.stdout.strip()
 
 
+def git_checked(args, repo_dir, timeout=120):
+    result = sp.run(['git'] + args, cwd=repo_dir, capture_output=True, text=True, timeout=timeout)
+    if result.returncode != 0:
+        raise SystemExit('git ' + ' '.join(args) + ' failed: ' + (result.stderr or result.stdout)[:300])
+    return result
+
+
+def gh_pr_create_args(title, body, branch):
+    return [
+        'gh', 'pr', 'create',
+        '--draft',
+        '--title', str(title or '').strip() or 'Riddle Proof change',
+        '--body', str(body or ''),
+        '--base', 'main',
+        '--head', str(branch or ''),
+    ]
+
+
 def remote_branch_head(repo_dir, branch):
     result = sp.run(['git', 'ls-remote', 'origin', 'refs/heads/' + branch], cwd=repo_dir, capture_output=True, text=True, timeout=60)
     if result.returncode != 0:
@@ -623,11 +641,11 @@ if lines:
         print('Only ship-noise paths changed; skipping commit.')
     if s.get('pr_url'):
         if staged_paths:
-            git('git commit --amend --no-edit', after_dir)
+            git_checked(['commit', '--amend', '--no-edit'], after_dir)
         push, push_info = push_existing_pr_branch(after_dir, branch, push_target)
     else:
         if staged_paths:
-            git('git commit -m ' + json.dumps(s['commit_message']), after_dir)
+            git_checked(['commit', '-m', s['commit_message']], after_dir)
         push = sp.run(
             ['git', 'push', 'origin', push_target],
             cwd=after_dir,
@@ -657,8 +675,8 @@ else:
 
 # Create PR if needed
 if not s.get('pr_url'):
-    q = sp.run('gh pr list --head "' + branch + '" --json url,number -q ".[0]"',
-               shell=True, cwd=repo_dir, capture_output=True, text=True)
+    q = sp.run(['gh', 'pr', 'list', '--head', branch, '--json', 'url,number', '-q', '.[0]'],
+               cwd=repo_dir, capture_output=True, text=True)
     pr_url = ''
     if q.stdout.strip():
         try:
@@ -667,10 +685,10 @@ if not s.get('pr_url'):
         except:
             pass
     if not pr_url:
-        c = sp.run('gh pr create --draft --title ' + json.dumps(s['commit_message']) +
-                    ' --body ' + json.dumps(s['change_request']) + ' --base main' +
-                    ' --head ' + branch,
-                    shell=True, cwd=repo_dir, capture_output=True, text=True)
+        c = sp.run(gh_pr_create_args(s.get('commit_message', ''), s.get('change_request', ''), branch),
+                    cwd=repo_dir, capture_output=True, text=True)
+        if c.returncode != 0:
+            raise SystemExit('Failed to create PR: ' + (c.stderr or c.stdout)[:500])
         pr_url = c.stdout.strip().splitlines()[-1].strip() if c.returncode == 0 else ''
     s['pr_url'] = pr_url
     s['pr_number'] = pr_url.rstrip('/').split('/')[-1] if pr_url else ''

package/runtime/tests/recon_verify_smoke.py

@@ -1646,6 +1646,42 @@ def run_ship_filters_tool_noise_when_staging():
         shutil.rmtree(tempdir, ignore_errors=True)
 
 
+def run_ship_preserves_literal_backticks_in_args():
+    sys.modules.pop('util', None)
+    source = SHIP_PATH.read_text()
+    helpers_source = source.split('\ns = load_state()', 1)[0]
+    namespace = {'__file__': str(SHIP_PATH)}
+    exec(compile(helpers_source, str(SHIP_PATH), 'exec'), namespace)
+
+    title = 'Change button from `Start Run` to `Launch Run`'
+    body = 'Proof request keeps `Start Run` and `Launch Run` literal.'
+    args = namespace['gh_pr_create_args'](title, body, 'agent/test-backticks')
+    assert args[0:3] == ['gh', 'pr', 'create'], args
+    assert args[args.index('--title') + 1] == title, args
+    assert args[args.index('--body') + 1] == body, args
+
+    tempdir = Path(tempfile.mkdtemp(prefix='riddle-proof-ship-backticks-'))
+    try:
+        sp.run(['git', 'init', '-b', 'main'], cwd=tempdir, check=True, capture_output=True, text=True)
+        sp.run(['git', 'config', 'user.email', 'test@example.com'], cwd=tempdir, check=True)
+        sp.run(['git', 'config', 'user.name', 'Test User'], cwd=tempdir, check=True)
+        (tempdir / 'tracked.txt').write_text('literal backticks\n')
+        sp.run(['git', 'add', 'tracked.txt'], cwd=tempdir, check=True)
+
+        namespace['git_checked'](['commit', '-m', title], str(tempdir))
+        subject = sp.run(
+            ['git', 'log', '-1', '--pretty=%s'],
+            cwd=tempdir,
+            check=True,
+            capture_output=True,
+            text=True,
+        ).stdout.strip()
+        assert subject == title, subject
+        return {'ok': True, 'subject': subject}
+    finally:
+        shutil.rmtree(tempdir, ignore_errors=True)
+
+
 def run_ship_resolves_real_pr_branch():
     sys.modules.pop('util', None)
     source = SHIP_PATH.read_text()
@@ -1728,6 +1764,7 @@ if __name__ == '__main__':
         'ship_structured_after_evidence': run_ship_accepts_structured_after_evidence(),
         'ship_discord_thread_target': run_ship_discord_thread_target(),
         'ship_filters_tool_noise_when_staging': run_ship_filters_tool_noise_when_staging(),
+        'ship_preserves_literal_backticks_in_args': run_ship_preserves_literal_backticks_in_args(),
         'ship_resolves_real_pr_branch': run_ship_resolves_real_pr_branch(),
     }
     print(json.dumps(payload, indent=2))