@rickcedwhat/playwright-smart-table 6.20.1-next.e170fdd → 6.20.1-next.e946424

package/dist/engine/tableIteration.js

@@ -37,6 +37,7 @@ async function runMap(env, callback, options = {}, label = 'map') {
     const tracker = new elementTracker_1.ElementTracker(label);
     log(env.config, `${label}: starting (maxPages=${effectiveMaxPages}, mode=${concurrency}, dedupe=${!!dedupeStrategy})`);
     const results = [];
+    const seenLogicalIndices = new Set();
     try {
         let rowIndex = 0;
         let stopped = false;
@@ -63,9 +64,12 @@ async function runMap(env, callback, options = {}, label = 'map') {
             // #384: overscan rows ABOVE the visible range have already scrolled past and will never
             // re-enter the viewport — collect them now. Only defer rows BELOW the visible range
             // (they'll scroll into view on a later page).
+            //
+            // #417 follow-up: skip viewport filtering on the final scan — there are no more pages
+            // to defer to, so collect all remaining unseen rows regardless of visibility.
             let candidateIndices = allIndices;
             const getVisibleRowIndices = (_f = env.config.strategies.viewport) === null || _f === void 0 ? void 0 : _f.getVisibleRowIndices;
-            if (getVisibleRowIndices) {
+            if (getVisibleRowIndices && !reachedEnd) {
                 const visible = new Set(await getVisibleRowIndices(env.getContext()));
                 const minVisible = visible.size > 0 ? Math.min(...visible) : Infinity;
                 candidateIndices = allIndices.filter(idx => visible.has(idx) || idx < minVisible);
@@ -111,6 +115,13 @@ async function runMap(env, callback, options = {}, label = 'map') {
                         if (stopped && enumIndex > stoppedIndex) {
                             return SKIP;
                         }
+                        // When resolveRowIndex is configured, identical logical indices across pages
+                        // indicate the same record (e.g. re-created DOM elements in recycling
+                        // virtualizers whose WeakMap entry was GC'd). Skip without processing.
+                        if (row.rowIndex !== undefined && seenLogicalIndices.has(row.rowIndex)) {
+                            log(env.config, `${label}: skipping duplicate logical row ${row.rowIndex}`);
+                            return SKIP;
+                        }
                         // Wait for the row to finish loading BEFORE evaluating its dedupe key (Bug #355).
                         // map/forEach/filter process a still-loading row when no timeout is set (unlike
                         // findRows, which skips) — see resolveRowLoading's `noTimeoutAction`.
@@ -141,6 +152,9 @@ async function runMap(env, callback, options = {}, label = 'map') {
                         if (dedupeKeys && dedupeKey !== undefined && result !== SKIP) {
                             dedupeKeys.add(dedupeKey);
                         }
+                        if (row.rowIndex !== undefined && result !== SKIP) {
+                            seenLogicalIndices.add(row.rowIndex);
+                        }
                         return result;
                     }
                     finally {

package/dist/packageVersion.d.ts

@@ -3,4 +3,4 @@
  * Generated by scripts/embed-version.mjs from package.json
  */
 /** Semver of this package. Use in logs or diagnostics to confirm the installed build. */
-export declare const PLAYWRIGHT_SMART_TABLE_VERSION: "6.20.1-next.e170fdd";
+export declare const PLAYWRIGHT_SMART_TABLE_VERSION: "6.20.1-next.e946424";

package/dist/packageVersion.js

@@ -6,4 +6,4 @@ exports.PLAYWRIGHT_SMART_TABLE_VERSION = void 0;
  * Generated by scripts/embed-version.mjs from package.json
  */
 /** Semver of this package. Use in logs or diagnostics to confirm the installed build. */
-exports.PLAYWRIGHT_SMART_TABLE_VERSION = "6.20.1-next.e170fdd";
+exports.PLAYWRIGHT_SMART_TABLE_VERSION = "6.20.1-next.e946424";

package/dist/strategies/pagination.js

@@ -83,6 +83,7 @@ exports.PaginationStrategies = {
                 const scrollTarget = options.scrollTarget
                     ? resolve(options.scrollTarget, root)
                     : root;
+                const beforeScrollTop = await scrollTarget.evaluate((el) => el.scrollTop);
                 const doScroll = async () => {
                     const box = await scrollTarget.boundingBox();
                     const scrollValue = amount * directionMultiplier;
@@ -98,8 +99,16 @@ exports.PaginationStrategies = {
                         await page.mouse.wheel(0, scrollValue);
                     }
                 };
-                // Stabilization: Wait
-                return await stabilization(context, doScroll);
+                // Stabilization: Wait for content to settle
+                const stabilizationResult = await stabilization(context, doScroll);
+                // EOF detection: use scroll position, not stabilization result.
+                // Stabilization may time out for recycling virtualizers when the scroll
+                // amount is small enough to stay within the overscan window (no new rows
+                // rendered), but the scroll position still changed — we haven't reached
+                // the end of the data.
+                const afterScrollTop = await scrollTarget.evaluate((el) => el.scrollTop);
+                const scrollMoved = Math.abs(afterScrollTop - beforeScrollTop) >= 1;
+                return scrollMoved || stabilizationResult;
             };
         };
         const createGoToFirst = () => {

package/dist/utils/elementTracker.js

@@ -18,7 +18,8 @@ class ElementTracker {
             const seenMap = win[trackerId];
             const newIndices = [];
             elements.forEach((el, index) => {
-                const signature = el.textContent || '';
+                const htmlEl = el;
+                const signature = htmlEl.offsetTop + '|' + (el.textContent || '');
                 if (seenMap.get(el) !== signature) {
                     newIndices.push(index);
                 }
@@ -39,8 +40,10 @@ class ElementTracker {
             const seenMap = win[trackerId];
             for (const index of indicesToCommit) {
                 const el = elements[index];
-                if (el)
-                    seenMap.set(el, el.textContent || '');
+                if (el) {
+                    const htmlEl = el;
+                    seenMap.set(el, htmlEl.offsetTop + '|' + (el.textContent || ''));
+                }
             }
         }, [this.id, indices]);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rickcedwhat/playwright-smart-table",
-  "version": "6.20.1-next.e170fdd",
+  "version": "6.20.1-next.e946424",
   "description": "Smart, column-aware table interactions for Playwright",
   "author": "Cedrick Catalan",
   "license": "MIT",