@revopush/code-push-cli 0.0.3 → 0.0.4

package/bin/script/command-executor.js

@@ -1082,7 +1082,7 @@ const releaseReact = (command) => {
         // This is needed to clear the react native bundler cache:
         // https://github.com/facebook/react-native/issues/4289
         .then(() => deleteFolder(`${os.tmpdir()}/react-*`))
-        .then(() => (0, exports.runReactNativeBundleCommand)(bundleName, command.development || false, entryFile, outputFolder, platform, command.sourcemapOutput))
+        .then(() => (0, exports.runReactNativeBundleCommand)(bundleName, command.development || false, entryFile, outputFolder, platform, command.sourcemapOutput, command.extraBundlerOptions))
         .then(async () => {
         const isHermesEnabled = command.useHermes ||
             (platform === "android" && (await (0, react_native_utils_1.getAndroidHermesEnabled)(command.gradleFile))) || // Check if we have to run hermes to compile JS to Byte Code if Hermes is enabled in build.gradle and we're releasing an Android build
@@ -1148,7 +1148,7 @@ function requestAccessKey() {
         });
     });
 }
-const runReactNativeBundleCommand = (bundleName, development, entryFile, outputFolder, platform, sourcemapOutput) => {
+const runReactNativeBundleCommand = (bundleName, development, entryFile, outputFolder, platform, sourcemapOutput, extraBundlerOptions) => {
     const reactNativeBundleArgs = [];
     const envNodeArgs = process.env.CODE_PUSH_NODE_ARGS;
     if (typeof envNodeArgs !== "undefined") {
@@ -1172,6 +1172,9 @@ const runReactNativeBundleCommand = (bundleName, development, entryFile, outputF
     if (sourcemapOutput) {
         reactNativeBundleArgs.push("--sourcemap-output", sourcemapOutput);
     }
+    if (extraBundlerOptions.length > 0) {
+        reactNativeBundleArgs.push(...extraBundlerOptions);
+    }
     (0, exports.log)(chalk.cyan('Running "react-native bundle" command:\n'));
     const reactNativeBundleProcess = (0, exports.spawn)("node", reactNativeBundleArgs);
     (0, exports.log)(`node ${reactNativeBundleArgs.join(" ")}`);

package/bin/script/command-parser.js

@@ -718,6 +718,13 @@ yargs
         demand: false,
         description: "Name of build configuration which specifies the binary version you want to target this release at. For example, 'Debug' or 'Release' (iOS only)",
         type: "string",
+    })
+        .option("extraBundlerOption", {
+        alias: "eo",
+        default: [],
+        demand: false,
+        description: "Option that gets passed to react-native bundler. Can be specified multiple times.",
+        type: "array",
     })
         .check((argv, aliases) => {
         return checkValidReleaseOptions(argv);
@@ -1045,6 +1052,7 @@ function createCommand() {
                     releaseReactCommand.xcodeProjectFile = argv["xcodeProjectFile"];
                     releaseReactCommand.xcodeTargetName = argv["xcodeTargetName"];
                     releaseReactCommand.buildConfigurationName = argv["buildConfigurationName"];
+                    releaseReactCommand.extraBundlerOptions = argv["extraBundlerOption"];
                 }
                 break;
             case "rollback":

package/bin/test/cli.js

@@ -1264,6 +1264,38 @@ describe("CLI", () => {
         })
             .done();
     });
+    it("release-react applies extraBundlerOptions to bundler command", (done) => {
+        var bundleName = "bundle.js";
+        var command = {
+            type: cli.CommandType.releaseReact,
+            appName: "a",
+            appStoreVersion: null,
+            bundleName: bundleName,
+            deploymentName: "Staging",
+            description: "Test default entry file",
+            mandatory: false,
+            rollout: null,
+            platform: "ios",
+            extraBundlerOptions: ["--foo=bar", "--baz"],
+        };
+        ensureInTestAppDirectory();
+        var release = sandbox.stub(cmdexec, "release");
+        cmdexec
+            .execute(command)
+            .then(() => {
+            var releaseCommand = command;
+            releaseCommand.package = path.join(os.tmpdir(), "CodePush");
+            releaseCommand.appStoreVersion = "1.2.3";
+            sinon.assert.calledOnce(spawn);
+            var spawnCommand = spawn.args[0][0];
+            var spawnCommandArgs = spawn.args[0][1].join(" ");
+            assert.equal(spawnCommand, "node");
+            assert.equal(spawnCommandArgs, `${path.join("node_modules", "react-native", "local-cli", "cli.js")} bundle --assets-dest ${path.join(os.tmpdir(), "CodePush")} --bundle-output ${path.join(os.tmpdir(), "CodePush", bundleName)} --dev false --entry-file index.ios.js --platform ios --foo=bar --baz`);
+            assertJsonDescribesObject(JSON.stringify(release.args[0][0], /*replacer=*/ null, /*spacing=*/ 2), releaseCommand);
+            done();
+        })
+            .done();
+    });
     it("sessionList lists session name and expires fields", (done) => {
         var command = {
             type: cli.CommandType.sessionList,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@revopush/code-push-cli",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Management CLI for the CodePush service",
   "main": "./script/cli.js",
   "scripts": {

package/script/command-executor.ts

@@ -1340,7 +1340,8 @@ export const releaseReact = (command: cli.IReleaseReactCommand): Promise<void> =
           entryFile,
           outputFolder,
           platform,
-          command.sourcemapOutput
+          command.sourcemapOutput,
+          command.extraBundlerOptions
         )
       )
       .then(async () => {
@@ -1431,7 +1432,8 @@ export const runReactNativeBundleCommand = (
   entryFile: string,
   outputFolder: string,
   platform: string,
-  sourcemapOutput: string
+  sourcemapOutput: string,
+  extraBundlerOptions: string[]
 ): Promise<void> => {
   const reactNativeBundleArgs: string[] = [];
   const envNodeArgs: string = process.env.CODE_PUSH_NODE_ARGS;
@@ -1461,6 +1463,10 @@ export const runReactNativeBundleCommand = (
     reactNativeBundleArgs.push("--sourcemap-output", sourcemapOutput);
   }
 
+  if (extraBundlerOptions.length > 0) {
+    reactNativeBundleArgs.push(...extraBundlerOptions);
+  }
+
   log(chalk.cyan('Running "react-native bundle" command:\n'));
   const reactNativeBundleProcess = spawn("node", reactNativeBundleArgs);
   log(`node ${reactNativeBundleArgs.join(" ")}`);

package/script/command-parser.ts

@@ -840,6 +840,14 @@ yargs
           "Name of build configuration which specifies the binary version you want to target this release at. For example, 'Debug' or 'Release' (iOS only)",
         type: "string",
       })
+      .option("extraBundlerOption", {
+        alias: "eo",
+        default: [],
+        demand: false,
+        description:
+          "Option that gets passed to react-native bundler. Can be specified multiple times.",
+        type: "array",
+      })
       .check((argv: any, aliases: { [aliases: string]: string }): any => {
         return checkValidReleaseOptions(argv);
       });
@@ -1245,6 +1253,7 @@ export function createCommand(): cli.ICommand {
           releaseReactCommand.xcodeProjectFile = argv["xcodeProjectFile"] as any;
           releaseReactCommand.xcodeTargetName = argv["xcodeTargetName"] as any;
           releaseReactCommand.buildConfigurationName = argv["buildConfigurationName"] as any;
+          releaseReactCommand.extraBundlerOptions = argv["extraBundlerOption"] as any;
         }
         break;
 

package/script/types/cli.ts

@@ -206,6 +206,7 @@ export interface IReleaseReactCommand extends IReleaseBaseCommand {
   xcodeProjectFile?: string;
   xcodeTargetName?: string;
   buildConfigurationName?: string;
+  extraBundlerOptions?: string[];
 }
 
 export interface IRollbackCommand extends ICommand {

package/test/cli.ts

@@ -1595,6 +1595,50 @@ describe("CLI", () => {
       .done();
   });
 
+  it("release-react applies extraBundlerOptions to bundler command", (done: Mocha.Done): void => {
+    var bundleName = "bundle.js";
+    var command: cli.IReleaseReactCommand = {
+      type: cli.CommandType.releaseReact,
+      appName: "a",
+      appStoreVersion: null,
+      bundleName: bundleName,
+      deploymentName: "Staging",
+      description: "Test default entry file",
+      mandatory: false,
+      rollout: null,
+      platform: "ios",
+      extraBundlerOptions: ["--foo=bar", "--baz"],
+    };
+
+    ensureInTestAppDirectory();
+
+    var release: sinon.SinonSpy = sandbox.stub(cmdexec, "release");
+
+    cmdexec
+      .execute(command)
+      .then(() => {
+        var releaseCommand: cli.IReleaseCommand = <any>command;
+        releaseCommand.package = path.join(os.tmpdir(), "CodePush");
+        releaseCommand.appStoreVersion = "1.2.3";
+
+        sinon.assert.calledOnce(spawn);
+        var spawnCommand: string = spawn.args[0][0];
+        var spawnCommandArgs: string = spawn.args[0][1].join(" ");
+        assert.equal(spawnCommand, "node");
+        assert.equal(
+          spawnCommandArgs,
+          `${path.join("node_modules", "react-native", "local-cli", "cli.js")} bundle --assets-dest ${path.join(
+            os.tmpdir(),
+            "CodePush"
+          )} --bundle-output ${path.join(os.tmpdir(), "CodePush", bundleName)} --dev false --entry-file index.ios.js --platform ios --foo=bar --baz`
+        );
+        assertJsonDescribesObject(JSON.stringify(release.args[0][0], /*replacer=*/ null, /*spacing=*/ 2), releaseCommand);
+
+        done();
+      })
+      .done();
+  });
+
   it("sessionList lists session name and expires fields", (done: Mocha.Done): void => {
     var command: cli.IAccessKeyListCommand = {
       type: cli.CommandType.sessionList,