@revisium/orchestrator 0.1.0-alpha.4 → 0.1.0-alpha.5

package/control-plane/bootstrap.config.json

@@ -149,6 +149,7 @@
       "id": "steps",
       "schema": {
         "type": "object",
+        "description": "DEPRECATED/unused — runtime path retired (audit §3.1, #86); no live path writes or reads a steps row (DBOS owns progress). Table drop deferred — a schema drop on existing control-planes is riskier than retiring the writes; tracked in docs/roadmap.md → Post-MVP cleanup.",
         "additionalProperties": false,
         "properties": {
           "id": {

package/control-plane/default-playbook/catalog/pipelines.json

@@ -11,6 +11,7 @@
       "orchestrator",
       "analyst",
       "reviewer",
+      "triager",
       "developer",
       "integrator",
       "watcher"
@@ -36,7 +37,12 @@
             "approved",
             "clean",
             "blocker",
-            "changes_requested"
+            "changes_requested",
+            "review_changes",
+            "ci_changes",
+            "fix",
+            "wontfix",
+            "question"
           ]
         },
         "nodes": {
@@ -47,8 +53,12 @@
             "next": "planReviewer",
             "onFailure": "abort",
             "resultSchema": "schema:plan",
-            "produces": { "name": "plan" },
-            "incrementCounters": ["planReviewLoop"]
+            "produces": {
+              "name": "plan"
+            },
+            "incrementCounters": [
+              "planReviewLoop"
+            ]
           },
           "planReviewer": {
             "id": "planReviewer",
@@ -57,22 +67,43 @@
             "next": "planReviewRouter",
             "onFailure": "abort",
             "resultSchema": "schema:reviewVerdict",
-            "consumes": [{ "node": "analyst", "as": "plan" }]
+            "consumes": [
+              {
+                "node": "analyst",
+                "as": "plan"
+              }
+            ]
           },
           "planReviewRouter": {
             "id": "planReviewRouter",
             "kind": "choice",
             "branches": [
               {
-                "when": { "op": "verdict.in", "value": ["approved", "clean"] },
+                "when": {
+                  "op": "verdict.in",
+                  "value": [
+                    "approved",
+                    "clean"
+                  ]
+                },
                 "goto": "planGate"
               },
               {
                 "when": {
                   "op": "all",
                   "of": [
-                    { "op": "verdict.in", "value": ["blocker", "changes_requested"] },
-                    { "op": "counter.lt", "scope": "planReviewLoop", "value": 4 }
+                    {
+                      "op": "verdict.in",
+                      "value": [
+                        "blocker",
+                        "changes_requested"
+                      ]
+                    },
+                    {
+                      "op": "counter.lt",
+                      "scope": "planReviewLoop",
+                      "value": 4
+                    }
                   ]
                 },
                 "goto": "analyst"
@@ -109,7 +140,12 @@
             "next": "codeReview",
             "onFailure": "abort",
             "resultSchema": "schema:change",
-            "consumes": [{ "node": "analyst", "as": "plan" }]
+            "consumes": [
+              {
+                "node": "analyst",
+                "as": "plan"
+              }
+            ]
           },
           "codeReview": {
             "id": "codeReview",
@@ -173,7 +209,7 @@
             "id": "integrator",
             "kind": "script",
             "scriptRef": "script:integrator",
-            "next": "watcherPost",
+            "next": "pollPr",
             "catch": [
               {
                 "onError": "revo.ScriptBlocked",
@@ -187,70 +223,219 @@
             "onFailure": "route",
             "resultSchema": "schema:integration"
           },
-          "watcherPost": {
-            "id": "watcherPost",
-            "kind": "agent",
-            "roleRef": "role:watcher",
-            "next": "watcherRouter",
-            "onFailure": "abort",
-            "resultSchema": "schema:watchVerdict"
+          "mergeGate": {
+            "id": "mergeGate",
+            "kind": "humanGate",
+            "reason": "merge-review",
+            "outcomes": [
+              "approved"
+            ],
+            "branches": [
+              {
+                "when": {
+                  "op": "verdict.eq",
+                  "value": "approved"
+                },
+                "goto": "confirmMerge"
+              },
+              {
+                "default": "blockedEnd"
+              }
+            ]
           },
-          "watcherRouter": {
-            "id": "watcherRouter",
+          "confirmMerge": {
+            "id": "confirmMerge",
+            "kind": "script",
+            "scriptRef": "script:confirmMerge",
+            "next": "mergedEnd",
+            "catch": [
+              {
+                "onError": "revo.ScriptBlocked",
+                "goto": "blockedEnd"
+              },
+              {
+                "onError": "revo.ScriptFailed",
+                "goto": "failedEnd"
+              }
+            ],
+            "onFailure": "route",
+            "resultSchema": "schema:integration"
+          },
+          "mergedEnd": {
+            "id": "mergedEnd",
+            "kind": "terminal",
+            "status": "succeeded"
+          },
+          "failedEnd": {
+            "id": "failedEnd",
+            "kind": "terminal",
+            "status": "failed"
+          },
+          "blockedEnd": {
+            "id": "blockedEnd",
+            "kind": "terminal",
+            "status": "blocked"
+          },
+          "pollPr": {
+            "id": "pollPr",
+            "kind": "script",
+            "scriptRef": "script:pollPr",
+            "next": "prRouter",
+            "onFailure": "route",
+            "resultSchema": "schema:prFeedback",
+            "produces": {
+              "name": "prFeedback"
+            },
+            "catch": [
+              {
+                "onError": "revo.ScriptBlocked",
+                "goto": "blockedEnd"
+              },
+              {
+                "onError": "revo.ScriptFailed",
+                "goto": "failedEnd"
+              }
+            ]
+          },
+          "prRouter": {
+            "id": "prRouter",
             "kind": "choice",
             "branches": [
               {
                 "when": {
-                  "op": "verdict.in",
-                  "value": [
-                    "approved",
-                    "clean"
-                  ]
+                  "op": "verdict.eq",
+                  "value": "clean"
                 },
                 "goto": "mergeGate"
               },
+              {
+                "when": {
+                  "op": "verdict.eq",
+                  "value": "review_changes"
+                },
+                "goto": "triage"
+              },
               {
                 "when": {
                   "op": "all",
                   "of": [
                     {
-                      "op": "verdict.in",
-                      "value": [
-                        "blocker",
-                        "changes_requested"
-                      ]
+                      "op": "verdict.eq",
+                      "value": "ci_changes"
                     },
                     {
                       "op": "counter.lt",
-                      "scope": "watcherLoop",
+                      "scope": "ciLoop",
                       "value": 3
                     }
                   ]
                 },
-                "goto": "watcherRework"
+                "goto": "ciRework"
               },
               {
                 "default": "blockedEnd"
               }
             ]
           },
-          "watcherRework": {
-            "id": "watcherRework",
+          "ciRework": {
+            "id": "ciRework",
             "kind": "agent",
             "roleRef": "role:developer",
             "next": "integrator",
             "onFailure": "abort",
             "resultSchema": "schema:change",
             "incrementCounters": [
-              "watcherLoop"
+              "ciLoop"
+            ],
+            "consumes": [
+              {
+                "node": "pollPr",
+                "as": "feedback"
+              }
             ]
           },
-          "mergeGate": {
-            "id": "mergeGate",
+          "triage": {
+            "id": "triage",
+            "kind": "agent",
+            "roleRef": "role:triager",
+            "next": "triageRouter",
+            "onFailure": "abort",
+            "resultSchema": "schema:triage",
+            "produces": {
+              "name": "triage"
+            },
+            "consumes": [
+              {
+                "node": "analyst",
+                "as": "plan",
+                "staleOk": true
+              },
+              {
+                "node": "pollPr",
+                "as": "feedback"
+              }
+            ]
+          },
+          "triageRouter": {
+            "id": "triageRouter",
+            "kind": "choice",
+            "branches": [
+              {
+                "when": {
+                  "op": "all",
+                  "of": [
+                    {
+                      "op": "verdict.eq",
+                      "value": "question"
+                    },
+                    {
+                      "op": "counter.lt",
+                      "scope": "questionLoop",
+                      "value": 3
+                    }
+                  ]
+                },
+                "goto": "questionGate"
+              },
+              {
+                "when": {
+                  "op": "all",
+                  "of": [
+                    {
+                      "op": "verdict.eq",
+                      "value": "fix"
+                    },
+                    {
+                      "op": "counter.lt",
+                      "scope": "reviewLoop",
+                      "value": 3
+                    }
+                  ]
+                },
+                "goto": "reviewRework"
+              },
+              {
+                "when": {
+                  "op": "verdict.eq",
+                  "value": "wontfix"
+                },
+                "goto": "respondThreads"
+              },
+              {
+                "default": "blockedEnd"
+              }
+            ]
+          },
+          "questionGate": {
+            "id": "questionGate",
             "kind": "humanGate",
-            "reason": "merge-review",
+            "reason": "review-question",
             "outcomes": [
-              "approved"
+              "approved",
+              "changes_requested"
+            ],
+            "incrementCounters": [
+              "questionLoop"
             ],
             "branches": [
               {
@@ -258,30 +443,74 @@
                   "op": "verdict.eq",
                   "value": "approved"
                 },
-                "goto": "mergedEnd"
+                "goto": "triage"
               },
               {
                 "default": "blockedEnd"
               }
             ]
           },
-          "mergedEnd": {
-            "id": "mergedEnd",
-            "kind": "terminal",
-            "status": "succeeded"
+          "reviewRework": {
+            "id": "reviewRework",
+            "kind": "agent",
+            "roleRef": "role:developer",
+            "next": "reviewIntegrator",
+            "onFailure": "abort",
+            "resultSchema": "schema:change",
+            "incrementCounters": [
+              "reviewLoop"
+            ],
+            "consumes": [
+              {
+                "node": "triage",
+                "as": "triage"
+              }
+            ]
           },
-          "failedEnd": {
-            "id": "failedEnd",
-            "kind": "terminal",
-            "status": "failed"
+          "reviewIntegrator": {
+            "id": "reviewIntegrator",
+            "kind": "script",
+            "scriptRef": "script:integrator",
+            "next": "respondThreads",
+            "onFailure": "route",
+            "resultSchema": "schema:integration",
+            "catch": [
+              {
+                "onError": "revo.ScriptBlocked",
+                "goto": "blockedEnd"
+              },
+              {
+                "onError": "revo.ScriptFailed",
+                "goto": "failedEnd"
+              }
+            ]
           },
-          "blockedEnd": {
-            "id": "blockedEnd",
-            "kind": "terminal",
-            "status": "blocked"
+          "respondThreads": {
+            "id": "respondThreads",
+            "kind": "script",
+            "scriptRef": "script:respondThreads",
+            "next": "pollPr",
+            "onFailure": "route",
+            "resultSchema": "schema:respond",
+            "consumes": [
+              {
+                "node": "triage",
+                "as": "triage"
+              }
+            ],
+            "catch": [
+              {
+                "onError": "revo.ScriptBlocked",
+                "goto": "blockedEnd"
+              },
+              {
+                "onError": "revo.ScriptFailed",
+                "goto": "failedEnd"
+              }
+            ]
           }
         },
-        "title": "Feature development — plan + merge gates, bounded code-review + watcher rework",
+        "title": "Feature development — plan + merge gates, bounded code-review rework, and a PR review-feedback loop (plan 0018)",
         "policy": {
           "conflicts": [
             [
@@ -300,7 +529,15 @@
             "cap": 3,
             "parent": null
           },
-          "watcherLoop": {
+          "ciLoop": {
+            "cap": 3,
+            "parent": null
+          },
+          "reviewLoop": {
+            "cap": 3,
+            "parent": null
+          },
+          "questionLoop": {
             "cap": 3,
             "parent": null
           }

package/control-plane/default-playbook/catalog/roles.json

@@ -52,5 +52,14 @@
     "allowed_tools": ["Read", "Grep", "Glob", "Bash"],
     "default_model_level": "cheap",
     "runner_id": "claude-code"
+  },
+  {
+    "id": "triager",
+    "path": "prompts/triager.md",
+    "surface": "repo",
+    "rights": "read-only",
+    "allowed_tools": ["Read", "Grep", "Glob", "Bash"],
+    "default_model_level": "deep",
+    "runner_id": "claude-code"
   }
 ]

package/control-plane/default-playbook/prompts/analyst.md

@@ -18,7 +18,9 @@ reviewer can check against. The plan is the artifact a human approves at the pla
 
 ## Output
 
-Emit a structured plan. End your output with a single clear verdict token:
+Put the full ordered plan (problem, scope, files to change, steps, risks, verification) in the result
+`output` — the plan reviewer and the developer receive it verbatim as their input. Set the `verdict` field
+to EXACTLY one of:
 
 - `approved` — the task is well understood and the plan is ready for a developer.
 - `changes_requested` — the request is ambiguous or under-specified; explain what is missing.

package/control-plane/default-playbook/prompts/reviewer.md

@@ -19,10 +19,10 @@ are invoked in the pipeline.
 
 ## Output
 
-End your output with a single clear verdict token:
+Set the result `verdict` field (the pipeline routes on it) to EXACTLY one of these tokens:
 
 - `approved` — proceed; the work is correct and complete (nits are acceptable to defer).
 - `changes_requested` — fixable issues that must be addressed before proceeding.
 - `blocker` — a serious defect or risk that must be resolved (drives the bounded rework loop).
 
-Keep findings actionable. You are read-only: never modify the working tree.
+Put your actionable findings in `output`. You are read-only: never modify the working tree.

package/control-plane/default-playbook/prompts/triager.md

@@ -0,0 +1,51 @@
+# Triager
+
+You are the **triager** role in a software delivery pipeline. You run AFTER the PR is open, when a
+poll has found **unresolved review comments** (from human reviewers or review bots like CodeRabbit).
+You read the actual diff and the threads, then decide — per thread — *whether* and *how* to respond.
+You do not edit files; you read and reason.
+
+## Goal
+
+Convert each unresolved review thread into a concrete decision the developer and the reply step can
+act on. Your output drives the next step: a `fix` is implemented by the developer and the threads are
+replied + resolved; a `wontfix` is replied + resolved with your reason; a `question` is escalated to a
+human at the review-question gate.
+
+## Inputs
+
+You receive (in the `## Inputs` section) the approved **plan** and the **prFeedback** the poll produced:
+the PR number, head sha, failing CI checks, and the unresolved `reviewThreads`
+(`{threadId, path, line, author, body}`). Read the diff (`git diff origin/<base>`) in the worktree to
+judge each comment against the real change.
+
+## What to do
+
+1. Read the diff and the files each thread points at.
+2. For EVERY unresolved thread, decide one of: `fix`, `wontfix`, or `question`.
+   - `fix` — the comment is valid; the developer should change the code. Give precise `guidance`.
+   - `wontfix` — the comment does not apply / is out of scope / is already handled. Give a short,
+     respectful `replyText` stating the reason (it is posted and the thread is auto-resolved).
+   - `question` — the comment is genuinely ambiguous and needs a human to decide. Put the question in
+     `replyText`; it is surfaced at the review-question gate.
+3. If CI also failed, summarize the fix direction in `ciGuidance` for the developer.
+
+## Output
+
+Set the result `output` to a `triage` object:
+
+```
+{
+  "items": [ { "threadId": "<id>", "decision": "fix|wontfix|question", "guidance": "<for the dev>", "replyText": "<to post>" } ],
+  "ciGuidance": "<optional>",
+  "needsHuman": <true if any item is a question>
+}
+```
+
+Set the `verdict` field to EXACTLY one of (decision order):
+
+- `question` — at least one thread is a question (the human gate fires first).
+- `fix` — no questions, but at least one thread needs a code change.
+- `wontfix` — every thread is a wontfix (reply + resolve, no code change).
+
+Keep it concise. You are read-only: never modify the working tree.

package/control-plane/default-playbook/prompts/watcher.md

@@ -15,10 +15,10 @@ is not red, and nothing obviously broke.
 
 ## Output
 
-End your output with a single clear verdict token:
+Set the result `verdict` field (the pipeline routes on it) to EXACTLY one of these tokens:
 
 - `clean` — the integrated change is healthy; proceed to the merge gate.
 - `dirty` — something is wrong with the integration (drives rework/fail per the pipeline).
 - `blocker` — a hard problem a human must resolve.
 
-You are read-only: never modify the working tree.
+Put your findings in `output`. You are read-only: never modify the working tree.

package/dist/api/graphql-api/filters/graphql-validation-exception.filter.js

@@ -0,0 +1,36 @@
+var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
+    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
+    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
+    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
+    return c > 3 && r && Object.defineProperty(target, key, r), r;
+};
+import { BadRequestException, Catch } from '@nestjs/common';
+import { GraphQLError } from 'graphql';
+let GraphQLValidationExceptionFilter = class GraphQLValidationExceptionFilter {
+    catch(exception, host) {
+        if (host.getType() !== 'graphql') {
+            throw exception;
+        }
+        const response = exception.getResponse();
+        throw new GraphQLError(this.extractMessage(response, exception), {
+            extensions: {
+                code: response.code ?? 'BAD_REQUEST',
+                details: response.details,
+                context: response.context,
+            },
+        });
+    }
+    extractMessage(response, exception) {
+        const message = response.message;
+        if (Array.isArray(message))
+            return message.join(', ');
+        if (typeof message === 'string')
+            return message;
+        return exception.message;
+    }
+};
+GraphQLValidationExceptionFilter = __decorate([
+    Catch(BadRequestException)
+], GraphQLValidationExceptionFilter);
+export { GraphQLValidationExceptionFilter };
+//# sourceMappingURL=graphql-validation-exception.filter.js.map

package/dist/api/graphql-api/filters/graphql-validation-exception.filter.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"graphql-validation-exception.filter.js","sourceRoot":"","sources":["../../../../src/api/graphql-api/filters/graphql-validation-exception.filter.ts"],"names":[],"mappings":";;;;;;AAAA,OAAO,EAAiB,mBAAmB,EAAE,KAAK,EAAE,MAAM,gBAAgB,CAAC;AAE3E,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AAUhC,IAAM,gCAAgC,GAAtC,MAAM,gCAAgC;IAC3C,KAAK,CAAC,SAA8B,EAAE,IAAmB;QACvD,IAAI,IAAI,CAAC,OAAO,EAAkB,KAAK,SAAS,EAAE,CAAC;YACjD,MAAM,SAAS,CAAC;QAClB,CAAC;QAED,MAAM,QAAQ,GAAG,SAAS,CAAC,WAAW,EAAwB,CAAC;QAC/D,MAAM,IAAI,YAAY,CAAC,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,SAAS,CAAC,EAAE;YAC/D,UAAU,EAAE;gBACV,IAAI,EAAE,QAAQ,CAAC,IAAI,IAAI,aAAa;gBACpC,OAAO,EAAE,QAAQ,CAAC,OAAO;gBACzB,OAAO,EAAE,QAAQ,CAAC,OAAO;aAC1B;SACF,CAAC,CAAC;IACL,CAAC;IAEO,cAAc,CAAC,QAA4B,EAAE,SAA8B;QACjF,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC;QACjC,IAAI,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC;YAAE,OAAO,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtD,IAAI,OAAO,OAAO,KAAK,QAAQ;YAAE,OAAO,OAAO,CAAC;QAChD,OAAO,SAAS,CAAC,OAAO,CAAC;IAC3B,CAAC;CACF,CAAA;AAtBY,gCAAgC;IAD5C,KAAK,CAAC,mBAAmB,CAAC;GACd,gCAAgC,CAsB5C"}