@reventlessdev/trait-attachments 1.0.0-alpha.1 → 1.0.0-alpha.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/trait-attachments",
-  "version": "1.0.0-alpha.1",
+  "version": "1.0.0-alpha.3",
   "description": "Attachments domain trait: rules, host contract, conformance suite and emitter for an ordered set of stored files on an entity, with a primary and captions",
   "license": "Apache-2.0",
   "files": [
@@ -13,8 +13,8 @@
   "dependencies": {
     "sury": "11.0.0-rc.2",
     "sury-ppx": "11.0.0-rc.2",
-    "@reventlessdev/reventless-gwt": "1.0.0-alpha.199",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.125"
+    "@reventlessdev/reventless-gwt": "1.0.0-alpha.201",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.127"
   },
   "devDependencies": {
     "rescript": "12.3.0"

package/src/Attachments_Scaffold.res

@@ -133,9 +133,9 @@ let refTypeOf = (c: config) => c.refType->Option.getOr("Reventless.UploadableIma
 //
 // The rule survives being emitted as an annotation because the PPX lowers it
 // into a `switch` whose arms are ordinary expressions: `AllowGroupz` does not
-// compile. `@transition` has no such second chance — it is stripped before the
-// typechecker runs — so the states go out through `commandTransition` below
-// instead, where the compiler resolves them.
+// compile. A stripped-before-the-typechecker attribute had no such second
+// chance, which is why the states go out through `commandTransition` below,
+// where the compiler resolves them.
 let commandAttributes = (c: config): string =>
   switch c.authorize {
   | Some(a) => `  | @authorize(${a})\n  `
@@ -146,8 +146,8 @@ let commandAttributes = (c: config): string =>
 // slice is a file the trait writes.
 //
 // The states arrive as config either way; what changes is where they land. In
-// `@transition([Products.Listed])` they are stripped before the typechecker and
-// matched as strings at plugin assembly; in `Guards([Products.Listed])` they are
+// the removed `@transition([Products.Listed])` they were stripped before the
+// typechecker and matched as strings at assembly; in `Guards([Products.Listed])` they are
 // constructor references the compiler resolves, so a config typo is a build
 // error naming it. Same input, and the difference is only who checks it.
 let commandTransitionBinding = (c: config): array<string> => {
@@ -210,10 +210,10 @@ let sliceSpec = (c: config): string => {
     `@schema`,
     `type consumedEvent =`,
     createdArm,
-    `  | ${n.attached}({ ${c.file}: string})`,
-    `  | ${n.removed}({ ${c.file}: string})`,
-    `  | ${n.primarySet}({ ${c.file}: string})`,
-    `  | ${n.altTextSet}({ ${c.file}: string, altText: string})`,
+    `  | ${n.attached}({ ${c.file}: ${ref}})`,
+    `  | ${n.removed}({ ${c.file}: ${ref}})`,
+    `  | ${n.primarySet}({ ${c.file}: ${ref}})`,
+    `  | ${n.altTextSet}({ ${c.file}: ${ref}, altText: string})`,
     `  // TODO(graft): add the events this host's own refusal turns on — whatever`,
     `  // moves it into a state where attachments may not be changed.`,
     ``,
@@ -395,8 +395,8 @@ let projectionPatch = (c: config): patch => {
       `// The second is not redundancy: a card, a gallery tile and a reference cell`,
       `// each read one image-semantic string per row, so without it every tile is blank.`,
       `//`,
-      `//   ${c.file}s: array<{${c.file}: string, altText?: string}>,`,
-      `//   ${c.file}?: string,`,
+      `//   ${c.file}s: array<{${c.file}: ${refTypeOf(c)}, altText?: string}>,`,
+      `//   ${c.file}?: ${refTypeOf(c)},`,
       ``,
       `| ${n.attached}({${c.entityId}, ${c.file}, altText: ?altText}) =>`,
       `  Update(${c.entityId}, state => {`,

package/src/Attachments_Scaffold.res.mjs

@@ -112,10 +112,10 @@ function sliceSpec(c) {
       `@schema`,
       `type consumedEvent =`,
       createdArm,
-      `  | ` + n.attached + `({ ` + c.file + `: string})`,
-      `  | ` + n.removed + `({ ` + c.file + `: string})`,
-      `  | ` + n.primarySet + `({ ` + c.file + `: string})`,
-      `  | ` + n.altTextSet + `({ ` + c.file + `: string, altText: string})`,
+      `  | ` + n.attached + `({ ` + c.file + `: ` + ref + `})`,
+      `  | ` + n.removed + `({ ` + c.file + `: ` + ref + `})`,
+      `  | ` + n.primarySet + `({ ` + c.file + `: ` + ref + `})`,
+      `  | ` + n.altTextSet + `({ ` + c.file + `: ` + ref + `, altText: string})`,
       `  // TODO(graft): add the events this host's own refusal turns on — whatever`,
       `  // moves it into a state where attachments may not be changed.`,
       ``,
@@ -283,8 +283,8 @@ function projectionPatch(c) {
       `// The second is not redundancy: a card, a gallery tile and a reference cell`,
       `// each read one image-semantic string per row, so without it every tile is blank.`,
       `//`,
-      `//   ` + c.file + `s: array<{` + c.file + `: string, altText?: string}>,`,
-      `//   ` + c.file + `?: string,`,
+      `//   ` + c.file + `s: array<{` + c.file + `: ` + Stdlib_Option.getOr(c.refType, "Reventless.UploadableImage.t") + `, altText?: string}>,`,
+      `//   ` + c.file + `?: ` + Stdlib_Option.getOr(c.refType, "Reventless.UploadableImage.t") + `,`,
       ``,
       `| ` + n.attached + `({` + c.entityId + `, ` + c.file + `, altText: ?altText}) =>`,
       `  Update(` + c.entityId + `, state => {`,