@reventlessdev/trait-address-geocoding 1.0.0-alpha.1 → 1.0.0-alpha.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/trait-address-geocoding",
-  "version": "1.0.0-alpha.1",
+  "version": "1.0.0-alpha.11",
   "description": "Address-geocoding domain trait: rules, host contract, conformance suite and emitter for grafting geocoding onto an aggregate",
   "license": "Apache-2.0",
   "files": [
@@ -13,10 +13,10 @@
   "dependencies": {
     "sury": "11.0.0-rc.2",
     "sury-ppx": "11.0.0-rc.2",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.153",
-    "@reventlessdev/reventless-gwt": "1.0.0-alpha.199",
-    "@reventlessdev/reventless-ppx": "1.0.0-alpha.75",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.125"
+    "@reventlessdev/reventless-gwt": "1.0.0-alpha.209",
+    "@reventlessdev/reventless-ppx": "1.0.0-alpha.80",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.163",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.135"
   },
   "devDependencies": {
     "rescript": "12.3.0"

package/src/AddressGeocoding.res

@@ -6,7 +6,6 @@ staleness, redelivery, an outage is not a verdict, the stand-down — live in
 host by `AddressGeocoding_Conformance`; the confidence rule stays core's
 (`Reventless.Geocoding`). The spec surface is written by `AddressGeocoding_Scaffold`.
 */
-
 /** Whether the graft reports back into its host. This trait does — the two `@noApi`
     commands — and the runner accepts nothing else yet; the flag is here so a
     competency that only observes is not mis-modelled as one that writes. */
@@ -102,11 +101,11 @@ The two commands a caller changes the address through, as constructors a host
 splices into its own command type.
 
 These are public, and that is what kept them out of the trait until now. Both
-are legal only while the entity is in some state the HOST names, and a
-`@transition` cannot be attached to a constructor a host did not declare — it
-lowers to a dict on the parent union, and a spread splices members. So the pair
-stayed hand-written in every host, which is the whole of what a spreading host
-still had to transcribe.
+are legal only while the entity is in some state the HOST names, and the
+attribute that used to declare that could not be attached to a constructor a
+host did not declare — it lowered to a dict on the parent union, and a spread
+splices members. So the pair stayed hand-written in every host, which is the
+whole of what a spreading host still had to transcribe.
 
 `commandTransition` is what freed them: the host answers for them in an
 exhaustive switch, in its own lifecycle vocabulary, and the compiler will not let

package/src/AddressGeocoding_Conformance.res

@@ -1,11 +1,3 @@
-/**
-The conformance suite, run by a host against its own graft. `Make(Binding).register()`
-inside a Jest test file registers one `describe` block; every assertion is written
-over the binding, never over a host's constructors.
-*/
-
-// Warning 23 flags the spread in `geocoder` as redundant today; it is there for
-// the day `Capabilities.t` grows a field.
 @@warning("-23")
 
 module Outcome = ReventlessGwt.Outcome
@@ -53,7 +45,9 @@ module Make = (B: AddressGeocoding.Binding) => {
     let triggers =
       B.triggers(B.subjectA)
       ->Array.map(e =>
-        e->Reventless.Message.encode(B.Slice.consumedEventSchema)->Reventless.Message.variantNameOfJson
+        e
+        ->Reventless.Message.encode(B.Slice.consumedEventSchema)
+        ->Reventless.Message.variantNameOfJson
       )
       ->sorted
     // Encoded through the aggregate's own schema, so a stand-down event is a
@@ -124,7 +118,10 @@ module Make = (B: AddressGeocoding.Binding) => {
 
       A.test("a redelivered verdict is a no-op", () =>
         A.givenEvents(
-          Array.concat(B.created(B.subjectA), [B.unresolvable(~subject=B.subjectA, ~reason="no match")]),
+          Array.concat(
+            B.created(B.subjectA),
+            [B.unresolvable(~subject=B.subjectA, ~reason="no match")],
+          ),
         )
         ->A.whenCmd(B.markUnresolvable(~subject=B.subjectA, ~reason="no match"))
         ->A.thenNoEvent
@@ -147,10 +144,12 @@ module Make = (B: AddressGeocoding.Binding) => {
       )
 
       B.triggers(B.subjectA)->Array.forEachWithIndex((trigger, i) =>
-        S.testSync(`trigger ${Int.toString(i + 1)} queues one TODO keyed by entity and subject`, () =>
-          S.givenEvent(trigger)
-          ->S.whenCollect(~sourceId=entityId)
-          ->S.thenTodos([(todoKey(B.subjectA), B.item(~entityId, ~subject=B.subjectA))])
+        S.testSync(
+          `trigger ${Int.toString(i + 1)} queues one TODO keyed by entity and subject`,
+          () =>
+            S.givenEvent(trigger)
+            ->S.whenCollect(~sourceId=entityId)
+            ->S.thenTodos([(todoKey(B.subjectA), B.item(~entityId, ~subject=B.subjectA))]),
         )
       )
 

package/src/AddressGeocoding_Conformance.res.mjs

@@ -28,7 +28,9 @@ function Make(B) {
   let todoKey = subject => entityId + `:` + B.subjectText(subject);
   let geocoder = answer => ({
     geocode: param => Promise.resolve(answer),
-    messaging: Capabilities$Reventless.none.messaging
+    messaging: Capabilities$Reventless.none.messaging,
+    identityProvider: Capabilities$Reventless.none.identityProvider,
+    secrets: Capabilities$Reventless.none.secrets
   });
   let translateWith = answer => ((id, item) => B.translate(id, item, geocoder(answer)));
   let describeCommand = cmd => JSON.stringify(Message$Reventless.encode(cmd, B.Slice.inboundCommandSchema));
@@ -110,23 +112,17 @@ function Make(B) {
           relevance: 0.995
         }]
     })), "a location", B.isLocation));
-    S.test("a no-match completes the TODO with a verdict", undefined, () => thenReports(S.whenTranslateMocked(S.givenTodo(todoKey(B.subjectA), B.item(entityId, B.subjectA)), (id, item) => B.translate(id, item, {
-      geocode: param => Promise.resolve({
-        TAG: "Error",
-        _0: "NoMatch"
-      }),
-      messaging: Capabilities$Reventless.none.messaging
-    })), "a verdict", B.isVerdict));
-    S.test("an outage leaves the TODO pending", undefined, () => S.thenTodoStatus(S.whenTranslateMocked(S.givenTodo(todoKey(B.subjectA), B.item(entityId, B.subjectA)), (id, item) => B.translate(id, item, {
-      geocode: param => Promise.resolve({
-        TAG: "Error",
-        _0: {
-          TAG: "Unavailable",
-          _0: "502"
-        }
-      }),
-      messaging: Capabilities$Reventless.none.messaging
-    })), todoKey(B.subjectA), "Pending"));
+    S.test("a no-match completes the TODO with a verdict", undefined, () => thenReports(S.whenTranslateMocked(S.givenTodo(todoKey(B.subjectA), B.item(entityId, B.subjectA)), (id, item) => B.translate(id, item, geocoder({
+      TAG: "Error",
+      _0: "NoMatch"
+    }))), "a verdict", B.isVerdict));
+    S.test("an outage leaves the TODO pending", undefined, () => S.thenTodoStatus(S.whenTranslateMocked(S.givenTodo(todoKey(B.subjectA), B.item(entityId, B.subjectA)), (id, item) => B.translate(id, item, geocoder({
+      TAG: "Error",
+      _0: {
+        TAG: "Unavailable",
+        _0: "502"
+      }
+    }))), todoKey(B.subjectA), "Pending"));
   });
   return {
     A: A,

package/src/AddressGeocoding_Guards.res

@@ -8,7 +8,6 @@ record in it would make every release that reshapes it a migration — and build
 `resolution` per call from the fields it already holds. What comes back is a
 verdict on one command, which the host names in its own event.
 */
-
 /** The three fields the rules read, as the host holds them. Its invariant, which
     every host arm must preserve: `resolvedFrom` is `None` or equal to `subject`. */
 type resolution = {

package/src/AddressGeocoding_Scaffold.res

@@ -24,11 +24,10 @@ and a host that needs it says so.
 
 **What it does not do.** It never writes the host's policy. Which states an
 address may be changed in, who may change it, what a host's own commands refuse
-— those are `@transition` and `@authorize` over the host's own lifecycle, which
-a trait cannot know. They are config when the host supplies them and absent
+— those are `commandTransition` and `@authorize` over the host's own lifecycle,
+which a trait cannot know. They are config when the host supplies them and absent
 when it does not.
 */
-
 /**
 The names a graft needs, and nothing else.
 
@@ -46,7 +45,6 @@ type config = {
       one of the slice's two triggers, because an entity created with an address
       has never been geocoded. */
   created: string,
-
   /**
   What this host calls the thing being geocoded, lowercase: `"address"`.
 
@@ -58,7 +56,6 @@ type config = {
   spelled out. The emitted patch says which of the two you are getting.
   */
   subject?: string,
-
   /**
   The creation event's payload *beyond* the subject, as declarations:
   `["email: string"]`.
@@ -72,7 +69,6 @@ type config = {
       conformance binding's histories. Omitted ⇒ omitted from the fixtures, which
       only compiles when `createdFields` is omitted too. */
   createdValues?: array<string>,
-
   /** The slice component's name. Defaults to `Geocode<Entity><Subject>`. */
   slice?: string,
   /** The external box the Event Graph draws. Defaults to `"Geocoder"`; a host on
@@ -81,7 +77,6 @@ type config = {
   /** The read model the projection patch is addressed to. Defaults to
       `<Entity>s`. */
   view?: string,
-
   /** Two subjects that differ, for the histories in which the address changes.
       Defaulted when absent — they are test data, not a decision. */
   subjectA?: string,
@@ -227,8 +222,7 @@ let sliceTranslation = (c: config): string => {
     ", {" ++
     c.entityId ++
     ": sourceId, " ++
-    n.subject ++
-    "})]"
+    n.subject ++ "})]"
   lines([
     `@@reventless.translation`,
     ``,
@@ -358,8 +352,8 @@ let conformanceBinding = (c: config): string => {
 // host choice: a report must be legal in every state, or an answer landing after
 // the entity moved on parks a TODO row forever. The two public commands are the
 // host's call, so they are printed as a marked hole. That split is the same one
-// the whole scaffold runs on, and it is why `@transition` could not serve here:
-// an attribute cannot be attached to a constructor the host did not declare.
+// the whole scaffold runs on, and it is why an attribute could not serve here:
+// one cannot be attached to a constructor the host did not declare.
 let transitionArms = (c: config): array<string> => {
   let n = namesOf(c)
   [
@@ -582,11 +576,11 @@ let emit = (~config: config, ~into: string, ~tests: string): output => {
   {
     files: [
       {
-        path: `${into}/OutboundTranslationSlice/${n.slice}.res`,
+        path: `${into}/OutboundTranslation/${n.slice}.res`,
         contents: sliceSpec(config),
       },
       {
-        path: `${into}/OutboundTranslationSlice/${n.slice}_Translation.res`,
+        path: `${into}/OutboundTranslation/${n.slice}_Translation.res`,
         contents: sliceTranslation(config),
       },
       {

package/src/AddressGeocoding_Scaffold.res.mjs

@@ -414,11 +414,11 @@ function emit(config, into, tests) {
   return {
     files: [
       {
-        path: into + `/OutboundTranslationSlice/` + n.slice + `.res`,
+        path: into + `/OutboundTranslation/` + n.slice + `.res`,
         contents: sliceSpec(config)
       },
       {
-        path: into + `/OutboundTranslationSlice/` + n.slice + `_Translation.res`,
+        path: into + `/OutboundTranslation/` + n.slice + `_Translation.res`,
         contents: sliceTranslation(config)
       },
       {

package/src/AddressGeocoding_Translate.res

@@ -7,7 +7,6 @@ An outage is not a verdict — it comes back `Error`, which leaves the TODO pend
 for another attempt — and once the retries are spent `exhaustedReason` is what the
 host reports instead, by the same command a confident refusal produces.
 */
-
 /** The geocoder arrives as a capability, so the deployment decides what answers. */
 let translate = async (
   ~text: string,