@reventlessdev/reventless-seed-aws 1.0.0-alpha.5 → 1.0.0-alpha.7

package/src/ReventlessSeedAws_Reset.res

@@ -48,14 +48,7 @@ module Ddb = AwsSdk.DynamoDb
 module Rgt = AwsSdk.ResourceGroupsTaggingApi
 module S3 = AwsSdk.S3
 
-@scope("process") @val external exit: int => unit = "exit"
-@scope("process") @val external processEnv: dict<string> = "env"
-@module("node:fs") external readFileSync: (string, string) => string = "readFileSync"
 
-type stream
-@scope("process") @val external stdin: stream = "stdin"
-// `process.stdin.isTTY` is `true` interactively and `undefined` under a pipe/CI.
-@get external isTTY: stream => option<bool> = "isTTY"
 
 // The Pulumi project name, which the framework stamps as `reventless:platform` on
 // every resource (`Plugin.res`: `platformName = getProjectName()`). Discovery
@@ -66,7 +59,7 @@ type stream
 // the target project's Pulumi.yaml — the same dir the pulumi subprocess uses.
 let projectName = (~projectDir: string): string => {
   let path = `${projectDir}/Pulumi.yaml`
-  let raw = try readFileSync(path, "utf8") catch {
+  let raw = try NodeFs.readFileSync(path) catch {
   | _ => throw(Seed.Failed(`could not read ${path} to scope the wipe to this Pulumi project.`))
   }
   switch raw
@@ -561,7 +554,7 @@ let run = (~stack=?, ~backend=?, ~targets: array<target>, ()): unit => {
           ),
         )
       }
-      processEnv->Dict.set("AWS_REGION", region)
+      NodeProcess.env->Dict.set("AWS_REGION", region)
 
       // Discover + count each target, scoped to its own project via the platform
       // tag so a same-named stack from another project is never touched.
@@ -597,7 +590,7 @@ let run = (~stack=?, ~backend=?, ~targets: array<target>, ()): unit => {
         Seed.Prompt.close()
         Console.log("")
         Console.log(`Nothing to reset — the selected scope already reads empty in ${region}.`)
-        exit(0)
+        NodeProcess.exit(0)
       }
 
       // Confirmation. Interactively, re-typing the exact stack name IS the
@@ -606,7 +599,7 @@ let run = (~stack=?, ~backend=?, ~targets: array<target>, ()): unit => {
       // TTY (CI/scripts) there is nothing to type into, so
       // REVENTLESS_WIPE_CONFIRM=<stack> is the equivalent opt-in. Dry-run is the
       // default either way.
-      let interactive = stdin->isTTY->Option.getOr(false)
+      let interactive = NodeProcess.stdin->NodeProcess.isTTY->Option.getOr(false)
       let confirmed = if interactive {
         let typed = await Seed.Prompt.ask(
           `About to permanently empty ${total->Int.toString} item(s)/object(s) across the selected scope of "${stack}". ` ++
@@ -624,7 +617,7 @@ let run = (~stack=?, ~backend=?, ~targets: array<target>, ()): unit => {
             ? "Dry run — nothing was deleted."
             : `Dry run — nothing was deleted. Set REVENTLESS_WIPE_CONFIRM=${stack} to empty this scope non-interactively.`,
         )
-        exit(0)
+        NodeProcess.exit(0)
       }
 
       for i in 0 to resolvedList->Array.length - 1 {
@@ -681,19 +674,19 @@ let run = (~stack=?, ~backend=?, ~targets: array<target>, ()): unit => {
 
       Console.log("")
       Console.log(`Reset complete — the selected scope of "${stack}" reads empty and is re-seedable.`)
-      exit(0)
+      NodeProcess.exit(0)
     } catch {
     | Seed.Failed(message) =>
       Seed.Prompt.close()
       Console.error("")
       Console.error(`Reset aborted — ${message}`)
-      exit(1)
+      NodeProcess.exit(1)
     | exn =>
       Seed.Prompt.close()
       Console.error("")
       Console.error("Reset aborted with an unexpected error:")
       Console.error(exn->JsExn.fromException->Option.flatMap(JsExn.message)->Option.getOr("unknown"))
-      exit(1)
+      NodeProcess.exit(1)
     }
   }
   go()->ignore

package/tests/EndpointResolutionTest.res

@@ -1,37 +1,30 @@
-// Which document `resolveEndpoints` reads, and what each arm takes from it.
+// Which document `resolveEndpoints` reads, and which GraphQL endpoint each arm takes
+// from it.
 //
 // `endpointsFrom` is the pure half of `resolveEndpoints`; the impure half is a
-// `pulumi stack output` subprocess and a `config.json` fetch, and the decision
-// these tests pin is in neither. The defect they lock out: **neither arm read
-// `uploadEndpoints`**, so a platform that publishes a presign endpoint per
-// declared store resolved "" and the seeder reported it as serving no uploads.
-// The stack-outputs arm is the one that matters — a platform deploying no host
-// shell publishes no `hostShellUrl` by construction, so it takes that arm, and
-// the per-store endpoint is its only way to reach the store.
+// `pulumi stack output` subprocess and a `config.json` fetch, and the decision these
+// tests pin is in neither. Upload endpoints are no longer resolved here — under route B
+// the seed mints through the domain API's `Upload_Presign` mutation on the GraphQL
+// endpoint below — so the only decision left is which GraphQL endpoint each source
+// publishes, and the merged-over-per-plugin precedence within the stack-outputs arm.
 
 open JestGlobals
 open ReventlessSeed
 
-@val @scope("process") external processEnv: dict<string> = "env"
-
 // Every value read here has an env override, and an ambient one in the runner's
-// environment (AWS_REGION is routinely set) would silently stand in for the
-// document under test. An empty string reads as unset.
+// environment (AWS_REGION is routinely set) would silently stand in for the document
+// under test. An empty string reads as unset.
 let clearOverrides = () =>
   [
     "REVENTLESS_GRAPHQL_ENDPOINT",
-    "REVENTLESS_UPLOAD_ENDPOINT",
     "AWS_REGION",
     "COGNITO_CLIENT_ID",
     "SEED_SKIP_UPLOADS",
-  ]->Array.forEach(k => processEnv->Dict.set(k, ""))
+  ]->Array.forEach(k => NodeProcess.env->Dict.set(k, ""))
 
 let obj = entries => JSON.Encode.object(entries->Dict.fromArray)
 let str = JSON.Encode.string
 
-// A host shell's config.json and the stack outputs of a platform that serves no
-// shell — the two documents the two arms read, minus the upload keys each test
-// supplies.
 let config = (~extra: array<(string, JSON.t)>) =>
   obj(
     Array.concat(
@@ -56,84 +49,18 @@ let outputs = (~extra: array<(string, JSON.t)>) =>
     ),
   )
 
-let storeEndpoints = obj([("Catalog.productImages", str("https://presign.example/"))])
-
 describe("endpointsFrom — host shell arm", () => {
   beforeEach(clearOverrides)
 
-  testSync("reads the legacy single service and the per-store map together", () => {
-    let eps = ReventlessSeedAws.endpointsFrom(
-      ~stack="alpha",
-      HostShellConfig(
-        config(
-          ~extra=[
-            ("uploadEndpoint", str("https://legacy.example/")),
-            ("uploadEndpoints", storeEndpoints),
-          ],
-        ),
-      ),
-    )
-    expect(eps.uploadEndpoint)->toBe("https://legacy.example/")
-    expect(eps.uploadEndpoints)->toEqual(
-      Dict.fromArray([("Catalog.productImages", "https://presign.example/")]),
-    )
-  })
-
-  // A shell fronting only declared stores writes no singular key. That used to
-  // fail the whole run before a command was sent ("deployment is missing
-  // uploadEndpoint"), which is a harder failure than the one this plan fixes.
-  testSync("a shell publishing only per-store endpoints resolves an empty legacy service", () => {
-    let eps = ReventlessSeedAws.endpointsFrom(
-      ~stack="alpha",
-      HostShellConfig(config(~extra=[("uploadEndpoints", storeEndpoints)])),
-    )
-    expect(eps.uploadEndpoint)->toBe("")
-    expect(eps.uploadEndpoints->Dict.keysToArray)->toEqual(["Catalog.productImages"])
-  })
-
-  testSync("REVENTLESS_UPLOAD_ENDPOINT overrides the legacy service and leaves the map alone", () => {
-    processEnv->Dict.set("REVENTLESS_UPLOAD_ENDPOINT", "https://override.example/")
-    let eps = ReventlessSeedAws.endpointsFrom(
-      ~stack="alpha",
-      HostShellConfig(
-        config(
-          ~extra=[
-            ("uploadEndpoint", str("https://legacy.example/")),
-            ("uploadEndpoints", storeEndpoints),
-          ],
-        ),
-      ),
-    )
-    expect(eps.uploadEndpoint)->toBe("https://override.example/")
-    expect(eps.uploadEndpoints->Dict.get("Catalog.productImages"))->toEqual(
-      Some("https://presign.example/"),
-    )
+  testSync("reads the GraphQL endpoint from the shell config", () => {
+    let eps = ReventlessSeedAws.endpointsFrom(~stack="alpha", HostShellConfig(config(~extra=[])))
+    expect(eps.graphql)->toBe("https://api.example/graphql")
   })
 })
 
 describe("endpointsFrom — stack outputs arm", () => {
   beforeEach(clearOverrides)
 
-  // The lookup that was missing entirely: this arm had no upload source but the
-  // env var, so a `PlatformOwned` deployment resolved "" whatever it published.
-  testSync("reads the uploadEndpoints stack output", () => {
-    let eps = ReventlessSeedAws.endpointsFrom(
-      ~stack="pr-verify",
-      StackOutputs(outputs(~extra=[("uploadEndpoints", storeEndpoints)])),
-    )
-    expect(eps.uploadEndpoints)->toEqual(
-      Dict.fromArray([("Catalog.productImages", "https://presign.example/")]),
-    )
-  })
-
-  // Declaring no store is a legitimate deployment, not a broken one — it stays a
-  // no-op at the data set rather than failing the run.
-  testSync("a deployment declaring no store resolves an empty map without failing", () => {
-    let eps = ReventlessSeedAws.endpointsFrom(~stack="pr-verify", StackOutputs(outputs(~extra=[])))
-    expect(eps.uploadEndpoint)->toBe("")
-    expect(eps.uploadEndpoints->Dict.keysToArray)->toEqual([])
-  })
-
   testSync("prefers the merged API endpoint over the per-plugin one", () => {
     let eps = ReventlessSeedAws.endpointsFrom(
       ~stack="pr-verify",
@@ -154,28 +81,3 @@ describe("endpointsFrom — stack outputs arm", () => {
     }
   )
 })
-
-describe("endpointsFrom — malformed uploadEndpoints", () => {
-  beforeEach(clearOverrides)
-
-  // One bad member should not cost the run every endpoint it could have used.
-  testSync("drops a non-string member rather than the whole map", () => {
-    let eps = ReventlessSeedAws.endpointsFrom(
-      ~stack="pr-verify",
-      StackOutputs(
-        outputs(
-          ~extra=[
-            (
-              "uploadEndpoints",
-              obj([
-                ("Catalog.productImages", str("https://presign.example/")),
-                ("Catalog.broken", JSON.Encode.int(7)),
-              ]),
-            ),
-          ],
-        ),
-      ),
-    )
-    expect(eps.uploadEndpoints->Dict.keysToArray)->toEqual(["Catalog.productImages"])
-  })
-})

package/tests/EndpointResolutionTest.res.mjs

@@ -8,7 +8,6 @@ import * as Primitive_exceptions from "@rescript/runtime/lib/es6/Primitive_excep
 function clearOverrides() {
   [
     "REVENTLESS_GRAPHQL_ENDPOINT",
-    "REVENTLESS_UPLOAD_ENDPOINT",
     "AWS_REGION",
     "COGNITO_CLIENT_ID",
     "SEED_SKIP_UPLOADS"
@@ -59,87 +58,19 @@ function outputs(extra) {
   ].concat(extra));
 }
 
-let storeEndpoints = Object.fromEntries([[
-    "Catalog.productImages",
-    "https://presign.example/"
-  ]]);
-
 globalThis.describe("endpointsFrom — host shell arm", () => {
   globalThis.beforeEach(clearOverrides);
-  globalThis.test("reads the legacy single service and the per-store map together", () => {
-    let eps = ReventlessSeedAws.endpointsFrom("alpha", {
-      TAG: "HostShellConfig",
-      _0: config([
-        [
-          "uploadEndpoint",
-          "https://legacy.example/"
-        ],
-        [
-          "uploadEndpoints",
-          storeEndpoints
-        ]
-      ])
-    });
-    globalThis.expect(eps.uploadEndpoint).toBe("https://legacy.example/");
-    globalThis.expect(eps.uploadEndpoints).toEqual(Object.fromEntries([[
-        "Catalog.productImages",
-        "https://presign.example/"
-      ]]));
-  });
-  globalThis.test("a shell publishing only per-store endpoints resolves an empty legacy service", () => {
+  globalThis.test("reads the GraphQL endpoint from the shell config", () => {
     let eps = ReventlessSeedAws.endpointsFrom("alpha", {
       TAG: "HostShellConfig",
-      _0: config([[
-          "uploadEndpoints",
-          storeEndpoints
-        ]])
+      _0: config([])
     });
-    globalThis.expect(eps.uploadEndpoint).toBe("");
-    globalThis.expect(Object.keys(eps.uploadEndpoints)).toEqual(["Catalog.productImages"]);
-  });
-  globalThis.test("REVENTLESS_UPLOAD_ENDPOINT overrides the legacy service and leaves the map alone", () => {
-    process.env["REVENTLESS_UPLOAD_ENDPOINT"] = "https://override.example/";
-    let eps = ReventlessSeedAws.endpointsFrom("alpha", {
-      TAG: "HostShellConfig",
-      _0: config([
-        [
-          "uploadEndpoint",
-          "https://legacy.example/"
-        ],
-        [
-          "uploadEndpoints",
-          storeEndpoints
-        ]
-      ])
-    });
-    globalThis.expect(eps.uploadEndpoint).toBe("https://override.example/");
-    globalThis.expect(eps.uploadEndpoints["Catalog.productImages"]).toEqual("https://presign.example/");
+    globalThis.expect(eps.graphql).toBe("https://api.example/graphql");
   });
 });
 
 globalThis.describe("endpointsFrom — stack outputs arm", () => {
   globalThis.beforeEach(clearOverrides);
-  globalThis.test("reads the uploadEndpoints stack output", () => {
-    let eps = ReventlessSeedAws.endpointsFrom("pr-verify", {
-      TAG: "StackOutputs",
-      _0: outputs([[
-          "uploadEndpoints",
-          storeEndpoints
-        ]])
-    });
-    globalThis.expect(eps.uploadEndpoints).toEqual(Object.fromEntries([[
-        "Catalog.productImages",
-        "https://presign.example/"
-      ]]));
-  });
-  globalThis.test("a deployment declaring no store resolves an empty map without failing", () => {
-    let eps = ReventlessSeedAws.endpointsFrom("pr-verify", {
-      TAG: "StackOutputs",
-      _0: outputs([])
-    });
-    globalThis.expect(eps.uploadEndpoint).toBe("");
-    globalThis.expect(Object.keys(eps.uploadEndpoints)).toEqual([]);
-  });
   globalThis.test("prefers the merged API endpoint over the per-plugin one", () => {
     let eps = ReventlessSeedAws.endpointsFrom("pr-verify", {
       TAG: "StackOutputs",
@@ -174,35 +105,11 @@ globalThis.describe("endpointsFrom — stack outputs arm", () => {
   });
 });
 
-globalThis.describe("endpointsFrom — malformed uploadEndpoints", () => {
-  globalThis.beforeEach(clearOverrides);
-  globalThis.test("drops a non-string member rather than the whole map", () => {
-    let eps = ReventlessSeedAws.endpointsFrom("pr-verify", {
-      TAG: "StackOutputs",
-      _0: outputs([[
-          "uploadEndpoints",
-          Object.fromEntries([
-            [
-              "Catalog.productImages",
-              "https://presign.example/"
-            ],
-            [
-              "Catalog.broken",
-              7
-            ]
-          ])
-        ]])
-    });
-    globalThis.expect(Object.keys(eps.uploadEndpoints)).toEqual(["Catalog.productImages"]);
-  });
-});
-
 export {
   clearOverrides,
   obj,
   str,
   config,
   outputs,
-  storeEndpoints,
 }
-/* storeEndpoints Not a pure module */
+/*  Not a pure module */