@reventlessdev/reventless-local 3.0.0-alpha.187 → 3.0.0-alpha.189

package/CHANGELOG.md

@@ -3,6 +3,33 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.189 (2026-08-02)
+
+### Features
+
+* **aws,core,spec,seed-aws:** expire uploads nobody committed a reference to ([f63e84c](https://github.com/ReventlessDev/reventless-core/commit/f63e84c1a11cc350b799a6f69a2e7427cf1ea6e9))
+
+
+# 3.0.0-alpha.188 (2026-08-01)
+
+* feat(aws,core,spec)!: qualify store prefixes by plugin and refuse name collisions ([da39405](https://github.com/ReventlessDev/reventless-core/commit/da394059d9f8f981bf7adc79e2c1ce2b429e0267))
+* feat(core,aws)!: name task buckets for their plugin and task ([05203cb](https://github.com/ReventlessDev/reventless-core/commit/05203cb3b0b019401a6f32cf78109f397b6799d5))
+
+### BREAKING CHANGES
+
+* objects minted under the old bare prefix are orphaned and their
+refs unresolvable. The migration is `seed:reset` for the owning plugin, then
+re-seed. Legacy-prefix grandfathering was considered and deliberately dropped —
+it would have added a permanent prefix SET across the deploy argument, both store
+configs, the presign IAM fan-out, the release scope check and the stack output,
+to spare a disposable stack one wipe.
+* a bucket name change is a replace. TaskBucket_S3 now sets
+forceDestroy on disposable stacks (Util_StoreLayout.protectionFor), so pr-*
+stacks recreate cleanly; protected stacks must have the task bucket drained by
+hand before the first deploy after this, or the replace fails BucketNotEmpty.
+
+
+
 # 3.0.0-alpha.187 (2026-08-01)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-local",
-  "version": "3.0.0-alpha.187",
+  "version": "3.0.0-alpha.189",
   "description": "Local platform for Reventless (in-memory or SQLite backend, for development and testing without AWS)",
   "license": "Apache-2.0",
   "bin": {
@@ -37,20 +37,20 @@
     "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
     "@reventlessdev/rescript-graphql-yoga": "1.0.0-alpha.26",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
-    "@reventlessdev/rescript-mcp-sdk": "1.0.0-alpha.21",
     "@reventlessdev/rescript-node": "2.0.0-alpha.0",
+    "@reventlessdev/rescript-mcp-sdk": "1.0.0-alpha.21",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.201",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.18",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.199",
-    "@reventlessdev/reventless-graphql-server": "1.0.0-alpha.47",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.116",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.63",
-    "@reventlessdev/reventless-gwt": "1.0.0-alpha.146",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.91"
+    "@reventlessdev/reventless-gwt": "1.0.0-alpha.148",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.118",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.65",
+    "@reventlessdev/reventless-graphql-server": "1.0.0-alpha.49",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.93"
   },
   "devDependencies": {
     "rescript": "12.3.0",
     "sury-ppx": "11.0.0-alpha.2",
-    "@reventlessdev/reventless-ppx": "1.0.0-alpha.59"
+    "@reventlessdev/reventless-ppx": "1.0.0-alpha.60"
   },
   "peerDependencies": {
     "rescript": "12.3.0"

package/src/Platform.res

@@ -865,6 +865,40 @@ module MakeWithConfig = (
           }
         })
     })
+
+    // Two plugins declaring one store name is refused by the deployed platform
+    // before it provisions anything. Local provisions no stores, so nothing here
+    // breaks — but this is the only place a developer meets the rule while the
+    // fix is still free: once a store has deployed, its minted refs are in an
+    // append-only event log and renaming it strands them. Hence a warning at
+    // composition, and the authoritative refusal at deploy.
+    let declared =
+      pluginStructuresStore.contents
+      ->Dict.valuesToArray
+      ->Array.flatMap(structure =>
+        structure.requiredStores
+        ->Option.getOr([])
+        ->Array.map(qualified => {
+          ReventlessCore.StorePrefixCollision.qualified,
+          // Local provisions no stores, so it has no prefix of its own — it
+          // restates the deployed rule (`{plugin}/{store}`) so the warning it
+          // gives matches the refusal a deploy would give. Reporting a collision
+          // the deployed platform does not have would be worse than silence.
+          prefix: switch qualified->String.indexOfOpt(".") {
+          | Some(i) =>
+            qualified->String.slice(~start=0, ~end=i) ++
+            "/" ++
+            qualified->String.slice(~start=i + 1, ~end=qualified->String.length)
+          | None => qualified
+          },
+        })
+      )
+    ReventlessCore.StorePrefixCollision.collisionsFor(~stores=declared)->Array.forEach(c =>
+      log.warn(
+        ~comp="Platform:plugins",
+        ReventlessCore.StorePrefixCollision.collisionMessage(c),
+      )
+    )
   }
 
   // Bus keys for the admin Plugin aggregate (name-keyed). ComponentType.toName maps

package/src/Platform.res.mjs

@@ -55,6 +55,7 @@ import * as PlatformMCP_Server$ReventlessLocal from "./adapter/PlatformMCP_Serve
 import * as Auth_GraphqlContext$ReventlessLocal from "./adapter/Auth/Auth_GraphqlContext.res.mjs";
 import * as PgProjectionCatchup$ReventlessLocal from "./adapter/PgProjectionCatchup.res.mjs";
 import * as PluginsReadModelSpec$ReventlessCore from "@reventlessdev/reventless-core/src/plugin/lifecycle/PluginsReadModelSpec.res.mjs";
+import * as StorePrefixCollision$ReventlessCore from "@reventlessdev/reventless-core/src/util/StorePrefixCollision.res.mjs";
 import * as DomainGraphQL_Server$ReventlessLocal from "./adapter/DomainGraphQL_Server.res.mjs";
 import * as EventPublish_Callback$ReventlessCore from "@reventlessdev/reventless-core/src/components/EventLog/EventPublish_Callback.res.mjs";
 import * as LocalUploadResolvers$ReventlessLocal from "./adapter/LocalUploadResolvers.res.mjs";
@@ -824,6 +825,14 @@ function MakeWithConfig(Config) {
         }
       });
     });
+    let declared = Object.values(pluginStructuresStore.contents).flatMap(structure => Stdlib_Option.getOr(structure.requiredStores, []).map(qualified => {
+      let i = Stdlib_String.indexOfOpt(qualified, ".");
+      return {
+        qualified: qualified,
+        prefix: i !== undefined ? qualified.slice(0, i) + "/" + qualified.slice(i + 1 | 0, qualified.length) : qualified
+      };
+    }));
+    StorePrefixCollision$ReventlessCore.collisionsFor(declared).forEach(c => log.warn("Platform:plugins", undefined, StorePrefixCollision$ReventlessCore.collisionMessage(c)));
   };
   let pluginCmdTopicKey = PluginSpec$ReventlessCore.name + "AggrCmdTopic";
   let pluginEventTopicKey = PluginSpec$ReventlessCore.name + "AggrEventTopic";
@@ -2500,6 +2509,14 @@ function Make($star) {
         }
       });
     });
+    let declared = Object.values(pluginStructuresStore.contents).flatMap(structure => Stdlib_Option.getOr(structure.requiredStores, []).map(qualified => {
+      let i = Stdlib_String.indexOfOpt(qualified, ".");
+      return {
+        qualified: qualified,
+        prefix: i !== undefined ? qualified.slice(0, i) + "/" + qualified.slice(i + 1 | 0, qualified.length) : qualified
+      };
+    }));
+    StorePrefixCollision$ReventlessCore.collisionsFor(declared).forEach(c => log.warn("Platform:plugins", undefined, StorePrefixCollision$ReventlessCore.collisionMessage(c)));
   };
   let pluginCmdTopicKey = PluginSpec$ReventlessCore.name + "AggrCmdTopic";
   let pluginEventTopicKey = PluginSpec$ReventlessCore.name + "AggrEventTopic";

package/src/adapter/DomainGraphQL_Server.res

@@ -131,7 +131,7 @@ let handleLogout = (_req: nodeRequest, res: nodeResponse): unit => {
 //   PUT  /{prefix}/{key}     raw bytes → 200 (store)
 //   GET  /{prefix}/{key}              → the stored bytes
 // Minting (`Upload_Presign`) and release (`Upload_Release`) are platform-API
-// mutations under route B (see [docs/plans/upload-release-path.md], resolved in
+// mutations under route B (see [docs/plans/done/upload-release-path.md], resolved in
 // Platform.res against this same `LocalObjectStore`); the presign returns
 // `uploadUrl == storageRef == /{prefix}/{key}`, so the byte PUT below is unchanged.
 

package/src/adapter/LocalObjectStore.res

@@ -57,7 +57,7 @@ let put = (~key: string, ~bytes: buffer, ~contentType: string): unit =>
 let get = (~key: string): option<entry> => objects->Dict.get(key)
 
 // Remove a stored object. Idempotent — deleting an absent key is a no-op, matching
-// the release contract (see docs/plans/upload-release-path.md, Step 3). The dev
+// the release contract (see docs/plans/done/upload-release-path.md, Step 3). The dev
 // store has no identities or clock, so the release resolver enforces only the
 // *shape* of the rule (key under a served prefix), not the identity/age conditions.
 let delete = (~key: string): unit => objects->Dict.delete(key)

package/src/adapter/LocalUploadResolvers.res

@@ -5,7 +5,7 @@
 // The dev store has no identities and no clock, so release enforces only the *shape*
 // of the rule (key under a served prefix), not the identity/age conditions AWS applies
 // — dev parity is about the client seeing the same contract, not reproducing AWS's
-// guarantees. See [docs/plans/upload-release-path.md] § Step 3.
+// guarantees. See [docs/plans/done/upload-release-path.md] § Step 3.
 
 // Mint a same-origin `/{prefix}/{uuid}/{fileName}` ref: both the PUT target and the
 // stored value, mirroring the AWS presign ticket's shape.

package/tests/components/task/TaskTest.res

@@ -90,9 +90,12 @@ describe("Task_Builder.Make:", () => {
       let bucketNames = outputs.bucketNames->Option.getUnsafe
       let idOutput = bucketNames->Dict.get("Reports")->Option.getUnsafe
       let id = await idOutput->TestRunner.resolve
-      // In-memory bucket id = resource name: taskName ++ pascalCase(bucketName) ++ "Bucket"
-      // = "OneBucketTask" ++ "Reports" ++ "Bucket". The lookup key stays "Reports".
-      expect(id)->toBe("OneBucketTaskReportsBucket")
+      // In-memory bucket id = the bucket's resource name, which is kebab-cased
+      // and plugin-qualified because S3 lowercases a bucket name and a PascalCase
+      // one collapses into a run-on. No plugin segment here: the task is built
+      // outside any plugin, so there is no ambient plugin to qualify with.
+      // The runtime lookup key is a separate string and stays "Reports".
+      expect(id)->toBe("one-bucket-task-reports")
     })
   })
 })

package/tests/components/task/TaskTest.res.mjs

@@ -38,7 +38,7 @@ globalThis.describe("Task_Builder.Make:", () => {
       let bucketNames = outputs.bucketNames;
       let idOutput = bucketNames["Reports"];
       let id = await TestRunner$ReventlessLocal.resolve(idOutput);
-      globalThis.expect(id).toBe("OneBucketTaskReportsBucket");
+      globalThis.expect(id).toBe("one-bucket-task-reports");
     });
   });
 });