@reventlessdev/reventless-local 3.0.0-alpha.168 → 3.0.0-alpha.169

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.169 (2026-07-26)
+
+### Bug Fixes
+
+* **api:** preserve nullability for optional enum fields in generated GraphQL ([3110a4a](https://github.com/ReventlessDev/reventless-core/commit/3110a4af032440ba2639519f61f221960ac78fba))
+
+
 # 3.0.0-alpha.168 (2026-07-26)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-local",
-  "version": "3.0.0-alpha.168",
+  "version": "3.0.0-alpha.169",
   "description": "Local platform for Reventless (in-memory or SQLite backend, for development and testing without AWS)",
   "license": "Apache-2.0",
   "jest": {
@@ -33,15 +33,15 @@
     "ws": "^8.18.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.31",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.9",
+    "@reventlessdev/rescript-graphql-yoga": "1.0.0-alpha.25",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.17",
     "@reventlessdev/rescript-mcp-sdk": "1.0.0-alpha.20",
-    "@reventlessdev/rescript-graphql-yoga": "1.0.0-alpha.25",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.181",
-    "@reventlessdev/reventless-graphql-server": "1.0.0-alpha.28",
-    "@reventlessdev/reventless-gwt": "1.0.0-alpha.128",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.45",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.182",
+    "@reventlessdev/reventless-gwt": "1.0.0-alpha.129",
+    "@reventlessdev/reventless-graphql-server": "1.0.0-alpha.29",
     "@reventlessdev/reventless-infra": "3.0.0-alpha.105",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.81"
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.81",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.46"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/tests/adapter/GraphQL_SchemaInspectorTest.res

@@ -27,6 +27,21 @@ type svState = {
   price: float,
 }
 
+// Multi-variant enum used both as a required and as an optional state field, to pin
+// the nullability the sury→GraphQL deriver must preserve for the optional case.
+@schema
+type sourceKind =
+  | @as("tagged") Tagged
+  | @as("ancestry") Ancestry
+  | @as("substrate") Substrate
+
+@schema
+type enumState = {
+  productId: @s.matches(Reventless.DcbTag.string) string,
+  requiredSource: sourceKind,
+  optionalSource?: sourceKind,
+}
+
 @schema
 type addCommand = {
   productId: @s.matches(Reventless.DcbTag.string) string,
@@ -907,8 +922,38 @@ describe("Plugin admin fragment — kind enum + kindEq filter", () => {
     // kind is a real enum on the Plugin type (auto-derived from the payload-less variant)
     expect(sdl->String.includes("enum Platform_PluginKind"))->toBe(true)
     expect(sdl->String.includes("PlatformInfrastructure"))->toBe(true)
-    expect(sdl->String.includes("kind: Platform_PluginKind!"))->toBe(true)
+    // `kind` is `option<pluginKind>` — nullable on purpose so a kind-less legacy row
+    // can't collapse the whole Platform_Plugins query. It must render without a `!`.
+    expect(sdl->String.includes("kind: Platform_PluginKind"))->toBe(true)
+    expect(sdl->String.includes("kind: Platform_PluginKind!"))->toBe(false)
     // @scan folds a server-side equality filter for the panel split
     expect(sdl->String.includes("kindEq: String"))->toBe(true)
   })
 })
+
+describe("optional enum fields preserve GraphQL nullability", () => {
+  testPromise(
+    "required variant field → SomeEnum!; optional variant field → nullable SomeEnum",
+    async () => {
+      let fragment = ReventlessCore.GraphQL_FragmentGenerator.generate(
+        ~mutationEntries=[],
+        ~queryEntries=[
+          {
+            singleFieldName: "SV_Sourced",
+            listFieldName: "SV_Sourceds",
+            returnTypeName: "EnumState",
+            stateSchema: enumStateSchema->S.castToUnknown,
+            authorization: None,
+            includeIdParam: false,
+          },
+        ],
+      )
+      let sdl = ReventlessCore.GraphQL_SchemaInspector.inspectFragment(fragment).sdlPreview
+      // A required variant field stays non-null.
+      expect(sdl->String.includes("requiredSource: EnumStateRequiredSource!"))->toBe(true)
+      // An optional variant field is nullable: the enum is present but never with a `!`.
+      expect(sdl->String.includes("optionalSource: EnumStateOptionalSource"))->toBe(true)
+      expect(sdl->String.includes("optionalSource: EnumStateOptionalSource!"))->toBe(false)
+    },
+  )
+})

package/tests/adapter/GraphQL_SchemaInspectorTest.res.mjs

@@ -29,6 +29,18 @@ let svStateSchema = S.schema(s => ({
   price: s.m(S.float)
 }));
 
+let sourceKindSchema = S.union([
+  S.literal("tagged"),
+  S.literal("ancestry"),
+  S.literal("substrate")
+]);
+
+let enumStateSchema = S.schema(s => ({
+  productId: s.m(DcbTag$Reventless.string),
+  requiredSource: s.m(sourceKindSchema),
+  optionalSource: s.m(S.option(sourceKindSchema))
+}));
+
 let addCommandSchema = S.schema(s => ({
   productId: s.m(DcbTag$Reventless.string),
   name: s.m(S.string)
@@ -641,11 +653,29 @@ globalThis.describe("Plugin admin fragment — kind enum + kindEq filter", () =>
     let sdl = GraphQL_SchemaInspector$ReventlessCore.inspectFragment(fragment).sdlPreview;
     globalThis.expect(sdl.includes("enum Platform_PluginKind")).toBe(true);
     globalThis.expect(sdl.includes("PlatformInfrastructure")).toBe(true);
-    globalThis.expect(sdl.includes("kind: Platform_PluginKind!")).toBe(true);
+    globalThis.expect(sdl.includes("kind: Platform_PluginKind")).toBe(true);
+    globalThis.expect(sdl.includes("kind: Platform_PluginKind!")).toBe(false);
     globalThis.expect(sdl.includes("kindEq: String")).toBe(true);
   });
 });
 
+globalThis.describe("optional enum fields preserve GraphQL nullability", () => {
+  globalThis.test("required variant field → SomeEnum!; optional variant field → nullable SomeEnum", async () => {
+    let fragment = GraphQL_FragmentGenerator$ReventlessCore.generate([], [{
+        singleFieldName: "SV_Sourced",
+        listFieldName: "SV_Sourceds",
+        returnTypeName: "EnumState",
+        stateSchema: enumStateSchema,
+        authorization: undefined,
+        includeIdParam: false
+      }]);
+    let sdl = GraphQL_SchemaInspector$ReventlessCore.inspectFragment(fragment).sdlPreview;
+    globalThis.expect(sdl.includes("requiredSource: EnumStateRequiredSource!")).toBe(true);
+    globalThis.expect(sdl.includes("optionalSource: EnumStateOptionalSource")).toBe(true);
+    globalThis.expect(sdl.includes("optionalSource: EnumStateOptionalSource!")).toBe(false);
+  });
+});
+
 let stringSchema = S.string;
 
 let taggedSchema = DcbTag$Reventless.string;
@@ -661,6 +691,8 @@ export {
   boolSchema,
   testStateSchema,
   svStateSchema,
+  sourceKindSchema,
+  enumStateSchema,
   addCommandSchema,
   unionCommandSchema,
   dcbSingleCommandSchema,