@reventlessdev/reventless-local 3.0.0-alpha.132 → 3.0.0-alpha.133

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.133 (2026-07-09)
+
+### Bug Fixes
+
+* **reventless-core:** DCB StateChangeSlice mutations use ${plugin}_${command}, not ${plugin}_${slice}_${command} ([c5874d2](https://github.com/ReventlessDev/reventless-core/commit/c5874d27ad63e6af5c639c8b6c6f8596fd7f682b))
+
+
 # 3.0.0-alpha.132 (2026-07-09)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-local",
-  "version": "3.0.0-alpha.132",
+  "version": "3.0.0-alpha.133",
   "description": "Local platform for Reventless (in-memory or SQLite backend, for development and testing without AWS)",
   "license": "Apache-2.0",
   "jest": {
@@ -33,14 +33,14 @@
     "ws": "^8.18.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.25",
     "@reventlessdev/rescript-graphql-yoga": "1.0.0-alpha.18",
-    "@reventlessdev/rescript-jest": "1.0.0-alpha.6",
     "@reventlessdev/rescript-mcp-sdk": "1.0.0-alpha.17",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.14",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.148",
-    "@reventlessdev/reventless-gwt": "1.0.0-alpha.93",
+    "@reventlessdev/rescript-jest": "1.0.0-alpha.6",
+    "@reventlessdev/reventless-gwt": "1.0.0-alpha.94",
     "@reventlessdev/reventless-infra": "3.0.0-alpha.91",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.12",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.69"
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.69",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.13",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.149"
   },
   "devDependencies": {
     "rescript": "^12.3.0",

package/src/adapter/CommandGenerator/CommandGeneratorResolvers_GraphQL.res

@@ -239,7 +239,7 @@ let registerDcb = (
   ensureCommandResultTypes(server)
   // Derive the constructor from the field name's trailing `_` segment (mirrors the
   // aggregate resolver). A single-command slice's `Plugin_Slice` resolves to its sole
-  // constructor (slice name == constructor); a multi-command slice's `Plugin_Slice_Ctor`
+  // constructor (slice name == constructor); a multi-command slice's `Plugin_Ctor`
   // resolves to `Ctor`. Position 0 was previously hardcoded, which dropped every
   // non-first constructor of a multi-command slice.
   let constructorNames = Reventless.DcbTag.extractAllVariantNames(commandSchema->Obj.magic)

package/tests/adapter/GraphQL_SchemaInspectorTest.res

@@ -41,7 +41,7 @@ type unionCommand =
 // DCB StateChangeSlice command shapes for the per-constructor mutation fan-out.
 // A single-variant union models a single-command slice (must keep the byte-identical
 // `Plugin_Slice` field); a multi-variant union models a multi-command slice (must
-// expose one `Plugin_Slice_Ctor` field per constructor).
+// expose one `Plugin_Command` field per constructor).
 @schema
 type dcbSingleCommand =
   | AddCategory({categoryId: @s.matches(Reventless.DcbTag.string) string, name: string})
@@ -802,21 +802,22 @@ describe("DCB StateChangeSlice — one mutation per command constructor", () =>
     expect(fieldNames)->toEqual(["Catalog_AddCategory"])
   })
 
-  testPromise("multi-command slice emits one field per constructor", async () => {
+  testPromise("multi-command slice emits one `${plugin}_${command}` field per constructor", async () => {
+    // The command constructor already names the operation; callers/plans expect
+    // `${plugin}_${command}` (e.g. Platform_SyncComponent / Platform_RemoveComponent),
+    // NOT the aggregate-style `${plugin}_${slice}_${command}` doubling — which both
+    // renamed the primary command and overflowed AppSync's subscription cap.
     let fieldNames =
       ReventlessCore.Api_Naming.sliceMutationFields(
         ~plugin="Ordering",
         ~slice="SyncCatalogProduct",
         ~commandSchema=dcbMultiCommandSchema->S.castToUnknown,
       )->Array.map(((f, _)) => f)
-    expect(fieldNames)->toEqual([
-      "Ordering_SyncCatalogProduct_SyncNewProduct",
-      "Ordering_SyncCatalogProduct_ChangeSyncedPrice",
-    ])
+    expect(fieldNames)->toEqual(["Ordering_SyncNewProduct", "Ordering_ChangeSyncedPrice"])
   })
 
   testPromise(
-    "multi-command slice: both mutations carry their own args, plus both subscriptions",
+    "multi-command slice: both mutations carry their own args, plus both subscriptions (each ≤ 50 chars)",
     async () => {
       let fieldNames =
         ReventlessCore.Api_Naming.sliceMutationFields(
@@ -834,12 +835,12 @@ describe("DCB StateChangeSlice — one mutation per command constructor", () =>
       // Each constructor's mutation carries that constructor's own argument shape.
       expect(
         sdl->String.includes(
-          "Ordering_SyncCatalogProduct_SyncNewProduct(id: ID!, productId: ID!, name: String!, price: Float!)",
+          "Ordering_SyncNewProduct(id: ID!, productId: ID!, name: String!, price: Float!)",
         ),
       )->toBe(true)
       expect(
         sdl->String.includes(
-          "Ordering_SyncCatalogProduct_ChangeSyncedPrice(id: ID!, productId: ID!, price: Float!)",
+          "Ordering_ChangeSyncedPrice(id: ID!, productId: ID!, price: Float!)",
         ),
       )->toBe(true)
 
@@ -849,8 +850,38 @@ describe("DCB StateChangeSlice — one mutation per command constructor", () =>
         ~eventLogEntries=[],
       )
       let subSdl = subs.subscriptionFields->Array.join("\n")
-      expect(subSdl->String.includes("onOrdering_SyncCatalogProduct_SyncNewProduct"))->toBe(true)
-      expect(subSdl->String.includes("onOrdering_SyncCatalogProduct_ChangeSyncedPrice"))->toBe(true)
+      expect(subSdl->String.includes("onOrdering_SyncNewProduct"))->toBe(true)
+      expect(subSdl->String.includes("onOrdering_ChangeSyncedPrice"))->toBe(true)
+
+      // Every emitted subscription field name stays within AppSync's 50-char cap.
+      subs.subscriptionFields->Array.forEach(sub => {
+        // `sub` is the full SDL line `  on<Field>(id: ID): CommandResult\n ...`;
+        // extract the leading `on<Field>` token to length-check the field name itself.
+        let name =
+          sub->String.trim->String.split("(")->Array.getUnsafe(0)
+        expect(name->String.length <= 50)->toBe(true)
+      })
+    },
+  )
+
+  testPromise(
+    "regression: a slice whose plugin+command overflow the 50-char cap fails at build, not at AppSync",
+    async () => {
+      // `on` + `Platform_SyncExtensionWiring_RemoveExtensionWiring` (the old doubled
+      // shape) was 52 chars → AppSync rejected the schema push with an opaque 500.
+      // A field long enough to overflow must now throw an actionable build-time error.
+      let longPlugin = "PlatformIntegrationOrchestration"
+      let field = ReventlessCore.Api_Naming.dcbCommandMutationField(
+        ~plugin=longPlugin,
+        ~command="RemoveExtensionWiring",
+      )
+      let raised = try {
+        let _ = ReventlessCore.Api_Naming.assertSubscriptionNameFits(~fieldName=field)
+        false
+      } catch {
+      | JsExn(_) => true
+      }
+      expect(raised)->toBe(true)
     },
   )
 })

package/tests/adapter/GraphQL_SchemaInspectorTest.res.mjs

@@ -3,6 +3,7 @@
 import * as S from "sury/src/S.res.mjs";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
+import * as Primitive_exceptions from "@rescript/runtime/lib/es6/Primitive_exceptions.js";
 import * as Api_Naming$ReventlessCore from "@reventlessdev/reventless-core/src/components/Api/Api_Naming.res.mjs";
 import * as TestRunner$ReventlessLocal from "../../src/test/TestRunner.res.mjs";
 import * as StateAnnotations$Reventless from "@reventlessdev/reventless-spec/src/components/StateAnnotations.res.mjs";
@@ -578,29 +579,49 @@ globalThis.describe("DCB StateChangeSlice — one mutation per command construct
     let fieldNames = Api_Naming$ReventlessCore.sliceMutationFields("Catalog", "AddCategory", dcbSingleCommandSchema).map(param => param[0]);
     globalThis.expect(fieldNames).toEqual(["Catalog_AddCategory"]);
   });
-  globalThis.test("multi-command slice emits one field per constructor", async () => {
+  globalThis.test("multi-command slice emits one `${plugin}_${command}` field per constructor", async () => {
     let fieldNames = Api_Naming$ReventlessCore.sliceMutationFields("Ordering", "SyncCatalogProduct", dcbMultiCommandSchema).map(param => param[0]);
     globalThis.expect(fieldNames).toEqual([
-      "Ordering_SyncCatalogProduct_SyncNewProduct",
-      "Ordering_SyncCatalogProduct_ChangeSyncedPrice"
+      "Ordering_SyncNewProduct",
+      "Ordering_ChangeSyncedPrice"
     ]);
   });
-  globalThis.test("multi-command slice: both mutations carry their own args, plus both subscriptions", async () => {
+  globalThis.test("multi-command slice: both mutations carry their own args, plus both subscriptions (each ≤ 50 chars)", async () => {
     let fieldNames = Api_Naming$ReventlessCore.sliceMutationFields("Ordering", "SyncCatalogProduct", dcbMultiCommandSchema).map(param => param[0]);
     let fragment = GraphQL_FragmentGenerator$ReventlessCore.generate([{
         fieldNames: fieldNames,
         commandSchema: dcbMultiCommandSchema
       }], []);
     let sdl = GraphQL_SchemaInspector$ReventlessCore.inspectFragment(fragment).sdlPreview;
-    globalThis.expect(sdl.includes("Ordering_SyncCatalogProduct_SyncNewProduct(id: ID!, productId: ID!, name: String!, price: Float!)")).toBe(true);
-    globalThis.expect(sdl.includes("Ordering_SyncCatalogProduct_ChangeSyncedPrice(id: ID!, productId: ID!, price: Float!)")).toBe(true);
+    globalThis.expect(sdl.includes("Ordering_SyncNewProduct(id: ID!, productId: ID!, name: String!, price: Float!)")).toBe(true);
+    globalThis.expect(sdl.includes("Ordering_ChangeSyncedPrice(id: ID!, productId: ID!, price: Float!)")).toBe(true);
     let subs = Plugin_SubscriptionSchema$ReventlessCore.generate([{
         fieldNames: fieldNames,
         commandSchema: dcbMultiCommandSchema
       }], []);
     let subSdl = subs.subscriptionFields.join("\n");
-    globalThis.expect(subSdl.includes("onOrdering_SyncCatalogProduct_SyncNewProduct")).toBe(true);
-    globalThis.expect(subSdl.includes("onOrdering_SyncCatalogProduct_ChangeSyncedPrice")).toBe(true);
+    globalThis.expect(subSdl.includes("onOrdering_SyncNewProduct")).toBe(true);
+    globalThis.expect(subSdl.includes("onOrdering_ChangeSyncedPrice")).toBe(true);
+    subs.subscriptionFields.forEach(sub => {
+      let name = sub.trim().split("(")[0];
+      globalThis.expect(name.length <= 50).toBe(true);
+    });
+  });
+  globalThis.test("regression: a slice whose plugin+command overflow the 50-char cap fails at build, not at AppSync", async () => {
+    let field = Api_Naming$ReventlessCore.dcbCommandMutationField("PlatformIntegrationOrchestration", "RemoveExtensionWiring");
+    let raised;
+    try {
+      Api_Naming$ReventlessCore.assertSubscriptionNameFits(field);
+      raised = false;
+    } catch (raw_exn) {
+      let exn = Primitive_exceptions.internalToException(raw_exn);
+      if (exn.RE_EXN_ID === "JsExn") {
+        raised = true;
+      } else {
+        throw exn;
+      }
+    }
+    globalThis.expect(raised).toBe(true);
   });
 });