@reventlessdev/reventless-core 3.0.0-alpha.300 → 3.0.0-alpha.302

package/tests/aggregate/AggregateFixtures.res

@@ -25,10 +25,10 @@ module AggSpec = {
 }
 
 // ─────────────────────────────────────────────────────────────
-// Behavior
+// Decision
 // ─────────────────────────────────────────────────────────────
 
-module TestBehavior = {
+module TestDecision = {
   module Spec = AggSpec
 
   @schema
@@ -36,8 +36,8 @@ module TestBehavior = {
 
   let initialState = NotCreated
 
-  // Hand-written behavior (no @@reventless.behavior PPX) — satisfy the
-  // Behavior.T snapshot field manually.
+  // Hand-written decision (no @@reventless.decision PPX) — satisfy the
+  // Decision.T snapshot field manually.
   let snapshot = None
 
   let moduleUrl: string = %raw(`import.meta.url`)
@@ -167,7 +167,7 @@ module TestOps = {
 // Callback handler under test
 // ─────────────────────────────────────────────────────────────
 
-module TestHandler = Aggregate_Callback.Make(AggSpec, TestBehavior, TestOps)
+module TestHandler = Aggregate_Callback.Make(AggSpec, TestDecision, TestOps)
 
 // ─────────────────────────────────────────────────────────────
 // Test helpers

package/tests/aggregate/AggregateFixtures.res.mjs

@@ -114,7 +114,7 @@ function decide(state, command) {
   }
 }
 
-let TestBehavior = {
+let TestDecision = {
   Spec: undefined,
   stateSchema: stateSchema,
   initialState: "NotCreated",
@@ -306,7 +306,7 @@ let OuterEventLog;
 
 export {
   AggSpec,
-  TestBehavior,
+  TestDecision,
   makeMockEL,
   mock,
   OuterEventLog,

package/tests/aggregate/AggregateRejectionTest.res

@@ -1,5 +1,5 @@
 // Tests for the Aggregate decide-rejection propagation path.
-// Verifies that domain rejections from Behavior.decide:
+// Verifies that domain rejections from Decision.decide:
 //   1. Surface to producers via CommandTopic_Helpers.rejectedResultChannel (with errorCode + detail)
 //   2. Return Ok(reference) so async (SQS) consumers delete the message — domain rejections don't redeliver
 //   3. Don't cancel surviving commands inside the same batch

package/tests/aggregate/AggregateSnapshotTest.res

@@ -1,5 +1,5 @@
 // Step 5 of docs/plans/done/aggregate-snapshotting.md — the Aggregate_Callback
-// snapshot wiring: a snapshot-enabled behavior seeds cold replays from the
+// snapshot wiring: a snapshot-enabled decision seeds cold replays from the
 // latest persisted snapshot (hash-gated) and writes a fresh one every
 // `interval` events, fire-and-forget. Snapshots never affect correctness — the
 // OCC append is the only consistency primitive — so a drifted/absent snapshot
@@ -28,7 +28,7 @@ module AggSpec = {
   let moduleUrl: string = %raw(`import.meta.url`)
 }
 
-module TestBehavior = {
+module TestDecision = {
   module Spec = AggSpec
 
   @schema
@@ -205,11 +205,11 @@ module MakeOps = (
 module TestOps = MakeOps({
   let name = "SnapshotMockEventLog"
 })
-module TestHandler = Aggregate_Callback.Make(AggSpec, TestBehavior, TestOps)
+module TestHandler = Aggregate_Callback.Make(AggSpec, TestDecision, TestOps)
 
-// A second behavior with snapshots DISABLED, sharing the same mock, to prove
+// A second decision with snapshots DISABLED, sharing the same mock, to prove
 // disabled aggregates do zero snapshot traffic.
-module PlainBehavior = {
+module PlainDecision = {
   module Spec = AggSpec
 
   @schema
@@ -233,7 +233,7 @@ module PlainBehavior = {
 module PlainOps = MakeOps({
   let name = "PlainMockEventLog"
 })
-module PlainHandler = Aggregate_Callback.Make(AggSpec, PlainBehavior, PlainOps)
+module PlainHandler = Aggregate_Callback.Make(AggSpec, PlainDecision, PlainOps)
 
 let makeItem = (~id="agg-1", reference, command): CommandTopic.topicItem<
   Message.command'<string, AggSpec.command>,
@@ -318,7 +318,7 @@ describe("Aggregate_Callback — snapshots:", () => {
     | Some(snap) =>
       expect(snap.seqNr)->toBe(20)
       // 20 items folded through the seeded state — no double-count, no gap.
-      let decoded = snap.state->Reventless.Util_Sury.fromJson(TestBehavior.stateSchema)
+      let decoded = snap.state->Reventless.Util_Sury.fromJson(TestDecision.stateSchema)
       expect(decoded.items->Array.length)->toBe(20)
     | None => expect("expected snapshot at 20")->toBe("none")
     }

package/tests/aggregate/AggregateSnapshotTest.res.mjs

@@ -88,7 +88,7 @@ function decide(_state, command) {
   }
 }
 
-let TestBehavior = {
+let TestDecision = {
   Spec: undefined,
   stateSchema: stateSchema,
   initialState: initialState,
@@ -369,7 +369,7 @@ function decide$1(_state, command) {
   }
 }
 
-let PlainBehavior = {
+let PlainDecision = {
   Spec: undefined,
   stateSchema: stateSchema$1,
   initialState: initialState$1,
@@ -642,7 +642,7 @@ let OuterEventLog;
 
 export {
   AggSpec,
-  TestBehavior,
+  TestDecision,
   testMeta,
   makeMockEL,
   mock,
@@ -650,7 +650,7 @@ export {
   MakeOps,
   TestOps,
   TestHandler,
-  PlainBehavior,
+  PlainDecision,
   PlainOps,
   PlainHandler,
   makeItem,

package/tests/api/PsInternalFieldsReadModel.res

@@ -4,7 +4,7 @@
 //
 // A spec file rather than a module inside the test, and named `*ReadModel*`
 // deliberately: the annotation machinery runs under `@@reventless.spec` AND only
-// for a file the PPX recognises as a read model or state view. That is also the
+// for a file the PPX recognizes as a read model or state view. That is also the
 // honest scope for `@internal` — it describes a read model's state.
 
 @@reventless.spec("InternalFieldsReadModel")

package/tests/api/TaggedUnionSchemaTest.res

@@ -129,7 +129,7 @@ describe("GraphQL_FragmentGenerator emits a union", () => {
     expect(row->String.includes("history: [Geolocation!]!"))->toBe(true)
   })
 
-  // Unchanged behaviour, pinned: without a name there is no type to emit, and
+  // Unchanged behavior, pinned: without a name there is no type to emit, and
   // inventing one would publish a contract nothing can stamp a `__typename` for.
   testSync("an unnamed union stays a String", () => {
     let unnamed = fragmentFor(

package/tests/commandgenerator/CommandGeneratorCallbackTest.res

@@ -207,7 +207,7 @@ describe("CommandGenerator_Callback.generateCommand:", () => {
       },
     )
 
-    // The control the drop is modelled on: absent and explicitly-null must
+    // The control the drop is modeled on: absent and explicitly-null must
     // reach the domain as the same command.
     testPromise(
       "and one simply omitted produce the same command",

package/tests/commandgenerator/CommandGeneratorFixtures.res

@@ -26,10 +26,10 @@ module CmdGenAggSpec = {
 }
 
 // ─────────────────────────────────────────────────────────────
-// Behavior
+// Decision
 // ─────────────────────────────────────────────────────────────
 
-module CmdGenBehavior = {
+module CmdGenDecision = {
   module Spec = CmdGenAggSpec
   type state = unit
 

package/tests/commandgenerator/CommandGeneratorFixtures.res.mjs

@@ -80,7 +80,7 @@ function decide(_state, command) {
   }
 }
 
-let CmdGenBehavior = {
+let CmdGenDecision = {
   Spec: undefined,
   moduleUrl: moduleUrl$1,
   initialState: undefined,
@@ -212,7 +212,7 @@ function reset() {
 
 export {
   CmdGenAggSpec,
-  CmdGenBehavior,
+  CmdGenDecision,
   capturedCmds,
   MockPublishSpec,
   TestGenerator,

package/tests/commandgenerator/OwnerActingTest.res

@@ -54,7 +54,7 @@ module OrderSlice = {
     | OrderNotFound
 }
 
-module OrderBehavior = {
+module OrderDecision = {
   type state = {placed: bool, cancelled: bool}
   let initialState = {placed: false, cancelled: false}
   let moduleUrl = OrderSlice.moduleUrl
@@ -83,7 +83,7 @@ module OrderBehavior = {
     }
 }
 
-module OrderHandler = StateChangeSlice_Callback.Make(OrderSlice, OrderBehavior)
+module OrderHandler = StateChangeSlice_Callback.Make(OrderSlice, OrderDecision)
 
 let dcbMock = DcbFixtures.makeMockStorage()
 
@@ -128,7 +128,7 @@ module AccountSpec = {
   let moduleUrl: string = %raw(`import.meta.url`)
 }
 
-module AccountBehavior = {
+module AccountDecision = {
   module Spec = AccountSpec
 
   @schema
@@ -210,7 +210,7 @@ module AccountOps = {
   }
 }
 
-module AccountHandler = Aggregate_Callback.Make(AccountSpec, AccountBehavior, AccountOps)
+module AccountHandler = Aggregate_Callback.Make(AccountSpec, AccountDecision, AccountOps)
 
 // ─── Callers ────────────────────────────────────────────────────────────────
 

package/tests/commandgenerator/OwnerActingTest.res.mjs

@@ -175,7 +175,7 @@ function decide(state, command) {
   }
 }
 
-let OrderBehavior = {
+let OrderDecision = {
   initialState: initialState,
   moduleUrl: moduleUrl,
   evolve: evolve,
@@ -352,7 +352,7 @@ function decide$1(state, command) {
   }
 }
 
-let AccountBehavior = {
+let AccountDecision = {
   Spec: undefined,
   stateSchema: stateSchema,
   initialState: "NotOpen",
@@ -978,7 +978,7 @@ let OuterEventLog;
 
 export {
   OrderSlice,
-  OrderBehavior,
+  OrderDecision,
   OrderHandler,
   dcbMock,
   DcbOps,
@@ -986,7 +986,7 @@ export {
   dcbEventLog,
   orderPartition,
   AccountSpec,
-  AccountBehavior,
+  AccountDecision,
   accountEvents,
   snapshotReads,
   OuterEventLog,

package/tests/commandgenerator/OwnerStampingTest.res

@@ -224,7 +224,7 @@ describe("the schema a generator is built with must answer for its commands:", (
     let _ = await permissive(
       placeOrder(~customerId="cust-B", ~identity=cognito(~userId="cust-A", ~groups=["User"])),
     )->Effect.runPromise
-    // Not the behaviour we want anywhere — recorded so that a change making the
+    // Not the behavior we want anywhere — recorded so that a change making the
     // permissive path stamp correctly is a deliberate one, and so the contrast
     // with the case below cannot be read as incidental.
     expect(lastPublished()->fieldOf("customerId"))->toEqual(Some(str("cust-B")))

package/tests/commandtopic/CommandOutcomeHookTest.res

@@ -25,7 +25,7 @@ let dcbEventLog: DcbEventLog.operations = {
   appendStream: EventLogOps.appendStream,
 }
 
-module SliceBehavior = {
+module SliceDecision = {
   type state = DcbFixtures.TestCommandSpec.state
   let initialState = DcbFixtures.TestCommandSpec.initialState
   let evolve = DcbFixtures.TestCommandSpec.evolve
@@ -33,7 +33,7 @@ module SliceBehavior = {
   let moduleUrl = DcbFixtures.TestCommandSpec.moduleUrl
 }
 
-module SliceHandler = StateChangeSlice_Callback.Make(DcbFixtures.TestCommandSpec, SliceBehavior)
+module SliceHandler = StateChangeSlice_Callback.Make(DcbFixtures.TestCommandSpec, SliceDecision)
 
 let sliceItem = (reference, command): CommandTopic.topicItem<
   Message.command'<Reventless.Id.String.t, DcbFixtures.TestCommandSpec.command>,

package/tests/commandtopic/CommandOutcomeHookTest.res.mjs

@@ -49,7 +49,7 @@ let decide = DcbFixtures$ReventlessCore.TestCommandSpec.decide;
 
 let moduleUrl = DcbFixtures$ReventlessCore.TestCommandSpec.moduleUrl;
 
-let SliceBehavior = {
+let SliceDecision = {
   initialState: initialState,
   evolve: evolve,
   decide: decide,
@@ -67,7 +67,7 @@ let SliceHandler = StateChangeSlice_Callback$ReventlessCore.Make({
   commandTransition: DcbFixtures$ReventlessCore.TestCommandSpec.commandTransition,
   traits: DcbFixtures$ReventlessCore.TestCommandSpec.traits,
   readConsistency: DcbFixtures$ReventlessCore.TestCommandSpec.readConsistency
-})(SliceBehavior);
+})(SliceDecision);
 
 function sliceItem(reference, command) {
   return {
@@ -373,7 +373,7 @@ export {
   TestDcbOps,
   EventLogOps,
   dcbEventLog,
-  SliceBehavior,
+  SliceDecision,
   SliceHandler,
   sliceItem,
   runSlice,

package/tests/dcb/DcbStateChangeSliceTest.res

@@ -18,7 +18,7 @@ let testDcbEventLog: DcbEventLog.operations = {
   appendStream: EventLogOps.appendStream,
 }
 
-module TestCommandBehavior = {
+module TestCommandDecision = {
   type state = DcbFixtures.TestCommandSpec.state
   let initialState = DcbFixtures.TestCommandSpec.initialState
   let evolve = DcbFixtures.TestCommandSpec.evolve
@@ -27,10 +27,10 @@ module TestCommandBehavior = {
 }
 module TestHandler = StateChangeSlice_Callback.Make(
   DcbFixtures.TestCommandSpec,
-  TestCommandBehavior,
+  TestCommandDecision,
 )
 
-// Per-slice `readConsistency` overrides: same types/behavior as TestCommandSpec,
+// Per-slice `readConsistency` overrides: same types/decision as TestCommandSpec,
 // only the build-time consistency mode differs. The default (TestCommandSpec) is
 // `EscalateOnRetry`; these force strong / eventual on every attempt.
 module StrongSpec = {
@@ -41,8 +41,8 @@ module EventualSpec = {
   include DcbFixtures.TestCommandSpec
   let readConsistency = Reventless.ReadConsistency.AlwaysEventual
 }
-module StrongHandler = StateChangeSlice_Callback.Make(StrongSpec, TestCommandBehavior)
-module EventualHandler = StateChangeSlice_Callback.Make(EventualSpec, TestCommandBehavior)
+module StrongHandler = StateChangeSlice_Callback.Make(StrongSpec, TestCommandDecision)
+module EventualHandler = StateChangeSlice_Callback.Make(EventualSpec, TestCommandDecision)
 
 let makeTopicItem = (reference, command): CommandTopic.topicItem<
   Message.command'<Reventless.Id.String.t, DcbFixtures.TestCommandSpec.command>,

package/tests/dcb/DcbStateChangeSliceTest.res.mjs

@@ -45,7 +45,7 @@ let decide = DcbFixtures$ReventlessCore.TestCommandSpec.decide;
 
 let moduleUrl = DcbFixtures$ReventlessCore.TestCommandSpec.moduleUrl;
 
-let TestCommandBehavior = {
+let TestCommandDecision = {
   initialState: initialState,
   evolve: evolve,
   decide: decide,
@@ -63,7 +63,7 @@ let TestHandler = StateChangeSlice_Callback$ReventlessCore.Make({
   commandTransition: DcbFixtures$ReventlessCore.TestCommandSpec.commandTransition,
   traits: DcbFixtures$ReventlessCore.TestCommandSpec.traits,
   readConsistency: DcbFixtures$ReventlessCore.TestCommandSpec.readConsistency
-})(TestCommandBehavior);
+})(TestCommandDecision);
 
 let name = DcbFixtures$ReventlessCore.TestCommandSpec.name;
 
@@ -162,7 +162,7 @@ let StrongHandler = StateChangeSlice_Callback$ReventlessCore.Make({
   commandTransition: commandTransition,
   traits: traits,
   readConsistency: "AlwaysStrong"
-})(TestCommandBehavior);
+})(TestCommandDecision);
 
 let EventualHandler = StateChangeSlice_Callback$ReventlessCore.Make({
   name: name$1,
@@ -175,7 +175,7 @@ let EventualHandler = StateChangeSlice_Callback$ReventlessCore.Make({
   commandTransition: commandTransition$1,
   traits: traits$1,
   readConsistency: "AlwaysEventual"
-})(TestCommandBehavior);
+})(TestCommandDecision);
 
 function makeTopicItem(reference, command) {
   return {
@@ -544,7 +544,7 @@ export {
   TestDcbOps,
   EventLogOps,
   testDcbEventLog,
-  TestCommandBehavior,
+  TestCommandDecision,
   TestHandler,
   StrongSpec,
   EventualSpec,

package/tests/message/MessageTest.res

@@ -158,7 +158,7 @@ describe("Message should", () => {
       let json = event'->Message.encodeEvent'(S.string, PluginSpec.eventSchema)
 
       // Simulate the persisted JSON as written before these fields existed: drop the
-      // mandatory enum `kind`, a top-level `T | null` field, and two nested writableDef
+      // mandatory enum `kind`, a top-level `T | null` field, and two nested writeSideDef
       // fields (a mandatory array + a `T | null`).
       let oldJson = %raw(`function(j){
         var c = JSON.parse(JSON.stringify(j));

package/tests/plugin/ManifestVisibilityTest.res

@@ -1,7 +1,7 @@
 // Verifies that ReadModel.Spec.visibility flows through PPX injection, that the
 // filter predicate used by Plugin_Builder.makeAutoUIManifest excludes Internal
 // entries while leaving Public ones intact, and that Plugin_Structure.make
-// CARRIES Internal entries but tags them via `queryableDef.visibility` (the
+// CARRIES Internal entries but tags them via `readSideDef.visibility` (the
 // dev-graph contract). Does NOT instantiate the full Plugin_Builder.Make functor
 // — the filter is a pure switch on a Spec field and is therefore testable in
 // isolation via stubbed ReadModel.T modules.
@@ -120,7 +120,7 @@ describe("ReadModel visibility filter", () => {
 
 describe("Plugin_Structure.make — visibility tagging", () => {
   // pluginStructure CARRIES Internal read models (so the dev graph / dead-code
-  // tools can see them) and tags each via `queryableDef.visibility`
+  // tools can see them) and tags each via `readSideDef.visibility`
   // (`None` = Public, `Some("Internal")` = Internal). The deployed AutoUI
   // consumers re-filter on that tag — visibility does not remove entries from
   // pluginStructure itself. See Plugin_Structure.res / Visibility.res.

package/tests/plugin/PluginStructureAccessTest.res

@@ -18,7 +18,7 @@ type svsComponent = Component.t<
 
 module PsGatedCommandsSlice: ReventlessInfra.StateChangeSlice.T = {
   module Spec = PsGatedCommands
-  module Behavior = {
+  module Decision = {
     type state = PsGatedCommands.state
     let initialState = PsGatedCommands.initialState
     let evolve = PsGatedCommands.evolve

package/tests/plugin/PluginStructureAccessTest.res.mjs

@@ -12,7 +12,7 @@ import * as PsGatedCommands$ReventlessCore from "./StateChange/PsGatedCommands.r
 import * as Plugin_Structure$ReventlessCore from "../../src/plugin/component/Plugin_Structure.res.mjs";
 import * as Platform_ComponentDefinitionsApi$ReventlessCore from "../../src/admin/Platform_ComponentDefinitionsApi.res.mjs";
 
-let Behavior = {
+let Decision = {
   initialState: false,
   evolve: PsGatedCommands$ReventlessCore.evolve,
   decide: PsGatedCommands$ReventlessCore.decide,
@@ -38,7 +38,7 @@ let PsGatedCommandsSlice_Spec = {
 
 let PsGatedCommandsSlice = {
   Spec: PsGatedCommandsSlice_Spec,
-  Behavior: Behavior,
+  Decision: Decision,
   isAsync: false,
   make: make
 };
@@ -56,7 +56,7 @@ let PsGatedViewSlice_Spec = {
   name: PsGatedView$ReventlessCore.name,
   moduleUrl: PsGatedView$ReventlessCore.moduleUrl,
   stateSchema: PsGatedView$ReventlessCore.stateSchema,
-  Key: {
+  Id: {
     schema: Id$Reventless.StringPure.schema,
     make: prim => prim,
     makeFromString: prim => prim,
@@ -89,7 +89,7 @@ let PsOrdersViewSlice_Spec = {
   name: PsOrdersView$ReventlessCore.name,
   moduleUrl: PsOrdersView$ReventlessCore.moduleUrl,
   stateSchema: PsOrdersView$ReventlessCore.stateSchema,
-  Key: {
+  Id: {
     schema: Id$Reventless.StringPure.schema,
     make: prim => prim,
     makeFromString: prim => prim,