@reventlessdev/reventless-core 3.0.0-alpha.275 → 3.0.0-alpha.276

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.276 (2026-09-25)
+
+### Bug Fixes
+
+* **spec:** a chapter that carries both keys backs neither ([cbd823e](https://github.com/ReventlessDev/reventless-core/commit/cbd823e4f87ddd5810debd929bb536b2003d0e4c))
+
+
 # 3.0.0-alpha.275 (2026-09-25)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.275",
+  "version": "3.0.0-alpha.276",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -30,15 +30,15 @@
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.34",
     "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.15",
-    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.15",
-    "@reventlessdev/rescript-jest": "1.0.0-alpha.11",
     "@reventlessdev/rescript-node": "2.0.0-alpha.15",
+    "@reventlessdev/rescript-jest": "1.0.0-alpha.11",
+    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.15",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.22",
     "@reventlessdev/rescript-ssh2": "2.0.0-alpha.15",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.1",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.175",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.38",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.147"
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.176",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.148",
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.38"
   },
   "devDependencies": {
     "rescript": "12.3.1",

package/tests/dcb/DcbScopeInferenceTest.res

@@ -545,12 +545,37 @@ describe("DcbScopeInference:", () => {
       },
     )
 
+    // Every producer is present, so the arms it reads by `categoryId` all come from
+    // category slices: only the chapter can refuse the hint.
+    let categories = [
+      {...addCategory, chapter: "Category"},
+      {...renameCategory, chapter: "Category"},
+      {...archiveCategory, chapter: "Category"},
+    ]
+
     testSync(
       "a hint its chapter disagrees with is still a contradiction",
       () => {
-        // Every event under `Product/` carries `productId`, not `categoryId`.
+        // `RenameProduct` writes only `productId`, so `Product/` is about products.
+        let renameProduct = slice(
+          "RenameProduct",
+          ~chapter="Product",
+          ~consumed=[ev("ProductAdded", [scal("productId")])],
+          ~produced=[ev("ProductRenamed", [scal("productId")])],
+        )
+        let inProduct = {...hinted(addProduct, "categoryId"), chapter: "Product"}
+        let issues = check([inProduct, renameProduct, ...categories])
+        expect(issues.contradictions->names)->toEqual(["AddProduct"])
+        expect(issues.overrides)->toEqual([])
+      },
+    )
+
+    testSync(
+      "a chapter that carries both keys everywhere backs neither",
+      () => {
+        // One slice, one event with both ids: the chapter cannot say which one it is about.
         let inProduct = {...hinted(addProduct, "categoryId"), chapter: "Product"}
-        let issues = check([inProduct, {...addCategory, chapter: "Category"}])
+        let issues = check([inProduct, ...categories])
         expect(issues.contradictions->names)->toEqual(["AddProduct"])
         expect(issues.overrides)->toEqual([])
       },

package/tests/dcb/DcbScopeInferenceTest.res.mjs

@@ -1,5 +1,6 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
+import * as Belt_Array from "@rescript/runtime/lib/es6/Belt_Array.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Primitive_string from "@rescript/runtime/lib/es6/Primitive_string.js";
 import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
@@ -884,14 +885,47 @@ globalThis.describe("DcbScopeInference:", () => {
       globalThis.expect(issues.contradictions.map(e => e.sliceName)).toEqual(["ShipOrder"]);
       globalThis.expect(issues.overrides).toEqual([]);
     });
+    let newrecord = {...addCategory};
+    let newrecord$1 = {...renameCategory};
+    let newrecord$2 = {...archiveCategory};
+    let categories = [
+      (newrecord.chapter = "Category", newrecord),
+      (newrecord$1.chapter = "Category", newrecord$1),
+      (newrecord$2.chapter = "Category", newrecord$2)
+    ];
     globalThis.test("a hint its chapter disagrees with is still a contradiction", () => {
+      let renameProduct = slice("RenameProduct", undefined, [{
+          eventType: "ProductAdded",
+          idFields: [{
+              name: "productId",
+              isList: false
+            }]
+        }], [{
+          eventType: "ProductRenamed",
+          idFields: [{
+              name: "productId",
+              isList: false
+            }]
+        }], undefined, "Product");
       let newrecord = {...hinted(addProduct, "categoryId")};
       newrecord.chapter = "Product";
-      let newrecord$1 = {...addCategory};
-      let issues = DcbValidation$Reventless.validatePartitionHintsVsInference([
-        newrecord,
-        (newrecord$1.chapter = "Category", newrecord$1)
-      ]);
+      let issues = DcbValidation$Reventless.validatePartitionHintsVsInference(Belt_Array.concatMany([
+        [
+          newrecord,
+          renameProduct
+        ],
+        categories
+      ]));
+      globalThis.expect(issues.contradictions.map(e => e.sliceName)).toEqual(["AddProduct"]);
+      globalThis.expect(issues.overrides).toEqual([]);
+    });
+    globalThis.test("a chapter that carries both keys everywhere backs neither", () => {
+      let newrecord = {...hinted(addProduct, "categoryId")};
+      newrecord.chapter = "Product";
+      let issues = DcbValidation$Reventless.validatePartitionHintsVsInference(Belt_Array.concatMany([
+        [newrecord],
+        categories
+      ]));
       globalThis.expect(issues.contradictions.map(e => e.sliceName)).toEqual(["AddProduct"]);
       globalThis.expect(issues.overrides).toEqual([]);
     });