@reventlessdev/reventless-core 3.0.0-alpha.272 → 3.0.0-alpha.273

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.273 (2026-09-24)
+
+### Features
+
+* **dcb:** a command reference no decision reads by stays out of the query ([3ae149a](https://github.com/ReventlessDev/reventless-core/commit/3ae149ae91ebab63413be57df5827c5fd4390160))
+
+
 # 3.0.0-alpha.272 (2026-09-23)
 
 **Note:** Version bump only for package @reventlessdev/reventless-core

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.272",
+  "version": "3.0.0-alpha.273",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -29,21 +29,21 @@
     "sury": "11.0.0",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.34",
+    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.15",
     "@reventlessdev/rescript-hash-object": "1.2.0-alpha.15",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.11",
     "@reventlessdev/rescript-node": "2.0.0-alpha.15",
-    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.15",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.22",
     "@reventlessdev/rescript-ssh2": "2.0.0-alpha.15",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.1",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.38",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.172",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.144"
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.173",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.145",
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.38"
   },
   "devDependencies": {
     "rescript": "12.3.1",
     "sury-ppx": "11.0.0",
-    "@reventlessdev/reventless-ppx": "1.0.0-alpha.89"
+    "@reventlessdev/reventless-ppx": "1.0.0-alpha.92"
   },
   "peerDependencies": {
     "rescript": "^12.3.1"

package/src/components/Dcb/Dcb_Builder.res

@@ -306,21 +306,6 @@ module Make = (
         ->Array.map(schema => Reventless.DcbTag.extractTagKeysByEventType(schema))
         ->Reventless.DcbTag.mergeTagKeysByEventType
 
-      // Warn on composite (multi-tag) decision reads that would silently miss an
-      // event carrying extra tags (the tag_composite key is the event's full tag
-      // set, so composite reads are exact-match). Non-fatal — today's slices are
-      // aligned; the guard catches a tag added to a multi-tag event later.
-      Reventless.DcbValidation.validateCompositeReads(
-        ~slices=stateChangeSlices->Array.map((module(Sc: StateChangeSlice.T)) => (
-          Sc.Spec.name,
-          Sc.Spec.commandSchema->S.castToUnknown,
-          Sc.Spec.consumedEventSchema->S.castToUnknown,
-        )),
-        ~producedTagKeys=tagKeysByEventType,
-      )->Array.forEach(w =>
-        log.warn(~comp="Dcb_Builder", `DCB composite-read warning (${w.sliceName}): ${w.message}`)
-      )
-
       // --- Phase 2 (dcb-tag-scope-inference): derive scope from the global slice
       // graph and THREAD it into the decision-query wiring, replacing the
       // annotation-based extraction. The derived `tagKeysByEventType` is what
@@ -388,6 +373,32 @@ module Make = (
       let effectiveCrossPartitionTagKeys = effective.crossPartitionTagKeys
       let effectiveTagKeysByEventType = effective.tagKeysByEventType
 
+      // Warn on composite (multi-tag) decision reads that would silently miss an
+      // event carrying extra tags (the tag_composite key is the event's full tag
+      // set, so composite reads are exact-match). Non-fatal — today's slices are
+      // aligned; the guard catches a tag added to a multi-tag event later.
+      Reventless.DcbValidation.validateCompositeReads(
+        ~slices=stateChangeSlices->Array.map((module(Sc: StateChangeSlice.T)) => (
+          Sc.Spec.name,
+          Sc.Spec.commandSchema->S.castToUnknown,
+          Sc.Spec.consumedEventSchema->S.castToUnknown,
+        )),
+        ~producedTagKeys=tagKeysByEventType,
+        ~payloadTagKeysBySlice=sliceSchemas
+        ->Array.map(slice => (
+          slice.name,
+          slice
+          ->Reventless.DcbTag.sliceShape
+          ->Reventless.DcbTag.commandPayloadTagKeys(
+            ~partitionTag=partitionTagOf(slice.name),
+            ~crossPartitionTagKeys=effectiveCrossPartitionTagKeys,
+          ),
+        ))
+        ->Dict.fromArray,
+      )->Array.forEach(w =>
+        log.warn(~comp="Dcb_Builder", `DCB composite-read warning (${w.sliceName}): ${w.message}`)
+      )
+
       // An ambiguity is a warning above because a boundary can fall back and
       // lose nothing. Losing a cross-partition key is not that: the decision
       // read for every slice that references another entity silently narrows to

package/src/components/Dcb/Dcb_Builder.res.mjs

@@ -198,11 +198,6 @@ function Make(DcbEventLogStorage) {
       });
       DcbValidation$Reventless.validateCrossPartitionScope(produced).forEach(err => log.error("Dcb_Builder", undefined, `DCB cross-partition scope error (` + err.sliceName + `): ` + err.message));
       let tagKeysByEventType = DcbTag$Reventless.mergeTagKeysByEventType(producedSchemas.map(DcbTag$Reventless.extractTagKeysByEventType));
-      DcbValidation$Reventless.validateCompositeReads(stateChangeSlices.map(Sc => [
-        Sc.Spec.name,
-        Sc.Spec.commandSchema,
-        Sc.Spec.consumedEventSchema
-      ]), tagKeysByEventType).forEach(w => log.warn("Dcb_Builder", undefined, `DCB composite-read warning (` + w.sliceName + `): ` + w.message));
       let inferred = DcbScopeInference$Reventless.infer(inferenceShapes);
       if (Primitive_object.notequal(inferred.crossPartitionTagKeys, crossPartitionTagKeys)) {
         log.info("Dcb_Builder", undefined, `DCB scope-inference diff: crossPartitionTagKeys annotated=[` + crossPartitionTagKeys.join(", ") + `] inferred=[` + inferred.crossPartitionTagKeys.join(", ") + `]`);
@@ -227,6 +222,14 @@ function Make(DcbEventLogStorage) {
       let effective = DcbTag$Reventless.deriveEffectiveScope(sliceSchemas);
       let effectiveCrossPartitionTagKeys = effective.crossPartitionTagKeys;
       let effectiveTagKeysByEventType = effective.tagKeysByEventType;
+      DcbValidation$Reventless.validateCompositeReads(stateChangeSlices.map(Sc => [
+        Sc.Spec.name,
+        Sc.Spec.commandSchema,
+        Sc.Spec.consumedEventSchema
+      ]), tagKeysByEventType, Object.fromEntries(sliceSchemas.map(slice => [
+        slice.name,
+        DcbTag$Reventless.commandPayloadTagKeys(DcbTag$Reventless.sliceShape(slice), DcbTag$Reventless.slicePartitionTag(boundaryPartition, slice.name), effectiveCrossPartitionTagKeys)
+      ]))).forEach(w => log.warn("Dcb_Builder", undefined, `DCB composite-read warning (` + w.sliceName + `): ` + w.message));
       if (effective.droppedCrossPartitionTagKeys.length !== 0) {
         log.error("Dcb_Builder", undefined, `DCB scope degraded (` + name + `): cross-partition reads of [` + effective.droppedCrossPartitionTagKeys.join(", ") + `] were derived but dropped — an ambiguous slice forced the boundary onto @crossPartition annotations that do not carry them. Slices referencing another entity by these keys will decide against an empty history and reject valid commands. Resolve: ` + effective.ambiguities.map(param => param[0] + ` (` + param[1] + `)`).join(" | "));
       }

package/src/components/StateChangeSlice/StateChangeSlice_Callback.res

@@ -93,6 +93,15 @@ module Make = (
     }
   )
 
+  // A command key the slice does not decide by stays out of its query; which keys
+  // those are depends on the partition, so `handleCommands` asks per boundary.
+  let scopeShape = Reventless.DcbTag.sliceShapeFromSchemas(
+    ~name=Spec.name,
+    ~commandSchema=Spec.commandSchema,
+    ~consumedEventSchema=Spec.consumedEventSchema,
+    ~eventSchema=Spec.eventSchema,
+  )
+
   // Extracts the entity id of a read event from its own tags, for logging
   // which events the decision model was built from. Prefers this slice's
   // partition key, but consumed events from other sources are tagged by their
@@ -162,6 +171,7 @@ module Make = (
   let handleSingleCommand = (
     ~tagKeysByEventType,
     ~crossPartitionTagKeys,
+    ~payloadTagKeys,
     ~partitionTag,
     dcbEventLog: DcbEventLog.operations,
     command': Message.command'<Reventless.Id.String.t, Spec.command>,
@@ -186,6 +196,7 @@ module Make = (
       ~value=command'.command,
       ~tagKeysByEventType,
       ~crossPartitionTagKeys,
+      ~payloadTagKeys,
     )
 
     // Log the DCB query parameters — the OR clauses (event types + tags) the
@@ -504,11 +515,14 @@ module Make = (
     | Some(_) => partitionTag
     | None => slicePartitionTag->Lazy.get
     }
+    let payloadTagKeys =
+      scopeShape->Reventless.DcbTag.commandPayloadTagKeys(~partitionTag, ~crossPartitionTagKeys)
     stream
     ->Stream.mapEffect(({ReventlessInfra.CommandTopic.reference: reference, command}) =>
       handleSingleCommand(
         ~tagKeysByEventType,
         ~crossPartitionTagKeys,
+        ~payloadTagKeys,
         ~partitionTag,
         dcbEventLog,
         command,

package/src/components/StateChangeSlice/StateChangeSlice_Callback.res.mjs

@@ -36,6 +36,7 @@ function Make(Spec) {
         return;
       }
     });
+    let scopeShape = DcbTag$Reventless.sliceShapeFromSchemas(Spec.name, Spec.commandSchema, Spec.consumedEventSchema, Spec.eventSchema, undefined);
     let readEventId = (partitionTag, tags) => {
       let ownTagValues = () => {
         let vals = Stdlib_Array.reduce(tags, [], (acc, t) => {
@@ -70,10 +71,10 @@ function Make(Spec) {
     };
     let projectionCache = Lru$ReventlessCore.make(100);
     let resetCache = () => Lru$ReventlessCore.clear(projectionCache);
-    let handleSingleCommand = (tagKeysByEventType, crossPartitionTagKeys, partitionTag, dcbEventLog, command$p) => {
+    let handleSingleCommand = (tagKeysByEventType, crossPartitionTagKeys, payloadTagKeys, partitionTag, dcbEventLog, command$p) => {
       let cmdJson = Message$ReventlessCore.commandJsonOfCommand$p(Id$Reventless.$$String.toString, Spec.commandSchema, command$p);
       Effect.runSync(EffectLogger$ReventlessCore.logInfo(comp, cmdJson.commandJson, `handling command: ` + LogFormat$ReventlessCore.cmdDetailNoId(cmdJson)));
-      let query = DcbTag$Reventless.buildQueryFromCommand(queryEventTypes, Spec.commandSchema, command$p.command, tagKeysByEventType, crossPartitionTagKeys);
+      let query = DcbTag$Reventless.buildQueryFromCommand(queryEventTypes, Spec.commandSchema, command$p.command, tagKeysByEventType, crossPartitionTagKeys, payloadTagKeys);
       let queryDetail = query.map(qi => {
         let ts = qi.eventTypes;
         let types = ts !== undefined ? ts.map(LogFormat$ReventlessCore.bold).join("|") : "*";
@@ -315,9 +316,10 @@ function Make(Spec) {
       let tagKeysByEventType = tagKeysByEventTypeOpt !== undefined ? tagKeysByEventTypeOpt : ({});
       let crossPartitionTagKeys = crossPartitionTagKeysOpt !== undefined ? crossPartitionTagKeysOpt : [];
       let partitionTag$1 = partitionTag !== undefined ? partitionTag : Stdlib_Lazy.get(slicePartitionTag);
+      let payloadTagKeys = DcbTag$Reventless.commandPayloadTagKeys(scopeShape, partitionTag$1, crossPartitionTagKeys);
       return Stream.runCollect(Stream$1.mapEffect(stream, param => {
         let reference = param.reference;
-        return Effect.map(handleSingleCommand(tagKeysByEventType, crossPartitionTagKeys, partitionTag$1, dcbEventLog, param.command), result => {
+        return Effect.map(handleSingleCommand(tagKeysByEventType, crossPartitionTagKeys, payloadTagKeys, partitionTag$1, dcbEventLog, param.command), result => {
           if (result.TAG === "Ok") {
             return {
               TAG: "Ok",

package/tests/dcb/DcbTagTest.res.mjs

@@ -540,7 +540,7 @@ globalThis.describe("DcbTag:", () => {
         TAG: "CreateItem",
         itemId: "item-1",
         name: "Test"
-      }, undefined, undefined)).toEqual([{
+      }, undefined, undefined, undefined)).toEqual([{
           eventTypes: eventTypes,
           tags: [{
               key: "itemId",
@@ -557,7 +557,7 @@ globalThis.describe("DcbTag:", () => {
           "prod-1",
           "prod-2"
         ]
-      }, undefined, undefined)).toEqual([
+      }, undefined, undefined, undefined)).toEqual([
         {
           eventTypes: eventTypes,
           tags: [{
@@ -587,7 +587,7 @@ globalThis.describe("DcbTag:", () => {
         orderId: "ord-1",
         customerId: "cust-1",
         productId: ["prod-1"]
-      }, undefined, undefined)).toEqual([
+      }, undefined, undefined, undefined)).toEqual([
         {
           eventTypes: eventTypes,
           tags: [{
@@ -610,7 +610,7 @@ globalThis.describe("DcbTag:", () => {
         orderId: "ord-1",
         customerId: "cust-1",
         productId: []
-      }, undefined, undefined)).toEqual([{
+      }, undefined, undefined, undefined)).toEqual([{
           eventTypes: eventTypes,
           tags: [{
               key: "orderId",
@@ -644,7 +644,7 @@ globalThis.describe("DcbTag:", () => {
         orderId: "ord-1",
         customerId: "cust-1",
         productId: ["prod-1"]
-      }, orderTagKeys, undefined)).toEqual([
+      }, orderTagKeys, undefined, undefined)).toEqual([
         {
           eventTypes: ["OrderPlaced"],
           tags: [{
@@ -672,7 +672,7 @@ globalThis.describe("DcbTag:", () => {
         TAG: "CreateItem",
         itemId: "item-1",
         name: "Test"
-      }, orderTagKeys, undefined)).toEqual([{
+      }, orderTagKeys, undefined, undefined)).toEqual([{
           eventTypes: [],
           tags: [{
               key: "itemId",
@@ -689,7 +689,7 @@ globalThis.describe("DcbTag:", () => {
         orderId: "ord-1",
         customerId: "cust-1",
         productId: ["prod-1"]
-      }, {}, undefined)).toEqual([
+      }, {}, undefined, undefined)).toEqual([
         {
           eventTypes: [
             "OrderPlaced",
@@ -723,7 +723,7 @@ globalThis.describe("DcbTag:", () => {
         TAG: "SubscribeStudent",
         courseId: "C1",
         studentId: "S1"
-      }, undefined, ["studentId"])).toEqual([
+      }, undefined, ["studentId"], undefined)).toEqual([
         {
           eventTypes: ["StudentSubscribed"],
           tags: [{
@@ -745,7 +745,7 @@ globalThis.describe("DcbTag:", () => {
         TAG: "SubscribeStudent",
         courseId: "C1",
         studentId: "S1"
-      }, undefined, undefined)).toEqual([{
+      }, undefined, undefined, undefined)).toEqual([{
           eventTypes: ["StudentSubscribed"],
           tags: [
             {
@@ -813,7 +813,7 @@ globalThis.describe("DcbTag:", () => {
           "prod-1",
           "prod-2"
         ]
-      }, undefined, undefined)).toEqual([
+      }, undefined, undefined, undefined)).toEqual([
         {
           eventTypes: [
             "OrderPlaced",

package/tests/dcb/DcbValidationTest.res.mjs

@@ -372,7 +372,7 @@ globalThis.describe("DcbValidation:", () => {
           "RecordDemand",
           recordDemandCommandSchema,
           demandConsumedSchema
-        ]], producedTagKeys);
+        ]], producedTagKeys, undefined);
       globalThis.expect(warnings.length).toBe(1);
       let w = warnings[0];
       globalThis.expect(w.sliceName).toBe("RecordDemand");
@@ -384,7 +384,7 @@ globalThis.describe("DcbValidation:", () => {
           "RecordDemand",
           recordDemandCommandSchema,
           demandConsumedSchema
-        ]], producedTagKeys);
+        ]], producedTagKeys, undefined);
       globalThis.expect(warnings.some(w => w.message.includes("ProductDemandRecorded"))).toBe(false);
     });
     globalThis.test("ignores single-tag commands (partition read, not composite)", () => {
@@ -392,7 +392,7 @@ globalThis.describe("DcbValidation:", () => {
           "TouchDemand",
           touchDemandCommandSchema,
           demandConsumedSchema
-        ]], producedTagKeys);
+        ]], producedTagKeys, undefined);
       globalThis.expect(warnings).toEqual([]);
     });
     globalThis.test("ignores tagged-array commands (per-element OR, not composite)", () => {
@@ -400,11 +400,11 @@ globalThis.describe("DcbValidation:", () => {
           "PlaceOrder",
           placeOrderCommandSchema,
           demandConsumedSchema
-        ]], producedTagKeys);
+        ]], producedTagKeys, undefined);
       globalThis.expect(warnings).toEqual([]);
     });
     globalThis.test("no warnings when nothing reads compositely", () => {
-      globalThis.expect(DcbValidation$Reventless.validateCompositeReads([], producedTagKeys)).toEqual([]);
+      globalThis.expect(DcbValidation$Reventless.validateCompositeReads([], producedTagKeys, undefined)).toEqual([]);
     });
   });
   globalThis.describe("validateCrossPartitionScope (Issue 13)", () => {