@reventlessdev/reventless-core 3.0.0-alpha.267 → 3.0.0-alpha.268

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.268 (2026-09-21)
+
+### Bug Fixes
+
+* **core:** a creating command's own id derives no reference ([58a921c](https://github.com/ReventlessDev/reventless-core/commit/58a921c84352f6522e7c175387927e32365aa94a))
+
+
 # 3.0.0-alpha.267 (2026-09-21)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.267",
+  "version": "3.0.0-alpha.268",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -29,15 +29,15 @@
     "sury": "11.0.0-rc.2",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.33",
-    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.12",
     "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
+    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.12",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
     "@reventlessdev/rescript-node": "2.0.0-alpha.12",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.21",
     "@reventlessdev/rescript-ssh2": "2.0.0-alpha.12",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.168",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.37",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.168",
     "@reventlessdev/reventless-spec": "3.0.0-alpha.140"
   },
   "devDependencies": {

package/src/plugin/component/Plugin_Structure.res

@@ -648,6 +648,9 @@ let identityReference = (
 // element schema.
 let extractReferences = (
   ~identityViews: option<identityViews>=?,
+  // The id a creating command mints. Its identity names the row the command
+  // brings into existence, not one it refers to, so nothing is derived for it.
+  ~minted: option<string>=?,
   properties: dict<S.t<unknown>>,
 ): array<Reventless.Plugin.fieldReference> =>
   properties
@@ -660,8 +663,9 @@ let extractReferences = (
     // nesting and the other not.
     let declared = Reventless.Reference.collectFieldTargets(fieldName, fieldSchema)
     let targets = switch identityViews {
-    | Some(views) => identityReference(views, ~fieldName, fieldSchema, declared)
-    | None => declared
+    | Some(views) if minted != Some(fieldName) =>
+      identityReference(views, ~fieldName, fieldSchema, declared)
+    | _ => declared
     }
     targets->Array.map(((path, target)): Reventless.Plugin.fieldReference => {
       Reventless.Plugin.fieldName: path,
@@ -849,7 +853,6 @@ let toCommandDef = (
       ~variantName,
       properties,
     )
-    let references = extractReferences(~identityViews?, properties)
     // Evaluated against a synthetic value per constructor, the same shape the
     // resolver builds at call time: a payload-bearing variant compiles to
     // `{TAG, ...}`, a payload-less one to a bare string.
@@ -913,6 +916,11 @@ let toCommandDef = (
     | None => Reventless.Transition.targetState(declared)
     }
     let level = derived->Option.flatMap(d => d.level)->Option.getOr(guessedLevel)
+    let references = extractReferences(
+      ~identityViews?,
+      ~minted=?level == Reventless.Plugin.Collection ? aggregateIdField : None,
+      properties,
+    )
     // API-exposed iff the whole command isn't @noApi and this variant
     // isn't in its @noApi-variants set — mirrors the API-generation filter
     // (Plugin_Helpers / PluginBaseFragment). Drives the event-graph API badge.

package/src/plugin/component/Plugin_Structure.res.mjs

@@ -481,12 +481,12 @@ function identityReference(identityViews, fieldName, fieldSchema, declared) {
     ]];
 }
 
-function extractReferences(identityViews, properties) {
+function extractReferences(identityViews, minted, properties) {
   return Object.entries(properties).flatMap(param => {
     let fieldSchema = param[1];
     let fieldName = param[0];
     let declared = Reference$Reventless.collectFieldTargets(fieldName, fieldSchema);
-    let targets = identityViews !== undefined ? identityReference(identityViews, fieldName, fieldSchema, declared) : declared;
+    let targets = identityViews !== undefined && Primitive_object.notequal(minted, fieldName) ? identityReference(identityViews, fieldName, fieldSchema, declared) : declared;
     return targets.map(param => {
       let target = param[1];
       return {
@@ -500,7 +500,7 @@ function extractReferences(identityViews, properties) {
 
 function toEventDef(identityViews, v) {
   let mkDef = (variantName, properties) => {
-    let references = extractReferences(identityViews, properties);
+    let references = extractReferences(identityViews, undefined, properties);
     return {
       name: variantName,
       schema: JSON.stringify(SuryToJsonSchema$ReventlessCore.deriveObjectSchema(undefined, undefined, v)),
@@ -643,7 +643,7 @@ function annotateArgTypes(schema, argTypes) {
 function toCommandDef(identityViews, isAggregate, partitionKey, mutationFieldFor, parentSchema, commandAuthorization, commandTransition, derivedEdgeFor, v) {
   let mkDef = (variantName, properties) => {
     let match = commandLevelAndId(isAggregate, partitionKey, variantName, properties);
-    let references = extractReferences(identityViews, properties);
+    let aggregateIdField = match[1];
     let syntheticCommand = DcbTag$Reventless.isVariantPayloadBearing(parentSchema, variantName) ? ({
         TAG: variantName
       }) : variantName;
@@ -678,6 +678,7 @@ function toCommandDef(identityViews, isAggregate, partitionKey, mutationFieldFor
     });
     let targetState = observed !== undefined ? observed : Transition$Reventless.targetState(declared);
     let level = Stdlib_Option.getOr(Stdlib_Option.flatMap(derived, d => d.level), match[0]);
+    let references = extractReferences(identityViews, level === "Collection" ? aggregateIdField : undefined, properties);
     let apiExposed = false;
     if (!ApiNoApiHelpers$ReventlessCore.isNoApi(parentSchema)) {
       let excluded = ApiNoApiHelpers$ReventlessCore.getExcludedVariants(parentSchema);
@@ -691,7 +692,7 @@ function toCommandDef(identityViews, isAggregate, partitionKey, mutationFieldFor
       name: variantName,
       schema: JSON.stringify(annotatedSchema),
       level: level,
-      aggregateIdField: match[1],
+      aggregateIdField: aggregateIdField,
       mutationField: mutationField,
       references: references,
       allowedStates: match$3[0],

package/tests/plugin/IdentityReferenceTest.res

@@ -11,7 +11,7 @@ module CustomerId = Reventless.Id.Make({
   let key = "customerId"
 })
 
-let refsOf = (~viewsByKey, schema: S.t<'a>) => {
+let refsOf = (~viewsByKey, ~minted=?, schema: S.t<'a>) => {
   let reports = []
   let identityViews: Plugin_Structure.identityViews = {
     viewsByKey: Dict.fromArray(viewsByKey),
@@ -23,7 +23,7 @@ let refsOf = (~viewsByKey, schema: S.t<'a>) => {
   | _ => Dict.make()
   }
   let refs =
-    Plugin_Structure.extractReferences(~identityViews, properties)->Array.map(r => (
+    Plugin_Structure.extractReferences(~identityViews, ~minted?, properties)->Array.map(r => (
       r.fieldName,
       r.entity,
     ))
@@ -63,6 +63,17 @@ describe("a reference derived from the type", () => {
     expect(reports->Array.some(r => r->String.includes("no view in this plugin")))->toBe(true)
   })
 
+  // A create form mints this id; a list of the rows that already exist is the
+  // wrong control for it.
+  testSync("the id a creating command mints references nothing", () => {
+    let (refs, reports) = refsOf(
+      ~viewsByKey=[("customerId", ["Customers"]), ("productId", ["AvailableProducts"])],
+      ~minted="buyer",
+      order,
+    )
+    expect((refs, reports))->toEqual(([("productIds", "AvailableProducts")], []))
+  })
+
   testSync("an untyped field is left to its name, as before", () => {
     let (refs, reports) = refsOf(
       ~viewsByKey=[("customerId", ["Customers"])],
@@ -96,4 +107,12 @@ describe("a declared @ref on a typed id", () => {
     )
     expect((refs, reports))->toEqual(([("buyer", "Customers")], []))
   })
+
+  testSync("stands on a minted id: only the derived one steps aside", () => {
+    let chosen = S.schema(
+      s => {"buyer": s.matches(CustomerId.schema->Reventless.Reference.mark("Customers"))},
+    )
+    let (refs, _) = refsOf(~viewsByKey=[("customerId", ["Customers"])], ~minted="buyer", chosen)
+    expect(refs)->toEqual([("buyer", "Customers")])
+  })
 })

package/tests/plugin/IdentityReferenceTest.res.mjs

@@ -13,7 +13,7 @@ let CustomerId = Id$Reventless.Make({
   key: "customerId"
 });
 
-function refsOf(viewsByKey, schema) {
+function refsOf(viewsByKey, minted, schema) {
   let reports = [];
   let identityViews_viewsByKey = Object.fromEntries(viewsByKey);
   let identityViews_viewNames = viewsByKey.flatMap(param => param[1]);
@@ -27,7 +27,7 @@ function refsOf(viewsByKey, schema) {
   };
   let properties;
   properties = schema.type === "object" ? schema.properties : ({});
-  let refs = Plugin_Structure$ReventlessCore.extractReferences(identityViews, properties).map(r => [
+  let refs = Plugin_Structure$ReventlessCore.extractReferences(identityViews, minted, properties).map(r => [
     r.fieldName,
     r.entity
   ]);
@@ -54,7 +54,7 @@ globalThis.describe("a reference derived from the type", () => {
         "productId",
         ["AvailableProducts"]
       ]
-    ], order);
+    ], undefined, order);
     globalThis.expect(match[0]).toEqual([
       [
         "buyer",
@@ -80,7 +80,7 @@ globalThis.describe("a reference derived from the type", () => {
           "ProductDemand"
         ]
       ]
-    ], order);
+    ], undefined, order);
     globalThis.expect(match[0]).toEqual([[
         "buyer",
         "Customers"
@@ -91,18 +91,40 @@ globalThis.describe("a reference derived from the type", () => {
     let match = refsOf([[
         "productId",
         ["AvailableProducts"]
-      ]], order);
+      ]], undefined, order);
     globalThis.expect(match[0]).toEqual([[
         "productIds",
         "AvailableProducts"
       ]]);
     globalThis.expect(match[1].some(r => r.includes("no view in this plugin"))).toBe(true);
   });
+  globalThis.test("the id a creating command mints references nothing", () => {
+    let match = refsOf([
+      [
+        "customerId",
+        ["Customers"]
+      ],
+      [
+        "productId",
+        ["AvailableProducts"]
+      ]
+    ], "buyer", order);
+    globalThis.expect([
+      match[0],
+      match[1]
+    ]).toEqual([
+      [[
+          "productIds",
+          "AvailableProducts"
+        ]],
+      []
+    ]);
+  });
   globalThis.test("an untyped field is left to its name, as before", () => {
     let match = refsOf([[
         "customerId",
         ["Customers"]
-      ]], Sury.$schema(s => ({
+      ]], undefined, Sury.$schema(s => ({
       customerId: s.m(Sury.string)
     })));
     globalThis.expect([
@@ -129,7 +151,7 @@ globalThis.describe("a declared @ref on a typed id", () => {
         "productId",
         ["Products"]
       ]
-    ], referenced);
+    ], undefined, referenced);
     globalThis.expect(match[0]).toEqual([[
         "buyer",
         "Products"
@@ -146,7 +168,7 @@ globalThis.describe("a declared @ref on a typed id", () => {
           "Customers",
           "VipCustomers"
         ]
-      ]], chosen);
+      ]], undefined, chosen);
     globalThis.expect([
       match[0],
       match[1]
@@ -158,6 +180,19 @@ globalThis.describe("a declared @ref on a typed id", () => {
       []
     ]);
   });
+  globalThis.test("stands on a minted id: only the derived one steps aside", () => {
+    let chosen = Sury.$schema(s => ({
+      buyer: s.m(Reference$Reventless.mark(CustomerId.schema, undefined, undefined, "Customers"))
+    }));
+    let match = refsOf([[
+        "customerId",
+        ["Customers"]
+      ]], "buyer", chosen);
+    globalThis.expect(match[0]).toEqual([[
+        "buyer",
+        "Customers"
+      ]]);
+  });
 });
 
 export {