@reventlessdev/reventless-core 3.0.0-alpha.259 → 3.0.0-alpha.261

package/src/plugin/api/PluginBaseFragment.res

@@ -42,7 +42,11 @@ let queryEntries: array<querySchemaEntry> = [
     // No `excludeFields`: the three fields this entry used to name are declared
     // `@internal` on the spec, and `deriveObjectTypeWithNested` reads that off the
     // schema itself.
-    subIdField: ?PluginsReadModelSpec.subIdConfig->Option.map((c: Reventless.ReadModel.subIdConfig<_>) => c.subIdField),
+    subIdField: ?(
+      PluginsReadModelSpec.subIdConfig->Option.map((c: Reventless.ReadModel.subIdConfig<_>) =>
+        c.subIdField
+      )
+    ),
     indexQueries: ?indexQueriesOfConfig(PluginsReadModelSpec.config),
   },
 ]
@@ -67,8 +71,10 @@ let queryEntries: array<querySchemaEntry> = [
 let pluginAggregateMutationEntries: array<mutationSchemaEntry> = {
   let commandSchema = PluginSpec.commandSchema->S.castToUnknown
   let constructorNames = Reventless.DcbTag.extractAllVariantNames(PluginSpec.commandSchema)
-  let filteredConstructorNames =
-    ApiNoApiHelpers.filterNoApiVariants(constructorNames, commandSchema)
+  let filteredConstructorNames = ApiNoApiHelpers.filterNoApiVariants(
+    constructorNames,
+    commandSchema,
+  )
   let fieldNames =
     filteredConstructorNames->Array.map(cname =>
       Api_Naming.adminField(~name=PluginSpec.name ++ "_" ++ cname)

package/src/plugin/component/Capability_Inference.res

@@ -36,7 +36,8 @@ let warningsFromProperties = (~component, properties: dict<S.t<unknown>>): array
   ->Dict.toArray
   ->Array.filterMap(((field, fieldSchema)) =>
     switch fieldSchema {
-    | String(_) if field != "TAG" &&
+    | String(_)
+      if field != "TAG" &&
       nameMatches(field) &&
       Reventless.StorageRef.getStore(fieldSchema)->Option.isNone =>
       Some({component, field})
@@ -64,8 +65,7 @@ let scanSchema = (~component: string, schema: S.t<unknown>): array<warning> => {
     and say what to do when the heuristic is wrong. */
 let message = (w: warning): string =>
   `${w.component}.${w.field} looks like a stored-object reference but declares no store — ` ++
-  `annotate it \`@storageRef("<store>")\` so the deployment provisions the store it needs, ` ++
-  `or rename the field if it holds an external URL. Heuristic matches are never provisioned.`
+  `annotate it \`@storageRef("<store>")\` so the deployment provisions the store it needs, ` ++ `or rename the field if it holds an external URL. Heuristic matches are never provisioned.`
 
 // ── Near-duplicate stores ──────────────────────────────────────────────────
 //
@@ -103,8 +103,7 @@ let withinOneEdit = (a: string, b: string): bool => {
     switch diffs {
     | [] => true
     | [_] => true
-    | [i, j] if j == i + 1 =>
-      charAt(a, i) == charAt(b, j) && charAt(a, j) == charAt(b, i)
+    | [i, j] if j == i + 1 => charAt(a, i) == charAt(b, j) && charAt(a, j) == charAt(b, i)
     | _ => false
     }
   } else if la - lb == 1 || lb - la == 1 {
@@ -147,9 +146,9 @@ Pairs of declared stores that are probably one store misspelled twice.
 Compared within an owning plugin only: two plugins may legitimately hold stores
 whose names are one edit apart, and neither can be a typo for the other.
 */
-let collisions = (
-  declarations: array<Reventless.Plugin.requiredStoreDeclaration>,
-): array<collision> => {
+let collisions = (declarations: array<Reventless.Plugin.requiredStoreDeclaration>): array<
+  collision,
+> => {
   // One entry per store, keeping the first declaration site as the one the
   // message names — several fields naming one store is ordinary, not a clash.
   let byStore: dict<Reventless.Plugin.requiredStoreDeclaration> = Dict.make()
@@ -181,5 +180,4 @@ let collisionMessage = (c: collision): string =>
   `${c.a.store} (${c.a.component}.${c.a.field}) and ${c.b.store} ` ++
   `(${c.b.component}.${c.b.field}) differ by one edit — one is probably a typo for ` ++
   `the other, and both would be provisioned, splitting objects across two stores. ` ++
-  `Fix the field name, or name the store explicitly with \`@storageRef("<store>")\` ` ++
-  `if the two really are separate stores.`
+  `Fix the field name, or name the store explicitly with \`@storageRef("<store>")\` ` ++ `if the two really are separate stores.`

package/src/plugin/component/Plugin.res

@@ -43,7 +43,9 @@ module type T = {
   let makePluginDefinition: (
     ~name: string,
     ~aggregates: array<module(ReventlessInfra.Aggregate.T with type api = api)>=?,
-    ~readModels: array<module(ReventlessInfra.ReadModel.T with type api = api and type role = role)>=?,
+    ~readModels: array<
+      module(ReventlessInfra.ReadModel.T with type api = api and type role = role),
+    >=?,
     ~stateViewSlices: array<module(ReventlessInfra.StateViewSlice.T)>=?,
     ~stateChangeSlices: array<module(ReventlessInfra.StateChangeSlice.T)>=?,
     ~automationSlices: array<module(ReventlessInfra.AutomationSlice.T)>=?,
@@ -63,13 +65,11 @@ let makeId = (name, version) => `${name}@${version}`
 // the platform invariant is one version per plugin at a time — so anything
 // crossing into the UI (routes, federation remote name, subscription
 // payloads) gets the bare name. If the input has no `@`, returns it as-is.
-let name = (id: string): string =>
-  id->String.split("@")->Array.get(0)->Option.getOr(id)
+let name = (id: string): string => id->String.split("@")->Array.get(0)->Option.getOr(id)
 
 // Version segment of a plugin id (`name@version`). Empty string when the id
 // carries no `@` (e.g. the synthetic admin plugin id).
-let version = (id: string): string =>
-  id->String.split("@")->Array.get(1)->Option.getOr("")
+let version = (id: string): string => id->String.split("@")->Array.get(1)->Option.getOr("")
 
 // Compare two plugin version strings (e.g. "0.10.0-alpha.73"), newest-first:
 // returns 1 when `a` is newer than `b`, -1 when older, 0 when equal. Separators
@@ -79,7 +79,7 @@ let version = (id: string): string =>
 // the admin manifest resolvers to enforce the one-version-per-plugin invariant
 // when more than one version lingers in `Connected` state.
 let compareVersions = (a: string, b: string): int => {
-  let parts = s => s->String.replaceRegExp(%re("/[-+]/g"), ".")->String.split(".")
+  let parts = s => s->String.replaceRegExp(/[-+]/g, ".")->String.split(".")
   let pa = parts(a)
   let pb = parts(b)
   let len = pa->Array.length > pb->Array.length ? pa->Array.length : pb->Array.length

package/src/plugin/component/Plugin_Builder.res

@@ -190,10 +190,17 @@ module Make = (
           []
         } else {
           let constructorNames = Reventless.DcbTag.extractAllVariantNames(M.Spec.commandSchema)
-          let filteredConstructorNames = ApiNoApiHelpers.filterNoApiVariants(constructorNames, commandSchema)
+          let filteredConstructorNames = ApiNoApiHelpers.filterNoApiVariants(
+            constructorNames,
+            commandSchema,
+          )
           let fieldNames =
             filteredConstructorNames->Array.map(cname =>
-              Api_Naming.aggregateMutationField(~plugin=name, ~aggregate=M.Spec.name, ~command=cname)
+              Api_Naming.aggregateMutationField(
+                ~plugin=name,
+                ~aggregate=M.Spec.name,
+                ~command=cname,
+              )
             )
           // Register plugin-prefixed field names for CommandGenerator_Builder.
           Plugin_Helpers.aggregateMutationFieldsRegistry->Dict.set(M.Spec.name, fieldNames)
@@ -223,20 +230,23 @@ module Make = (
             let fieldPermissions = Dict.make()
             filteredConstructorNames->Array.forEachWithIndex((cname, idx) => {
               let fieldName = fieldNames->Array.getUnsafe(idx)
-              let hasPayload =
-                Reventless.DcbTag.isVariantPayloadBearing(M.Spec.commandSchema->Obj.magic, cname)
-              let syntheticCmd: unknown =
-                hasPayload ? {"TAG": cname}->Obj.magic : cname->Obj.magic
+              let hasPayload = Reventless.DcbTag.isVariantPayloadBearing(
+                M.Spec.commandSchema->Obj.magic,
+                cname,
+              )
+              let syntheticCmd: unknown = hasPayload ? {"TAG": cname}->Obj.magic : cname->Obj.magic
               let rule = M.Spec.commandAuthorization(syntheticCmd->Obj.magic)
               fieldPermissions->Dict.set(fieldName, rule)
             })
-            [{
-              ReventlessInfra.Api.fieldNames,
-              commandSchema,
-              fieldPermissions,
-              linkedViews: ?aggDef->Option.map(d => d.linkedViews),
-              consistencyRead: ?aggDef->Option.flatMap(d => d.consistencyRead),
-            }]
+            [
+              {
+                ReventlessInfra.Api.fieldNames,
+                commandSchema,
+                fieldPermissions,
+                linkedViews: ?(aggDef->Option.map(d => d.linkedViews)),
+                consistencyRead: ?(aggDef->Option.flatMap(d => d.consistencyRead)),
+              },
+            ]
           }
         }
       })
@@ -264,7 +274,7 @@ module Make = (
           authorization: None,
           permission: R.Spec.authorization,
           connectionSpec: true,
-          subIdField: ?subIdField,
+          ?subIdField,
           indexQueries: ?(indexes->Array.length > 0 ? Some(indexes) : None),
           resolvedFields: ?(resolvedFields->Array.length > 0 ? Some(resolvedFields) : None),
         }
@@ -299,8 +309,7 @@ module Make = (
         connectionFilterTypeName: qn.returnTypeName ++ "Filter",
       }
       let qn = switch R.Spec.subIdConfig {
-      | Some(_) =>
-        {
+      | Some(_) => {
           ...qn,
           itemsFieldName: qn.singleFieldName ++ "Items",
           itemsFilterTypeName: qn.returnTypeName ++ "ItemsFilter",
@@ -308,18 +317,12 @@ module Make = (
       | None => qn
       }
       Plugin_Helpers.queryFieldNamesRegistry->Dict.set(R.Spec.name, qn)
-      Plugin_Helpers.stateSchemaRegistry->Dict.set(
-        R.Spec.name,
-        R.Spec.stateSchema->S.castToUnknown,
-      )
+      Plugin_Helpers.stateSchemaRegistry->Dict.set(R.Spec.name, R.Spec.stateSchema->S.castToUnknown)
     })
 
     let apiSchemaFragment = {
       let baseFragment = FragmentProvider.generateFragment(~mutationEntries, ~queryEntries)
-      let subResult = Plugin_SubscriptionSchema.generate(
-        ~mutationEntries,
-        ~eventLogEntries,
-      )
+      let subResult = Plugin_SubscriptionSchema.generate(~mutationEntries, ~eventLogEntries)
       // The historical read counterpart of the Source A subscription — same
       // event logs, same generation point, so the two cannot disagree about
       // which streams exist.
@@ -442,12 +445,8 @@ module Make = (
           commandTypes: extractTypes(M.Spec.commandSchema),
           eventTypes: extractTypes(M.Spec.eventSchema),
           errorTypes: extractTypes(M.Spec.errorSchema),
-          commandSchemas: [
-            SchemaWalker.walk(M.Spec.name ++ ".command", M.Spec.commandSchema),
-          ],
-          eventSchemas: [
-            SchemaWalker.walk(M.Spec.name ++ ".event", M.Spec.eventSchema),
-          ],
+          commandSchemas: [SchemaWalker.walk(M.Spec.name ++ ".command", M.Spec.commandSchema)],
+          eventSchemas: [SchemaWalker.walk(M.Spec.name ++ ".event", M.Spec.eventSchema)],
           chapter: ?chapterFor(M.Spec.name),
         }
         Plugin_Helpers.componentSchemaRegistry->Dict.set(M.Spec.name, schema)
@@ -595,10 +594,10 @@ module Make = (
         hook({
           name,
           version,
-          kind: ?meta->Option.flatMap(m => m.kind),
-          displayName: ?meta->Option.flatMap(m => m.displayName),
-          vendor: ?meta->Option.flatMap(m => m.vendor),
-          architectureType: ?meta->Option.flatMap(m => m.architectureType),
+          kind: ?(meta->Option.flatMap(m => m.kind)),
+          displayName: ?(meta->Option.flatMap(m => m.displayName)),
+          vendor: ?(meta->Option.flatMap(m => m.vendor)),
+          architectureType: ?(meta->Option.flatMap(m => m.architectureType)),
           components,
         })
       | None => ()
@@ -790,24 +789,29 @@ module Make = (
         // topics → this plugin's EventCollector, and vice-versa. The eventTopic
         // resource's `id` is the SNS topic ARN (same convention as
         // extensionPointDefinition.eventTopic).
-        let dcbEventLogDef: Pulumi.Output.t<option<Reventless.Plugin.dcbEventLogDefinition>> =
-          switch dcbResult.dcbEventLogOutputs {
+        let dcbEventLogDef: Pulumi.Output.t<
+          option<Reventless.Plugin.dcbEventLogDefinition>,
+        > = switch dcbResult.dcbEventLogOutputs {
+        | None => Pulumi.Output.make(None)
+        | Some(dcbOutputs) =>
+          switch dcbOutputs.eventTopic.resources->Array.get(0) {
+          | Some(r) =>
+            r.id->Pulumi.Output.apply(arn => Some({
+              Reventless.Plugin.name: name ++ "DcbEventLog",
+              eventTopicArn: arn,
+            }))
           | None => Pulumi.Output.make(None)
-          | Some(dcbOutputs) =>
-            switch dcbOutputs.eventTopic.resources->Array.get(0) {
-            | Some(r) =>
-              r.id->Pulumi.Output.apply(arn => Some({
-                Reventless.Plugin.name: name ++ "DcbEventLog",
-                eventTopicArn: arn,
-              }))
-            | None => Pulumi.Output.make(None)
-            }
           }
+        }
 
         let pluginDefinition =
           (extensionPointsDefinitions, eventCollectorUrn, dcbEventLogDef)
           ->Pulumi.Output.all3
-          ->Pulumi.Output.apply(((extensionPointsDefinitions, eventCollectorUrn, dcbEventLogDef)) => {
+          ->Pulumi.Output.apply(((
+            extensionPointsDefinitions,
+            eventCollectorUrn,
+            dcbEventLogDef,
+          )) => {
             Reventless.Plugin.id,
             name,
             version,
@@ -854,13 +858,13 @@ module Make = (
         readModelsOutputs
         ->Dict.toArray
         ->Array.forEach(((rmName, rmOut)) => {
-          let urlOutput =
-            rmOut.eventCollector->Pulumi.Output.flatMap(ecOutputs =>
+          let urlOutput = rmOut.eventCollector->Pulumi.Output.flatMap(
+            ecOutputs =>
               switch ecOutputs.resources->Array.get(0) {
               | Some(r) => r.id
               | None => Pulumi.Output.make("")
-              }
-            )
+              },
+          )
           readModelQueueUrls->Dict.set(rmName, urlOutput)
         })
 

package/src/plugin/component/Plugin_Callback.res

@@ -75,10 +75,14 @@ module Make = (Spec: Spec): T => {
           Spec.outgoingExtensionEventHandlers->Dict.get(serviceName)->Option.isSome ||
           Spec.incomingExtensionEventHandlers->Dict.get(serviceName)->Option.isSome
         if isHandled {
-          EffectLogger.logInfo(~comp=`Plugin(${id})`, `incoming event: ${LogFormat.eventSummary(eventJson')}`)
-          ->Effect.zipRight(
-            handleEventEffect(eventJson', Spec.incomingConnectExtensionEventHandlers)
-            ->Effect.zipRight(
+          EffectLogger.logInfo(
+            ~comp=`Plugin(${id})`,
+            `incoming event: ${LogFormat.eventSummary(eventJson')}`,
+          )->Effect.zipRight(
+            handleEventEffect(
+              eventJson',
+              Spec.incomingConnectExtensionEventHandlers,
+            )->Effect.zipRight(
               Effect.all(
                 [
                   handleEventEffect(eventJson', Spec.outgoingExtensionPointEventHandlers),
@@ -86,8 +90,8 @@ module Make = (Spec: Spec): T => {
                   handleEventEffect(eventJson', Spec.incomingExtensionEventHandlers),
                 ],
                 {"concurrency": "unbounded"},
-              )->Effect.map(_ => ())
-            )
+              )->Effect.map(_ => ()),
+            ),
           )
         } else {
           warnUnmatchedServiceOnce(~id, ~serviceName)