@reventlessdev/reventless-core 3.0.0-alpha.255 → 3.0.0-alpha.257

package/tests/plugin/PluginStructureTest.res

@@ -241,6 +241,7 @@ describe("lifecycle topology", () => {
     references: [],
     allowedStates,
     targetState,
+    allowedStatesSource: ?allowedStates->Option.map(_ => "declared"),
     apiExposed: None,
     requiredAccess: None,
     ownerField: None,
@@ -344,6 +345,141 @@ describe("commandTransition — the edge as a switch", () => {
   })
 })
 
+describe("the harvested model against the switch", () => {
+  // The switch is a claim; the component's own scenarios are evidence. Where the
+  // evidence says something it wins and the structure records that it did, so a
+  // consumer can rank an observed edge against an authored one. Where it says
+  // nothing the claim stands — an empty derivation published as `Some([])` would
+  // match no row's lifecycle and offer the command nowhere at all, while the
+  // annotation that would have been right sat unread beside it.
+  let edge = (
+    ~command,
+    ~level: option<Reventless.Plugin.commandLevel>=?,
+    ~allowedStates=[],
+    ~targets=[],
+  ): Reventless.Plugin.derivedEdge => {
+    component: "TransitionSwitch",
+    command,
+    level: ?level,
+    allowedStates,
+    targets,
+  }
+  let build = lifecycleModel =>
+    Plugin_Structure.make(
+      ~name="HarvestPlugin",
+      ~stateChangeSlices=[module(PsTransitionSwitchSlice)],
+      ~stateViewSlices=[],
+      ~lifecycleModel,
+    )
+  let edgeOf = (model, name) => {
+    let slice = build(model).stateChangeSlices->Array.getUnsafe(0)
+    slice.commands
+    ->Array.find(c => c.name == name)
+    ->Option.map(c => (c.allowedStates, c.targetState, c.allowedStatesSource))
+  }
+
+  testSync("an observed from-set replaces the declared one, and says where it came from", () => {
+    expect(
+      edgeOf([edge(~command="Book", ~allowedStates=["Booked"], ~targets=["Abandoned"])], "Book"),
+    )->toEqual(Some((Some(["Booked"]), Some("Abandoned"), Some("derived"))))
+  })
+
+  testSync("a corpus that observed nothing leaves the switch standing", () => {
+    // Present in the model and empty is the same answer as absent from it: the
+    // scenarios did not reach this command.
+    expect(edgeOf([edge(~command="Book")], "Book"))->toEqual(
+      Some((Some(["Draft"]), Some("Booked"), Some("declared"))),
+    )
+  })
+
+  testSync("the two halves resolve separately", () => {
+    // A corpus routinely shows a command taking effect without ever showing
+    // where it lands, and erasing the declared target for that would cost a
+    // consumer the edge it had.
+    expect(edgeOf([edge(~command="Book", ~allowedStates=["Booked"])], "Book"))->toEqual(
+      Some((Some(["Booked"]), Some("Booked"), Some("derived"))),
+    )
+  })
+
+  testSync("two observed targets leave the declaration to speak", () => {
+    // `targetState` carries one state, so a branching command is an edge it
+    // cannot express. The harvest reports that as a contradiction; here the
+    // choice is between the declaration and picking one of the two arbitrarily.
+    expect(
+      edgeOf([edge(~command="Book", ~allowedStates=["Booked"], ~targets=["Booked", "Abandoned"])], "Book"),
+    )->toEqual(Some((Some(["Booked"]), Some("Booked"), Some("derived"))))
+  })
+
+  testSync("a command the model does not mention keeps its declaration", () => {
+    expect(edgeOf([edge(~command="Book", ~allowedStates=["Booked"])], "Rebook"))->toEqual(
+      Some((Some(["Booked"]), None, Some("declared"))),
+    )
+  })
+
+  testSync("an authored Unrestricted publishes no from-set, and says it meant to", () => {
+    // Distinct from the field being absent, which is "nobody said". A consumer
+    // drawing a state machine can tell an edge left unconstrained on purpose
+    // from one nothing is known about.
+    expect(edgeOf([], "Abandon"))->toEqual(Some((None, None, Some("unrestricted"))))
+  })
+
+  testSync("and the scenarios may not narrow it", () => {
+    // "Legal in every state" is a claim; a corpus only covers the states
+    // somebody wrote a scenario for. Deriving a from-set here would shrink the
+    // claim to an accident of coverage and withdraw the command from every row
+    // nobody tested — which for `Customer.SetLocation`'s trait reports is the
+    // difference between a late geocode landing and a row parked in Failed.
+    expect(edgeOf([edge(~command="Abandon", ~allowedStates=["Booked"])], "Abandon"))->toEqual(
+      Some((None, None, Some("unrestricted"))),
+    )
+  })
+
+  testSync("a spec that wrote no switch is silence, which they may answer", () => {
+    // `PsPlaceOrder` declares no `commandTransition`, so the ppx injects
+    // `Undeclared`. It erases to the same pair of `None`s as `Unrestricted` and
+    // is the reason the two are separate constructors at all.
+    let structure = Plugin_Structure.make(
+      ~name="SilentPlugin",
+      ~stateChangeSlices=[module(PsPlaceOrderSlice)],
+      ~stateViewSlices=[],
+      ~lifecycleModel=[
+        {
+          component: "PlaceOrder",
+          command: "PlaceOrder",
+          allowedStates: ["Draft"],
+          targets: ["Placed"],
+        },
+      ],
+    )
+    let slice = structure.stateChangeSlices->Array.getUnsafe(0)
+    expect(
+      slice.commands
+      ->Array.find(c => c.name == "PlaceOrder")
+      ->Option.map(c => (c.allowedStates, c.targetState, c.allowedStatesSource)),
+    )->toEqual(Some((Some(["Draft"]), Some("Placed"), Some("derived"))))
+  })
+
+  let levelOf = (model, name) => {
+    let slice = build(model).stateChangeSlices->Array.getUnsafe(0)
+    slice.commands->Array.find(c => c.name == name)->Option.map(c => c.level)
+  }
+
+  testSync("the level comes from the corpus where it has one", () => {
+    // `Abandon` starts with none of the create-command stems, so the name-stem
+    // guess makes it Instance-level. The scenarios say otherwise, and they have
+    // seen the histories.
+    expect(levelOf([edge(~command="Abandon", ~level=Collection)], "Abandon"))->toEqual(
+      Some(Reventless.Plugin.Collection),
+    )
+  })
+
+  testSync("and from the name stem where it does not", () => {
+    expect(levelOf([edge(~command="Abandon")], "Abandon"))->toEqual(
+      Some(Reventless.Plugin.Instance),
+    )
+  })
+})
+
 describe("traitDeclarations — a graft leaves a trace", () => {
   // The one signal a graft leaves that survives into a deployed plugin. Every
   // other one — the package dependency, the variant spread, the rules alias, the
@@ -1859,15 +1995,43 @@ describe("Plugin_Structure.make — Phase 2 graph fields", () => {
 
     // Scalar and plural in one command: the plural forms are the regression, the
     // scalar one is here so a fix that reaches them by breaking it cannot pass.
+    // The nested one rides alongside, named by its path rather than by the field
+    // that holds it.
     testSync("a command collects its array refs alongside its scalar one", () => {
       let cmd = slice.commands->Array.getUnsafe(0)
       expect(cmd.references->referencesOf)->toEqual([
         ("customerId", "Customers"),
         ("productIds", "AvailableProducts"),
         ("warehouseIds", "Warehouses"),
+        ("lineItems[].productId", "AvailableProducts"),
       ])
     })
 
+    // A reference declared on a field of a record the command holds belongs to
+    // *that* field, so it is named by its path: `[]` for "each element of", `.`
+    // for "property of". Attributing it to `lineItems` would name a field that
+    // declares nothing, and dropping it would leave the consuming side free to
+    // guess an entity from the name.
+    testSync("a reference on a nested record's field is named by its path", () => {
+      let cmd = slice.commands->Array.getUnsafe(0)
+      expect(
+        cmd.references->Array.find(({fieldName}) => fieldName == "lineItems[].productId"),
+      )->toEqual(
+        Some({
+          Reventless.Plugin.fieldName: "lineItems[].productId",
+          entity: "AvailableProducts",
+          plugin: None,
+        }),
+      )
+    })
+
+    // The other half of the path contract: a flat field keeps its bare name, so
+    // nothing reading today's paths has to learn the new form to go on working.
+    testSync("a flat reference in the same variant keeps its bare name", () => {
+      let cmd = slice.commands->Array.getUnsafe(0)
+      expect(cmd.references->Array.some(({fieldName}) => fieldName == "customerId"))->toBe(true)
+    })
+
     // Optionality is a statement about presence. An optional array puts the
     // element two wrappers down, which is the shape most likely to be missed by
     // an unwrap that only handles one.
@@ -1885,6 +2049,26 @@ describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       expect(evt.references->referencesOf)->toEqual([("productIds", "AvailableProducts")])
     })
 
+    // A client assembling this mutation declares a variable per argument, and
+    // for `lineItems` it needs the *element* input type by name. The rendered
+    // reference `x-reventless-graphql-type` publishes is keyed by argument, so it
+    // stops at the top level; this one travels with the object itself, which is
+    // what a reader that has descended into the list has in hand.
+    //
+    // The name is composed from the mutation field by a server-side convention,
+    // so nothing downstream of the JSON Schema could reconstruct it.
+    testSync("a nested input object publishes the type name the SDL declares", () => {
+      let cmd = slice.commands->Array.getUnsafe(0)
+      let itemName =
+        cmd.schema
+        ->JSON.parseOrThrow
+        ->getPropertyOf("lineItems")
+        ->Option.flatMap(s => getProperty(s, "items"))
+        ->Option.flatMap(s => getProperty(s, "x-reventless-graphql-input"))
+        ->Option.flatMap(JSON.Decode.string)
+      expect(itemName)->toEqual(Some(cmd.mutationField ++ "LineItems"))
+    })
+
     // The declared entity, not the one `productIds` reads like. Before the
     // element unwrap this field resolved by heuristic to `Products`.
     testSync("the declared entity wins over the one the field name suggests", () => {

package/tests/plugin/PluginStructureTest.res.mjs

@@ -519,7 +519,7 @@ let structure = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, un
 ], [
   PsPlaceOrderSlice,
   PsShipOrderSlice
-], undefined, undefined, undefined, undefined, undefined, undefined);
+], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
 
 globalThis.describe("lifecycle topology", () => {
   let ordersStates = Object.fromEntries([[
@@ -550,6 +550,7 @@ globalThis.describe("lifecycle topology", () => {
     references: [],
     allowedStates: allowedStates,
     targetState: targetState,
+    allowedStatesSource: Stdlib_Option.map(allowedStates, param => "declared"),
     apiExposed: undefined,
     requiredAccess: undefined,
     ownerField: undefined
@@ -582,7 +583,7 @@ globalThis.describe("lifecycle topology", () => {
 });
 
 globalThis.describe("commandTransition — the edge as a switch", () => {
-  let structure = Plugin_Structure$ReventlessCore.make("TransitionSwitchPlugin", undefined, undefined, [], [PsTransitionSwitchSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+  let structure = Plugin_Structure$ReventlessCore.make("TransitionSwitchPlugin", undefined, undefined, [], [PsTransitionSwitchSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
   let slice = structure.stateChangeSlices[0];
   let byName = name => slice.commands.find(c => c.name === name);
   globalThis.test("the switch fills allowedStates and targetState", () => {
@@ -614,11 +615,114 @@ globalThis.describe("commandTransition — the edge as a switch", () => {
   });
 });
 
+globalThis.describe("the harvested model against the switch", () => {
+  let edge = (command, level, allowedStatesOpt, targetsOpt) => {
+    let allowedStates = allowedStatesOpt !== undefined ? allowedStatesOpt : [];
+    let targets = targetsOpt !== undefined ? targetsOpt : [];
+    return {
+      component: "TransitionSwitch",
+      command: command,
+      level: level,
+      allowedStates: allowedStates,
+      targets: targets
+    };
+  };
+  let build = lifecycleModel => Plugin_Structure$ReventlessCore.make("HarvestPlugin", undefined, undefined, [], [PsTransitionSwitchSlice], undefined, undefined, undefined, undefined, undefined, undefined, lifecycleModel);
+  let edgeOf = (model, name) => {
+    let slice = build(model).stateChangeSlices[0];
+    return Stdlib_Option.map(slice.commands.find(c => c.name === name), c => [
+      c.allowedStates,
+      c.targetState,
+      c.allowedStatesSource
+    ]);
+  };
+  globalThis.test("an observed from-set replaces the declared one, and says where it came from", () => {
+    globalThis.expect(edgeOf([edge("Book", undefined, ["Booked"], ["Abandoned"])], "Book")).toEqual([
+      ["Booked"],
+      "Abandoned",
+      "derived"
+    ]);
+  });
+  globalThis.test("a corpus that observed nothing leaves the switch standing", () => {
+    globalThis.expect(edgeOf([edge("Book", undefined, undefined, undefined)], "Book")).toEqual([
+      ["Draft"],
+      "Booked",
+      "declared"
+    ]);
+  });
+  globalThis.test("the two halves resolve separately", () => {
+    globalThis.expect(edgeOf([edge("Book", undefined, ["Booked"], undefined)], "Book")).toEqual([
+      ["Booked"],
+      "Booked",
+      "derived"
+    ]);
+  });
+  globalThis.test("two observed targets leave the declaration to speak", () => {
+    globalThis.expect(edgeOf([edge("Book", undefined, ["Booked"], [
+        "Booked",
+        "Abandoned"
+      ])], "Book")).toEqual([
+      ["Booked"],
+      "Booked",
+      "derived"
+    ]);
+  });
+  globalThis.test("a command the model does not mention keeps its declaration", () => {
+    globalThis.expect(edgeOf([edge("Book", undefined, ["Booked"], undefined)], "Rebook")).toEqual([
+      ["Booked"],
+      undefined,
+      "declared"
+    ]);
+  });
+  globalThis.test("an authored Unrestricted publishes no from-set, and says it meant to", () => {
+    globalThis.expect(edgeOf([], "Abandon")).toEqual([
+      undefined,
+      undefined,
+      "unrestricted"
+    ]);
+  });
+  globalThis.test("and the scenarios may not narrow it", () => {
+    globalThis.expect(edgeOf([edge("Abandon", undefined, ["Booked"], undefined)], "Abandon")).toEqual([
+      undefined,
+      undefined,
+      "unrestricted"
+    ]);
+  });
+  globalThis.test("a spec that wrote no switch is silence, which they may answer", () => {
+    let structure = Plugin_Structure$ReventlessCore.make("SilentPlugin", undefined, undefined, [], [PsPlaceOrderSlice], undefined, undefined, undefined, undefined, undefined, undefined, [{
+        component: "PlaceOrder",
+        command: "PlaceOrder",
+        allowedStates: ["Draft"],
+        targets: ["Placed"]
+      }]);
+    let slice = structure.stateChangeSlices[0];
+    globalThis.expect(Stdlib_Option.map(slice.commands.find(c => c.name === "PlaceOrder"), c => [
+      c.allowedStates,
+      c.targetState,
+      c.allowedStatesSource
+    ])).toEqual([
+      ["Draft"],
+      "Placed",
+      "derived"
+    ]);
+  });
+  let levelOf = (model, name) => {
+    let slice = build(model).stateChangeSlices[0];
+    return Stdlib_Option.map(slice.commands.find(c => c.name === name), c => c.level);
+  };
+  globalThis.test("the level comes from the corpus where it has one", () => {
+    globalThis.expect(levelOf([edge("Abandon", "Collection", undefined, undefined)], "Abandon")).toEqual("Collection");
+  });
+  globalThis.test("and from the name stem where it does not", () => {
+    globalThis.expect(levelOf([edge("Abandon", undefined, undefined, undefined)], "Abandon")).toEqual("Instance");
+  });
+});
+
 globalThis.describe("traitDeclarations — a graft leaves a trace", () => {
   let structure = Plugin_Structure$ReventlessCore.make("TraitPlugin", undefined, undefined, [], [
     PsTransitionSwitchSlice,
     PsShipOrderSlice
-  ], undefined, undefined, undefined, undefined, undefined, undefined);
+  ], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
   globalThis.test("a declaring component's trait reaches the structure", () => {
     globalThis.expect(Stdlib_Option.getOr(structure.traitDeclarations, []).map(d => [
       d.trait,
@@ -647,7 +751,7 @@ globalThis.describe("traitDeclarations — a graft leaves a trace", () => {
 globalThis.describe("declared-edge cross-check", () => {
   let buildBad = () => {
     try {
-      Plugin_Structure$ReventlessCore.make("TransitionPlugin", undefined, undefined, [PsShipmentsViewSlice], [PsDispatchShipmentSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+      Plugin_Structure$ReventlessCore.make("TransitionPlugin", undefined, undefined, [PsShipmentsViewSlice], [PsDispatchShipmentSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
       return;
     } catch (raw_e) {
       let e = Primitive_exceptions.internalToException(raw_e);
@@ -1094,7 +1198,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
     });
   });
   globalThis.describe("singleQueryField — the singular the schema actually serves", () => {
-    let withIrregularPlural = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, [PsCategoriesViewSlice], [], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withIrregularPlural = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, [PsCategoriesViewSlice], [], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     let categories = withIrregularPlural.stateViewSlices[0];
     globalThis.test("an `-ies` plural publishes the `y` singular, not a truncation", () => {
       globalThis.expect([
@@ -1115,7 +1219,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       q.idField,
       q.idFieldSource
     ];
-    let withCategories = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, [PsCategoriesViewSlice], [], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withCategories = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, [PsCategoriesViewSlice], [], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     globalThis.test("a name-matching `*Id` field is a guess the consumer can also make", () => {
       globalThis.expect(keyOf(structure.stateViewSlices[0])).toEqual([
         "orderId",
@@ -1499,7 +1603,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
         "Orders",
         "Order"
       ]
-    ]));
+    ]), undefined);
     globalThis.test("a chaptered state-change slice carries Some(chapter)", () => {
       let placeOrder = chaptered.stateChangeSlices[0];
       globalThis.expect(placeOrder.chapter).toEqual("Order");
@@ -1518,7 +1622,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
     });
   });
   globalThis.describe("requiredStores", () => {
-    let withStores = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsAttachInvoiceSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withStores = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsAttachInvoiceSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     let stores = Stdlib_Option.getOr(withStores.requiredStores, []);
     globalThis.test("an unqualified store resolves against the declaring plugin", () => {
       globalThis.expect(stores.includes("TestPlugin.documents")).toBe(true);
@@ -1674,7 +1778,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
     });
   });
   globalThis.describe("uploadable types derive their store from the field name", () => {
-    let withUploads = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadImagesSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withUploads = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadImagesSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     let stores = Stdlib_Option.getOr(withUploads.requiredStores, []);
     globalThis.test("the derived store is the field name, pluralised", () => {
       globalThis.expect(stores.includes("TestPlugin.productImages")).toBe(true);
@@ -1735,7 +1839,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
   globalThis.describe("near-duplicate stores are refused", () => {
     let failureText = () => {
       try {
-        Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsTypoStoreSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+        Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsTypoStoreSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
         return "";
       } catch (raw_e) {
         let e = Primitive_exceptions.internalToException(raw_e);
@@ -1764,7 +1868,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       ]);
     });
     globalThis.test("the four stores of the uploadable fixture do not collide", () => {
-      globalThis.expect(Capability_Inference$ReventlessCore.collisions(Stdlib_Option.getOr(Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadImagesSlice], undefined, undefined, undefined, undefined, undefined, undefined).requiredStoreDeclarations, []))).toEqual([]);
+      globalThis.expect(Capability_Inference$ReventlessCore.collisions(Stdlib_Option.getOr(Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadImagesSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined).requiredStoreDeclarations, []))).toEqual([]);
     });
     globalThis.test("one edit, transpositions included; two edits not", () => {
       globalThis.expect([
@@ -1801,7 +1905,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
     });
   });
   globalThis.describe("optional carriers keep their declarations", () => {
-    let withOptional = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadAvatarSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withOptional = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsUploadAvatarSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     globalThis.test("an optional storage ref still requires its store", () => {
       globalThis.expect(withOptional.requiredStores).toEqual(["TestPlugin.avatars"]);
     });
@@ -1852,7 +1956,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       globalThis.expect(eventWarnings).toEqual(expected);
     });
     globalThis.test("a heuristic-only match reaches no manifest entry", () => {
-      let withHeuristicField = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsChangePhotoSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+      let withHeuristicField = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsChangePhotoSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
       globalThis.expect(withHeuristicField.requiredStores).toEqual(["TestPlugin.productPhotos"]);
       let manifest = CapabilityManifest$Reventless.fromStructure(withHeuristicField);
       globalThis.expect(manifest.capabilities.every(entry => entry.declaredBy.every(site => Primitive_object.notequal(site.field, "photoUrl")))).toBe(true);
@@ -1879,7 +1983,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
     });
   });
   globalThis.describe("plural references reach the manifest", () => {
-    let withPluralRefs = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsReserveStockSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+    let withPluralRefs = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [PsReserveStockSlice], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     let slice = withPluralRefs.stateChangeSlices[0];
     let referencesOf = refs => refs.map(param => [
       param.fieldName,
@@ -1899,9 +2003,25 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
         [
           "warehouseIds",
           "Warehouses"
+        ],
+        [
+          "lineItems[].productId",
+          "AvailableProducts"
         ]
       ]);
     });
+    globalThis.test("a reference on a nested record's field is named by its path", () => {
+      let cmd = slice.commands[0];
+      globalThis.expect(cmd.references.find(param => param.fieldName === "lineItems[].productId")).toEqual({
+        fieldName: "lineItems[].productId",
+        entity: "AvailableProducts",
+        plugin: undefined
+      });
+    });
+    globalThis.test("a flat reference in the same variant keeps its bare name", () => {
+      let cmd = slice.commands[0];
+      globalThis.expect(cmd.references.some(param => param.fieldName === "customerId")).toBe(true);
+    });
     globalThis.test("an optional array ref is collected under the field's own name", () => {
       let cmd = slice.commands[0];
       globalThis.expect(cmd.references.find(param => param.fieldName === "warehouseIds")).toEqual({
@@ -1917,6 +2037,11 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
           "AvailableProducts"
         ]]);
     });
+    globalThis.test("a nested input object publishes the type name the SDL declares", () => {
+      let cmd = slice.commands[0];
+      let itemName = Stdlib_Option.flatMap(Stdlib_Option.flatMap(Stdlib_Option.flatMap(getPropertyOf(JSON.parse(cmd.schema), "lineItems"), s => getProperty(s, "items")), s => getProperty(s, "x-reventless-graphql-input")), Stdlib_JSON.Decode.string);
+      globalThis.expect(itemName).toEqual(cmd.mutationField + "LineItems");
+    });
     globalThis.test("the declared entity wins over the one the field name suggests", () => {
       let cmd = slice.commands[0];
       globalThis.expect(Stdlib_Option.map(cmd.references.find(param => param.fieldName === "productIds"), param => param.entity)).toEqual("AvailableProducts");
@@ -2058,7 +2183,7 @@ globalThis.describe("duplicate DCB command names", () => {
       Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [
         PsShipOrderSlice,
         PsShipOrderSlice
-      ], undefined, undefined, undefined, undefined, undefined, undefined);
+      ], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
       tmp = false;
     } catch (exn) {
       tmp = true;
@@ -2071,7 +2196,7 @@ globalThis.describe("duplicate DCB command names", () => {
       val = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [
         PsShipOrderSlice,
         PsShipOrderSlice
-      ], undefined, undefined, undefined, undefined, undefined, undefined);
+      ], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
     } catch (raw_e) {
       let e = Primitive_exceptions.internalToException(raw_e);
       if (e.RE_EXN_ID === "JsExn") {
@@ -2095,7 +2220,7 @@ globalThis.describe("duplicate DCB command names", () => {
       Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, undefined, [
         PsPlaceOrderSlice,
         PsShipOrderSlice
-      ], undefined, undefined, undefined, undefined, undefined, undefined);
+      ], undefined, undefined, undefined, undefined, undefined, undefined, undefined);
       tmp = true;
     } catch (exn) {
       tmp = false;

package/tests/plugin/StateChangeSlice/PsAttachInvoice.res.mjs

@@ -37,7 +37,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];

package/tests/plugin/StateChangeSlice/PsChangePhoto.res.mjs

@@ -38,7 +38,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];

package/tests/plugin/StateChangeSlice/PsGatedCommands.res.mjs

@@ -58,7 +58,7 @@ function commandAuthorization(command) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];

package/tests/plugin/StateChangeSlice/PsPlaceOrder.res.mjs

@@ -36,7 +36,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];

package/tests/plugin/StateChangeSlice/PsReserveStock.res

@@ -1,4 +1,5 @@
-// Test fixture spec where every reference carrier is PLURAL.
+// Test fixture spec where every reference carrier is one the naive walk misses:
+// PLURAL, or declared on a field of a record the command holds.
 //
 // `Reference.to_` returns an *element* schema, so the ppx annotates the `string`
 // inside `array<string>` and the field's own schema carries no marker. A walk
@@ -11,6 +12,11 @@
 // shows up as one of the two disappearing rather than as an empty list, and
 // `warehouseIds?` covers the plural-inside-optional shape, where the array sits
 // one wrapper further down still.
+//
+// `lineItems` covers the other shape the walk has to descend into: a reference
+// declared on a field of a record the command holds, which belongs to that field
+// and is named by its path. A named record type, not an inline one — the ppx
+// walks a type declaration, which is what puts the marker on `productId` at all.
 
 @@reventless.spec("ReserveStock")
 
@@ -22,6 +28,12 @@ type consumedEvent = StockReserved({reservationId: string})
 
 let evolve = (_state, _event) => true
 
+@schema
+type lineItem = {
+  @ref("AvailableProducts") productId: string,
+  quantity: int,
+}
+
 @schema
 type command =
   | ReserveStock({
@@ -29,6 +41,7 @@ type command =
       @ref("Customers") customerId: string,
       @ref("AvailableProducts") productIds: array<string>,
       @ref("Warehouses") warehouseIds?: array<string>,
+      lineItems: array<lineItem>,
     })
 
 @schema

package/tests/plugin/StateChangeSlice/PsReserveStock.res.mjs

@@ -13,12 +13,18 @@ function evolve(_state, _event) {
   return true;
 }
 
+let lineItemSchema = Sury.$schema(s => ({
+  productId: s.m(Reference$Reventless.to_(undefined, undefined, "AvailableProducts")),
+  quantity: s.m(Sury.int)
+}));
+
 let commandSchema = Sury.$schema(s => ({
   TAG: "ReserveStock",
   reservationId: s.m(DcbTag$Reventless.partition),
   customerId: s.m(Reference$Reventless.to_(undefined, undefined, "Customers")),
   productIds: s.m(Sury.array(Reference$Reventless.to_(undefined, "productId", "AvailableProducts"))),
-  warehouseIds: s.m(Sury.$option(Sury.array(Reference$Reventless.to_(undefined, "warehouseId", "Warehouses"))))
+  warehouseIds: s.m(Sury.$option(Sury.array(Reference$Reventless.to_(undefined, "warehouseId", "Warehouses")))),
+  lineItems: s.m(Sury.array(lineItemSchema))
 }));
 
 let errorSchema = Sury.literal("OutOfStock");
@@ -41,7 +47,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];
@@ -62,6 +68,7 @@ export {
   initialState,
   consumedEventSchema,
   evolve,
+  lineItemSchema,
   commandSchema,
   errorSchema,
   eventSchema,

package/tests/plugin/StateChangeSlice/PsTypoStore.res.mjs

@@ -36,7 +36,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];

package/tests/plugin/StateChangeSlice/PsUploadAvatar.res.mjs

@@ -38,7 +38,7 @@ function commandAuthorization(param) {
 }
 
 function commandTransition(param) {
-  return "Unrestricted";
+  return "Undeclared";
 }
 
 let traits = [];