@reventlessdev/reventless-core 3.0.0-alpha.251 → 3.0.0-alpha.253

package/tests/plugin/StateChangeSlice/PsDispatchShipment.res

@@ -1,15 +1,16 @@
-// Test fixture spec for the @transition cross-check — the failing case.
+// Test fixture spec for the declared-edge cross-check — the failing case.
 //
-// `Dispatchd` is a deliberate typo. It compiles: the PPX strips the attribute
-// before the typechecker sees it, so a misspelled state is a well-formed string
-// all the way down. That is exactly the hole the structure-side check closes,
-// and a fixture that could not compile would not demonstrate it.
+// The switch names constructors of THIS file's own enum, and `Dispatchd` is a
+// real case of it, so the compiler is satisfied. The linked `Shipments` view
+// declares `Booked | Dispatched`, and nothing forces a spec to pick its linked
+// view's enum — which is the hole the structure-side check closes, and the half
+// the typechecker cannot reach.
 
 @@reventless.spec("DispatchShipment")
 
 type shipmentStatus =
   | Booked
-  | Dispatched
+  | Dispatchd
 
 @schema
 type consumedEvent = ShipmentBooked({shipmentId: string})
@@ -20,7 +21,7 @@ type state = bool
 let initialState = false
 
 @schema
-type command = @transition(([Booked]) => Dispatchd) DispatchShipment({shipmentId: string})
+type command = DispatchShipment({shipmentId: string})
 
 @schema
 type error = ShipmentNotFound
@@ -29,3 +30,12 @@ type error = ShipmentNotFound
 type event = ShipmentDispatched({shipmentId: string})
 
 let decide = (_state, _command): result<array<event>, error> => Ok([])
+
+type lifecycleState = shipmentStatus
+
+let commandTransition = (command: command): Reventless.Transition.t<lifecycleState> => {
+  open Reventless.Transition
+  switch command {
+  | DispatchShipment(_) => Moves([Booked], Dispatchd)
+  }
+}

package/tests/plugin/StateChangeSlice/PsDispatchShipment.res.mjs

@@ -2,7 +2,6 @@
 
 import * as Sury from "sury";
 import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
-import * as Api$ReventlessInfra from "@reventlessdev/reventless-infra/src/components/Api.res.mjs";
 
 let consumedEventSchema = Sury.$schema(s => ({
   TAG: "ShipmentBooked",
@@ -32,20 +31,20 @@ function decide(_state, _command) {
   };
 }
 
-let commandSchema$1 = Api$ReventlessInfra.markAllowedStates(commandSchema, [[
-    "DispatchShipment",
-    ["Booked"]
-  ]]);
-
-let commandSchema$2 = Api$ReventlessInfra.markTargetState(commandSchema$1, [[
-    "DispatchShipment",
-    "Dispatchd"
-  ]]);
+function commandTransition(command) {
+  return {
+    TAG: "Moves",
+    _0: ["Booked"],
+    _1: "Dispatchd"
+  };
+}
 
 function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+let traits = [];
+
 let name = "DispatchShipment";
 
 let Id;
@@ -62,12 +61,14 @@ export {
   consumedEventSchema,
   evolve,
   initialState,
+  commandSchema,
   errorSchema,
   eventSchema,
   decide,
-  commandSchema$2 as commandSchema,
+  commandTransition,
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsGatedCommands.res.mjs

@@ -57,6 +57,12 @@ function commandAuthorization(command) {
   }
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "GatedCommands";
 
 let Id;
@@ -80,5 +86,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsPlaceOrder.res.mjs

@@ -35,6 +35,12 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "PlaceOrder";
 
 let Id;
@@ -58,5 +64,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsReserveStock.res.mjs

@@ -40,6 +40,12 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "ReserveStock";
 
 let Id;
@@ -63,5 +69,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsShipOrder.res

@@ -13,27 +13,21 @@ type consumedEvent = OrderPlaced | OrderShipped | OrderCancelled
 
 let evolve = (_state, _event) => true
 
-// CancelShipment is payload-less — it compiles to a bare string literal, so it
-// exercises toCommandDef's payload-less branch (still surfaced in `commands`).
-// It is also `@noApi` (internal/admin only): a two-variant slice with exactly
-// one API-exposed command, which is the case that used to leak the exposed
-// command's slice mutation field onto the non-exposed variant.
-// The lifecycle this slice's commands move a shipment through. The PPX strips
-// @transition before the typechecker sees it, so this enum is not what makes the
-// reference below valid — the structure-side check against the linked view is.
-// It is here because a state is a constructor, and naming one in a string is a
-// reference nothing can check at any layer.
+// The lifecycle this slice's commands move a shipment through. Declared here
+// rather than on a linked view because this fixture's plugin has none: the
+// structure-side check warns instead of failing when a component's views declare
+// no lifecycle, and that is the path this exercises.
 type shipmentStatus = Placed | Shipped | Cancelled
 
 // CancelShipment is payload-less — it compiles to a bare string literal, so it
 // exercises toCommandDef's payload-less branch (still surfaced in `commands`).
 // It is also `@noApi` (internal/admin only): a two-variant slice with exactly
 // one API-exposed command, which is the case that used to leak the exposed
-// command's slice mutation field onto the non-exposed variant. It carries no
-// @transition, which is the un-annotated case the resolver still guesses for.
+// command's slice mutation field onto the non-exposed variant. It declares no
+// edge, which is the case the board resolver still guesses for.
 @schema
 type command =
-  | @transition(([Placed]) => Shipped) ShipOrder({orderId: string})
+  | ShipOrder({orderId: string})
   | @noApi CancelShipment
 
 // Two variants, one payload-less and one carrying a field — the same two branches
@@ -47,3 +41,13 @@ type error = OrderNotFound | NotShippable({reason: string})
 type event = OrderShipped({orderId: string}) | ShipmentVoided
 
 let decide = (_state, _command): result<array<event>, error> => Ok([])
+
+type lifecycleState = shipmentStatus
+
+let commandTransition = (command: command): Reventless.Transition.t<lifecycleState> => {
+  open Reventless.Transition
+  switch command {
+  | ShipOrder(_) => Moves([Placed], Shipped)
+  | CancelShipment => Unrestricted
+  }
+}

package/tests/plugin/StateChangeSlice/PsShipOrder.res.mjs

@@ -45,22 +45,26 @@ function decide(_state, _command) {
   };
 }
 
-let commandSchema$1 = Api$ReventlessInfra.markNoApiVariants(commandSchema, ["CancelShipment"]);
-
-let commandSchema$2 = Api$ReventlessInfra.markAllowedStates(commandSchema$1, [[
-    "ShipOrder",
-    ["Placed"]
-  ]]);
+function commandTransition(command) {
+  if (typeof command !== "object") {
+    return "Unrestricted";
+  } else {
+    return {
+      TAG: "Moves",
+      _0: ["Placed"],
+      _1: "Shipped"
+    };
+  }
+}
 
-let commandSchema$3 = Api$ReventlessInfra.markTargetState(commandSchema$2, [[
-    "ShipOrder",
-    "Shipped"
-  ]]);
+let commandSchema$1 = Api$ReventlessInfra.markNoApiVariants(commandSchema, ["CancelShipment"]);
 
 function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+let traits = [];
+
 let name = "ShipOrder";
 
 let Id;
@@ -80,9 +84,11 @@ export {
   errorSchema,
   eventSchema,
   decide,
-  commandSchema$3 as commandSchema,
+  commandTransition,
+  commandSchema$1 as commandSchema,
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsTransitionSwitch.res

@@ -0,0 +1,54 @@
+// Test fixture spec for `commandTransition` — the three shapes of a declared
+// edge, in one command type:
+//
+//   `Book`     moves the row: a from-set and a target.
+//   `Rebook`   guards only: a from-set and no target, which is the positive
+//              claim that the command moves the row nowhere.
+//   `Abandon`  declares nothing, and must stay unconstrained.
+//
+// The states go in as constructors of this file's own enum, so the compiler
+// resolves them.
+
+@@reventless.spec("TransitionSwitch")
+
+type bookingStatus = Draft | Booked | Abandoned
+
+@schema
+type consumedEvent = BookingDrafted({bookingId: string})
+
+let evolve = (_state, _event) => true
+
+type state = bool
+let initialState = false
+
+@schema
+type command =
+  | Book({bookingId: string})
+  | Rebook({bookingId: string})
+  | Abandon({bookingId: string})
+
+@schema
+type error = BookingNotFound
+
+@schema
+type event = BookingBooked({bookingId: string}) | BookingAbandoned({bookingId: string})
+
+let decide = (_state, _command): result<array<event>, error> => Ok([])
+
+type lifecycleState = bookingStatus
+
+let commandTransition = (command: command): Reventless.Transition.t<lifecycleState> => {
+  open Reventless.Transition
+  switch command {
+  | Book(_) => Moves([Draft], Booked)
+  | Rebook(_) => Guards([Booked])
+  | Abandon(_) => Unrestricted
+  }
+}
+
+// Declared, so the structure has a graft to record. The value stands in for a
+// trait package's own `declaration` — a fixture cannot depend on one, and what is
+// under test is the collection, not where the value came from.
+let traits: array<Reventless.Trait.t> = [
+  {trait: "@reventlessdev/trait-booking", version: "9.9.9", posture: SelfContained},
+]

package/tests/plugin/StateChangeSlice/PsTransitionSwitch.res.mjs

@@ -0,0 +1,104 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as Sury from "sury";
+import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
+
+let consumedEventSchema = Sury.$schema(s => ({
+  TAG: "BookingDrafted",
+  bookingId: s.m(DcbTag$Reventless.string)
+}));
+
+function evolve(_state, _event) {
+  return true;
+}
+
+let commandSchema = Sury.union([
+  Sury.$schema(s => ({
+    TAG: "Book",
+    bookingId: s.m(DcbTag$Reventless.string)
+  })),
+  Sury.$schema(s => ({
+    TAG: "Rebook",
+    bookingId: s.m(DcbTag$Reventless.string)
+  })),
+  Sury.$schema(s => ({
+    TAG: "Abandon",
+    bookingId: s.m(DcbTag$Reventless.string)
+  }))
+]);
+
+let errorSchema = Sury.literal("BookingNotFound");
+
+let eventSchema = Sury.union([
+  Sury.$schema(s => ({
+    TAG: "BookingBooked",
+    bookingId: s.m(DcbTag$Reventless.string)
+  })),
+  Sury.$schema(s => ({
+    TAG: "BookingAbandoned",
+    bookingId: s.m(DcbTag$Reventless.string)
+  }))
+]);
+
+function decide(_state, _command) {
+  return {
+    TAG: "Ok",
+    _0: []
+  };
+}
+
+function commandTransition(command) {
+  switch (command.TAG) {
+    case "Book" :
+      return {
+        TAG: "Moves",
+        _0: ["Draft"],
+        _1: "Booked"
+      };
+    case "Rebook" :
+      return {
+        TAG: "Guards",
+        _0: ["Booked"]
+      };
+    case "Abandon" :
+      return "Unrestricted";
+  }
+}
+
+let traits = [{
+    trait: "@reventlessdev/trait-booking",
+    version: "9.9.9",
+    posture: "SelfContained"
+  }];
+
+function commandAuthorization(param) {
+  return "AllowAuthenticated";
+}
+
+let name = "TransitionSwitch";
+
+let Id;
+
+let initialState = false;
+
+let moduleUrl = "@reventlessdev/reventless-core/tests/plugin/StateChangeSlice/PsTransitionSwitch.res.mjs";
+
+let readConsistency = "EscalateOnRetry";
+
+export {
+  name,
+  Id,
+  consumedEventSchema,
+  evolve,
+  initialState,
+  commandSchema,
+  errorSchema,
+  eventSchema,
+  decide,
+  commandTransition,
+  traits,
+  moduleUrl,
+  commandAuthorization,
+  readConsistency,
+}
+/* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsTypoStore.res.mjs

@@ -35,6 +35,12 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "TypoStore";
 
 let Id;
@@ -58,5 +64,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsUploadAvatar.res.mjs

@@ -37,6 +37,12 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "UploadAvatar";
 
 let Id;
@@ -60,5 +66,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsUploadImages.res.mjs

@@ -39,6 +39,12 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let name = "UploadImages";
 
 let Id;
@@ -62,5 +68,7 @@ export {
   moduleUrl,
   commandAuthorization,
   readConsistency,
+  commandTransition,
+  traits,
 }
 /* consumedEventSchema Not a pure module */

package/tests/plugin/StateViewSlice/PsShipmentsView.res

@@ -1,4 +1,4 @@
-// Test fixture spec for the @transition cross-check.
+// Test fixture spec for the declared-edge cross-check.
 // A view that declares a lifecycle, so a command's declared states have
 // something to be checked against. `PsOrdersView` deliberately declares none —
 // the two together cover both the checked and the unvalidated path.

package/tests/plugin/pluginDefinitionRequiredScalars.txt

@@ -105,6 +105,24 @@
 .structure.readModels[].retiredValues[]: string
 .structure.readModels[].schema: string
 .structure.readModels[].searchableFields[]: string
+# `requiredCapabilities` is itself `js_nullable` and is NEW, so no persisted payload
+# carries the array: a stored structure heals to null and these two are never reached.
+# Required inside it because a declaration naming no capability, or no declaring
+# component, is not a declaration — the same call `requiredStoreDeclarations` made for
+# `store`/`component`/`field`.
+.structure.requiredCapabilities[].capability: string
+.structure.requiredCapabilities[].component: string
+# `traitDeclarations` is itself `js_nullable` and is NEW, so no persisted payload
+# carries the array: a stored structure heals to null and these four are never
+# reached. Required inside it for the same reason the two above are — a graft
+# naming no trait, no version, no posture or no component is not a record of a
+# graft, and a fabricated `""` here would read as "grafted from nothing", which is
+# worse than absent. The version is read from the trait's own package rather than
+# written by hand, so it cannot be the empty string in practice either.
+.structure.traitDeclarations[].component: string
+.structure.traitDeclarations[].posture: string
+.structure.traitDeclarations[].trait: string
+.structure.traitDeclarations[].version: string
 .structure.requiredStoreDeclarations[].component: string
 .structure.requiredStoreDeclarations[].field: string
 .structure.requiredStoreDeclarations[].store: string

package/tests/util/CommandPublisherTest.res.mjs

@@ -15,10 +15,18 @@ function commandAuthorization(param) {
   return "AllowAuthenticated";
 }
 
+function commandTransition(param) {
+  return "Unrestricted";
+}
+
+let traits = [];
+
 let TestSpec = {
   name: "TestCmd",
   commandSchema: commandSchema,
-  commandAuthorization: commandAuthorization
+  commandAuthorization: commandAuthorization,
+  commandTransition: commandTransition,
+  traits: traits
 };
 
 function publishCommands(_name, cmds) {

package/src/components/Api/ApiAllowedStatesHelpers.res

@@ -1,18 +0,0 @@
-// Read per-variant `allowedStates` metadata that the reventless-ppx
-// an `@transition` from-set attaches to a command schema. Consumed by
-// `Plugin_Structure.toCommandDef` when building the `commandDef` records that
-// land in `Platform_ComponentDefinitions` so AutoUI can filter the per-row command
-// menu by the row's status.
-
-open ReventlessInfra.Api
-
-/** Returns the allowed-state list for a given command-variant name, or None
-    when the variant declares no `@transition` (the command shows on every row). */
-let getAllowedStates = (
-  commandSchema: S.t<unknown>,
-  ~variantName: string,
-): option<array<string>> =>
-  switch commandSchema->S.Metadata.get(~id=allowedStatesId) {
-  | None => None
-  | Some(entries) => entries->Dict.get(variantName)
-  }

package/src/components/Api/ApiAllowedStatesHelpers.res.mjs

@@ -1,16 +0,0 @@
-// Generated by ReScript, PLEASE EDIT WITH CARE
-
-import * as Sury from "sury";
-import * as Api$ReventlessInfra from "@reventlessdev/reventless-infra/src/components/Api.res.mjs";
-
-function getAllowedStates(commandSchema, variantName) {
-  let entries = Sury.$Metadata_get(commandSchema, Api$ReventlessInfra.allowedStatesId);
-  if (entries !== undefined) {
-    return entries[variantName];
-  }
-}
-
-export {
-  getAllowedStates,
-}
-/* sury Not a pure module */

package/src/components/Api/ApiTargetStateHelpers.res

@@ -1,21 +0,0 @@
-// Read per-variant `targetState` metadata that the reventless-ppx
-// an `@transition` target attaches to a command schema. Consumed by
-// `Plugin_Structure.toCommandDef` when building the `commandDef` records that
-// land in `Platform_ComponentDefinitions`, so AutoUI's board drag resolver can
-// move a row by a *declared* transition instead of a name-stem guess. Mirrors
-// `ApiAllowedStatesHelpers.getAllowedStates`.
-
-open ReventlessInfra.Api
-
-/** Returns the declared target state for a given command-variant name, or None
-    when the variant declares no target — either because it carries no
-    `@transition` at all, or because it declares a from-set only, which is a
-    command saying it does not move the row. */
-let getTargetState = (
-  commandSchema: S.t<unknown>,
-  ~variantName: string,
-): option<string> =>
-  switch commandSchema->S.Metadata.get(~id=targetStateId) {
-  | None => None
-  | Some(entries) => entries->Dict.get(variantName)
-  }

package/src/components/Api/ApiTargetStateHelpers.res.mjs

@@ -1,16 +0,0 @@
-// Generated by ReScript, PLEASE EDIT WITH CARE
-
-import * as Sury from "sury";
-import * as Api$ReventlessInfra from "@reventlessdev/reventless-infra/src/components/Api.res.mjs";
-
-function getTargetState(commandSchema, variantName) {
-  let entries = Sury.$Metadata_get(commandSchema, Api$ReventlessInfra.targetStateId);
-  if (entries !== undefined) {
-    return entries[variantName];
-  }
-}
-
-export {
-  getTargetState,
-}
-/* sury Not a pure module */