@reventlessdev/reventless-core 3.0.0-alpha.249 → 3.0.0-alpha.250

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.250 (2026-08-23)
+
+### Bug Fixes
+
+* **querydb:** serve the previous page instead of refusing it ([48341c9](https://github.com/ReventlessDev/reventless-core/commit/48341c9f61b5155b441deeb0edc9abf461948346))
+
+
 # 3.0.0-alpha.249 (2026-08-23)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.249",
+  "version": "3.0.0-alpha.250",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -30,15 +30,15 @@
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
     "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.8",
-    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
+    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
     "@reventlessdev/rescript-node": "2.0.0-alpha.8",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.19",
     "@reventlessdev/rescript-ssh2": "2.0.0-alpha.8",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.33",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.151",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.123"
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.123",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.151"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/components/Api/QueryDbListQuery.res

@@ -265,10 +265,22 @@ let run = (
 
   let first =
     argsDict->Dict.get("first")->Option.flatMap(JSON.Decode.float)->Option.map(Float.toInt)
-  let after = argsDict->Dict.get("after")->Option.flatMap(JSON.Decode.string)
+  // An empty cursor is no cursor. The host shell clears the opposite argument by
+  // setting it to "" rather than dropping it, and `Some("")` read as a cursor
+  // bounds nothing while still selecting the branch that expects one.
+  let cursorArg = key =>
+    argsDict
+    ->Dict.get(key)
+    ->Option.flatMap(JSON.Decode.string)
+    ->Option.flatMap(s => s == "" ? None : Some(s))
+  let after = cursorArg("after")
   let last = argsDict->Dict.get("last")->Option.flatMap(JSON.Decode.float)->Option.map(Float.toInt)
-  let before = argsDict->Dict.get("before")->Option.flatMap(JSON.Decode.string)
-  let isBackward = last->Option.isSome
+  let before = cursorArg("before")
+  // `before` decides the direction, not `last`. Relay pairs `last` with `before`,
+  // but a client that keeps its page size in `first` and only moves the cursor
+  // sends `before` alone — and keying on `last` made that a FORWARD read bounded
+  // by nothing, which answers page one and calls it the previous page.
+  let isBackward = last->Option.isSome || before->Option.isSome
   let cursorField = orderByField->Option.getOr("id")
   let getCursorValue = item => getFieldString(item, cursorField)->Option.getOr(getId(item))
 
@@ -288,8 +300,12 @@ let run = (
   | _ => sorted
   }
 
+  // `last` when given, else the page size the caller has been paging with.
   let pageSize = if isBackward {
-    last->Option.getOr(defaultListPageSize)
+    switch last {
+    | Some(n) => n
+    | None => first->Option.getOr(defaultListPageSize)
+    }
   } else {
     first->Option.getOr(defaultListPageSize)
   }
@@ -311,10 +327,14 @@ let run = (
     (arr->Array.slice(~start=0, ~end=pageSize), hasMore)
   }
 
+  // Both directions report both flags. A backward page was cut from ahead, so a
+  // next page provably exists — the one the caller came from — and a forward page
+  // reached by a cursor has one behind it. Reporting only the flag that matches
+  // the direction made Prev vanish the moment it was used.
   buildConnection(
     ~pageItems,
-    ~hasNextPage=!isBackward && hasMore,
-    ~hasPreviousPage=isBackward && hasMore,
+    ~hasNextPage=isBackward ? true : hasMore,
+    ~hasPreviousPage=isBackward ? hasMore : after->Option.isSome,
     ~cursorValueOf=getCursorValue,
   )
 }

package/src/components/Api/QueryDbListQuery.res.mjs

@@ -154,10 +154,17 @@ function run(items, argsDict, capability, labelField, decodeLocalIdOpt, ownerSco
     });
   }
   let first = Stdlib_Option.map(Stdlib_Option.flatMap(argsDict["first"], Stdlib_JSON.Decode.float), prim => prim | 0);
-  let after = Stdlib_Option.flatMap(argsDict["after"], Stdlib_JSON.Decode.string);
+  let cursorArg = key => Stdlib_Option.flatMap(Stdlib_Option.flatMap(argsDict[key], Stdlib_JSON.Decode.string), s => {
+    if (s === "") {
+      return;
+    } else {
+      return s;
+    }
+  });
+  let after = cursorArg("after");
   let last = Stdlib_Option.map(Stdlib_Option.flatMap(argsDict["last"], Stdlib_JSON.Decode.float), prim => prim | 0);
-  let before = Stdlib_Option.flatMap(argsDict["before"], Stdlib_JSON.Decode.string);
-  let isBackward = Stdlib_Option.isSome(last);
+  let before = cursorArg("before");
+  let isBackward = Stdlib_Option.isSome(last) || Stdlib_Option.isSome(before);
   let cursorField = Stdlib_Option.getOr(orderByField, "id");
   let getCursorValue = item => Stdlib_Option.getOr(getFieldString(item, cursorField), getId(item));
   let cursorBounded;
@@ -188,7 +195,7 @@ function run(items, argsDict, capability, labelField, decodeLocalIdOpt, ownerSco
   } else {
     cursorBounded = sorted;
   }
-  let pageSize = isBackward ? Stdlib_Option.getOr(last, 50) : Stdlib_Option.getOr(first, 50);
+  let pageSize = isBackward && last !== undefined ? last : Stdlib_Option.getOr(first, 50);
   let take = pageSize + 1 | 0;
   let match;
   if (isBackward) {
@@ -210,7 +217,7 @@ function run(items, argsDict, capability, labelField, decodeLocalIdOpt, ownerSco
     ];
   }
   let hasMore$2 = match[1];
-  return buildConnection(match[0], !isBackward && hasMore$2, isBackward && hasMore$2, getCursorValue);
+  return buildConnection(match[0], isBackward ? true : hasMore$2, isBackward ? hasMore$2 : Stdlib_Option.isSome(after), getCursorValue);
 }
 
 let defaultListPageSize = 50;