@reventlessdev/reventless-core 3.0.0-alpha.243 → 3.0.0-alpha.244

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.244 (2026-08-20)
+
+### Bug Fixes
+
+* **api:** name a union after itself, not after the keyword ([58ab956](https://github.com/ReventlessDev/reventless-core/commit/58ab956b8fa310c60f118595768e40e750d61784))
+
+
 # 3.0.0-alpha.243 (2026-08-20)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.243",
+  "version": "3.0.0-alpha.244",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -35,9 +35,9 @@
     "@reventlessdev/rescript-node": "2.0.0-alpha.8",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.19",
     "@reventlessdev/rescript-ssh2": "2.0.0-alpha.8",
+    "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
     "@reventlessdev/reventless-infra": "3.0.0-alpha.148",
     "@reventlessdev/reventless-spec": "3.0.0-alpha.120",
-    "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.32"
   },
   "devDependencies": {

package/src/components/Api/GraphQL_Stitcher.res

@@ -122,17 +122,19 @@ let collectSubscriptionSources = (
 // Extract the first identifier from a SDL field/type string.
 // e.g. "  fieldName(args): Type" → "fieldName"
 //      "type TypeName {" → "TypeName"
+// Every SDL keyword that introduces a named definition. `union` was missing while
+// `CommandResult` was the only union in the schema: a keyword left in place makes
+// every declaration of that kind name itself after the keyword, so the second one
+// deduped against the first and vanished — AppSync then rejected the schema for a
+// type that was never emitted.
+let definitionKeywords = ["type ", "enum ", "input ", "union ", "interface ", "scalar "]
+
 let extractLeadingName = (str: string): string => {
   let trimmed = str->String.trim
-  // Remove "type ", "enum ", or "input " prefix if present
-  let afterType = if trimmed->String.startsWith("type ") {
-    trimmed->String.slice(~start=5, ~end=trimmed->String.length)->String.trim
-  } else if trimmed->String.startsWith("enum ") {
-    trimmed->String.slice(~start=5, ~end=trimmed->String.length)->String.trim
-  } else if trimmed->String.startsWith("input ") {
-    trimmed->String.slice(~start=6, ~end=trimmed->String.length)->String.trim
-  } else {
-    trimmed
+  let afterType = switch definitionKeywords->Array.find(kw => trimmed->String.startsWith(kw)) {
+  | Some(kw) =>
+    trimmed->String.slice(~start=kw->String.length, ~end=trimmed->String.length)->String.trim
+  | None => trimmed
   }
   // Split on "(" first to remove arg list, then on " ", "{", and ":" for the name.
   // The ":" split is load-bearing for ARG-LESS fields: `Foo: [Bar!]!` has no "(" to

package/src/components/Api/GraphQL_Stitcher.res.mjs

@@ -115,11 +115,19 @@ function collectSubscriptionSources(baseFragment, pluginFragments) {
   });
 }
 
+let definitionKeywords = [
+  "type ",
+  "enum ",
+  "input ",
+  "union ",
+  "interface ",
+  "scalar "
+];
+
 function extractLeadingName(str) {
   let trimmed = str.trim();
-  let afterType = trimmed.startsWith("type ") || trimmed.startsWith("enum ") ? trimmed.slice(5, trimmed.length).trim() : (
-      trimmed.startsWith("input ") ? trimmed.slice(6, trimmed.length).trim() : trimmed
-    );
+  let kw = definitionKeywords.find(kw => trimmed.startsWith(kw));
+  let afterType = kw !== undefined ? trimmed.slice(kw.length, trimmed.length).trim() : trimmed;
   return Stdlib_Option.getOr(Stdlib_Option.getOr(Stdlib_Option.getOr(Stdlib_Option.getOr(afterType.split("(")[0], "").trim().split(" ")[0], "").trim().split("{")[0], "").trim().split(":")[0], "").trim();
 }
 
@@ -231,6 +239,7 @@ export {
   encode,
   decode,
   collectSubscriptionSources,
+  definitionKeywords,
   extractLeadingName,
   relayBaseTypes,
   relayBaseQueries,

package/tests/api/GraphQL_StitcherTest.res

@@ -64,6 +64,51 @@ describe("GraphQL_Stitcher.subscriptionSources", () => {
   })
 })
 
+// Two unions in one schema is what caught this: every definition keyword the name
+// extractor does not strip makes each declaration of that kind name itself after
+// the keyword, so the second dedupes against the first and is dropped. With
+// `CommandResult` the only union, nothing showed it. The local path does not use
+// this dedup, so a golden carrying both unions still passed while AppSync rejected
+// the schema for a type that was never emitted.
+describe("GraphQL_Stitcher.extractLeadingName", () => {
+  testSync("names a union after the union, not after the keyword", () => {
+    expect(extractLeadingName("union Geolocation = GeolocationLocated | GeolocationPending"))->toBe(
+      "Geolocation",
+    )
+    expect(extractLeadingName("union CommandResult = CommandAccepted | CommandRejected"))->toBe(
+      "CommandResult",
+    )
+  })
+
+  testSync("names an interface and a scalar after themselves", () => {
+    expect(extractLeadingName("interface Node { id: ID! }"))->toBe("Node")
+    expect(extractLeadingName("scalar AWSDateTime"))->toBe("AWSDateTime")
+  })
+
+  // The cases that already worked, kept so a rewrite of the keyword list has to
+  // keep them working.
+  testSync("still names types, enums and inputs", () => {
+    expect(extractLeadingName("type Ordering_Customer implements Node { id: ID! }"))->toBe(
+      "Ordering_Customer",
+    )
+    expect(extractLeadingName("enum SortOrder { ASC DESC }"))->toBe("SortOrder")
+    expect(extractLeadingName("input Ordering_CustomerFilter { id: ID }"))->toBe(
+      "Ordering_CustomerFilter",
+    )
+  })
+
+  // Fields go through the same extractor, and an arg-less one has no "(" to cleave
+  // the type off.
+  testSync("still names fields, with and without args", () => {
+    expect(extractLeadingName("  Catalog_AddProduct(input: AddInput): CommandResult"))->toBe(
+      "Catalog_AddProduct",
+    )
+    expect(extractLeadingName("  Platform_ApiFragments: [Fragment!]!"))->toBe(
+      "Platform_ApiFragments",
+    )
+  })
+})
+
 describe("GraphQL_Stitcher.stitchStandalone", () => {
   let pluginFragment = encode({
     types: [

package/tests/api/GraphQL_StitcherTest.res.mjs

@@ -77,6 +77,26 @@ globalThis.describe("GraphQL_Stitcher.subscriptionSources", () => {
   });
 });
 
+globalThis.describe("GraphQL_Stitcher.extractLeadingName", () => {
+  globalThis.test("names a union after the union, not after the keyword", () => {
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("union Geolocation = GeolocationLocated | GeolocationPending")).toBe("Geolocation");
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("union CommandResult = CommandAccepted | CommandRejected")).toBe("CommandResult");
+  });
+  globalThis.test("names an interface and a scalar after themselves", () => {
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("interface Node { id: ID! }")).toBe("Node");
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("scalar AWSDateTime")).toBe("AWSDateTime");
+  });
+  globalThis.test("still names types, enums and inputs", () => {
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("type Ordering_Customer implements Node { id: ID! }")).toBe("Ordering_Customer");
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("enum SortOrder { ASC DESC }")).toBe("SortOrder");
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("input Ordering_CustomerFilter { id: ID }")).toBe("Ordering_CustomerFilter");
+  });
+  globalThis.test("still names fields, with and without args", () => {
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("  Catalog_AddProduct(input: AddInput): CommandResult")).toBe("Catalog_AddProduct");
+    globalThis.expect(GraphQL_Stitcher$ReventlessCore.extractLeadingName("  Platform_ApiFragments: [Fragment!]!")).toBe("Platform_ApiFragments");
+  });
+});
+
 globalThis.describe("GraphQL_Stitcher.stitchStandalone", () => {
   let pluginFragment = GraphQL_Stitcher$ReventlessCore.encode({
     types: [