@reventlessdev/reventless-core 3.0.0-alpha.238 → 3.0.0-alpha.240

package/src/plugin/lifecycle/PluginsReadModelSpec.res

@@ -1,5 +1,17 @@
 @@reventless.spec("Plugins")
 
+// Who may read this view. Declared rather than left to default, because the
+// default was `AllowAuthenticated` and it was not true: `PluginBaseFragment`
+// hand-wrote an `Admin` Cognito gate beside it, and the local platform serves
+// every `Platform_*` field behind an `Admin` wrapper. Three statements of one
+// rule, one of which disagreed with the other two.
+//
+// Stating it here makes the spec the source. The AppSync directive comes from
+// this (spec-level `permission` outranks the legacy `{tableName, group}` pair),
+// and so does the `requiredAccess` the platform publishes — so a shell can gate
+// the Plugins view up front instead of offering it and meeting a refusal.
+@@reventless.authorize(Reventless.Authorization.AllowGroups(["Admin"]))
+
 // Current view — one row per plugin **name**, holding the currently-active
 // version's definition. Keyed by the aggregate id (= plugin name). The status
 // here is the *current* version's status; "Superseded" is not represented (a
@@ -17,21 +29,33 @@ type status =
 type state = {
   name: Reventless.Plugin.name,
   version: Reventless.Plugin.version,
-  eventCollector: string,
+  // Projection/storage only — never on the GraphQL surface. `@internal` says so
+  // on the field, where the next person to edit the record will see it; the same
+  // three names used to live in a hand-written exclude list in `PluginBaseFragment`
+  // that nothing kept in step with this declaration.
+  @internal eventCollector: string,
   extensionPoints: array<Reventless.Plugin.extensionPointDefinition>,
-  extensionPointNames: array<string>,
-  extensionNames: array<string>,
+  @internal extensionPointNames: array<string>,
+  @internal extensionNames: array<string>,
   extensions: array<Reventless.Plugin.extensionDefinition>,
-  status: status,
+  // Annotated rather than renamed to `lifecycle` to meet the convention: `status`
+  // is published in the SDL, in stored rows and in the UI's hand-written plugin
+  // views. Without this the transition check has no states to compare and passes
+  // while verifying nothing.
+  @lifecycle status: status,
   statusChange: Message.statusChange,
   // Stored as the **untagged** offload wire JSON (a bare fragment, or an
   // `{$offload: {...}}` reference) — NOT the `Offload.payload` variant. The QueryDb
   // write path marshals the raw ReScript value straight to DynamoDB without
   // sury-encoding through this field's schema, so a variant would persist as its
-  // runtime `{TAG, _0}` shape and no reader could parse it. UI-excluded
-  // (PluginBaseFragment.pluginUIOnlyExcludeFields), so JSON.t typing costs no
-  // GraphQL consumer. PluginsProjection.displayState writes it via Offload.toJson.
-  apiSchemaFragment: option<JSON.t>,
+  // runtime `{TAG, _0}` shape and no reader could parse it.
+  // PluginsProjection.displayState writes it via Offload.toJson.
+  //
+  // `@hidden`, not `@internal`: the field IS on the API and the host shell fetches
+  // it through a dedicated resolver path. What it must not be is a column in a
+  // generated list view — it is a multi-kilobyte JSON blob, and a query that names
+  // it drags one per row over the wire to render a cell nobody reads.
+  @hidden apiSchemaFragment: option<JSON.t>,
   // API target for split-API schema routing. Absent/None means "Domain" (backward compat).
   // "Platform" → excluded from DomainApi runtime schema stitching in updateApiSchema.
   apiTarget?: string,
@@ -39,7 +63,10 @@ type state = {
   // None for older plugins whose protocol version did not carry the field. Same
   // untagged-JSON storage as apiSchemaFragment above; the ComponentDefinitions
   // Lambda detects the `$offload` sentinel and resolves it from S3.
-  structure: option<JSON.t>,
+  //
+  // `@hidden` for the same reason, and more so: this is the larger of the two
+  // blobs.
+  @hidden structure: option<JSON.t>,
   // DCB EventLog definition for plugins that bundle a DcbEventLog component.
   // Admin's manageSubscriptions uses this to wire cross-plugin SNS subscriptions
   // from this plugin's DCB topic → peer EventCollectors (and vice-versa). None

package/src/plugin/lifecycle/PluginsReadModelSpec.res.mjs

@@ -1,46 +1,54 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
-import * as S from "sury/src/S.res.mjs";
+import * as Sury from "sury";
 import * as Plugin$Reventless from "@reventlessdev/reventless-spec/src/components/Plugin.res.mjs";
 import * as ReadModel$Reventless from "@reventlessdev/reventless-spec/src/components/ReadModel.res.mjs";
 import * as Message$ReventlessCore from "../../Message.res.mjs";
 import * as StateAnnotations$Reventless from "@reventlessdev/reventless-spec/src/components/StateAnnotations.res.mjs";
 
-let statusSchema = S.union([
-  S.literal("Connected"),
-  S.literal("Disconnected"),
-  S.literal("Inactive"),
-  S.literal("Retired")
+let statusSchema = Sury.union([
+  Sury.literal("Connected"),
+  Sury.literal("Disconnected"),
+  Sury.literal("Inactive"),
+  Sury.literal("Retired")
 ]);
 
-let stateSchema = S.schema(s => ({
+let stateSchema = Sury.$schema(s => ({
   name: s.m(Plugin$Reventless.nameSchema),
   version: s.m(Plugin$Reventless.versionSchema),
-  eventCollector: s.m(S.string),
-  extensionPoints: s.m(S.array(Plugin$Reventless.extensionPointDefinitionSchema)),
-  extensionPointNames: s.m(S.array(S.string)),
-  extensionNames: s.m(S.array(S.string)),
-  extensions: s.m(S.array(Plugin$Reventless.extensionDefinitionSchema)),
+  eventCollector: s.m(Sury.string),
+  extensionPoints: s.m(Sury.array(Plugin$Reventless.extensionPointDefinitionSchema)),
+  extensionPointNames: s.m(Sury.array(Sury.string)),
+  extensionNames: s.m(Sury.array(Sury.string)),
+  extensions: s.m(Sury.array(Plugin$Reventless.extensionDefinitionSchema)),
   status: s.m(statusSchema),
   statusChange: s.m(Message$ReventlessCore.statusChangeSchema),
-  apiSchemaFragment: s.m(S.option(S.json)),
-  apiTarget: s.m(S.option(S.string)),
-  structure: s.m(S.option(S.json)),
+  apiSchemaFragment: s.m(Sury.$option(Sury.json)),
+  apiTarget: s.m(Sury.$option(Sury.string)),
+  structure: s.m(Sury.$option(Sury.json)),
   dcbEventLog: s.m(Plugin$Reventless.dcbEventLogOptionSchema),
-  kind: s.m(S.option(Plugin$Reventless.pluginKindSchema)),
-  otherConnectedVersions: s.m(S.array(Plugin$Reventless.versionSchema))
+  kind: s.m(Sury.$option(Plugin$Reventless.pluginKindSchema)),
+  otherConnectedVersions: s.m(Sury.array(Plugin$Reventless.versionSchema))
 }));
 
 let config = ReadModel$Reventless.config(undefined, undefined, undefined);
 
-let stateSchema$1 = S.Metadata.set(stateSchema, StateAnnotations$Reventless.stateAnnotationsId, {
+let stateSchema$1 = Sury.$Metadata_set(stateSchema, StateAnnotations$Reventless.stateAnnotationsId, {
   ids: [],
   compositeIds: [],
   subIds: [],
   compositeSubIds: [],
   indexes: [],
-  hidden: [],
+  hidden: [
+    "apiSchemaFragment",
+    "structure"
+  ],
   summary: [],
+  internal: [
+    "eventCollector",
+    "extensionPointNames",
+    "extensionNames"
+  ],
   drillTargets: [],
   drillTargetKeys: [],
   collapsed: [],
@@ -48,13 +56,18 @@ let stateSchema$1 = S.Metadata.set(stateSchema, StateAnnotations$Reventless.stat
   scanSort: [],
   semantic: [],
   metric: [],
-  lifecycle: undefined,
+  lifecycle: "status",
   groupBy: "kind",
   visibility: undefined,
   live: undefined,
   retired: undefined
 });
 
+let authorization = {
+  TAG: "AllowGroups",
+  _0: ["Admin"]
+};
+
 let name = "Plugins";
 
 let Id;
@@ -63,8 +76,6 @@ let subIdConfig;
 
 let moduleUrl = "@reventlessdev/reventless-core/src/plugin/lifecycle/PluginsReadModelSpec.res.mjs";
 
-let authorization = "AllowAuthenticated";
-
 let visibility = "Public";
 
 export {

package/src/util/Interstack.res

@@ -21,7 +21,7 @@ module DefaultTaskQuery = ReventlessInterop.Query.Task.Make({
   let requiredFields = ["name"]
   let optionalFields = ["bucketNames", "sideEffectSources"]
   let fromJson = (json: JSON.t) =>
-    try Ok(json->S.parseOrThrow(ReventlessInterop.Task.resolvedOutputsSchema))
+    try Ok(json->S.parseOrThrow(~to=ReventlessInterop.Task.resolvedOutputsSchema))
     catch {
     | exn =>
       let msg =
@@ -35,7 +35,7 @@ module DefaultEventMapperQuery = ReventlessInterop.Query.EventMapper.Make({
   let requiredFields = ["name", "eventCollector"]
   let optionalFields = ["counter"]
   let fromJson = (json: JSON.t) =>
-    try Ok(json->S.parseOrThrow(ReventlessInterop.EventMapper.resolvedOutputsSchema))
+    try Ok(json->S.parseOrThrow(~to=ReventlessInterop.EventMapper.resolvedOutputsSchema))
     catch {
     | exn =>
       let msg =
@@ -54,7 +54,7 @@ module DefaultExtensionPointQuery = ReventlessInterop.Query.ExtensionPoint.Make(
   let requiredFields = ["name", "commandTopic", "eventTopic"]
   let optionalFields = []
   let fromJson = (json: JSON.t) =>
-    try Ok(json->S.parseOrThrow(ReventlessInterop.ExtensionPoint.resolvedOutputsSchema))
+    try Ok(json->S.parseOrThrow(~to=ReventlessInterop.ExtensionPoint.resolvedOutputsSchema))
     catch {
     | exn =>
       let msg =

package/src/util/LogFormat.res

@@ -248,8 +248,7 @@ let fmtState = (~name: string, ~id: string, ~seq: int): string =>
   `state=${name}(${id}) seq=${seq->Int.toString}`
 
 // "err=<message>"
-let fmtExn = (e: exn): string =>
-  `err=${e->JsExn.fromException->Option.flatMap(JsExn.message)->Option.getOr("unknown")}`
+let fmtExn = (e: exn): string => `err=${e->Reventless.Util_Sury.exnMessage}`
 
 // ─── Legacy aliases (kept for existing callers) ──────────────────────────────
 

package/src/util/LogFormat.res.mjs

@@ -3,10 +3,10 @@
 import * as Stdlib_Int from "@rescript/runtime/lib/es6/Stdlib_Int.js";
 import * as Stdlib_JSON from "@rescript/runtime/lib/es6/Stdlib_JSON.js";
 import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
-import * as Stdlib_JsExn from "@rescript/runtime/lib/es6/Stdlib_JsExn.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Primitive_option from "@rescript/runtime/lib/es6/Primitive_option.js";
 import * as AnsiStyle$Reventless from "@reventlessdev/reventless-spec/src/AnsiStyle.res.mjs";
+import * as Util_Sury$Reventless from "@reventlessdev/reventless-spec/src/util/Util_Sury.res.mjs";
 import * as Message$ReventlessCore from "../Message.res.mjs";
 
 let maxValueChars = Stdlib_Option.getOr(Stdlib_Option.flatMap(process.env["REVENTLESS_LOG_MAX_VALUE"], v => Stdlib_Int.fromString(v, undefined)), 512);
@@ -204,7 +204,7 @@ function fmtState(name, id, seq) {
 }
 
 function fmtExn(e) {
-  return `err=` + Stdlib_Option.getOr(Stdlib_Option.flatMap(Stdlib_JsExn.fromException(e), Stdlib_JsExn.message), "unknown");
+  return `err=` + Util_Sury$Reventless.exnMessage(e, undefined);
 }
 
 function commandJsonsToLogMessages(cmdJsons) {

package/tests/IdentityTest.res

@@ -1,6 +1,5 @@
 open JestGlobals
 
-S.enableJson()
 
 describe("Identity", () => {
   describe("anonymous", () => {
@@ -71,8 +70,8 @@ describe("Identity", () => {
         claims: Dict.fromArray([("tenant", "acme")]),
         provider: Cognito,
       }
-      let json = identity->S.reverseConvertToJsonOrThrow(Reventless.Identity.schema)
-      let decoded = json->S.parseJsonOrThrow(Reventless.Identity.schema)
+      let json = identity->Reventless.Util_Sury.toJson(Reventless.Identity.schema)
+      let decoded = json->Reventless.Util_Sury.fromJson(Reventless.Identity.schema)
       expect(decoded)->toEqual(identity)
     })
 
@@ -83,8 +82,8 @@ describe("Identity", () => {
         groups: [],
         provider: Custom("oauth2"),
       }
-      let json = identity->S.reverseConvertToJsonOrThrow(Reventless.Identity.schema)
-      let decoded = json->S.parseJsonOrThrow(Reventless.Identity.schema)
+      let json = identity->Reventless.Util_Sury.toJson(Reventless.Identity.schema)
+      let decoded = json->Reventless.Util_Sury.fromJson(Reventless.Identity.schema)
       expect(decoded)->toEqual(identity)
     })
 
@@ -95,8 +94,8 @@ describe("Identity", () => {
         groups: [],
         provider: InMemory,
       }
-      let json = identity->S.reverseConvertToJsonOrThrow(Reventless.Identity.schema)
-      let decoded = json->S.parseJsonOrThrow(Reventless.Identity.schema)
+      let json = identity->Reventless.Util_Sury.toJson(Reventless.Identity.schema)
+      let decoded = json->Reventless.Util_Sury.fromJson(Reventless.Identity.schema)
       expect(decoded.userId)->toBe("user-3")->ignore
       expect(decoded.provider)->toEqual(Reventless.Identity.InMemory)
     })

package/tests/IdentityTest.res.mjs

@@ -1,11 +1,9 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
-import * as S from "sury/src/S.res.mjs";
 import * as Identity$Reventless from "@reventlessdev/reventless-spec/src/types/Identity.res.mjs";
+import * as Util_Sury$Reventless from "@reventlessdev/reventless-spec/src/util/Util_Sury.res.mjs";
 import * as RequestContext$ReventlessCore from "../src/RequestContext.res.mjs";
 
-S.enableJson();
-
 globalThis.describe("Identity", () => {
   globalThis.describe("anonymous", () => {
     globalThis.test("has userId 'anonymous'", () => {
@@ -86,8 +84,8 @@ globalThis.describe("Identity", () => {
         claims: identity_claims,
         provider: "Cognito"
       };
-      let json = S.reverseConvertToJsonOrThrow(identity, Identity$Reventless.schema);
-      let decoded = S.parseJsonOrThrow(json, Identity$Reventless.schema);
+      let json = Util_Sury$Reventless.toJson(identity, Identity$Reventless.schema);
+      let decoded = Util_Sury$Reventless.fromJson(json, Identity$Reventless.schema);
       globalThis.expect(decoded).toEqual(identity);
     });
     globalThis.test("roundtrip with Custom provider", () => {
@@ -102,8 +100,8 @@ globalThis.describe("Identity", () => {
         groups: identity_groups,
         provider: identity_provider
       };
-      let json = S.reverseConvertToJsonOrThrow(identity, Identity$Reventless.schema);
-      let decoded = S.parseJsonOrThrow(json, Identity$Reventless.schema);
+      let json = Util_Sury$Reventless.toJson(identity, Identity$Reventless.schema);
+      let decoded = Util_Sury$Reventless.fromJson(json, Identity$Reventless.schema);
       globalThis.expect(decoded).toEqual(identity);
     });
     globalThis.test("roundtrip without optional claims", () => {
@@ -114,8 +112,8 @@ globalThis.describe("Identity", () => {
         groups: identity_groups,
         provider: "InMemory"
       };
-      let json = S.reverseConvertToJsonOrThrow(identity, Identity$Reventless.schema);
-      let decoded = S.parseJsonOrThrow(json, Identity$Reventless.schema);
+      let json = Util_Sury$Reventless.toJson(identity, Identity$Reventless.schema);
+      let decoded = Util_Sury$Reventless.fromJson(json, Identity$Reventless.schema);
       globalThis.expect(decoded.userId).toBe("user-3");
       globalThis.expect(decoded.provider).toEqual("InMemory");
     });

package/tests/adapter/MonitoringTest.res

@@ -15,7 +15,7 @@ describe("Monitoring", () => {
   testSync("use registers a backend that receives every notify, role and name", () => {
     let recorded: array<(Monitoring.unitKind, string)> = []
     module Recorder: Monitoring.Backend = {
-      let onProvisioned = (~kind, ~name, ~component as _, ~plugin as _, ~platform as _) =>
+      let onProvisioned = (~kind, ~name, ~component as _, ~plugin as _, ~platform as _, ~logLocator as _) =>
         recorded->Array.push((kind, name))
     }
     Monitoring.use(module(Recorder: Monitoring.Backend))
@@ -39,7 +39,7 @@ describe("Monitoring", () => {
   testSync("notify forwards the static name and component resource to the backend", () => {
     let seen: ref<option<(string, ReventlessInfra.Adapter.resource)>> = ref(None)
     module Capture: Monitoring.Backend = {
-      let onProvisioned = (~kind as _, ~name, ~component, ~plugin as _, ~platform as _) =>
+      let onProvisioned = (~kind as _, ~name, ~component, ~plugin as _, ~platform as _, ~logLocator as _) =>
         seen := Some((name, component))
     }
     Monitoring.use(module(Capture: Monitoring.Backend))
@@ -56,7 +56,7 @@ describe("Monitoring", () => {
   testSync("notify delivers the ambient plugin/platform inside a construct scope, None outside", () => {
     let seen: array<(option<string>, option<string>)> = []
     module OwnerCapture: Monitoring.Backend = {
-      let onProvisioned = (~kind as _, ~name as _, ~component as _, ~plugin, ~platform) =>
+      let onProvisioned = (~kind as _, ~name as _, ~component as _, ~plugin, ~platform, ~logLocator as _) =>
         seen->Array.push((plugin, platform))
     }
     Monitoring.use(module(OwnerCapture: Monitoring.Backend))
@@ -80,4 +80,31 @@ describe("Monitoring", () => {
 
     Monitoring.use(module(Monitoring.Noop))
   })
+
+  // Unlike the owner, the locator is not ambient — the seam only forwards what the provisioning
+  // site passed. A site with nothing to say omits it, and the backend must see that as "this unit
+  // has no logs of its own" rather than receiving a fabricated address.
+  testSync("notify forwards the log locator when given one, None when omitted", () => {
+    // The registry only forwards the locator; it never resolves it. A structural stand-in keeps
+    // @pulumi/pulumi out of the Jest run, exactly as `stubResource` does.
+    let stubLocator: Pulumi.Output.t<string> = %raw(`{}`)
+    let seen: array<bool> = []
+    module LocatorCapture: Monitoring.Backend = {
+      let onProvisioned = (~kind as _, ~name as _, ~component as _, ~plugin as _, ~platform as _, ~logLocator) =>
+        seen->Array.push(logLocator->Option.isSome)
+    }
+    Monitoring.use(module(LocatorCapture: Monitoring.Backend))
+
+    Monitoring.notify(
+      ~kind=CommandHandler,
+      ~name="AllAggregatesCmdHandler",
+      ~component=stubResource,
+      ~logLocator=stubLocator,
+    )
+    Monitoring.notify(~kind=DeadLetterSink, ~name="DeadLetterQueue", ~component=stubResource)
+
+    expect(seen)->toEqual([true, false])
+
+    Monitoring.use(module(Monitoring.Noop))
+  })
 })

package/tests/adapter/MonitoringTest.res.mjs

@@ -1,5 +1,6 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
+import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Monitoring$ReventlessCore from "../../src/adapter/Monitoring/Monitoring.res.mjs";
 import * as ResourceAttribution$ReventlessCore from "../../src/ResourceAttribution.res.mjs";
 
@@ -7,12 +8,12 @@ let stubResource = {};
 
 globalThis.describe("Monitoring", () => {
   globalThis.test("Noop default: notify is silent and does not throw", () => {
-    Monitoring$ReventlessCore.notify("CommandHandler", "before", stubResource);
+    Monitoring$ReventlessCore.notify("CommandHandler", "before", stubResource, undefined);
     globalThis.expect(true).toBe(true);
   });
   globalThis.test("use registers a backend that receives every notify, role and name", () => {
     let recorded = [];
-    let onProvisioned = (kind, name, param, param$1, param$2) => {
+    let onProvisioned = (kind, name, param, param$1, param$2, param$3) => {
       recorded.push([
         kind,
         name
@@ -22,13 +23,13 @@ globalThis.describe("Monitoring", () => {
       onProvisioned: onProvisioned
     };
     Monitoring$ReventlessCore.use(Recorder);
-    Monitoring$ReventlessCore.notify("CommandHandler", "AllAggregatesCmdHandler", stubResource);
-    Monitoring$ReventlessCore.notify("Projection", "AllStateViewSlices", stubResource);
-    Monitoring$ReventlessCore.notify("DeadLetterSink", "DeadLetterQueue", stubResource);
+    Monitoring$ReventlessCore.notify("CommandHandler", "AllAggregatesCmdHandler", stubResource, undefined);
+    Monitoring$ReventlessCore.notify("Projection", "AllStateViewSlices", stubResource, undefined);
+    Monitoring$ReventlessCore.notify("DeadLetterSink", "DeadLetterQueue", stubResource, undefined);
     Monitoring$ReventlessCore.notify({
       TAG: "Other",
       _0: "Counter"
-    }, "ProductCounter", stubResource);
+    }, "ProductCounter", stubResource, undefined);
     globalThis.expect(recorded).toEqual([
       [
         "CommandHandler",
@@ -56,7 +57,7 @@ globalThis.describe("Monitoring", () => {
     let seen = {
       contents: undefined
     };
-    let onProvisioned = (param, name, component, param$1, param$2) => {
+    let onProvisioned = (param, name, component, param$1, param$2, param$3) => {
       seen.contents = [
         name,
         component
@@ -66,7 +67,7 @@ globalThis.describe("Monitoring", () => {
       onProvisioned: onProvisioned
     };
     Monitoring$ReventlessCore.use(Capture);
-    Monitoring$ReventlessCore.notify("Scheduler", "HeartbeatUnit", stubResource);
+    Monitoring$ReventlessCore.notify("Scheduler", "HeartbeatUnit", stubResource, undefined);
     let match = seen.contents;
     if (match !== undefined) {
       globalThis.expect(match[0]).toBe("HeartbeatUnit");
@@ -77,7 +78,7 @@ globalThis.describe("Monitoring", () => {
   });
   globalThis.test("notify delivers the ambient plugin/platform inside a construct scope, None outside", () => {
     let seen = [];
-    let onProvisioned = (param, param$1, param$2, plugin, platform) => {
+    let onProvisioned = (param, param$1, param$2, plugin, platform, param$3) => {
       seen.push([
         plugin,
         platform
@@ -87,11 +88,11 @@ globalThis.describe("Monitoring", () => {
       onProvisioned: onProvisioned
     };
     Monitoring$ReventlessCore.use(OwnerCapture);
-    Monitoring$ReventlessCore.notify("CommandHandler", "ApiRouter", stubResource);
+    Monitoring$ReventlessCore.notify("CommandHandler", "ApiRouter", stubResource, undefined);
     let prev = ResourceAttribution$ReventlessCore.enter("online-shop", "Ordering");
-    Monitoring$ReventlessCore.notify("CommandHandler", "AllAggregatesCmdHandler", stubResource);
+    Monitoring$ReventlessCore.notify("CommandHandler", "AllAggregatesCmdHandler", stubResource, undefined);
     ResourceAttribution$ReventlessCore.restore(prev);
-    Monitoring$ReventlessCore.notify("Projection", "AllStateViewSlices", stubResource);
+    Monitoring$ReventlessCore.notify("Projection", "AllStateViewSlices", stubResource, undefined);
     globalThis.expect(seen).toEqual([
       [
         undefined,
@@ -108,6 +109,24 @@ globalThis.describe("Monitoring", () => {
     ]);
     Monitoring$ReventlessCore.use(Monitoring$ReventlessCore.Noop);
   });
+  globalThis.test("notify forwards the log locator when given one, None when omitted", () => {
+    let stubLocator = {};
+    let seen = [];
+    let onProvisioned = (param, param$1, param$2, param$3, param$4, logLocator) => {
+      seen.push(Stdlib_Option.isSome(logLocator));
+    };
+    let LocatorCapture = {
+      onProvisioned: onProvisioned
+    };
+    Monitoring$ReventlessCore.use(LocatorCapture);
+    Monitoring$ReventlessCore.notify("CommandHandler", "AllAggregatesCmdHandler", stubResource, stubLocator);
+    Monitoring$ReventlessCore.notify("DeadLetterSink", "DeadLetterQueue", stubResource, undefined);
+    globalThis.expect(seen).toEqual([
+      true,
+      false
+    ]);
+    Monitoring$ReventlessCore.use(Monitoring$ReventlessCore.Noop);
+  });
 });
 
 export {

package/tests/adapter/RuntimeExtensionHookReachTest.res

@@ -1,6 +1,5 @@
 open JestGlobals
 
-S.enableJson()
 
 // The point of the seam, end to end at the hook level: an extension that only
 // ever gets `onColdStart` can reach the framework's runtime callback hooks from

package/tests/adapter/RuntimeExtensionHookReachTest.res.mjs

@@ -1,6 +1,6 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
-import * as S from "sury/src/S.res.mjs";
+import * as Sury from "sury";
 import * as Stdlib_JsExn from "@rescript/runtime/lib/es6/Stdlib_JsExn.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Effect from "effect/Effect";
@@ -8,12 +8,10 @@ import * as Primitive_exceptions from "@rescript/runtime/lib/es6/Primitive_excep
 import * as RuntimeExtension$ReventlessCore from "../../src/adapter/RuntimeExtension/RuntimeExtension.res.mjs";
 import * as CommandGenerator_Callback$ReventlessCore from "../../src/components/CommandGenerator/CommandGenerator_Callback.res.mjs";
 
-S.enableJson();
-
-let commandSchema = S.schema(s => ({
+let commandSchema = Sury.$schema(s => ({
   TAG: "Add",
-  productId: s.m(S.string),
-  name: s.m(S.string)
+  productId: s.m(Sury.string),
+  name: s.m(Sury.string)
 }));
 
 let published = {
@@ -94,4 +92,4 @@ export {
   addChair,
   runAdd,
 }
-/*  Not a pure module */
+/* commandSchema Not a pure module */