@reventlessdev/reventless-core 3.0.0-alpha.237 → 3.0.0-alpha.238

package/tests/plugin/PluginStructureTest.res

@@ -144,6 +144,29 @@ module PsReserveStockSlice: ReventlessInfra.StateChangeSlice.T = {
   let make = (~dcbEventLog as _, ~publishJsons as _, ~tagKeysByEventType as _=?, ~crossPartitionTagKeys as _=?, ~runtime as _=?, ~opts as _=?): component => Obj.magic(0)
 }
 
+module PsDispatchShipmentSlice: ReventlessInfra.StateChangeSlice.T = {
+  module Spec = PsDispatchShipment
+  module Behavior = {
+    type state = PsDispatchShipment.state
+    let initialState = PsDispatchShipment.initialState
+    let evolve = PsDispatchShipment.evolve
+    let decide = PsDispatchShipment.decide
+    let moduleUrl = PsDispatchShipment.moduleUrl
+  }
+  let isAsync = false
+  type component = scsComponent
+  let make = (~dcbEventLog as _, ~publishJsons as _, ~tagKeysByEventType as _=?, ~crossPartitionTagKeys as _=?, ~runtime as _=?, ~opts as _=?): component => Obj.magic(0)
+}
+module PsShipmentsViewSlice: ReventlessInfra.StateViewSlice.T = {
+  module Spec = PsShipmentsView
+  module Projection = {
+    let project = PsShipmentsView.project
+    let moduleUrl = PsShipmentsView.moduleUrl
+  }
+  type component = svsComponent
+  let make = (~dcbEventLog as _, ~runtime as _=?, ~opts as _=?): component => Obj.magic(0)
+}
+
 let structure = Plugin_Structure.make(
   ~name="TestPlugin",
   ~stateChangeSlices=[module(PsPlaceOrderSlice), module(PsShipOrderSlice)],
@@ -155,6 +178,132 @@ let structure = Plugin_Structure.make(
   ],
 )
 
+describe("lifecycle topology", () => {
+  let ordersStates = Dict.fromArray([("Orders", ["Placed", "Shipped", "Cancelled"])])
+  let writableWith = (commands): Reventless.Plugin.writableDef => {
+    name: "Ordering",
+    commands,
+    producedEventTypes: [],
+    consumedEventTypes: [],
+    linkedViews: ["Orders"],
+    consistencyRead: None,
+    events: [],
+    errors: [],
+    chapter: None,
+  }
+  let command = (~name, ~allowedStates=?, ~targetState=?, ()): Reventless.Plugin.commandDef => {
+    name,
+    schema: "",
+    level: Instance,
+    aggregateIdField: None,
+    mutationField: "",
+    references: [],
+    allowedStates,
+    targetState,
+    apiExposed: None,
+    requiredAccess: None,
+    ownerField: None,
+  }
+
+  testSync("names a state no command can reach", () => {
+    // `Cancelled` is in the enum and nothing declares an edge into it.
+    let findings = Plugin_Structure.lifecycleTopologyFindings(
+      ~writables=[
+        writableWith([command(~name="Ship", ~allowedStates=["Placed"], ~targetState="Shipped", ())]),
+      ],
+      ~lifecycleStatesByView=ordersStates,
+    )
+    expect(findings->Array.map(((_, m)) => m->String.includes("Cancelled")))->toEqual([true])
+  })
+
+  testSync("says nothing when every state is reachable", () => {
+    let findings = Plugin_Structure.lifecycleTopologyFindings(
+      ~writables=[
+        writableWith([
+          command(~name="Ship", ~allowedStates=["Placed"], ~targetState="Shipped", ()),
+          command(~name="Cancel", ~allowedStates=["Placed"], ~targetState="Cancelled", ()),
+        ]),
+      ],
+      ~lifecycleStatesByView=ordersStates,
+    )
+    expect(findings->Array.length)->toBe(0)
+  })
+
+  // The first declared state is where rows begin, so nothing pointing at it is
+  // expected rather than suspicious.
+  testSync("does not call the initial state unreachable", () => {
+    let findings = Plugin_Structure.lifecycleTopologyFindings(
+      ~writables=[
+        writableWith([
+          command(~name="Ship", ~allowedStates=["Placed"], ~targetState="Shipped", ()),
+          command(~name="Cancel", ~allowedStates=["Placed"], ~targetState="Cancelled", ()),
+        ]),
+      ],
+      ~lifecycleStatesByView=ordersStates,
+    )
+    expect(findings->Array.map(((_, m)) => m->String.includes("Placed")))->toEqual([])
+  })
+
+  // A terminal state is not a finding. `Shipped` and `Refunded` have no way out
+  // in the shipped aggregates example, and both are correct — which is why the
+  // "dead end" rule this pass was going to carry was dropped rather than
+  // silenced. See the comment in Plugin_Structure.
+  testSync("does not report a state with no way out", () => {
+    let findings = Plugin_Structure.lifecycleTopologyFindings(
+      ~writables=[
+        writableWith([
+          command(~name="Ship", ~allowedStates=["Placed"], ~targetState="Shipped", ()),
+          command(~name="Cancel", ~allowedStates=["Placed"], ~targetState="Cancelled", ()),
+        ]),
+      ],
+      ~lifecycleStatesByView=ordersStates,
+    )
+    expect(findings->Array.length)->toBe(0)
+  })
+})
+
+describe("@transition cross-check", () => {
+  // The exit criterion: a state no linked view declares stops the build, and the
+  // message says which command, which state, and what it was checked against.
+  // `DispatchShipment` produces `ShipmentDispatched`, which the `Shipments` view
+  // consumes — so the two are linked, the view's lifecycle is in hand, and
+  // "Dispatchd" has somewhere to be wrong.
+  let buildBad = () =>
+    try {
+      Plugin_Structure.make(
+        ~name="TransitionPlugin",
+        ~stateChangeSlices=[module(PsDispatchShipmentSlice)],
+        ~stateViewSlices=[module(PsShipmentsViewSlice)],
+      )->ignore
+      None
+    } catch {
+    | Exn.Error(e) => Some(Exn.message(e)->Option.getOr(""))
+    | _ => Some("")
+    }
+
+  testSync("a state no linked view declares fails the build", () => {
+    expect(buildBad()->Option.isSome)->toBe(true)
+  })
+
+  testSync("the failure names the command, the state and the view", () => {
+    let message = buildBad()->Option.getOr("")
+    expect((
+      message->String.includes("DispatchShipment"),
+      message->String.includes("Dispatchd"),
+      message->String.includes("Shipments"),
+      message->String.includes("Booked"),
+    ))->toEqual((true, true, true, true))
+  })
+
+  // The other half of the rule: a correctly-spelled edge passes, and a command
+  // whose linked views declare no lifecycle is warned about rather than failed —
+  // `PsShipOrder` is exactly that shape, and the suite's main `structure` above
+  // builds without throwing, which is that path already exercised.
+  testSync("a plugin whose views declare no lifecycle still builds", () => {
+    expect(structure.stateChangeSlices->Array.length)->toBe(2)
+  })
+})
+
 describe("Plugin_Structure.make — Phase 2 graph fields", () => {
   describe("stateChangeSlices", () => {
     testSync("produces two SCS entries in declaration order", () => {
@@ -233,8 +382,8 @@ describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       ))->toEqual((Some(true), Some(false)))
     })
 
-    testSync("ShipOrder: @targetState(\"Shipped\") flows through the PPX to commandDef.targetState", () => {
-      // End-to-end: the reventless-ppx @targetState annotation → markTargetState
+    testSync("ShipOrder: @transition's target flows through the PPX to commandDef.targetState", () => {
+      // End-to-end: the reventless-ppx @transition annotation → markTargetState
       // metadata → ApiTargetStateHelpers.getTargetState → commandDef. The
       // un-annotated CancelShipment carries None (resolver falls back to
       // name-stem).
@@ -246,6 +395,18 @@ describe("Plugin_Structure.make — Phase 2 graph fields", () => {
       ))->toEqual((Some("Shipped"), None))
     })
 
+    testSync("ShipOrder: @transition's from-set flows through to commandDef.allowedStates", () => {
+      // The other half of the same annotation, which the removed pair spelled
+      // separately: one attribute now fills both fields, so a command that
+      // declares a target cannot end up without the states it may run from.
+      let shipOrder = structure.stateChangeSlices->Array.getUnsafe(1)
+      let byName = name => shipOrder.commands->Array.find(c => c.name == name)
+      expect((
+        byName("ShipOrder")->Option.flatMap(c => c.allowedStates),
+        byName("CancelShipment")->Option.flatMap(c => c.allowedStates),
+      ))->toEqual((Some(["Placed"]), None))
+    })
+
     testSync("ShipOrder: the @noApi variant carries no callable mutation field (no sibling leak)", () => {
       // Regression: for a single-exposed-command slice, `mutationFieldFor`
       // resolves every variant — including the @noApi one — to the slice's one
@@ -962,7 +1123,7 @@ describe("Plugin_Structure.make — Phase 2 graph fields", () => {
   // The generator captures each component's chapter (source-folder grouping band)
   // and passes it as ~componentChapters; Plugin_Structure looks it up by Spec.name
   // and threads it onto every def, so a deployed-graph consumer can render chapter
-  // bands without workspace access. See docs/plans/deployed-chapter-grouping.md.
+  // bands without workspace access. See docs/plans/done/deployed-chapter-grouping.md.
   describe("componentChapters threading", () => {
     let chaptered = Plugin_Structure.make(
       ~name="TestPlugin",

package/tests/plugin/PluginStructureTest.res.mjs

@@ -1,6 +1,7 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
 import * as S from "sury/src/S.res.mjs";
+import * as Stdlib_Exn from "@rescript/runtime/lib/es6/Stdlib_Exn.js";
 import * as Stdlib_JSON from "@rescript/runtime/lib/es6/Stdlib_JSON.js";
 import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
 import * as Id$Reventless from "@reventlessdev/reventless-spec/src/types/Id.res.mjs";
@@ -8,6 +9,7 @@ import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Primitive_object from "@rescript/runtime/lib/es6/Primitive_object.js";
 import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
 import * as DateTime$Reventless from "@reventlessdev/reventless-spec/src/types/DateTime.res.mjs";
+import * as Primitive_exceptions from "@rescript/runtime/lib/es6/Primitive_exceptions.js";
 import * as Reference$Reventless from "@reventlessdev/reventless-spec/src/components/Reference.res.mjs";
 import * as StorageRef$Reventless from "@reventlessdev/reventless-spec/src/semantic/StorageRef.res.mjs";
 import * as Api_Naming$ReventlessCore from "../../src/components/Api/Api_Naming.res.mjs";
@@ -22,8 +24,10 @@ import * as PsUploadAvatar$ReventlessCore from "./StateChangeSlice/PsUploadAvata
 import * as PsAnnotatedView$ReventlessCore from "./StateViewSlice/PsAnnotatedView.res.mjs";
 import * as PsAttachInvoice$ReventlessCore from "./StateChangeSlice/PsAttachInvoice.res.mjs";
 import * as PsCustomersView$ReventlessCore from "./StateViewSlice/PsCustomersView.res.mjs";
+import * as PsShipmentsView$ReventlessCore from "./StateViewSlice/PsShipmentsView.res.mjs";
 import * as Plugin_Structure$ReventlessCore from "../../src/plugin/component/Plugin_Structure.res.mjs";
 import * as PsCategoriesView$ReventlessCore from "./StateViewSlice/PsCategoriesView.res.mjs";
+import * as PsDispatchShipment$ReventlessCore from "./StateChangeSlice/PsDispatchShipment.res.mjs";
 import * as Capability_Inference$ReventlessCore from "../../src/plugin/component/Capability_Inference.res.mjs";
 import * as PsAvailableProductsView$ReventlessCore from "./StateViewSlice/PsAvailableProductsView.res.mjs";
 
@@ -337,6 +341,62 @@ let PsReserveStockSlice = {
   make: make$10
 };
 
+let Behavior$6 = {
+  initialState: false,
+  evolve: PsDispatchShipment$ReventlessCore.evolve,
+  decide: PsDispatchShipment$ReventlessCore.decide,
+  moduleUrl: PsDispatchShipment$ReventlessCore.moduleUrl
+};
+
+function make$11(param, param$1, param$2, param$3, param$4, param$5) {
+  return 0;
+}
+
+let PsDispatchShipmentSlice_Spec = {
+  name: PsDispatchShipment$ReventlessCore.name,
+  moduleUrl: PsDispatchShipment$ReventlessCore.moduleUrl,
+  Id: Id$Reventless.$$String,
+  consumedEventSchema: PsDispatchShipment$ReventlessCore.consumedEventSchema,
+  errorSchema: PsDispatchShipment$ReventlessCore.errorSchema,
+  eventSchema: PsDispatchShipment$ReventlessCore.eventSchema,
+  commandSchema: PsDispatchShipment$ReventlessCore.commandSchema,
+  commandAuthorization: PsDispatchShipment$ReventlessCore.commandAuthorization,
+  readConsistency: PsDispatchShipment$ReventlessCore.readConsistency
+};
+
+let PsDispatchShipmentSlice = {
+  Spec: PsDispatchShipmentSlice_Spec,
+  Behavior: Behavior$6,
+  isAsync: false,
+  make: make$11
+};
+
+let Projection$5 = {
+  project: PsShipmentsView$ReventlessCore.project,
+  moduleUrl: PsShipmentsView$ReventlessCore.moduleUrl
+};
+
+function make$12(param, param$1, param$2) {
+  return 0;
+}
+
+let PsShipmentsViewSlice_Spec = {
+  name: PsShipmentsView$ReventlessCore.name,
+  moduleUrl: PsShipmentsView$ReventlessCore.moduleUrl,
+  stateSchema: PsShipmentsView$ReventlessCore.stateSchema,
+  consumedEventSchema: PsShipmentsView$ReventlessCore.consumedEventSchema,
+  config: PsShipmentsView$ReventlessCore.config,
+  subIdConfig: undefined,
+  authorization: PsShipmentsView$ReventlessCore.authorization,
+  visibility: PsShipmentsView$ReventlessCore.visibility
+};
+
+let PsShipmentsViewSlice = {
+  Spec: PsShipmentsViewSlice_Spec,
+  Projection: Projection$5,
+  make: make$12
+};
+
 let structure = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, undefined, [
   PsOrdersViewSlice,
   PsAvailableProductsViewSlice,
@@ -347,6 +407,102 @@ let structure = Plugin_Structure$ReventlessCore.make("TestPlugin", undefined, un
   PsShipOrderSlice
 ], undefined, undefined, undefined, undefined, undefined, undefined);
 
+globalThis.describe("lifecycle topology", () => {
+  let ordersStates = Object.fromEntries([[
+      "Orders",
+      [
+        "Placed",
+        "Shipped",
+        "Cancelled"
+      ]
+    ]]);
+  let writableWith = commands => ({
+    name: "Ordering",
+    commands: commands,
+    producedEventTypes: [],
+    consumedEventTypes: [],
+    linkedViews: ["Orders"],
+    consistencyRead: undefined,
+    events: [],
+    errors: [],
+    chapter: undefined
+  });
+  let command = (name, allowedStates, targetState, param) => ({
+    name: name,
+    schema: "",
+    level: "Instance",
+    aggregateIdField: undefined,
+    mutationField: "",
+    references: [],
+    allowedStates: allowedStates,
+    targetState: targetState,
+    apiExposed: undefined,
+    requiredAccess: undefined,
+    ownerField: undefined
+  });
+  globalThis.test("names a state no command can reach", () => {
+    let findings = Plugin_Structure$ReventlessCore.lifecycleTopologyFindings([writableWith([command("Ship", ["Placed"], "Shipped", undefined)])], ordersStates);
+    globalThis.expect(findings.map(param => param[1].includes("Cancelled"))).toEqual([true]);
+  });
+  globalThis.test("says nothing when every state is reachable", () => {
+    let findings = Plugin_Structure$ReventlessCore.lifecycleTopologyFindings([writableWith([
+        command("Ship", ["Placed"], "Shipped", undefined),
+        command("Cancel", ["Placed"], "Cancelled", undefined)
+      ])], ordersStates);
+    globalThis.expect(findings.length).toBe(0);
+  });
+  globalThis.test("does not call the initial state unreachable", () => {
+    let findings = Plugin_Structure$ReventlessCore.lifecycleTopologyFindings([writableWith([
+        command("Ship", ["Placed"], "Shipped", undefined),
+        command("Cancel", ["Placed"], "Cancelled", undefined)
+      ])], ordersStates);
+    globalThis.expect(findings.map(param => param[1].includes("Placed"))).toEqual([]);
+  });
+  globalThis.test("does not report a state with no way out", () => {
+    let findings = Plugin_Structure$ReventlessCore.lifecycleTopologyFindings([writableWith([
+        command("Ship", ["Placed"], "Shipped", undefined),
+        command("Cancel", ["Placed"], "Cancelled", undefined)
+      ])], ordersStates);
+    globalThis.expect(findings.length).toBe(0);
+  });
+});
+
+globalThis.describe("@transition cross-check", () => {
+  let buildBad = () => {
+    try {
+      Plugin_Structure$ReventlessCore.make("TransitionPlugin", undefined, undefined, [PsShipmentsViewSlice], [PsDispatchShipmentSlice], undefined, undefined, undefined, undefined, undefined, undefined);
+      return;
+    } catch (raw_e) {
+      let e = Primitive_exceptions.internalToException(raw_e);
+      if (e.RE_EXN_ID === Stdlib_Exn.$$Error) {
+        return Stdlib_Option.getOr(e._1.message, "");
+      } else {
+        return "";
+      }
+    }
+  };
+  globalThis.test("a state no linked view declares fails the build", () => {
+    globalThis.expect(Stdlib_Option.isSome(buildBad())).toBe(true);
+  });
+  globalThis.test("the failure names the command, the state and the view", () => {
+    let message = Stdlib_Option.getOr(buildBad(), "");
+    globalThis.expect([
+      message.includes("DispatchShipment"),
+      message.includes("Dispatchd"),
+      message.includes("Shipments"),
+      message.includes("Booked")
+    ]).toEqual([
+      true,
+      true,
+      true,
+      true
+    ]);
+  });
+  globalThis.test("a plugin whose views declare no lifecycle still builds", () => {
+    globalThis.expect(structure.stateChangeSlices.length).toBe(2);
+  });
+});
+
 globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
   globalThis.describe("stateChangeSlices", () => {
     globalThis.test("produces two SCS entries in declaration order", () => {
@@ -424,7 +580,7 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
         false
       ]);
     });
-    globalThis.test("ShipOrder: @targetState(\"Shipped\") flows through the PPX to commandDef.targetState", () => {
+    globalThis.test("ShipOrder: @transition's target flows through the PPX to commandDef.targetState", () => {
       let shipOrder = structure.stateChangeSlices[1];
       let byName = name => shipOrder.commands.find(c => c.name === name);
       globalThis.expect([
@@ -435,6 +591,17 @@ globalThis.describe("Plugin_Structure.make — Phase 2 graph fields", () => {
         undefined
       ]);
     });
+    globalThis.test("ShipOrder: @transition's from-set flows through to commandDef.allowedStates", () => {
+      let shipOrder = structure.stateChangeSlices[1];
+      let byName = name => shipOrder.commands.find(c => c.name === name);
+      globalThis.expect([
+        Stdlib_Option.flatMap(byName("ShipOrder"), c => c.allowedStates),
+        Stdlib_Option.flatMap(byName("CancelShipment"), c => c.allowedStates)
+      ]).toEqual([
+        ["Placed"],
+        undefined
+      ]);
+    });
     globalThis.test("ShipOrder: the @noApi variant carries no callable mutation field (no sibling leak)", () => {
       let shipOrder = structure.stateChangeSlices[1];
       let byName = name => shipOrder.commands.find(c => c.name === name);
@@ -1275,6 +1442,8 @@ export {
   PsUploadAvatarSlice,
   PsChangePhotoSlice,
   PsReserveStockSlice,
+  PsDispatchShipmentSlice,
+  PsShipmentsViewSlice,
   structure,
 }
 /* structure Not a pure module */

package/tests/plugin/StateChangeSlice/PsDispatchShipment.res

@@ -0,0 +1,31 @@
+// Test fixture spec for the @transition cross-check — the failing case.
+//
+// `Dispatchd` is a deliberate typo. It compiles: the PPX strips the attribute
+// before the typechecker sees it, so a misspelled state is a well-formed string
+// all the way down. That is exactly the hole the structure-side check closes,
+// and a fixture that could not compile would not demonstrate it.
+
+@@reventless.spec("DispatchShipment")
+
+type shipmentStatus =
+  | Booked
+  | Dispatched
+
+@schema
+type consumedEvent = ShipmentBooked({shipmentId: string})
+
+let evolve = (_state, _event) => true
+
+type state = bool
+let initialState = false
+
+@schema
+type command = @transition(([Booked]) => Dispatchd) DispatchShipment({shipmentId: string})
+
+@schema
+type error = ShipmentNotFound
+
+@schema
+type event = ShipmentDispatched({shipmentId: string})
+
+let decide = (_state, _command): result<array<event>, error> => Ok([])

package/tests/plugin/StateChangeSlice/PsDispatchShipment.res.mjs

@@ -0,0 +1,73 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as S from "sury/src/S.res.mjs";
+import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
+import * as Api$ReventlessInfra from "@reventlessdev/reventless-infra/src/components/Api.res.mjs";
+
+let consumedEventSchema = S.schema(s => ({
+  TAG: "ShipmentBooked",
+  shipmentId: s.m(DcbTag$Reventless.string)
+}));
+
+function evolve(_state, _event) {
+  return true;
+}
+
+let commandSchema = S.schema(s => ({
+  TAG: "DispatchShipment",
+  shipmentId: s.m(DcbTag$Reventless.string)
+}));
+
+let errorSchema = S.literal("ShipmentNotFound");
+
+let eventSchema = S.schema(s => ({
+  TAG: "ShipmentDispatched",
+  shipmentId: s.m(DcbTag$Reventless.string)
+}));
+
+function decide(_state, _command) {
+  return {
+    TAG: "Ok",
+    _0: []
+  };
+}
+
+let commandSchema$1 = Api$ReventlessInfra.markAllowedStates(commandSchema, [[
+    "DispatchShipment",
+    ["Booked"]
+  ]]);
+
+let commandSchema$2 = Api$ReventlessInfra.markTargetState(commandSchema$1, [[
+    "DispatchShipment",
+    "Dispatchd"
+  ]]);
+
+function commandAuthorization(param) {
+  return "AllowAuthenticated";
+}
+
+let name = "DispatchShipment";
+
+let Id;
+
+let initialState = false;
+
+let moduleUrl = "@reventlessdev/reventless-core/tests/plugin/StateChangeSlice/PsDispatchShipment.res.mjs";
+
+let readConsistency = "EscalateOnRetry";
+
+export {
+  name,
+  Id,
+  consumedEventSchema,
+  evolve,
+  initialState,
+  errorSchema,
+  eventSchema,
+  decide,
+  commandSchema$2 as commandSchema,
+  moduleUrl,
+  commandAuthorization,
+  readConsistency,
+}
+/* consumedEventSchema Not a pure module */

package/tests/plugin/StateChangeSlice/PsShipOrder.res

@@ -18,8 +18,23 @@ let evolve = (_state, _event) => true
 // It is also `@noApi` (internal/admin only): a two-variant slice with exactly
 // one API-exposed command, which is the case that used to leak the exposed
 // command's slice mutation field onto the non-exposed variant.
+// The lifecycle this slice's commands move a shipment through. The PPX strips
+// @transition before the typechecker sees it, so this enum is not what makes the
+// reference below valid — the structure-side check against the linked view is.
+// It is here because a state is a constructor, and naming one in a string is a
+// reference nothing can check at any layer.
+type shipmentStatus = Placed | Shipped | Cancelled
+
+// CancelShipment is payload-less — it compiles to a bare string literal, so it
+// exercises toCommandDef's payload-less branch (still surfaced in `commands`).
+// It is also `@noApi` (internal/admin only): a two-variant slice with exactly
+// one API-exposed command, which is the case that used to leak the exposed
+// command's slice mutation field onto the non-exposed variant. It carries no
+// @transition, which is the un-annotated case the resolver still guesses for.
 @schema
-type command = @targetState("Shipped") ShipOrder({orderId: string}) | @noApi CancelShipment
+type command =
+  | @transition(([Placed]) => Shipped) ShipOrder({orderId: string})
+  | @noApi CancelShipment
 
 // Two variants, one payload-less and one carrying a field — the same two branches
 // `events` exercises, so the structure's `errors` list is pinned on both.

package/tests/plugin/StateChangeSlice/PsShipOrder.res.mjs

@@ -47,7 +47,12 @@ function decide(_state, _command) {
 
 let commandSchema$1 = Api$ReventlessInfra.markNoApiVariants(commandSchema, ["CancelShipment"]);
 
-let commandSchema$2 = Api$ReventlessInfra.markTargetState(commandSchema$1, [[
+let commandSchema$2 = Api$ReventlessInfra.markAllowedStates(commandSchema$1, [[
+    "ShipOrder",
+    ["Placed"]
+  ]]);
+
+let commandSchema$3 = Api$ReventlessInfra.markTargetState(commandSchema$2, [[
     "ShipOrder",
     "Shipped"
   ]]);
@@ -75,7 +80,7 @@ export {
   errorSchema,
   eventSchema,
   decide,
-  commandSchema$2 as commandSchema,
+  commandSchema$3 as commandSchema,
   moduleUrl,
   commandAuthorization,
   readConsistency,

package/tests/plugin/StateViewSlice/PsShipmentsView.res

@@ -0,0 +1,26 @@
+// Test fixture spec for the @transition cross-check.
+// A view that declares a lifecycle, so a command's declared states have
+// something to be checked against. `PsOrdersView` deliberately declares none —
+// the two together cover both the checked and the unvalidated path.
+
+@@reventless.spec("Shipments")
+
+@schema
+type consumedEvent =
+  | ShipmentBooked({shipmentId: string})
+  | ShipmentDispatched({shipmentId: string})
+
+@schema
+type shipmentStatus =
+  | Booked
+  | Dispatched
+
+@schema
+type state = {shipmentId: string, @lifecycle shipmentStatus: shipmentStatus}
+
+let project = ({event}: Reventless.StateViewSlice.consumed<consumedEvent>) =>
+  switch event {
+  | ShipmentBooked({shipmentId}) => [Set(shipmentId, {shipmentId, shipmentStatus: Booked})]
+  | ShipmentDispatched({shipmentId}) =>
+    [Update(shipmentId, s => {...s, shipmentStatus: Dispatched})]
+  }