@reventlessdev/reventless-core 3.0.0-alpha.212 → 3.0.0-alpha.214

package/tests/api/GraphQL_FragmentGeneratorTest.res.mjs

@@ -4,6 +4,7 @@ import * as S from "sury/src/S.res.mjs";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as GraphQL_Stitcher$ReventlessCore from "../../src/components/Api/GraphQL_Stitcher.res.mjs";
 import * as GraphQL_FragmentGenerator$ReventlessCore from "../../src/components/Api/GraphQL_FragmentGenerator.res.mjs";
+import * as OutboundTranslationSlice_Callback$ReventlessCore from "../../src/components/OutboundTranslationSlice/OutboundTranslationSlice_Callback.res.mjs";
 
 let commandSchema = S.union([
   S.schema(s => ({
@@ -50,8 +51,42 @@ globalThis.describe("GraphQL_FragmentGenerator.generate mutation id injection",
   });
 });
 
+let outboundItemSchema = S.schema(s => ({
+  customerId: s.m(S.string),
+  address: s.m(S.string)
+}));
+
+let GeocodeItem = {
+  outboundItemSchema: outboundItemSchema,
+  externalSystem: undefined
+};
+
+function typeDefFor(fragment, needle) {
+  return GraphQL_Stitcher$ReventlessCore.decode(fragment).types.find(t => t.includes(needle));
+}
+
+globalThis.describe("GraphQL_FragmentGenerator slice TODO rows", () => {
+  globalThis.test("item carries the slice's item type, not String", () => {
+    let fragment = GraphQL_FragmentGenerator$ReventlessCore.generate([], [{
+        singleFieldName: "Ordering_GeocodeCustomerAddressTodo",
+        listFieldName: "Ordering_GeocodeCustomerAddressTodos",
+        returnTypeName: "Ordering_GeocodeCustomerAddressTodo",
+        stateSchema: OutboundTranslationSlice_Callback$ReventlessCore.todoRowSchemaFor(outboundItemSchema),
+        authorization: undefined,
+        connectionSpec: true
+      }]);
+    let row = Stdlib_Option.getOr(typeDefFor(fragment, "type Ordering_GeocodeCustomerAddressTodo "), "");
+    globalThis.expect(row.includes("item: Ordering_GeocodeCustomerAddressTodoItem!")).toBe(true);
+    let item = Stdlib_Option.getOr(typeDefFor(fragment, "type Ordering_GeocodeCustomerAddressTodoItem "), "");
+    globalThis.expect(item.includes("customerId: ID!")).toBe(true);
+    globalThis.expect(item.includes("address: String!")).toBe(true);
+  });
+});
+
 export {
   OrderSliceCmd,
   mutationFor,
+  GeocodeItem,
+  typeDefFor,
 }
 /* commandSchema Not a pure module */

package/tests/logger/LogFormatTest.res

@@ -127,6 +127,48 @@ describe("LogFormat", () => {
       },
     )
   })
+
+  // A ReScript record's absent optional field survives encoding as an own
+  // property whose value is `undefined` — the one thing `JSON.t` cannot hold and
+  // `JSON.stringify` answers with `undefined` instead of a string. Rendering a
+  // command carrying one must not reach a string function with that `undefined`:
+  // `variantFields` runs inside the CommandGenerator's log tap, so a throw there
+  // takes the command down with it and the slice never sees it.
+  describe("variantFields", () => {
+    module OptionalFieldCmd = {
+      @schema
+      type command = AddProduct({productId: string, name: string, imageUrl?: string})
+    }
+
+    testSync("omits an absent optional field", () => {
+      let json =
+        OptionalFieldCmd.AddProduct({productId: "prd-1", name: "Cirrus"})
+        ->Message.encode(OptionalFieldCmd.commandSchema)
+      expect(variantFields(json))->toEqual(`, {productId:"prd-1",name:"Cirrus"}`)
+    })
+
+    testSync("keeps a present optional field", () => {
+      let json =
+        OptionalFieldCmd.AddProduct({productId: "prd-1", name: "Cirrus", imageUrl: "/u/a.png"})
+        ->Message.encode(OptionalFieldCmd.commandSchema)
+      expect(variantFields(json))->toEqual(
+        `, {productId:"prd-1",name:"Cirrus",imageUrl:"/u/a.png"}`,
+      )
+    })
+
+    testSync("elides a value past the budget rather than dropping it", () => {
+      let long = String.repeat("x", maxValueChars + 20)
+      let json =
+        OptionalFieldCmd.AddProduct({productId: "prd-1", name: long})
+        ->Message.encode(OptionalFieldCmd.commandSchema)
+      let rendered = variantFields(json)
+      expect(rendered->String.includes("…(+22 chars)"))->toBe(true)
+      // The oversized value is capped, not the line: the neighbouring field that
+      // says which product this is stays intact.
+      expect(rendered->String.includes(long))->toBe(false)
+      expect(rendered->String.includes(`productId:"prd-1"`))->toBe(true)
+    })
+  })
 })
 
 // ─── JSON sink (non-TTY collector: CloudWatch / Datadog / …) ─────────────────

package/tests/logger/LogFormatTest.res.mjs

@@ -124,6 +124,43 @@ globalThis.describe("LogFormat", () => {
       globalThis.expect(msg).toEqual(`\x1b[1mVersionDetected\x1b[0m(testId): {"event":{"TAG":"VersionDetected","_0":"0.0.0"},"meta":{"service":"testService","time":"testTime","ip":"testIp","user":"testUser","msgId":"testMsgId","correlationId":"testCorrelationId"},"id":"testId"}`);
     });
   });
+  globalThis.describe("variantFields", () => {
+    let commandSchema = S.schema(s => ({
+      TAG: "AddProduct",
+      productId: s.m(S.string),
+      name: s.m(S.string),
+      imageUrl: s.m(S.option(S.string))
+    }));
+    globalThis.test("omits an absent optional field", () => {
+      let json = Message$ReventlessCore.encode({
+        TAG: "AddProduct",
+        productId: "prd-1",
+        name: "Cirrus"
+      }, commandSchema);
+      globalThis.expect(LogFormat$ReventlessCore.variantFields(json)).toEqual(`, {productId:"prd-1",name:"Cirrus"}`);
+    });
+    globalThis.test("keeps a present optional field", () => {
+      let json = Message$ReventlessCore.encode({
+        TAG: "AddProduct",
+        productId: "prd-1",
+        name: "Cirrus",
+        imageUrl: "/u/a.png"
+      }, commandSchema);
+      globalThis.expect(LogFormat$ReventlessCore.variantFields(json)).toEqual(`, {productId:"prd-1",name:"Cirrus",imageUrl:"/u/a.png"}`);
+    });
+    globalThis.test("elides a value past the budget rather than dropping it", () => {
+      let long = "x".repeat(LogFormat$ReventlessCore.maxValueChars + 20 | 0);
+      let json = Message$ReventlessCore.encode({
+        TAG: "AddProduct",
+        productId: "prd-1",
+        name: long
+      }, commandSchema);
+      let rendered = LogFormat$ReventlessCore.variantFields(json);
+      globalThis.expect(rendered.includes("…(+22 chars)")).toBe(true);
+      globalThis.expect(rendered.includes(long)).toBe(false);
+      globalThis.expect(rendered.includes(`productId:"prd-1"`)).toBe(true);
+    });
+  });
 });
 
 function hasAnsi(s) {