@reventlessdev/reventless-core 3.0.0-alpha.202 → 3.0.0-alpha.204

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.204 (2026-08-02)
+
+### Bug Fixes
+
+* **core:** store offloaded plugin structure untagged in the read model ([9036991](https://github.com/ReventlessDev/reventless-core/commit/9036991d9fbc7bbb01157fa58be1702ea4ba36d1))
+
+
+# 3.0.0-alpha.203 (2026-08-02)
+
+### Bug Fixes
+
+* **core:** run the offload hook at graph-construction, not inside .apply ([5a102f1](https://github.com/ReventlessDev/reventless-core/commit/5a102f149d6d218cdeeb28dbf9bded1d6fb1252e))
+
+
 # 3.0.0-alpha.202 (2026-08-02)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.202",
+  "version": "3.0.0-alpha.204",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -29,16 +29,16 @@
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
+    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.1",
     "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
-    "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.0",
+    "@reventlessdev/rescript-node": "2.0.0-alpha.1",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
-    "@reventlessdev/rescript-node": "2.0.0-alpha.0",
+    "@reventlessdev/rescript-ssh2": "2.0.0-alpha.1",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.18",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
-    "@reventlessdev/rescript-ssh2": "2.0.0-alpha.0",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.119",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.94",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.30"
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.121",
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.30",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.96"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/plugin/component/Plugin_Builder.res

@@ -606,6 +606,32 @@ module Make = (
       | None => Pulumi.Output.make()
       }
 
+      // Offload the two large pluginDefinition fields at deploy time when a
+      // provider offers an object store (AWS writes a content-addressed object
+      // and returns a reference); unset locally, so they stay Inline. Computed
+      // HERE, at graph-construction time — both values are concrete and the hook
+      // (which creates the object resource) MUST run outside the Pulumi.Output.apply
+      // below: a resource cannot be created inside .apply, and an apply callback is
+      // skipped entirely on `pulumi preview` when its inputs are still unknown.
+      // Unconditional: these fields are always large enough to be worth offloading.
+      let toPayload = (value, ~schema, ~store) =>
+        switch Plugin_Helpers.offloadHook.contents {
+        | Some(hook) =>
+          Reventless.Offload.Offloaded(
+            hook(~store, ~bytes=value->S.reverseConvertToJsonStringOrThrow(schema)),
+          )
+        | None => Reventless.Offload.Inline(value)
+        }
+      let apiSchemaFragmentPayload = toPayload(
+        apiSchemaFragment,
+        ~schema=Reventless.Plugin.apiSchemaFragmentSchema,
+        ~store="pluginApiFragments",
+      )
+      let structurePayload =
+        pluginStructure->Option.map(s =>
+          toPayload(s, ~schema=Reventless.Plugin.pluginStructureSchema, ~store="pluginStructures")
+        )
+
       (
         (interstackAdminExtensionPoints, localAdminResolvedEP, schemaPushed)->Pulumi.Output.all3,
         aggregateResources->Pulumi.Output.allDict,
@@ -738,31 +764,6 @@ module Make = (
         // so reading it inside the async callback would always yield "Domain".
         let capturedDeployTarget = Spec.hooks.deployTarget.contents
 
-        // Offload the two large pluginDefinition fields at deploy time when a
-        // provider offers an object store (AWS writes a content-addressed object
-        // and returns a reference); unset locally, so they stay Inline. Both
-        // values are concrete here, so the hook — and the object write it does —
-        // runs at graph-construction time, before the Pulumi.Output.apply below
-        // (a resource cannot be created inside .apply). Unconditional: these
-        // fields are always large enough to be worth offloading.
-        let toPayload = (value, ~schema, ~store) =>
-          switch Plugin_Helpers.offloadHook.contents {
-          | Some(hook) =>
-            Reventless.Offload.Offloaded(
-              hook(~store, ~bytes=value->S.reverseConvertToJsonStringOrThrow(schema)),
-            )
-          | None => Reventless.Offload.Inline(value)
-          }
-        let apiSchemaFragmentPayload = toPayload(
-          apiSchemaFragment,
-          ~schema=Reventless.Plugin.apiSchemaFragmentSchema,
-          ~store="pluginApiFragments",
-        )
-        let structurePayload =
-          pluginStructure->Option.map(s =>
-            toPayload(s, ~schema=Reventless.Plugin.pluginStructureSchema, ~store="pluginStructures")
-          )
-
         // DCB EventLog definition — Some when this plugin has a DcbEventLog
         // component, None otherwise. Admin's manageSubscriptions reads this to
         // provision cross-plugin SNS subscriptions from peer plugins' DCB

package/src/plugin/component/Plugin_Builder.res.mjs

@@ -421,6 +421,22 @@ function Make(Spec) {
         });
         let pushSchema = Spec.hooks.preResolversSchemaHook;
         let schemaPushed = pushSchema !== undefined ? pushSchema(extra$1, version, apiSchemaFragment) : Pulumi.output();
+        let toPayload = (value, schema, store) => {
+          let hook = Plugin_Helpers$ReventlessCore.offloadHook.contents;
+          if (hook !== undefined) {
+            return {
+              TAG: "Offloaded",
+              _0: hook(store, S.reverseConvertToJsonStringOrThrow(value, schema, undefined))
+            };
+          } else {
+            return {
+              TAG: "Inline",
+              _0: value
+            };
+          }
+        };
+        let apiSchemaFragmentPayload = toPayload(apiSchemaFragment, Plugin$Reventless.apiSchemaFragmentSchema, "pluginApiFragments");
+        let structurePayload = Stdlib_Option.map(pluginStructure, s => toPayload(s, Plugin$Reventless.pluginStructureSchema, "pluginStructures"));
         let builderOutputs = Pulumi.all([
           Pulumi.all([
             interstackAdminExtensionPoints,
@@ -487,22 +503,6 @@ function Make(Spec) {
           let match$3 = EventCollectorHelper.make(childName, eventTopics, opts);
           let eventCollector = match$3[0];
           let capturedDeployTarget = Spec.hooks.deployTarget.contents;
-          let toPayload = (value, schema, store) => {
-            let hook = Plugin_Helpers$ReventlessCore.offloadHook.contents;
-            if (hook !== undefined) {
-              return {
-                TAG: "Offloaded",
-                _0: hook(store, S.reverseConvertToJsonStringOrThrow(value, schema, undefined))
-              };
-            } else {
-              return {
-                TAG: "Inline",
-                _0: value
-              };
-            }
-          };
-          let apiSchemaFragmentPayload = toPayload(apiSchemaFragment, Plugin$Reventless.apiSchemaFragmentSchema, "pluginApiFragments");
-          let structurePayload = Stdlib_Option.map(pluginStructure, s => toPayload(s, Plugin$Reventless.pluginStructureSchema, "pluginStructures"));
           let dcbOutputs$1 = dcbResult.dcbEventLogOutputs;
           let dcbEventLogDef;
           if (dcbOutputs$1 !== undefined) {

package/src/plugin/lifecycle/PluginsProjection.res

@@ -54,8 +54,17 @@ let displayState = (
     extensions: def.extensions,
     status,
     statusChange,
-    apiSchemaFragment: def.apiSchemaFragment,
-    structure: def.structure,
+    // Store the offloadable fields as their untagged wire JSON (bare value, or an
+    // `{$offload: {...}}` reference), not the `Offload.payload` variant: the QueryDb
+    // write path marshals the raw ReScript value, so a variant would land in DynamoDB
+    // as `{TAG, _0}`. The ComponentDefinitions Lambda then reads structure back and
+    // resolves the sentinel.
+    apiSchemaFragment: def.apiSchemaFragment->Option.map(
+      Reventless.Offload.toJson(Reventless.Plugin.apiSchemaFragmentSchema, _),
+    ),
+    structure: def.structure->Option.map(
+      Reventless.Offload.toJson(Reventless.Plugin.pluginStructureSchema, _),
+    ),
     dcbEventLog: def.dcbEventLog,
     // A freshly projected row always knows its kind (the definition carries it as a
     // mandatory field). `option` here is purely for rows persisted before `kind`

package/src/plugin/lifecycle/PluginsProjection.res.mjs

@@ -3,6 +3,8 @@
 import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
 import * as Id$Reventless from "@reventlessdev/reventless-spec/src/types/Id.res.mjs";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
+import * as Plugin$Reventless from "@reventlessdev/reventless-spec/src/components/Plugin.res.mjs";
+import * as Offload$Reventless from "@reventlessdev/reventless-spec/src/semantic/Offload.res.mjs";
 import * as Plugin$ReventlessCore from "../component/Plugin.res.mjs";
 import * as Projection$Reventless from "@reventlessdev/reventless-spec/src/types/Projection.res.mjs";
 import * as PluginSpec$ReventlessCore from "./PluginSpec.res.mjs";
@@ -70,8 +72,8 @@ function displayState(def, status, statusChange, otherConnectedVersions) {
   let base_extensionPointNames = def.extensionPoints.map(extensionPoint => extensionPoint.name);
   let base_extensionNames = def.extensions.map(extension => extension.extensionPointName);
   let base_extensions = def.extensions;
-  let base_apiSchemaFragment = def.apiSchemaFragment;
-  let base_structure = def.structure;
+  let base_apiSchemaFragment = Stdlib_Option.map(def.apiSchemaFragment, __x => Offload$Reventless.toJson(Plugin$Reventless.apiSchemaFragmentSchema, __x));
+  let base_structure = Stdlib_Option.map(def.structure, __x => Offload$Reventless.toJson(Plugin$Reventless.pluginStructureSchema, __x));
   let base_dcbEventLog = def.dcbEventLog;
   let base_kind = def.kind;
   let base_otherConnectedVersions = without(otherConnectedVersions, def.version);

package/src/plugin/lifecycle/PluginsReadModelSpec.res

@@ -24,15 +24,22 @@ type state = {
   extensions: array<Reventless.Plugin.extensionDefinition>,
   status: status,
   statusChange: Message.statusChange,
-  apiSchemaFragment: @s.matches(Reventless.Plugin.apiSchemaFragmentOffloadSchema)
-    option<Reventless.Offload.payload<Reventless.Plugin.apiSchemaFragment>>,
+  // Stored as the **untagged** offload wire JSON (a bare fragment, or an
+  // `{$offload: {...}}` reference) — NOT the `Offload.payload` variant. The QueryDb
+  // write path marshals the raw ReScript value straight to DynamoDB without
+  // sury-encoding through this field's schema, so a variant would persist as its
+  // runtime `{TAG, _0}` shape and no reader could parse it. UI-excluded
+  // (PluginBaseFragment.pluginUIOnlyExcludeFields), so JSON.t typing costs no
+  // GraphQL consumer. PluginsProjection.displayState writes it via Offload.toJson.
+  apiSchemaFragment: option<JSON.t>,
   // API target for split-API schema routing. Absent/None means "Domain" (backward compat).
   // "Platform" → excluded from DomainApi runtime schema stitching in updateApiSchema.
   apiTarget?: string,
   // Plugin structure (component metadata) — surfaced via Platform_ComponentDefinitions.
-  // None for older plugins whose protocol version did not carry the field.
-  structure: @s.matches(Reventless.Plugin.pluginStructureOffloadSchema)
-    option<Reventless.Offload.payload<Reventless.Plugin.pluginStructure>>,
+  // None for older plugins whose protocol version did not carry the field. Same
+  // untagged-JSON storage as apiSchemaFragment above; the ComponentDefinitions
+  // Lambda detects the `$offload` sentinel and resolves it from S3.
+  structure: option<JSON.t>,
   // DCB EventLog definition for plugins that bundle a DcbEventLog component.
   // Admin's manageSubscriptions uses this to wire cross-plugin SNS subscriptions
   // from this plugin's DCB topic → peer EventCollectors (and vice-versa). None
@@ -74,9 +81,9 @@ type queryResult = {
   extensionNames: array<string>,
   extensions: array<Reventless.Plugin.extensionDefinition>,
   status: status,
-  apiSchemaFragment: option<Reventless.Offload.payload<Reventless.Plugin.apiSchemaFragment>>,
+  apiSchemaFragment: option<JSON.t>,
   apiTarget?: string,
-  structure: option<Reventless.Offload.payload<Reventless.Plugin.pluginStructure>>,
+  structure: option<JSON.t>,
   dcbEventLog: option<Reventless.Plugin.dcbEventLogDefinition>,
   kind: option<Reventless.Plugin.pluginKind>,
 }

package/src/plugin/lifecycle/PluginsReadModelSpec.res.mjs

@@ -23,9 +23,9 @@ let stateSchema = S.schema(s => ({
   extensions: s.m(S.array(Plugin$Reventless.extensionDefinitionSchema)),
   status: s.m(statusSchema),
   statusChange: s.m(Message$ReventlessCore.statusChangeSchema),
-  apiSchemaFragment: s.m(Plugin$Reventless.apiSchemaFragmentOffloadSchema),
+  apiSchemaFragment: s.m(S.option(S.json)),
   apiTarget: s.m(S.option(S.string)),
-  structure: s.m(Plugin$Reventless.pluginStructureOffloadSchema),
+  structure: s.m(S.option(S.json)),
   dcbEventLog: s.m(Plugin$Reventless.dcbEventLogOptionSchema),
   kind: s.m(S.option(Plugin$Reventless.pluginKindSchema)),
   otherConnectedVersions: s.m(S.array(Plugin$Reventless.versionSchema))