@reventlessdev/reventless-core 3.0.0-alpha.196 → 3.0.0-alpha.198

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.198 (2026-08-01)
+
+### Bug Fixes
+
+* **core:** drain the inbound audit log per request, not wholesale ([e18d4ec](https://github.com/ReventlessDev/reventless-core/commit/e18d4ec4b7ffb38a9e2bd3594d39a07e2ee91851))
+
+
+# 3.0.0-alpha.197 (2026-08-01)
+
+### Features
+
+* **spec:** add DateRange semantic type ([d85b6cc](https://github.com/ReventlessDev/reventless-core/commit/d85b6cc18241644905241df2abd99949dd758059))
+
+
 # 3.0.0-alpha.196 (2026-07-31)
 
 * feat(rescript)!: one Node bindings package, not two ([1258d8c](https://github.com/ReventlessDev/reventless-core/commit/1258d8c2b2ff2636b36a849fc5bdf9005c6fb0eb))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.196",
+  "version": "3.0.0-alpha.198",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -28,17 +28,17 @@
   "dependencies": {
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
-    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
-    "@reventlessdev/rescript-node": "2.0.0-alpha.0",
-    "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
+    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.14",
     "@reventlessdev/rescript-fast-csv": "2.0.0-alpha.0",
-    "@reventlessdev/rescript-ssh2": "2.0.0-alpha.0",
+    "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
+    "@reventlessdev/rescript-node": "2.0.0-alpha.0",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.18",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.114",
+    "@reventlessdev/rescript-ssh2": "2.0.0-alpha.0",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.89",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.30"
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.30",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.115",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.90"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/components/InboundTranslationSlice/InboundTranslationSlice_Builder.res

@@ -41,18 +41,19 @@ module Make = (
 
     module SpecificQueryDb = QueryDb_Builder.Make(AuditQueryDbSpec, QueryDbStorage, QueryDbResolvers)
 
-    let syncToQueryDb = async (queryDbOps: SpecificQueryDb.operations) => {
-      let items = Callback.auditLog->Dict.toArray
-      let _ = await items->Array.reduce(Promise.resolve(), async (prev, (id, row)) => {
-        let _ = await prev
+    // Persist just this request's audit row, taking it out of the in-memory log
+    // as it goes — see `takeAuditRow` for why draining the whole dict is wrong.
+    let syncToQueryDb = async (queryDbOps: SpecificQueryDb.operations, requestId: string) =>
+      switch Callback.auditLog->InboundTranslationSlice_Callback.takeAuditRow(requestId) {
+      | Some(row) =>
         let _ = await queryDbOps.save(
-          id->Reventless.Id.String.makeFromString,
+          requestId->Reventless.Id.String.makeFromString,
           row,
           QueryDb.Overwrite,
           None,
         )
-      })
-    }
+      | None => ()
+      }
 
     let construct = (~publishJsons, self, _name) => {
       let opts = {Pulumi.ComponentResource.parent: self->Component.toPulumiResource}
@@ -77,7 +78,10 @@ module Make = (
           let ops: InboundTranslationSlice.operations = {
             receive: async inputJson => {
               let result = await Callback.receive(publishJsonsFn, inputJson)
-              await syncToQueryDb(queryDbOps)
+              await syncToQueryDb(
+                queryDbOps,
+                result->InboundTranslationSlice_Callback.requestIdOf,
+              )
               result
             },
           }

package/src/components/InboundTranslationSlice/InboundTranslationSlice_Builder.res.mjs

@@ -1,6 +1,5 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
-import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
 import * as Id$Reventless from "@reventlessdev/reventless-spec/src/types/Id.res.mjs";
 import * as Pulumi from "@pulumi/pulumi";
 import * as ReadModel$Reventless from "@reventlessdev/reventless-spec/src/components/ReadModel.res.mjs";
@@ -27,12 +26,12 @@ function Make(QueryDbStorage) {
         authorization: "AllowAuthenticated",
         visibility: "Public"
       })(QueryDbStorage)(QueryDbResolvers);
-      let syncToQueryDb = async queryDbOps => {
-        let items = Object.entries(Callback.auditLog);
-        await Stdlib_Array.reduce(items, Promise.resolve(), async (prev, param) => {
-          await prev;
-          await queryDbOps.save(Id$Reventless.$$String.makeFromString(param[0]), param[1], "Overwrite", undefined);
-        });
+      let syncToQueryDb = async (queryDbOps, requestId) => {
+        let row = InboundTranslationSlice_Callback$ReventlessCore.takeAuditRow(Callback.auditLog, requestId);
+        if (row !== undefined) {
+          await queryDbOps.save(Id$Reventless.$$String.makeFromString(requestId), row, "Overwrite", undefined);
+          return;
+        }
       };
       let make = (publishJsons, param, opts) => Component$ReventlessCore.make(ComponentType$ReventlessCore.toString(InboundTranslationSlice$ReventlessCore.componentType), Spec.name, (extra, extra$1) => {
         let opts_parent = Component$ReventlessCore.toPulumiResource(extra);
@@ -58,7 +57,7 @@ function Make(QueryDbStorage) {
           return {
             receive: async inputJson => {
               let result = await Callback.receive(publishJsonsFn, inputJson);
-              await syncToQueryDb(queryDbOps);
+              await syncToQueryDb(queryDbOps, InboundTranslationSlice_Callback$ReventlessCore.requestIdOf(result));
               return result;
             }
           };

package/src/components/InboundTranslationSlice/InboundTranslationSlice_Callback.res

@@ -46,6 +46,33 @@ let receiveResultToOutcome = (
     Rejected({msgId: requestId, errorCode: "TranslationFailed", errorDetail: Some(error)})
   }
 
+/**
+The request a `receive` outcome belongs to, from either arm. Both carry the id
+that keys the outcome's audit row, so a caller draining the log does not have to
+match on the result to find its own row.
+*/
+let requestIdOf = (result: ReventlessInfra.InboundTranslationSlice.receiveResult): string =>
+  switch result {
+  | Ok({requestId}) | Error({requestId}) => requestId
+  }
+
+/**
+Remove one request's audit row from the in-memory log and hand it back.
+
+`auditLog` is a hand-off buffer between `receive` and whoever persists the row,
+not a log in its own right — the QueryDb it drains into is the durable one. It
+has to be emptied as it drains: the dict lives as long as the process (a warm
+Lambda container serves many requests), so a drain that walked the whole dict
+would rewrite every row the container had ever seen on every request — quadratic
+writes, unbounded retention, and, because the write is an overwrite by row id,
+resurrection of rows deleted from the table since.
+*/
+let takeAuditRow = (auditLog: Dict.t<auditRow>, requestId: string): option<auditRow> => {
+  let row = auditLog->Dict.get(requestId)
+  auditLog->Dict.delete(requestId)
+  row
+}
+
 module type T = {
   module Spec: Reventless.InboundTranslationSlice.Spec
   module Translation: Reventless.InboundTranslationSlice.Translation with module Spec := Spec

package/src/components/InboundTranslationSlice/InboundTranslationSlice_Callback.res.mjs

@@ -2,6 +2,7 @@
 
 import * as S from "sury/src/S.res.mjs";
 import * as Uuid from "uuid";
+import * as Stdlib_Dict from "@rescript/runtime/lib/es6/Stdlib_Dict.js";
 import * as Stdlib_JsExn from "@rescript/runtime/lib/es6/Stdlib_JsExn.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Effect from "effect/Effect";
@@ -55,6 +56,16 @@ function receiveResultToOutcome(result) {
   };
 }
 
+function requestIdOf(result) {
+  return result._0.requestId;
+}
+
+function takeAuditRow(auditLog, requestId) {
+  let row = auditLog[requestId];
+  Stdlib_Dict.$$delete(auditLog, requestId);
+  return row;
+}
+
 function Make(Spec) {
   return Translation => {
     let auditLog = {};
@@ -221,6 +232,8 @@ export {
   auditStatusSchema,
   auditRowSchema,
   receiveResultToOutcome,
+  requestIdOf,
+  takeAuditRow,
   Make,
 }
 /*  Not a pure module */

package/tests/api/SuryToJsonSchemaTest.res

@@ -742,4 +742,56 @@ describe("SuryToJsonSchema:", () => {
       ))->toEqual((true, true, true, false))
     })
   })
+
+  // The second composite, and the one whose emission the reader's shape rung
+  // depends on. Like `Money` it turns the field into an object — same
+  // shape-changed evidence, same upcaster warning for a collapse. Unlike it, the
+  // two parts keep their own `dateTime` marker, so a walker that only understands
+  // date-times still sees into the composite. That last property is asserted, not
+  // described, because it is what lets the UI's primary rung key on the shape
+  // before the `dateRange` marker reaches it in a release.
+  describe("DateRange is an object whose parts stay date-times:", () => {
+    let json = SuryToJsonSchema.deriveObjectSchema(
+      S.schema(s =>
+        {
+          "deliveryWindow": s.matches(Reventless.DateRange.schema),
+          "orderedAt": s.matches(Reventless.DateTime.string),
+        }
+      )->S.castToUnknown,
+    )
+    let keyOf = (name, key) => getPropertyOf(json, name)->Option.flatMap(s => getProperty(s, key))
+
+    testSync("the field is an object, not a string", () =>
+      expect(keyOf("deliveryWindow", "type"))->toEqual(Some(JSON.Encode.string("object")))
+    )
+
+    testSync("it carries the dateRange id, sourced from the type", () =>
+      expect((
+        keyOf("deliveryWindow", "x-reventless-semantic"),
+        keyOf("deliveryWindow", "x-reventless-semantic-source"),
+      ))->toEqual((Some(JSON.Encode.string("dateRange")), Some(JSON.Encode.string("type"))))
+    )
+
+    // The property that is not incidental: each part keeps its own date-time
+    // marker under the composite. `dateTime` predates the generic marker and
+    // surfaces as `format: "date-time"` (not `x-reventless-semantic`), so that is
+    // what a walker reads to see the two instants without knowing about ranges.
+    testSync("both instants keep their own date-time marker", () => {
+      let inner = getPropertyOf(json, "deliveryWindow")->Option.getOr(JSON.Encode.null)
+      expect((
+        getPropertyOf(inner, "start")->Option.flatMap(s => getProperty(s, "format")),
+        getPropertyOf(inner, "end")->Option.flatMap(s => getProperty(s, "format")),
+      ))->toEqual((Some(JSON.Encode.string("date-time")), Some(JSON.Encode.string("date-time"))))
+    })
+
+    // The control, mirroring the `Money` block's plain-float case: a lone
+    // date-time field stays a string and never becomes an object, so the
+    // object-ness above is the composite's doing and not the walk's.
+    testSync("a lone date-time field stays a string", () =>
+      expect((keyOf("orderedAt", "type"), keyOf("orderedAt", "format")))->toEqual((
+        Some(JSON.Encode.string("string")),
+        Some(JSON.Encode.string("date-time")),
+      ))
+    )
+  })
 })

package/tests/api/SuryToJsonSchemaTest.res.mjs

@@ -11,6 +11,7 @@ import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/component
 import * as Percent$Reventless from "@reventlessdev/reventless-spec/src/semantic/Percent.res.mjs";
 import * as Currency$Reventless from "@reventlessdev/reventless-spec/src/semantic/Currency.res.mjs";
 import * as DateTime$Reventless from "@reventlessdev/reventless-spec/src/types/DateTime.res.mjs";
+import * as DateRange$Reventless from "@reventlessdev/reventless-spec/src/semantic/DateRange.res.mjs";
 import * as Reference$Reventless from "@reventlessdev/reventless-spec/src/components/Reference.res.mjs";
 import * as StorageRef$Reventless from "@reventlessdev/reventless-spec/src/semantic/StorageRef.res.mjs";
 import * as StateAnnotations$Reventless from "@reventlessdev/reventless-spec/src/components/StateAnnotations.res.mjs";
@@ -1035,6 +1036,44 @@ globalThis.describe("SuryToJsonSchema:", () => {
       ]);
     });
   });
+  globalThis.describe("DateRange is an object whose parts stay date-times:", () => {
+    let json = SuryToJsonSchema$ReventlessCore.deriveObjectSchema(S.schema(s => ({
+      deliveryWindow: s.m(DateRange$Reventless.schema),
+      orderedAt: s.m(DateTime$Reventless.string)
+    })));
+    let keyOf = (name, key) => Stdlib_Option.flatMap(getPropertyOf(json, name), s => getProperty(s, key));
+    globalThis.test("the field is an object, not a string", () => {
+      globalThis.expect(keyOf("deliveryWindow", "type")).toEqual("object");
+    });
+    globalThis.test("it carries the dateRange id, sourced from the type", () => {
+      globalThis.expect([
+        keyOf("deliveryWindow", "x-reventless-semantic"),
+        keyOf("deliveryWindow", "x-reventless-semantic-source")
+      ]).toEqual([
+        "dateRange",
+        "type"
+      ]);
+    });
+    globalThis.test("both instants keep their own date-time marker", () => {
+      let inner = Stdlib_Option.getOr(getPropertyOf(json, "deliveryWindow"), null);
+      globalThis.expect([
+        Stdlib_Option.flatMap(getPropertyOf(inner, "start"), s => getProperty(s, "format")),
+        Stdlib_Option.flatMap(getPropertyOf(inner, "end"), s => getProperty(s, "format"))
+      ]).toEqual([
+        "date-time",
+        "date-time"
+      ]);
+    });
+    globalThis.test("a lone date-time field stays a string", () => {
+      globalThis.expect([
+        keyOf("orderedAt", "type"),
+        keyOf("orderedAt", "format")
+      ]).toEqual([
+        "string",
+        "date-time"
+      ]);
+    });
+  });
 });
 
 export {