@reventlessdev/reventless-core 3.0.0-alpha.177 → 3.0.0-alpha.178

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.178 (2026-07-22)
+
+### Bug Fixes
+
+* **core:** derive the disconnect schedule's rule name in one place ([6324a5b](https://github.com/ReventlessDev/reventless-core/commit/6324a5bc678a375688ec98571423f164b09375ae))
+
+
 # 3.0.0-alpha.177 (2026-07-22)
 
 * refactor!: retire the stale "Admin" vocabulary for platform-owned resources ([2770bd9](https://github.com/ReventlessDev/reventless-core/commit/2770bd96f309142bdfc65b9f36bd1a3ef60641bd))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-core",
-  "version": "3.0.0-alpha.177",
+  "version": "3.0.0-alpha.178",
   "description": "Core package for Reventless framework",
   "license": "Apache-2.0",
   "jest": {
@@ -29,16 +29,16 @@
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.30",
-    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.13",
     "@reventlessdev/rescript-fast-csv": "1.2.0-alpha.14",
-    "@reventlessdev/rescript-node-streams": "1.1.0-alpha.13",
+    "@reventlessdev/rescript-hash-object": "1.2.0-alpha.13",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.9",
-    "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.17",
+    "@reventlessdev/rescript-node-streams": "1.1.0-alpha.13",
     "@reventlessdev/rescript-ssh2": "1.1.0-alpha.14",
+    "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.17",
     "@reventlessdev/rescript-uuid": "1.1.0-alpha.17",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.80",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.29",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.104"
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.104",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.80"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/plugin/connect/PluginExtensionPoint_Plugin.res

@@ -29,6 +29,13 @@ module type Spec = {
 }
 
 module Make = (Spec: Spec) => {
+  // Single owner of the disconnect schedule's rule name. Create and delete must
+  // derive it identically — they previously did not (create prefixed the stack,
+  // delete did not), so every delete targeted a name that was never created and
+  // the rule survived. The stack prefix itself is load-bearing: several stacks
+  // share one EventBridge bus, and an unprefixed plugin id would collide.
+  let disconnectScheduleName = id => Spec.environment ++ ("-" ++ id)
+
   let forwardCommand = async (
     _id,
     command,
@@ -104,7 +111,7 @@ module Make = (Spec: Spec) => {
     switch directive {
     | PluginExtensionPointSpec.CreateDisconnectSchedule(id, timeout) =>
       await createSchedule({
-        name: Spec.environment ++ ("-" ++ id),
+        name: id->disconnectScheduleName,
         rate: timeout->ScheduleOps.minutesFromNow,
         payload: {
           Message.id,
@@ -114,7 +121,7 @@ module Make = (Spec: Spec) => {
         ->Message.encodeCommand'(S.string, PluginExtensionPointSpec.commandSchema)
         ->JSON.stringify,
       })
-    | DeleteDisconnectSchedule(id) => await deleteSchedule(id)
+    | DeleteDisconnectSchedule(id) => await deleteSchedule(id->disconnectScheduleName)
     | ForwardCommand({id, command, extensionPointName}) =>
       await forwardCommand(id, command, extensionPointName, queryEngine)
     | DoConnectPlugin(pluginDef) =>

package/src/plugin/connect/PluginExtensionPoint_Plugin.res.mjs

@@ -23,6 +23,7 @@ function disconnectGrace(interval) {
 }
 
 function Make(Spec) {
+  let disconnectScheduleName = id => Spec.environment + ("-" + id);
   let forwardCommand = async (_id, command, extensionPointName, queryEngine) => {
     let jsons = await queryEngine.scan(PluginSpec$ReventlessCore.name, [
       [
@@ -81,7 +82,7 @@ function Make(Spec) {
       case "CreateDisconnectSchedule" :
         let id = directive._0;
         return await createSchedule({
-          name: Spec.environment + ("-" + id),
+          name: disconnectScheduleName(id),
           rate: ScheduleOps$ReventlessCore.minutesFromNow(directive._1),
           payload: JSON.stringify(Message$ReventlessCore.encodeCommand$p({
             id: id,
@@ -90,7 +91,7 @@ function Make(Spec) {
           }, S.string, PluginExtensionPointSpec$ReventlessInfra.commandSchema))
         });
       case "DeleteDisconnectSchedule" :
-        return await deleteSchedule(directive._0);
+        return await deleteSchedule(disconnectScheduleName(directive._0));
       case "DoConnectPlugin" :
         let fn = Spec.manageSubscriptions;
         if (fn !== undefined) {
@@ -355,6 +356,7 @@ function Make(Spec) {
     mapOutgoingEvent: mapOutgoingEvent
   });
   return {
+    disconnectScheduleName: disconnectScheduleName,
     forwardCommand: forwardCommand,
     directiveHandler: directiveHandler,
     PluginMapping: PluginMapping,

package/tests/extensionpoint/PluginDisconnectScheduleTest.res

@@ -0,0 +1,66 @@
+// Guards the disconnect schedule's rule name. Create and delete must derive it
+// identically: they previously did not — create prefixed `Spec.environment`,
+// delete did not — so every delete targeted a rule that had never been created
+// and the real rule survived. The leak is invisible at runtime, because the
+// delete reports success against a name AWS simply doesn't have.
+
+open JestGlobals
+
+let created: ref<array<string>> = ref([])
+let deleted: ref<array<string>> = ref([])
+
+module DisconnectSpec = {
+  let runtimeOps: PluginRuntimeOperations.operations = {
+    messagePublish: {
+      sendMessageToChannel: async (~channelId as _, ~messageBody as _) => (),
+    },
+  }
+  let environment = "teststack"
+  let updateApiSchema = None
+  let manageSubscriptions = None
+}
+
+module EP = PluginExtensionPoint_Plugin.Make(DisconnectSpec)
+
+let createSchedule: Reventless.Schedule.create = async schedule => {
+  created := created.contents->Array.concat([schedule.name])
+}
+
+let deleteSchedule: Reventless.Schedule.delete = async name => {
+  deleted := deleted.contents->Array.concat([name])
+}
+
+let queryEngine: Reventless.QueryEngine.operations = {
+  scan: async (~readModelName as _, ~filterConfigs as _, ~limit as _) => [],
+  query: async (
+    ~readModelName as _,
+    ~key as _=?,
+    ~id as _,
+    ~subIdConfig as _=?,
+    ~filterConfigs as _=?,
+    ~ascending as _=?,
+    ~limit as _=?,
+  ) => [],
+}
+
+let pluginId = "Catalog_1.0.0-alpha.169"
+
+let handle = directive => EP.directiveHandler(createSchedule, deleteSchedule, queryEngine, directive)
+
+describe("plugin disconnect schedule", () => {
+  test("create and delete address the same rule name", async () => {
+    created := []
+    deleted := []
+    await handle(ReventlessInfra.PluginExtensionPointSpec.CreateDisconnectSchedule(pluginId, 5))
+    await handle(DeleteDisconnectSchedule(pluginId))
+    expect(deleted.contents)->toEqual(created.contents)
+  })
+
+  test("the rule name is namespaced by stack", async () => {
+    created := []
+    await handle(ReventlessInfra.PluginExtensionPointSpec.CreateDisconnectSchedule(pluginId, 5))
+    // Several stacks share one EventBridge bus, so a bare plugin id would
+    // collide across them.
+    expect(created.contents)->toEqual(["teststack-" ++ pluginId])
+  })
+})