@reventlessdev/reventless-aws 3.0.0-alpha.392 → 3.0.0-alpha.393

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.393 (2026-10-21)
+
+### Bug Fixes
+
+* **aws:** a failed AppSync schema push names the API and AWS's message ([01f662a](https://github.com/ReventlessDev/reventless-core/commit/01f662a7c664807808c15933f6234b6b6588addd))
+
+
 # 3.0.0-alpha.392 (2026-10-21)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.392",
+  "version": "3.0.0-alpha.393",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "bin": {
@@ -23,18 +23,18 @@
     "uuid": "^13.0.0",
     "yaml": "^2.8.3",
     "@reventlessdev/rescript-aws-sdk": "3.0.0-alpha.33",
-    "@reventlessdev/rescript-effect": "1.0.0-alpha.1",
+    "@reventlessdev/rescript-jest": "1.0.0-alpha.13",
     "@reventlessdev/rescript-node": "2.0.0-alpha.23",
+    "@reventlessdev/rescript-effect": "1.0.0-alpha.1",
     "@reventlessdev/rescript-pulumi-aws": "3.0.0-alpha.31",
-    "@reventlessdev/rescript-jest": "1.0.0-alpha.13",
-    "@reventlessdev/rescript-uuid": "2.0.0-alpha.1",
     "@reventlessdev/rescript-pulumi-pulumi": "3.0.0-alpha.0",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.303",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.200",
+    "@reventlessdev/rescript-uuid": "2.0.0-alpha.1",
     "@reventlessdev/rescript-web": "1.0.0-alpha.8",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.201",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.168",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.42",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.167",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.172"
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.173",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.304"
   },
   "devDependencies": {
     "rescript": "12.3.1",

package/src/components/Api/AppSync_Adapter.res

@@ -45,6 +45,15 @@ let startSchemaCreation = (client: appSyncClient, input: startSchemaCreationInpu
 // jittered exponential backoff so a losing call can wait for the in-progress
 // schema to finish and try again. Permanent errors (e.g. invalid SDL) are not
 // retried — see AppSync_Error.classify.
+// What the deploy reports when the push gives up. Carries AWS's own message: the classified
+// error is a variant, which a rejected promise prints as `[object Object]`.
+let schemaPushFailure = (~apiId: string, err: AppSync_Error.t): string =>
+  switch err {
+  | Transient(msg) =>
+    `StartSchemaCreation for AppSync API ${apiId} still failed after its retries: ${msg}`
+  | Permanent(msg) => `StartSchemaCreation for AppSync API ${apiId} failed: ${msg}`
+  }
+
 let startSchemaCreationRetrying = (client: appSyncClient, input: startSchemaCreationInput): promise<
   unit,
 > => {
@@ -52,6 +61,7 @@ let startSchemaCreationRetrying = (client: appSyncClient, input: startSchemaCrea
     startSchemaCreation(client, input)->Promise.then(_ => Promise.resolve())
   )
   ->Effect.retry(AppSync_Error.retrySchedule)
+  ->Effect.catchAll(err => Effect.fail(schemaPushFailure(~apiId=input.apiId, err)))
   ->Effect.runPromise
 }
 

package/src/components/Api/AppSync_Adapter.res.mjs

@@ -33,8 +33,16 @@ function startSchemaCreation(client, input) {
   return client.send(new ClientAppsync.StartSchemaCreationCommand(input));
 }
 
+function schemaPushFailure(apiId, err) {
+  if (err.TAG === "Transient") {
+    return `StartSchemaCreation for AppSync API ` + apiId + ` still failed after its retries: ` + err._0;
+  } else {
+    return `StartSchemaCreation for AppSync API ` + apiId + ` failed: ` + err._0;
+  }
+}
+
 function startSchemaCreationRetrying(client, input) {
-  return Effect$1.runPromise(Effect$1.retry(Effect.tryPromise(AppSync_Error$ReventlessAws.classify, () => client.send(new ClientAppsync.StartSchemaCreationCommand(input)).then(param => Promise.resolve())), AppSync_Error$ReventlessAws.retrySchedule));
+  return Effect$1.runPromise(Effect$1.catchAll(Effect$1.retry(Effect.tryPromise(AppSync_Error$ReventlessAws.classify, () => client.send(new ClientAppsync.StartSchemaCreationCommand(input)).then(param => Promise.resolve())), AppSync_Error$ReventlessAws.retrySchedule), err => Effect$1.fail(schemaPushFailure(input.apiId, err))));
 }
 
 async function waitForSchemaActive(client, apiId, maxAttemptsOpt, attemptOpt) {
@@ -326,6 +334,7 @@ export {
   log,
   sha256Hex,
   startSchemaCreation,
+  schemaPushFailure,
   startSchemaCreationRetrying,
   waitForSchemaActive,
   _client,

package/tests/AppSync_AdapterTest.res

@@ -1080,3 +1080,36 @@ describe("AppSync_Adapter.injectAwsAuth — subscriptions", () => {
     expect(decodeFragment(aug).subscriptions->Array.length)->toBe(2)
   })
 })
+
+// ── A failed schema push says why ────────────────────────────────────────────
+
+describe("AppSync_Adapter.startSchemaCreationRetrying", () => {
+  // A client whose every call rejects the way the SDK does, with an Error.
+  let rejectingClient: string => AppSync_Adapter.appSyncClient = %raw(`
+    message => ({send: () => Promise.reject(new Error(message))})
+  `)
+
+  test("fails with the API and AWS's message, not [object Object]", async () => {
+    let message = ref("")
+    try {
+      await AppSync_Adapter.startSchemaCreationRetrying(
+        rejectingClient("BadRequestException: Failed to parse schema document"),
+        {apiId: "api-1", definition: "type Query"},
+      )
+    } catch {
+    | exn => message := exn->JsExn.fromException->Option.flatMap(JsExn.message)->Option.getOr("")
+    }
+    expect(message.contents)->toContain("api-1")
+    expect(message.contents)->toContain("Failed to parse schema document")
+    expect(message.contents)->not_->toContain("[object Object]")
+  })
+
+  testSync("says when the retries ran out", () =>
+    expect(
+      AppSync_Adapter.schemaPushFailure(
+        ~apiId="api-1",
+        Transient("ConcurrentModificationException: Schema is currently being altered"),
+      ),
+    )->toContain("still failed after its retries")
+  )
+})

package/tests/AppSync_AdapterTest.res.mjs

@@ -953,6 +953,31 @@ globalThis.describe("AppSync_Adapter.injectAwsAuth — subscriptions", () => {
   });
 });
 
+globalThis.describe("AppSync_Adapter.startSchemaCreationRetrying", () => {
+  let rejectingClient = (message => ({send: () => Promise.reject(new Error(message))}));
+  globalThis.test("fails with the API and AWS's message, not [object Object]", async () => {
+    let message = "";
+    try {
+      await AppSync_Adapter$ReventlessAws.startSchemaCreationRetrying(rejectingClient("BadRequestException: Failed to parse schema document"), {
+        apiId: "api-1",
+        definition: "type Query"
+      });
+    } catch (raw_exn) {
+      let exn = Primitive_exceptions.internalToException(raw_exn);
+      message = Stdlib_Option.getOr(Stdlib_Option.flatMap(Stdlib_JsExn.fromException(exn), Stdlib_JsExn.message), "");
+    }
+    globalThis.expect(message).toContain("api-1");
+    globalThis.expect(message).toContain("Failed to parse schema document");
+    globalThis.expect(message).not.toContain("[object Object]");
+  });
+  globalThis.test("says when the retries ran out", () => {
+    globalThis.expect(AppSync_Adapter$ReventlessAws.schemaPushFailure("api-1", {
+      TAG: "Transient",
+      _0: "ConcurrentModificationException: Schema is currently being altered"
+    })).toContain("still failed after its retries");
+  });
+});
+
 export {
   decodeFragment,
   TwoRuleFeed,