@reventlessdev/reventless-aws 3.0.0-alpha.372 → 3.0.0-alpha.374

package/CHANGELOG.md

@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.374 (2026-10-06)
+
+**Note:** Version bump only for package @reventlessdev/reventless-aws
+
+
+
+
+
+# 3.0.0-alpha.373 (2026-10-05)
+
+### Bug Fixes
+
+* **deploy:** the bake waits for a review's plugins, and never follows a cancelled deploy ([84bdfbd](https://github.com/ReventlessDev/reventless-core/commit/84bdfbd13a892ceb9741a573e7928328e45f9d79))
+
+
 # 3.0.0-alpha.372 (2026-10-05)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.372",
+  "version": "3.0.0-alpha.374",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "bin": {
@@ -22,19 +22,19 @@
     "sury": "11.0.0",
     "uuid": "^13.0.0",
     "yaml": "^2.8.3",
-    "@reventlessdev/rescript-aws-sdk": "3.0.0-alpha.28",
+    "@reventlessdev/rescript-aws-sdk": "3.0.0-alpha.29",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.11",
-    "@reventlessdev/rescript-node": "2.0.0-alpha.20",
+    "@reventlessdev/rescript-node": "2.0.0-alpha.21",
+    "@reventlessdev/rescript-pulumi-aws": "3.0.0-alpha.24",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.34",
-    "@reventlessdev/rescript-pulumi-aws": "3.0.0-alpha.23",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.23",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.1",
     "@reventlessdev/rescript-web": "1.0.0-alpha.7",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.287",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.185",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.151",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.288",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.186",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.158",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.39",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.157"
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.152"
   },
   "devDependencies": {
     "rescript": "12.3.1",

package/scripts/BakeManifest.res

@@ -27,21 +27,23 @@ type args = {
   manifest: option<string>,
   stack: option<string>,
   since: option<string>,
+  review: bool,
   help: bool,
 }
 
 let parseArgs = (argv: array<string>): result<args, string> =>
-  Reventless.CliArgs.parse(~strings=["manifest", "stack", "since"], argv)
+  Reventless.CliArgs.parse(~strings=["manifest", "stack", "since"], ~bools=["review"], argv)
   ->Result.flatMap(Reventless.CliArgs.noPositionals)
   ->Result.map(a => {
     manifest: a->Reventless.CliArgs.string("manifest"),
     stack: a->Reventless.CliArgs.string("stack"),
     since: a->Reventless.CliArgs.string("since")->Option.flatMap(v => v == "" ? None : Some(v)),
+    review: a->Reventless.CliArgs.bool("review"),
     help: a->Reventless.CliArgs.help,
   })
 
 let usage = `
-Usage: bake-manifest [--manifest <path>] [--stack <name>] [--since <instant>]
+Usage: bake-manifest [--manifest <path>] [--stack <name>] [--since <instant>] [--review]
 
 Bake the component manifest of a deployed platform.
 
@@ -51,6 +53,9 @@ Bake the component manifest of a deployed platform.
                       platform's folder.
   --since <instant>   When this deploy started (ISO 8601). Lets the report tell a
                       plugin that re-registered from one that was unchanged.
+  --review            The stack is a pull request's review environment. Its stacks'
+                      settings are not in this checkout, so every plugin with a
+                      review stack is waited for, not only those with a file here.
 
 Reads the bake function from the platform stack and each plugin's structure key
 from its stack, then asks the function to bake — again every
@@ -61,6 +66,17 @@ waiting, so that stops the run at once.
 
 // ── What the stacks say ──────────────────────────────────────────────────────
 
+/** The plugins whose registration the bake waits for. A stack with no settings
+    file here was never deployed, except in a review environment, whose settings
+    exist only in the runner that created it: there it is every plugin with a
+    review stack. */
+let pluginsToRead = (
+  plugins: array<DeployManifest.project>,
+  ~stack: string,
+  ~review: bool,
+  ~hasStackFile: (~dir: string, ~stack: string) => bool,
+) => plugins->Array.filter(p => review ? p.review : hasStackFile(~dir=p.dir, ~stack))
+
 type target = {functionName: string, bucket: string, key: string}
 
 /** `None` when the platform declares no bake. */
@@ -278,7 +294,12 @@ let invokeWith = (client: Lambda.client, ~functionName: string, ~payload: JSON.t
     | exception exn => Error(`could not invoke ${functionName}: ${Util_AwsError.describe(exn)}`)
     }
 
-let bake = async (~manifest: DeployManifest.resolved, ~stack: string, ~since: option<string>) =>
+let bake = async (
+  ~manifest: DeployManifest.resolved,
+  ~stack: string,
+  ~since: option<string>,
+  ~review: bool,
+) =>
   switch PulumiCli.stackOutputs(~dir=manifest.platform.dir, ~stack) {
   | Error(_) as e => e
   | Ok(outputs) =>
@@ -288,12 +309,12 @@ let bake = async (~manifest: DeployManifest.resolved, ~stack: string, ~since: op
       Ok()
     | Some(target) =>
       let refs = []
-      manifest.plugins->Array.forEach(p =>
-        if PulumiCli.hasStackFile(~dir=p.dir, ~stack) {
-          switch PulumiCli.stackOutputs(~dir=p.dir, ~stack) {
-          | Ok(o) => o->structureRefOf->Option.forEach(r => refs->Array.push(r))
-          | Error(message) => Console.error(`${p.name}: ${message} — not waited for`)
-          }
+      manifest.plugins
+      ->pluginsToRead(~stack, ~review, ~hasStackFile=PulumiCli.hasStackFile)
+      ->Array.forEach(p =>
+        switch PulumiCli.stackOutputs(~dir=p.dir, ~stack) {
+        | Ok(o) => o->structureRefOf->Option.forEach(r => refs->Array.push(r))
+        | Error(message) => Console.error(`${p.name}: ${message} — not waited for`)
         }
       )
       let expect = refs->Dict.fromArray
@@ -352,7 +373,7 @@ let run = async (args: args): result<unit, string> =>
   | Ok(manifest) =>
     switch args.stack->Option.orElse(PulumiCli.selectedStack(~dir=manifest.platform.dir)) {
     | None => Error(`no stack selected in ${manifest.platform.dir} — pass --stack`)
-    | Some(stack) => await bake(~manifest, ~stack, ~since=args.since)
+    | Some(stack) => await bake(~manifest, ~stack, ~since=args.since, ~review=args.review)
     }
   }
 

package/scripts/BakeManifest.res.mjs

@@ -19,7 +19,7 @@ function parseArgs(argv) {
     "manifest",
     "stack",
     "since"
-  ], undefined, undefined, undefined, argv), CliArgs$Reventless.noPositionals), a => ({
+  ], ["review"], undefined, undefined, argv), CliArgs$Reventless.noPositionals), a => ({
     manifest: CliArgs$Reventless.string(a, "manifest"),
     stack: CliArgs$Reventless.string(a, "stack"),
     since: Stdlib_Option.flatMap(CliArgs$Reventless.string(a, "since"), v => {
@@ -29,12 +29,13 @@ function parseArgs(argv) {
         return v;
       }
     }),
+    review: CliArgs$Reventless.bool(a, "review"),
     help: CliArgs$Reventless.help(a)
   }));
 }
 
 let usage = `
-Usage: bake-manifest [--manifest <path>] [--stack <name>] [--since <instant>]
+Usage: bake-manifest [--manifest <path>] [--stack <name>] [--since <instant>] [--review]
 
 Bake the component manifest of a deployed platform.
 
@@ -44,6 +45,9 @@ Bake the component manifest of a deployed platform.
                       platform's folder.
   --since <instant>   When this deploy started (ISO 8601). Lets the report tell a
                       plugin that re-registered from one that was unchanged.
+  --review            The stack is a pull request's review environment. Its stacks'
+                      settings are not in this checkout, so every plugin with a
+                      review stack is waited for, not only those with a file here.
 
 Reads the bake function from the platform stack and each plugin's structure key
 from its stack, then asks the function to bake — again every
@@ -52,6 +56,16 @@ not arrived. A registration this deploy wrote with another key cannot arrive by
 waiting, so that stops the run at once.
 `;
 
+function pluginsToRead(plugins, stack, review, hasStackFile) {
+  return plugins.filter(p => {
+    if (review) {
+      return p.review;
+    } else {
+      return hasStackFile(p.dir, stack);
+    }
+  });
+}
+
 function targetOf(outputs) {
   let match = PulumiCli$ReventlessAws.stringOutput(outputs, "bakedManifestFunction");
   let match$1 = PulumiCli$ReventlessAws.stringOutput(outputs, "bakedManifestBucket");
@@ -269,7 +283,7 @@ function invokeWith(client, functionName, payload) {
   };
 }
 
-async function bake(manifest, stack, since) {
+async function bake(manifest, stack, since, review) {
   let e = PulumiCli$ReventlessAws.stackOutputs(manifest.platform.dir, stack);
   if (e.TAG !== "Ok") {
     return e;
@@ -277,10 +291,7 @@ async function bake(manifest, stack, since) {
   let target = targetOf(e._0);
   if (target !== undefined) {
     let refs = [];
-    manifest.plugins.forEach(p => {
-      if (!PulumiCli$ReventlessAws.hasStackFile(p.dir, stack)) {
-        return;
-      }
+    pluginsToRead(manifest.plugins, stack, review, PulumiCli$ReventlessAws.hasStackFile).forEach(p => {
       let o = PulumiCli$ReventlessAws.stackOutputs(p.dir, stack);
       if (o.TAG === "Ok") {
         return Stdlib_Option.forEach(structureRefOf(o._0), r => {
@@ -336,7 +347,7 @@ async function run(args) {
   let manifest = e._0;
   let stack = Stdlib_Option.orElse(args.stack, PulumiCli$ReventlessAws.selectedStack(manifest.platform.dir));
   if (stack !== undefined) {
-    return await bake(manifest, stack, args.since);
+    return await bake(manifest, stack, args.since, args.review);
   } else {
     return {
       TAG: "Error",
@@ -381,6 +392,7 @@ export {
   Lambda,
   parseArgs,
   usage,
+  pluginsToRead,
   targetOf,
   structureRefOf,
   payload,

package/scripts/DeployApp.res

@@ -570,7 +570,12 @@ let up = async (~manifest: DeployManifest.resolved, ~stack: string): result<unit
               | Error(_) as e => e
               | Ok() =>
                 Console.log("\n── Baking the component manifest ──\n")
-                switch await BakeManifest.bake(~manifest, ~stack, ~since=Some(startedAt)) {
+                switch await BakeManifest.bake(
+                  ~manifest,
+                  ~stack,
+                  ~since=Some(startedAt),
+                  ~review=false,
+                ) {
                 | Error(_) as e => e
                 | Ok() =>
                   let accounts = switch (

package/scripts/DeployApp.res.mjs

@@ -718,7 +718,7 @@ async function up(manifest, stack) {
     return e$4;
   }
   console.log("\n── Baking the component manifest ──\n");
-  let e$5 = await BakeManifest$ReventlessAws.bake(manifest, stack, startedAt);
+  let e$5 = await BakeManifest$ReventlessAws.bake(manifest, stack, startedAt, false);
   if (e$5.TAG !== "Ok") {
     return e$5;
   }

package/scripts/DeployManifest.res

@@ -38,7 +38,14 @@ type t = {
 }
 
 /** One stack folder, with its path made absolute. */
-type project = {name: string, dir: string, stackDefaults: dict<string>, region: option<string>}
+type project = {
+  name: string,
+  dir: string,
+  stackDefaults: dict<string>,
+  region: option<string>,
+  /** Whether a review environment deploys it: false only on a plugin marked so. */
+  review: bool,
+}
 
 type resolved = {
   file: string,
@@ -65,6 +72,7 @@ let resolve = (manifest: t, ~file: string): resolved => {
       dir: NodePath.resolve([base, manifest.platform.path]),
       stackDefaults: manifest.platform.stackDefaults->Option.getOr(Dict.make()),
       region: None,
+      review: true,
     },
     plugins: manifest.plugins
     ->Option.getOr([])
@@ -73,6 +81,7 @@ let resolve = (manifest: t, ~file: string): resolved => {
       dir: NodePath.resolve([base, p.path]),
       stackDefaults: p.stackDefaults->Option.getOr(Dict.make()),
       region: p.region,
+      review: p.review->Option.getOr(true),
     }),
   }
 }

package/scripts/DeployManifest.res.mjs

@@ -60,13 +60,15 @@ function resolve(manifest, file) {
       name: Stdlib_Option.getOr(manifest.platform.name, "platform"),
       dir: Nodepath.resolve(base, manifest.platform.path),
       stackDefaults: Stdlib_Option.getOr(manifest.platform["stack-defaults"], {}),
-      region: undefined
+      region: undefined,
+      review: true
     },
     plugins: Stdlib_Option.getOr(manifest.plugins, []).map(p => ({
       name: p.name,
       dir: Nodepath.resolve(base, p.path),
       stackDefaults: Stdlib_Option.getOr(p["stack-defaults"], {}),
-      region: p.region
+      region: p.region,
+      review: Stdlib_Option.getOr(p.review, true)
     }))
   };
 }

package/tests/BakeManifestTest.res

@@ -39,6 +39,7 @@ plugins:
           dir: "/repo/shop/platform-aws",
           stackDefaults: Dict.fromArray([("platform:messagingEmailProvider", "log")]),
           region: None,
+          review: true,
         },
         plugins: [
           {
@@ -46,12 +47,14 @@ plugins:
             dir: "/repo/shop/catalog-aws",
             stackDefaults: Dict.make(),
             region: None,
+            review: true,
           },
           {
             name: "ordering",
             dir: "/repo/shop/ordering-aws",
             stackDefaults: Dict.make(),
             region: Some("eu-central-1"),
+            review: false,
           },
         ],
       }),
@@ -79,6 +82,7 @@ describe("BakeManifest.parseArgs", () => {
         Bake.manifest: Some("m.yaml"),
         stack: Some("alpha"),
         since: Some("2026-09-16T10:00:00Z"),
+        review: false,
         help: false,
       }),
     )
@@ -89,11 +93,44 @@ describe("BakeManifest.parseArgs", () => {
     expect(Bake.parseArgs(["--since", ""])->Result.map(a => a.since))->toEqual(Ok(None))
   )
 
+  testSync("--review says the stack is a review environment", () =>
+    expect(
+      Bake.parseArgs(["--stack", "review-pr-7", "--review"])->Result.map(a => a.review),
+    )->toEqual(Ok(true))
+  )
+
   testSync("an unknown flag refuses", () =>
     expect(Bake.parseArgs(["--stak", "alpha"]))->toEqual(Error(`unknown argument "--stak"`))
   )
 })
 
+describe("BakeManifest.pluginsToRead", () => {
+  let plugin = (name, ~review) => {
+    DeployManifest.name,
+    dir: `/repo/shop/${name}-aws`,
+    stackDefaults: Dict.make(),
+    region: None,
+    review,
+  }
+  let plugins = [plugin("catalog", ~review=true), plugin("ingest", ~review=false)]
+  let names = ps => ps->Array.map((p: DeployManifest.project) => p.name)
+
+  testSync("outside a review, the plugins whose stack has a settings file here", () => {
+    let hasStackFile = (~dir, ~stack as _) => dir == "/repo/shop/ingest-aws"
+    expect(
+      plugins->Bake.pluginsToRead(~stack="alpha", ~review=false, ~hasStackFile)->names,
+    )->toEqual(["ingest"])
+  })
+
+  // A review stack's settings exist only in the runner that created it.
+  testSync("in a review, every plugin with a review stack, files or not", () => {
+    let hasStackFile = (~dir as _, ~stack as _) => false
+    expect(
+      plugins->Bake.pluginsToRead(~stack="review-pr-7", ~review=true, ~hasStackFile)->names,
+    )->toEqual(["catalog"])
+  })
+})
+
 describe("BakeManifest reads the stacks", () => {
   testSync("a platform without a bake function declares no bake", () =>
     expect(

package/tests/BakeManifestTest.res.mjs

@@ -40,20 +40,23 @@ plugins:
               "platform:messagingEmailProvider",
               "log"
             ]]),
-          region: undefined
+          region: undefined,
+          review: true
         },
         plugins: [
           {
             name: "catalog",
             dir: "/repo/shop/catalog-aws",
             stackDefaults: {},
-            region: undefined
+            region: undefined,
+            review: true
           },
           {
             name: "ordering",
             dir: "/repo/shop/ordering-aws",
             stackDefaults: {},
-            region: "eu-central-1"
+            region: "eu-central-1",
+            review: false
           }
         ]
       }
@@ -79,6 +82,7 @@ globalThis.describe("BakeManifest.parseArgs", () => {
         manifest: "m.yaml",
         stack: "alpha",
         since: "2026-09-16T10:00:00Z",
+        review: false,
         help: false
       }
     });
@@ -92,6 +96,16 @@ globalThis.describe("BakeManifest.parseArgs", () => {
       _0: undefined
     });
   });
+  globalThis.test("--review says the stack is a review environment", () => {
+    globalThis.expect(Stdlib_Result.map(BakeManifest$ReventlessAws.parseArgs([
+      "--stack",
+      "review-pr-7",
+      "--review"
+    ]), a => a.review)).toEqual({
+      TAG: "Ok",
+      _0: true
+    });
+  });
   globalThis.test("an unknown flag refuses", () => {
     globalThis.expect(BakeManifest$ReventlessAws.parseArgs([
       "--stak",
@@ -103,6 +117,30 @@ globalThis.describe("BakeManifest.parseArgs", () => {
   });
 });
 
+globalThis.describe("BakeManifest.pluginsToRead", () => {
+  let plugin = (name, review) => ({
+    name: name,
+    dir: `/repo/shop/` + name + `-aws`,
+    stackDefaults: {},
+    region: undefined,
+    review: review
+  });
+  let plugins = [
+    plugin("catalog", true),
+    plugin("ingest", false)
+  ];
+  globalThis.test("outside a review, the plugins whose stack has a settings file here", () => {
+    let hasStackFile = (dir, param) => dir === "/repo/shop/ingest-aws";
+    let ps = BakeManifest$ReventlessAws.pluginsToRead(plugins, "alpha", false, hasStackFile);
+    globalThis.expect(ps.map(p => p.name)).toEqual(["ingest"]);
+  });
+  globalThis.test("in a review, every plugin with a review stack, files or not", () => {
+    let hasStackFile = (param, param$1) => false;
+    let ps = BakeManifest$ReventlessAws.pluginsToRead(plugins, "review-pr-7", true, hasStackFile);
+    globalThis.expect(ps.map(p => p.name)).toEqual(["catalog"]);
+  });
+});
+
 globalThis.describe("BakeManifest reads the stacks", () => {
   globalThis.test("a platform without a bake function declares no bake", () => {
     globalThis.expect(BakeManifest$ReventlessAws.targetOf(Stdlib_Option.getOr(Stdlib_JSON.Decode.object(JSON.parse(`{"bakedManifestBucket": "b", "bakedManifestFunction": ""}`)), {}))).toEqual(undefined);