@reventlessdev/reventless-aws 3.0.0-alpha.311 → 3.0.0-alpha.312

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.312 (2026-08-19)
+
+### Bug Fixes
+
+* **aws:** build the platform's definition asset from the shared value ([c0e432d](https://github.com/ReventlessDev/reventless-core/commit/c0e432d98d96af3ff4c305b62f658ae102c5d142))
+
+
 # 3.0.0-alpha.311 (2026-08-19)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.311",
+  "version": "3.0.0-alpha.312",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -13,17 +13,17 @@
     "sury": "11.0.0-rc.1",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-aws-sdk": "3.0.0-alpha.12",
-    "@reventlessdev/rescript-node": "2.0.0-alpha.8",
+    "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
+    "@reventlessdev/rescript-node": "2.0.0-alpha.8",
     "@reventlessdev/rescript-pulumi-aws": "3.0.0-alpha.1",
-    "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.19",
     "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.240",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.32",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.241",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.146",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.105",
     "@reventlessdev/reventless-spec": "3.0.0-alpha.118",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.104",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.146"
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.32"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/adapter/Runtime/EventCollectorEntryPoint_Ops.res

@@ -683,8 +683,12 @@ let loadPluginDefinition = (): Reventless.Plugin.pluginDefinition =>
     ->Reventless.Util_Sury.fromJsonString(Reventless.Plugin.pluginDefinitionSchema)
   } catch {
   | exn =>
+    // Util_Sury.exnMessage, not the local one: sury raises S.Exn, which is not a
+    // JsExn, so the local reader yields "unknown error" and loses the field path —
+    // the whole diagnosis for a decode failure here.
     JsError.throwWithMessage(
-      "Failed to load pluginDefinition.json from asset zip: " ++ exnMessage(exn),
+      "Failed to load pluginDefinition.json from asset zip: " ++
+      Reventless.Util_Sury.exnMessage(exn),
     )
   }
 

package/src/adapter/Runtime/EventCollectorEntryPoint_Ops.res.mjs

@@ -524,7 +524,7 @@ function loadPluginDefinition() {
     return Util_Sury$Reventless.fromJsonString(Nodefs.readFileSync(assetPath("pluginDefinition.json"), "utf8"), Plugin$Reventless.pluginDefinitionSchema);
   } catch (raw_exn) {
     let exn = Primitive_exceptions.internalToException(raw_exn);
-    return Stdlib_JsError.throwWithMessage("Failed to load pluginDefinition.json from asset zip: " + exnMessage(exn));
+    return Stdlib_JsError.throwWithMessage("Failed to load pluginDefinition.json from asset zip: " + Util_Sury$Reventless.exnMessage(exn, undefined));
   }
 }
 

package/src/plugin/runtime/PluginRuntime_Builder.res

@@ -268,12 +268,13 @@ module Make = (
   // keeps the JSON shape consistent so the entry point can parse uniformly.
   let synthesizeAdminContext = (): ReventlessCore.Plugin_Helpers.eventCollectorContext => {
     let config = configRef.contents
-    // Stable JSON literal — matches Reventless.Plugin.pluginDefinitionSchema
-    // (optional fields encoded as null via js_nullable). Must stay byte-aligned with
-    // the ReScript-built twin in `Platform_Admin.construct`'s `fakePluginDefinition`.
-    let platformId = ReventlessCore.Platform_Admin_Structure.pluginId
+    // Encoded from the one placeholder value, through the same schema the entry
+    // point decodes with. It was a hand-written JSON literal, which drifted: the
+    // schema gained `dcbEventLog` and `kind` and the literal did not follow.
     let fakePluginDefinitionJson =
-      `{"id":"${platformId}@INTERNAL","name":"${platformId}","version":"INTERNAL","extensionPoints":[],"extensions":[],"eventCollector":"NOT-SET","extensionProtocols":[],"apiSchemaFragment":null,"apiTarget":null,"structure":null}`->Pulumi.Output.make
+      ReventlessCore.Platform_Admin_Structure.internalPluginDefinition
+      ->Reventless.Util_Sury.toJsonString(Reventless.Plugin.pluginDefinitionSchema)
+      ->Pulumi.Output.make
     let adminEpEventTopicArn = switch config.eventTopicArn {
     | Some(arn) => arn
     | None => Pulumi.Output.make("NOT_AVAILABLE")

package/src/plugin/runtime/PluginRuntime_Builder.res.mjs

@@ -5,6 +5,8 @@ import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Pulumi from "@pulumi/pulumi";
 import * as Primitive_string from "@rescript/runtime/lib/es6/Primitive_string.js";
+import * as Plugin$Reventless from "@reventlessdev/reventless-spec/src/components/Plugin.res.mjs";
+import * as Util_Sury$Reventless from "@reventlessdev/reventless-spec/src/util/Util_Sury.res.mjs";
 import * as Logger$ReventlessCore from "@reventlessdev/reventless-core/src/util/Logger.res.mjs";
 import * as Component$ReventlessCore from "@reventlessdev/reventless-core/src/components/Component.res.mjs";
 import * as DcbBackend$ReventlessAws from "../../adapter/DcbEventLog/DcbBackend.res.mjs";
@@ -202,7 +204,7 @@ function Make(EventCollectorChannel) {
   };
   let synthesizeAdminContext = () => {
     let config = configRef.contents;
-    let fakePluginDefinitionJson = Pulumi.output(`{"id":"` + Platform_Admin_Structure$ReventlessCore.pluginId + `@INTERNAL","name":"` + Platform_Admin_Structure$ReventlessCore.pluginId + `","version":"INTERNAL","extensionPoints":[],"extensions":[],"eventCollector":"NOT-SET","extensionProtocols":[],"apiSchemaFragment":null,"apiTarget":null,"structure":null}`);
+    let fakePluginDefinitionJson = Pulumi.output(Util_Sury$Reventless.toJsonString(Platform_Admin_Structure$ReventlessCore.internalPluginDefinition, Plugin$Reventless.pluginDefinitionSchema, undefined));
     let arn = config.eventTopicArn;
     let adminEpEventTopicArn = arn !== undefined ? arn : Pulumi.output("NOT_AVAILABLE");
     return {

package/tests/EventCollectorPluginDefinitionAssetTest.res

@@ -101,4 +101,15 @@ describe("pluginDefinition.json write/read symmetry", () => {
     expect(def.structure->Option.isNone)->toBe(true)
     expect(def.dcbEventLog->Option.isNone)->toBe(true)
   })
+
+  // The platform's own EventCollector ships a placeholder rather than a real
+  // definition — the admin IS the Plugin extension point — but it is read back on
+  // this same path, so it has to satisfy the same schema. Its asset used to be a
+  // hand-written JSON literal in PluginRuntime_Builder and fell two fields behind
+  // (dcbEventLog, kind) with nothing to notice.
+  testSync("the platform's own placeholder asset survives the same round trip", () => {
+    let def = ReventlessCore.Platform_Admin_Structure.internalPluginDefinition->writeAsset->readAsset
+    expect(def.id)->toBe(ReventlessCore.Platform_Admin_Structure.pluginId ++ "@INTERNAL")
+    expect(def.kind)->toBe(Reventless.Plugin.Domain)
+  })
 })

package/tests/EventCollectorPluginDefinitionAssetTest.res.mjs

@@ -8,6 +8,7 @@ import * as Stdlib_JSON from "@rescript/runtime/lib/es6/Stdlib_JSON.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Plugin$Reventless from "@reventlessdev/reventless-spec/src/components/Plugin.res.mjs";
 import * as Util_Sury$Reventless from "@reventlessdev/reventless-spec/src/util/Util_Sury.res.mjs";
+import * as Platform_Admin_Structure$ReventlessCore from "@reventlessdev/reventless-core/src/admin/Platform_Admin_Structure.res.mjs";
 import * as PluginExtensionPointSpec$ReventlessInfra from "@reventlessdev/reventless-infra/src/types/PluginExtensionPointSpec.res.mjs";
 import * as EventCollectorEntryPoint_Ops$ReventlessAws from "../src/adapter/Runtime/EventCollectorEntryPoint_Ops.res.mjs";
 
@@ -118,6 +119,11 @@ globalThis.describe("pluginDefinition.json write/read symmetry", () => {
     globalThis.expect(Stdlib_Option.isNone(def.structure)).toBe(true);
     globalThis.expect(Stdlib_Option.isNone(def.dcbEventLog)).toBe(true);
   });
+  globalThis.test("the platform's own placeholder asset survives the same round trip", () => {
+    let def = readAsset(Util_Sury$Reventless.toJsonString(Platform_Admin_Structure$ReventlessCore.internalPluginDefinition, Plugin$Reventless.pluginDefinitionSchema, undefined));
+    globalThis.expect(def.id).toBe(Platform_Admin_Structure$ReventlessCore.pluginId + "@INTERNAL");
+    globalThis.expect(def.kind).toBe("Domain");
+  });
 });
 
 export {