@reventlessdev/reventless-aws 3.0.0-alpha.273 → 3.0.0-alpha.274

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.274 (2026-08-08)
+
+### Bug Fixes
+
+* **aws:** scope a managed log group by project as well as stack ([f3ea01a](https://github.com/ReventlessDev/reventless-core/commit/f3ea01a254465012becf6a27b401f10382439864))
+
+
 # 3.0.0-alpha.273 (2026-08-08)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.273",
+  "version": "3.0.0-alpha.274",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -13,15 +13,15 @@
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-aws-sdk": "3.0.0-alpha.4",
-    "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
-    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.67",
     "@reventlessdev/rescript-node": "2.0.0-alpha.2",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.10",
+    "@reventlessdev/rescript-effect": "0.1.0-alpha.32",
+    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.67",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.18",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.128",
+    "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
     "@reventlessdev/reventless-core": "3.0.0-alpha.217",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.30",
-    "@reventlessdev/rescript-uuid": "2.0.0-alpha.0",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.128",
     "@reventlessdev/reventless-postgres": "3.0.0-alpha.81",
     "@reventlessdev/reventless-spec": "3.0.0-alpha.102"
   },

package/src/util/Util_LambdaLogging.res

@@ -51,11 +51,21 @@ let applyLogLevelDefault = (variables: dict<Pulumi.Input.t<string>>) =>
     - **stable**: it carries no `-<7hex>` Pulumi suffix, so replacing a function
       keeps its group instead of stranding the old one as an orphan nothing
       tears down.
-    - **stack-scoped**: stacks sharing an account cannot collide, which was the
-      reason the physical name was used before.
+    - **deployment-scoped**: deployments sharing an account cannot collide, which
+      was the reason the physical name was used before.
+
+    The scope is `project`/`stack`, and **both halves are load-bearing**. A stack
+    name alone is not a discriminator: every plugin of one platform is deployed as
+    its own Pulumi project under the *same* stack name (`alpha`, `beta`, …), and
+    the components inside them are named by role rather than by owner — so several
+    projects each host an `AllStateViewSlices`, an `AllReadModels`, an
+    `AllAggregatesCmdHandler`. Scoping on the stack alone gives all of them one
+    name, and every deployment after the first fails with
+    `ResourceAlreadyExistsException`.
 
     Pure, so the naming is decidable without Pulumi. */
-let logGroupNameFor = (~stack: string, ~name: string): string => `/aws/lambda/${stack}-${name}`
+let logGroupNameFor = (~project: string, ~stack: string, ~name: string): string =>
+  `/aws/lambda/${project}-${stack}-${name}`
 
 // Create the managed CloudWatch log group for a Lambda **before** the function
 // that writes to it, so the function can be pointed at it via `loggingConfig`
@@ -101,7 +111,11 @@ let makeManagedLogGroup = (
     Cloudwatch.LogGroup.make(
       ~name=`${name}LogGroup`,
       ~args={
-        name: logGroupNameFor(~stack, ~name)->Pulumi.Input.make,
+        name: logGroupNameFor(
+          ~project=Pulumi.Pulumi.getProjectName(),
+          ~stack,
+          ~name,
+        )->Pulumi.Input.make,
         retentionInDays: days->Pulumi.Input.make,
         tags,
       },

package/src/util/Util_LambdaLogging.res.mjs

@@ -36,8 +36,8 @@ function applyLogLevelDefault(variables) {
   variables[match[0]] = match[1];
 }
 
-function logGroupNameFor(stack, name) {
-  return `/aws/lambda/` + stack + `-` + name;
+function logGroupNameFor(project, stack, name) {
+  return `/aws/lambda/` + project + `-` + stack + `-` + name;
 }
 
 function makeManagedLogGroup(name, retentionDaysOverride, tags, opts, param) {
@@ -48,7 +48,7 @@ function makeManagedLogGroup(name, retentionDaysOverride, tags, opts, param) {
       match$1 ? Util_LogRetention$ReventlessAws.retentionDaysFor(stack, match[1], Stdlib_Option.flatMap(Util_LocalConfig$ReventlessAws.get("logRetentionDays"), s => Stdlib_Int.fromString(s, undefined))) : undefined
     );
   return Stdlib_Option.map(retentionDays, days => new (Aws.cloudwatch.LogGroup)(name + `LogGroup`, {
-    name: logGroupNameFor(stack, name),
+    name: logGroupNameFor(Pulumi.getProject(), stack, name),
     retentionInDays: days,
     tags: tags
   }, opts !== undefined ? Primitive_option.valFromOption(opts) : undefined));

package/tests/Util_LambdaLoggingTest.res

@@ -5,32 +5,44 @@ open JestGlobals
 // (the group can be created before the function, and pointed at from
 // `loggingConfig`), so the properties it has to keep are worth pinning.
 describe("Util_LambdaLogging.logGroupNameFor", () => {
+  let nameFor = (~project="online-shop-catalog-aws", ~stack="alpha", ~name) =>
+    Util_LambdaLogging.logGroupNameFor(~project, ~stack, ~name)
+
   testSync("is the conventional Lambda group prefix", () =>
-    expect(Util_LambdaLogging.logGroupNameFor(~stack="alpha", ~name="AllReadModels"))->toBe(
-      "/aws/lambda/alpha-AllReadModels",
+    expect(nameFor(~name="AllReadModels"))->toBe(
+      "/aws/lambda/online-shop-catalog-aws-alpha-AllReadModels",
     )
   )
 
   testSync("carries no Pulumi physical-name suffix, so a replaced function keeps its group", () => {
-    let before = Util_LambdaLogging.logGroupNameFor(~stack="alpha", ~name="AllReadModels")
-    let afterReplacement = Util_LambdaLogging.logGroupNameFor(~stack="alpha", ~name="AllReadModels")
+    let before = nameFor(~name="AllReadModels")
+    let afterReplacement = nameFor(~name="AllReadModels")
     expect(before)->toBe(afterReplacement)
   })
 
-  testSync("is stack-scoped, so stacks sharing an account cannot collide", () =>
-    expect(Util_LambdaLogging.logGroupNameFor(~stack="pr-42", ~name="AllReadModels"))->not_->toBe(
-      Util_LambdaLogging.logGroupNameFor(~stack="alpha", ~name="AllReadModels"),
+  testSync("is stack-scoped, so environments of one project cannot collide", () =>
+    expect(nameFor(~stack="pr-42", ~name="AllReadModels"))->not_->toBe(
+      nameFor(~stack="alpha", ~name="AllReadModels"),
     )
   )
 
+  // The regression this scoping exists for. Every plugin of one platform is its
+  // own Pulumi PROJECT deployed under the SAME stack name, and components are
+  // named by role rather than by owner — so several projects each host an
+  // `AllStateViewSlices`. Scoping on the stack alone gave them one name, and
+  // every deploy after the first failed with ResourceAlreadyExistsException.
+  testSync("is project-scoped, so one platform's plugins cannot collide", () =>
+    expect(nameFor(~project="online-shop-catalog-aws", ~name="AllStateViewSlices"))
+    ->not_
+    ->toBe(nameFor(~project="online-shop-ordering-aws", ~name="AllStateViewSlices"))
+  )
+
   testSync("differs from the group Lambda would auto-create for the same function", () => {
     // Lambda auto-creates `/aws/lambda/<physical name>`, and the physical name
     // always carries Pulumi's `-<7hex>` suffix. Not colliding with it is what
     // makes the create unconditionally safe on a stack whose groups AWS already
     // made.
     let autoCreated = "/aws/lambda/AllReadModels-0287438"
-    expect(Util_LambdaLogging.logGroupNameFor(~stack="alpha", ~name="AllReadModels"))->not_->toBe(
-      autoCreated,
-    )
+    expect(nameFor(~name="AllReadModels"))->not_->toBe(autoCreated)
   })
 })

package/tests/Util_LambdaLoggingTest.res.mjs

@@ -3,19 +3,27 @@
 import * as Util_LambdaLogging$ReventlessAws from "../src/util/Util_LambdaLogging.res.mjs";
 
 globalThis.describe("Util_LambdaLogging.logGroupNameFor", () => {
+  let nameFor = (projectOpt, stackOpt, name) => {
+    let project = projectOpt !== undefined ? projectOpt : "online-shop-catalog-aws";
+    let stack = stackOpt !== undefined ? stackOpt : "alpha";
+    return Util_LambdaLogging$ReventlessAws.logGroupNameFor(project, stack, name);
+  };
   globalThis.test("is the conventional Lambda group prefix", () => {
-    globalThis.expect(Util_LambdaLogging$ReventlessAws.logGroupNameFor("alpha", "AllReadModels")).toBe("/aws/lambda/alpha-AllReadModels");
+    globalThis.expect(nameFor(undefined, undefined, "AllReadModels")).toBe("/aws/lambda/online-shop-catalog-aws-alpha-AllReadModels");
   });
   globalThis.test("carries no Pulumi physical-name suffix, so a replaced function keeps its group", () => {
-    let before = Util_LambdaLogging$ReventlessAws.logGroupNameFor("alpha", "AllReadModels");
-    let afterReplacement = Util_LambdaLogging$ReventlessAws.logGroupNameFor("alpha", "AllReadModels");
+    let before = nameFor(undefined, undefined, "AllReadModels");
+    let afterReplacement = nameFor(undefined, undefined, "AllReadModels");
     globalThis.expect(before).toBe(afterReplacement);
   });
-  globalThis.test("is stack-scoped, so stacks sharing an account cannot collide", () => {
-    globalThis.expect(Util_LambdaLogging$ReventlessAws.logGroupNameFor("pr-42", "AllReadModels")).not.toBe(Util_LambdaLogging$ReventlessAws.logGroupNameFor("alpha", "AllReadModels"));
+  globalThis.test("is stack-scoped, so environments of one project cannot collide", () => {
+    globalThis.expect(nameFor(undefined, "pr-42", "AllReadModels")).not.toBe(nameFor(undefined, "alpha", "AllReadModels"));
+  });
+  globalThis.test("is project-scoped, so one platform's plugins cannot collide", () => {
+    globalThis.expect(nameFor("online-shop-catalog-aws", undefined, "AllStateViewSlices")).not.toBe(nameFor("online-shop-ordering-aws", undefined, "AllStateViewSlices"));
   });
   globalThis.test("differs from the group Lambda would auto-create for the same function", () => {
-    globalThis.expect(Util_LambdaLogging$ReventlessAws.logGroupNameFor("alpha", "AllReadModels")).not.toBe("/aws/lambda/AllReadModels-0287438");
+    globalThis.expect(nameFor(undefined, undefined, "AllReadModels")).not.toBe("/aws/lambda/AllReadModels-0287438");
   });
 });