@reventlessdev/reventless-aws 3.0.0-alpha.233 → 3.0.0-alpha.235

package/CHANGELOG.md

@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.235 (2026-07-27)
+
+**Note:** Version bump only for package @reventlessdev/reventless-aws
+
+
+
+
+
+# 3.0.0-alpha.234 (2026-07-27)
+
+### Bug Fixes
+
+* **aws:** thread InboundTranslationSlice audit table name without option<Output> ([8b2368a](https://github.com/ReventlessDev/reventless-core/commit/8b2368a17e49746beacc0855fd5c655517bfd41a))
+
+
 # 3.0.0-alpha.233 (2026-07-27)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.233",
+  "version": "3.0.0-alpha.235",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -11,17 +11,17 @@
     "@aws-sdk/s3-request-presigner": "3.970.0",
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
-    "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.25",
-    "@reventlessdev/rescript-effect": "0.1.0-alpha.31",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.9",
+    "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.25",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.17",
     "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.61",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.184",
-    "@reventlessdev/reventless-interop": "3.0.0-alpha.29",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.105",
+    "@reventlessdev/rescript-effect": "0.1.0-alpha.31",
     "@reventlessdev/rescript-uuid": "1.1.0-alpha.17",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.81",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.48"
+    "@reventlessdev/reventless-core": "3.0.0-alpha.185",
+    "@reventlessdev/reventless-interop": "3.0.0-alpha.29",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.106",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.49",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.81"
   },
   "devDependencies": {
     "rescript": "12.3.0",

package/src/adapter/Runtime/DcbCommandTopicEntryPoint.mjs

@@ -160,7 +160,20 @@ export async function buildHandlersForConfig(config, opts = {}) {
   await Promise.all(inboundModules.map(async ({ spec, translation, auditTableName }) => {
     const specModule = await loadModule(spec);
     const translationModule = await loadModule(translation);
-    const auditOps = (auditTableName && !config.pgConnection)
+    // auditTableName must be a real non-empty string. A non-string here (e.g. a
+    // mis-serialized deploy-time value) would build a QueryDb ops whose TableName
+    // is an object, and every PutCommand would crash in AWS endpoint resolution
+    // ("value.split is not a function") — silently, since the audit save is
+    // best-effort. Guard against that instead of trusting the config shape.
+    const hasAuditTable = typeof auditTableName === "string" && auditTableName.length > 0;
+    if (auditTableName != null && !hasAuditTable) {
+      log.warn(
+        "inbound audit table name is not a string; skipping audit persistence: " +
+          JSON.stringify(auditTableName),
+        { comp: "DcbCommandTopicRuntime" },
+      );
+    }
+    const auditOps = (hasAuditTable && !config.pgConnection)
       ? makeDynamoQueryDbOps(auditTableName)
       : undefined;
     const fieldName = config.pluginName + "_" + specModule.name;

package/src/adapter/Runtime/DcbCommandTopicEntryPoint_Ops.res

@@ -266,14 +266,24 @@ let buildInboundReceiver = (
         let json = row->S.reverseConvertToJsonOrThrow(
           ReventlessCore.InboundTranslationSlice_Callback.auditRowSchema,
         )
+        // A failed audit write must not fail the mutation (the command was
+        // already published), but it must not vanish either. `save` RESOLVES
+        // with `Error(_)` on a storage failure (it does not throw), so the
+        // result must be inspected — a bare `let _ = await ops.save(...)` would
+        // swallow the failure and leave the audit view permanently, silently
+        // empty. `try` still guards an unexpected reject.
         try {
-          let _ = await ops.save(id, json, ReventlessCore.QueryDb.Overwrite, None)
+          switch await ops.save(id, json, ReventlessCore.QueryDb.Overwrite, None) {
+          | Ok() => ()
+          | Error(err) =>
+            ReventlessCore.EffectLogger.logError(
+              ~comp="InboundTranslationSlice.audit",
+              `failed to persist audit row ${id}: ${err
+                ->ReventlessCore.QueryDb.storageErrorToString}`,
+            )->Effect.runSync
+          }
         } catch {
         | exn =>
-          // A failed audit write must not fail the mutation (the command was
-          // already published), but it must not vanish either: an AccessDenied
-          // here means the command Lambda's role lacks PutItem on the audit table,
-          // which otherwise surfaces only as a permanently empty audit view.
           let detail =
             exn->JsExn.fromException->Option.flatMap(JsExn.message)->Option.getOr("unknown error")
           ReventlessCore.EffectLogger.logError(

package/src/adapter/Runtime/DcbCommandTopicEntryPoint_Ops.res.mjs

@@ -11,6 +11,7 @@ import * as Primitive_option from "@rescript/runtime/lib/es6/Primitive_option.js
 import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
 import * as Primitive_exceptions from "@rescript/runtime/lib/es6/Primitive_exceptions.js";
 import * as Message$ReventlessCore from "@reventlessdev/reventless-core/src/Message.res.mjs";
+import * as QueryDb$ReventlessCore from "@reventlessdev/reventless-core/src/components/QueryDb/QueryDb.res.mjs";
 import * as EffectLogger$ReventlessCore from "@reventlessdev/reventless-core/src/util/EffectLogger.res.mjs";
 import * as CommandTopic_Helpers$ReventlessCore from "@reventlessdev/reventless-core/src/components/CommandTopic/CommandTopic_Helpers.res.mjs";
 import * as InboundTranslationSlice_Callback$ReventlessCore from "@reventlessdev/reventless-core/src/components/InboundTranslationSlice/InboundTranslationSlice_Callback.res.mjs";
@@ -112,8 +113,12 @@ function buildInboundReceiver(spec, translation, publishJsons, auditQueryDbOps)
         await prev;
         let json = S.reverseConvertToJsonOrThrow(param[1], InboundTranslationSlice_Callback$ReventlessCore.auditRowSchema);
         try {
-          await auditQueryDbOps.save(id, json, "Overwrite", undefined);
-          return;
+          let err = await auditQueryDbOps.save(id, json, "Overwrite", undefined);
+          if (err.TAG === "Ok") {
+            return;
+          } else {
+            return Effect.runSync(EffectLogger$ReventlessCore.logError("InboundTranslationSlice.audit", undefined, `failed to persist audit row ` + id + `: ` + QueryDb$ReventlessCore.storageErrorToString(err._0)));
+          }
         } catch (raw_exn) {
           let exn = Primitive_exceptions.internalToException(raw_exn);
           let detail = Stdlib_Option.getOr(Stdlib_Option.flatMap(Stdlib_JsExn.fromException(exn), Stdlib_JsExn.message), "unknown error");

package/src/adapter/Runtime/RuntimeEnvironment_Lambda.res

@@ -13,9 +13,28 @@ type iamPolicy = {
 }
 let additionalIamPolicies: array<iamPolicy> = []
 
-// Legacy CallbackFunction path — retained for module type compatibility.
-// Not called at runtime; all Lambda deployments now use makeFromCodeAsset.
-// Can be removed once the module type no longer requires environmentMaker.
+// CallbackFunction path — the last serialized-closure Lambda builder on AWS.
+//
+// REACHABLE, despite most deployments going through makeFromCodeAsset. Three
+// component builders instantiate ReventlessCore.EventCollectorRuntime_Builder_
+// PerEventCollector.Make over this module — ForeignReadModel_Builder,
+// SideEffectHandler_PerSideEffectHandler and Task_Builder_PerBucket — and that
+// functor's forEventCollector calls `make` below. The live route is a Task whose
+// spec returns `Task.sideEffects`: Task_Builder then constructs a
+// SideEffectHandler, which provisions its collector Lambda here.
+//
+// A Lambda built this way is a serialized closure, and Pulumi's closure walker
+// fails on Effect-TS — silently, so the function is simply never created and the
+// deploy still reports success (see docs/plans/done/complete-bundled-migration.md,
+// where an ordering-aws deploy came up four Lambdas short). Where it does
+// serialize, it then resolves @aws-sdk against whatever the layer and the runtime
+// each supply, carrying the cold-start SDK-skew failure compiled entry points
+// were introduced to avoid. Converting these three builders to a compiled entry
+// point is the fix; until then a side-effect-bearing Task is the exposed surface.
+//
+// `make` cannot simply be dropped: Runtime.Environment requires environmentMaker
+// and the in-memory platform implements it for real (LocalRuntimeEnvironment
+// registers the handler in a Deferred).
 let make: ReventlessCore.Runtime.environmentMaker<'event, context, 'result, parts> = (
   ~name,
   ~handler,
@@ -27,8 +46,8 @@ let make: ReventlessCore.Runtime.environmentMaker<'event, context, 'result, part
   let opts =
     opts->Option.map(ReventlessCore.Util.Pulumi.ComponentResourceOptions.toCustomResourceOptions)
 
-  // Legacy path (see above): no component kind reaches here because nothing calls
-  // it, so it is attributed to the Platform rather than to an invented domain kind.
+  // The environmentMaker signature carries no component kind, so callers cannot
+  // pass one through; attributed to the Platform rather than to an invented kind.
   let tags = AWS.Tags.make(~name, ~kind=ReventlessCore.ComponentType.Platform, ~role=Runtime, ~scope=Platform)
 
   let lambdaRole = IAM.Role.makeWithDefaultPolicy(
@@ -58,7 +77,8 @@ let make: ReventlessCore.Runtime.environmentMaker<'event, context, 'result, part
     )
 
   // Coerce CallbackFunction.t → Function.t (structurally compatible: both have arn, id, name).
-  // This legacy path is only retained for module type compatibility.
+  // The coercion goes away with the path itself, once the three PerEventCollector
+  // builders above move to a compiled entry point.
   let lambdaAsFunction: Pulumi.Output.t<PulumiAws.Lambda.Function.t> = lambda->Obj.magic
 
   {

package/src/adapter/Runtime/StateChangeSliceRuntime_Builder_Single.res

@@ -21,7 +21,10 @@ let log = ReventlessCore.Logger.fromEnv()
 type inboundSlicePaths = {
   specPath: string,
   translationPath: string,
-  auditTableName: option<Pulumi.Output.t<string>>,
+  // Plain Output, never `option<Pulumi.Output.t<string>>` — see the note on
+  // `PluginRuntime_Builder.inboundSliceReg.auditTableName`. Empty string = no
+  // audit table (serialized as `null`).
+  auditTableName: Pulumi.Output.t<string>,
 }
 
 // `slicePaths`: `(specPath, behaviorPath)` per StateChangeSlice (already merged
@@ -142,7 +145,7 @@ let forDcbCommandTopic = (
     | [] => Pulumi.Output.make("")
     | slices =>
       slices
-      ->Array.map(s => s.auditTableName->Option.getOr(Pulumi.Output.make("")))
+      ->Array.map(s => s.auditTableName)
       ->Pulumi.Output.all
       ->Pulumi.Output.apply(tableNames => {
         let entries =

package/src/adapter/Runtime/StateChangeSliceRuntime_Builder_Single.res.mjs

@@ -59,7 +59,7 @@ function forDcbCommandTopic(slicePaths, inboundSlicesOpt, dcbTableName, pluginNa
     return `{"spec":` + s + `,"behavior":` + b + `}`;
   }).join(",");
   let pgConnectionFragment = pgSelection !== undefined ? pgSelection.connectionConfig.apply(cc => `,"pgConnection":` + JSON.stringify(PgConnection$ReventlessAws.connectionConfigToJson(pgSelection.lockStrategy, cc))) : Pulumi.output("");
-  let inboundFragment = inboundSlices.length !== 0 ? Pulumi.all(inboundSlices.map(s => Stdlib_Option.getOr(s.auditTableName, Pulumi.output("")))).apply(tableNames => {
+  let inboundFragment = inboundSlices.length !== 0 ? Pulumi.all(inboundSlices.map(s => s.auditTableName)).apply(tableNames => {
       let entries = inboundSlices.map((s, i) => {
         let spec = Stdlib_Option.getOr(JSON.stringify(s.specPath), `""`);
         let translation = Stdlib_Option.getOr(JSON.stringify(s.translationPath), `""`);

package/src/plugin/runtime/PluginRuntime_Builder.res

@@ -56,7 +56,13 @@ let registerStateChangeSliceSpec = (~specPath: string, ~behaviorPath: string) =>
 type inboundSliceReg = {
   specPath: string,
   translationPath: string,
-  mutable auditTableName: option<Pulumi.Output.t<string>>,
+  // Plain `Pulumi.Output.t<string>`, never `option<Pulumi.Output.t<string>>`:
+  // any generic `Option.*` call over an Output runs `valFromOption`, whose
+  // `.BS_PRIVATE_NESTED_SOME_NONE` probe hits the Output proxy (every property
+  // access returns a truthy Output), mis-classifies it as a nested-option and
+  // corrupts it into `{BS_PRIVATE_NESTED_SOME_NONE:0}`. The empty-string Output
+  // is the "no audit table" sentinel (serialized as `null` downstream).
+  mutable auditTableName: Pulumi.Output.t<string>,
 }
 let registeredInboundSlices: dict<inboundSliceReg> = Dict.make()
 
@@ -68,16 +74,19 @@ let registerInboundTranslationSliceSpec = (
   switch registeredInboundSlices->Dict.get(specName) {
   | Some(reg) => registeredInboundSlices->Dict.set(specName, {...reg, specPath, translationPath})
   | None =>
-    registeredInboundSlices->Dict.set(specName, {specPath, translationPath, auditTableName: None})
+    registeredInboundSlices->Dict.set(
+      specName,
+      {specPath, translationPath, auditTableName: Pulumi.Output.make("")},
+    )
   }
 
 let registerInboundAuditTableName = (~specName: string, tableName: Pulumi.Output.t<string>) =>
   switch registeredInboundSlices->Dict.get(specName) {
-  | Some(reg) => reg.auditTableName = Some(tableName)
+  | Some(reg) => reg.auditTableName = tableName
   | None =>
     registeredInboundSlices->Dict.set(
       specName,
-      {specPath: "", translationPath: "", auditTableName: Some(tableName)},
+      {specPath: "", translationPath: "", auditTableName: tableName},
     )
   }
 

package/src/plugin/runtime/PluginRuntime_Builder.res.mjs

@@ -65,7 +65,7 @@ function registerInboundTranslationSliceSpec(specName, specPath, translationPath
     registeredInboundSlices[specName] = {
       specPath: specPath,
       translationPath: translationPath,
-      auditTableName: undefined
+      auditTableName: Pulumi.output("")
     };
   }
 }