@reventlessdev/reventless-aws 3.0.0-alpha.229 → 3.0.0-alpha.231

package/src/plugin/runtime/PluginRuntime_Builder.res.mjs

@@ -1,6 +1,7 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
 import * as Aws from "@pulumi/aws";
+import * as Stdlib_Array from "@rescript/runtime/lib/es6/Stdlib_Array.js";
 import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
 import * as Pulumi from "@pulumi/pulumi";
 import * as Primitive_string from "@rescript/runtime/lib/es6/Primitive_string.js";
@@ -50,6 +51,38 @@ function registerStateChangeSliceSpec(specPath, behaviorPath) {
   });
 }
 
+let registeredInboundSlices = {};
+
+function registerInboundTranslationSliceSpec(specName, specPath, translationPath) {
+  let reg = registeredInboundSlices[specName];
+  if (reg !== undefined) {
+    registeredInboundSlices[specName] = {
+      specPath: specPath,
+      translationPath: translationPath,
+      auditTableName: reg.auditTableName
+    };
+  } else {
+    registeredInboundSlices[specName] = {
+      specPath: specPath,
+      translationPath: translationPath,
+      auditTableName: undefined
+    };
+  }
+}
+
+function registerInboundAuditTableName(specName, tableName) {
+  let reg = registeredInboundSlices[specName];
+  if (reg !== undefined) {
+    reg.auditTableName = tableName;
+  } else {
+    registeredInboundSlices[specName] = {
+      specPath: "",
+      translationPath: "",
+      auditTableName: tableName
+    };
+  }
+}
+
 function registerDcbConfig(pluginName, dcbTableName, stateChangeSliceModulePathsOpt, param) {
   let stateChangeSliceModulePaths = stateChangeSliceModulePathsOpt !== undefined ? stateChangeSliceModulePathsOpt : [];
   dcbConfigRef.contents = {
@@ -422,7 +455,7 @@ function Make(EventCollectorChannel) {
     envVars["EP_QUEUE_URL"] = epQueueUrl;
     envVars["PLUGIN_ID"] = Pulumi.output(hbConfig.pluginId);
     envVars["HEARTBEAT_TIMEOUT"] = Pulumi.output(hbConfig.heartbeatTimeout.toString());
-    let match = Util_Bundle$ReventlessAws.buildCodeArchive("@reventlessdev/reventless-aws/src/adapter/Runtime/HeartbeatEntryPoint.mjs", {}, undefined);
+    let match = Util_Bundle$ReventlessAws.buildCodeArchive("@reventlessdev/reventless-aws/src/adapter/Runtime/HeartbeatEntryPoint.res.mjs", {}, undefined);
     connect(RuntimeEnvironment_Lambda$ReventlessAws.makeFromCodeAsset(name, "Scheduler", "Scheduler", match.code, match.sourceCodeHash, envVars, memorySize, timeout, undefined, undefined, undefined, undefined, undefined, opts));
   };
   let forDcbCommandTopic = (param, connect, memorySizeOpt, timeoutOpt, dcbCommandTopic) => {
@@ -433,7 +466,18 @@ function Make(EventCollectorChannel) {
       param.specPath,
       param.behaviorPath
     ]);
-    StateChangeSliceRuntime_Builder_Single$ReventlessAws.forDcbCommandTopic(slicePaths, dcbConfig.dcbTableName, dcbConfig.pluginName, syncStateChangesConfigRef.contents, asyncStateChangesConfigRef.contents, memorySize, timeout, connect, dcbCommandTopic);
+    let inboundSlices = Stdlib_Array.filterMap(Object.values(registeredInboundSlices), reg => {
+      if (reg.specPath === "") {
+        return;
+      } else {
+        return {
+          specPath: reg.specPath,
+          translationPath: reg.translationPath,
+          auditTableName: reg.auditTableName
+        };
+      }
+    });
+    StateChangeSliceRuntime_Builder_Single$ReventlessAws.forDcbCommandTopic(slicePaths, inboundSlices, dcbConfig.dcbTableName, dcbConfig.pluginName, syncStateChangesConfigRef.contents, asyncStateChangesConfigRef.contents, memorySize, timeout, connect, dcbCommandTopic);
   };
   let finish = () => {};
   return {
@@ -452,6 +496,9 @@ export {
   dcbConfigRef,
   registeredSliceModulePaths,
   registerStateChangeSliceSpec,
+  registeredInboundSlices,
+  registerInboundTranslationSliceSpec,
+  registerInboundAuditTableName,
   registerDcbConfig,
   registerDcbTableName,
   heartbeatConfigRef,

package/tests/DcbInboundTranslationRoutingTest.res

@@ -0,0 +1,73 @@
+// CI routing guard for the DCB CommandTopic Lambda's Route 0 (InboundTranslation).
+//
+// The AppSync resolver for an InboundTranslationSlice mutation invokes the shared
+// DCB command Lambda with `{__inboundTranslation, fieldName, arguments}` — no
+// `command`, no `Records`. Before Route 0 existed the payload fell through to the
+// SQS route and crashed on `event.records` being undefined ("Cannot read
+// properties of undefined (reading 'length')"), so every inbound mutation 500'd
+// on a deployed stack (docs/plans/done/aws-inbound-translation-lambda-routing.md).
+// The gap that let this ship: `__inboundTranslation` was only ever asserted on the
+// sending side (the resolver-template test). This pins the receiving end.
+//
+// Drives the real `buildHandlersForConfig` with an inbound slice module and a stub
+// loader, then dispatches the payload exactly as `handler`'s Route 0 does. The
+// fixture translation rejects its input, so the receiver returns CommandRejected
+// inline without touching SQS or DynamoDB — no Docker needed, runs in CI.
+
+open JestGlobals
+
+let routeInbound: JSON.t => promise<JSON.t> = %raw(`
+  async (event) => {
+    const { buildHandlersForConfig } = await import(
+      "@reventlessdev/reventless-aws/src/adapter/Runtime/DcbCommandTopicEntryPoint.mjs"
+    );
+    const loadModule = async (specifier) => {
+      if (specifier === "ep-inbound-test://spec") return await import("./EpInboundTestSlice.res.mjs");
+      if (specifier === "ep-inbound-test://translation") return await import("./EpInboundTestSliceTranslation.res.mjs");
+      throw new Error("unknown test specifier: " + specifier);
+    };
+    const config = {
+      pluginName: "EpInboundTestPlugin",
+      dcbEventLogTableName: "ep-inbound-test-table",
+      stateChangeSliceModules: [],
+      queueUrl: "https://sqs.eu-west-1.amazonaws.com/000000000000/ep-inbound-test-queue",
+      inboundTranslationSliceModules: [
+        { spec: "ep-inbound-test://spec", translation: "ep-inbound-test://translation", auditTableName: null },
+      ],
+    };
+    const [,,,, inboundReceivers] = await buildHandlersForConfig(config, { loadModule });
+    // Mirror handler's Route 0 dispatch.
+    const receiver = (inboundReceivers || {})[event.fieldName];
+    if (receiver === undefined) throw new Error("no inbound receiver for " + event.fieldName);
+    return await receiver(event.arguments);
+  }
+`)
+
+let inboundEvent = (~fieldName, ~currency): JSON.t => {
+  let arguments = Dict.fromArray([
+    ("sku", "SKU-1"->JSON.Encode.string),
+    ("currency", currency->JSON.Encode.string),
+  ])
+  Dict.fromArray([
+    ("__inboundTranslation", true->JSON.Encode.bool),
+    ("fieldName", fieldName->JSON.Encode.string),
+    ("arguments", arguments->JSON.Encode.object),
+  ])->JSON.Encode.object
+}
+
+describe("DcbCommandTopicEntryPoint Route 0 (InboundTranslation)", () => {
+  test(
+    "routes an __inboundTranslation payload to the slice's receive and encodes the outcome",
+    async () => {
+      // fieldName is `${pluginName}_${specName}` — the same string
+      // Api_Naming.sliceMutationField produces at deploy time.
+      let event = inboundEvent(~fieldName="EpInboundTestPlugin_EpInboundTest", ~currency="EUR")
+      let outcome = await routeInbound(event)
+      let s = outcome->JSON.stringifyAny->Option.getOr("<unserializable>")
+      // A serializable outcome at all proves the payload no longer crashes on the
+      // SQS route; the rejection proves it ran the slice's translate.
+      expect(s->String.includes("CommandRejected"))->toBe(true)
+      expect(s->String.includes("Unsupported currency"))->toBe(true)
+    },
+  )
+})

package/tests/DcbInboundTranslationRoutingTest.res.mjs

@@ -0,0 +1,71 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as Stdlib_Option from "@rescript/runtime/lib/es6/Stdlib_Option.js";
+
+let routeInbound = (async (event) => {
+    const { buildHandlersForConfig } = await import(
+      "@reventlessdev/reventless-aws/src/adapter/Runtime/DcbCommandTopicEntryPoint.mjs"
+    );
+    const loadModule = async (specifier) => {
+      if (specifier === "ep-inbound-test://spec") return await import("./EpInboundTestSlice.res.mjs");
+      if (specifier === "ep-inbound-test://translation") return await import("./EpInboundTestSliceTranslation.res.mjs");
+      throw new Error("unknown test specifier: " + specifier);
+    };
+    const config = {
+      pluginName: "EpInboundTestPlugin",
+      dcbEventLogTableName: "ep-inbound-test-table",
+      stateChangeSliceModules: [],
+      queueUrl: "https://sqs.eu-west-1.amazonaws.com/000000000000/ep-inbound-test-queue",
+      inboundTranslationSliceModules: [
+        { spec: "ep-inbound-test://spec", translation: "ep-inbound-test://translation", auditTableName: null },
+      ],
+    };
+    const [,,,, inboundReceivers] = await buildHandlersForConfig(config, { loadModule });
+    // Mirror handler's Route 0 dispatch.
+    const receiver = (inboundReceivers || {})[event.fieldName];
+    if (receiver === undefined) throw new Error("no inbound receiver for " + event.fieldName);
+    return await receiver(event.arguments);
+  });
+
+function inboundEvent(fieldName, currency) {
+  let $$arguments = Object.fromEntries([
+    [
+      "sku",
+      "SKU-1"
+    ],
+    [
+      "currency",
+      currency
+    ]
+  ]);
+  return Object.fromEntries([
+    [
+      "__inboundTranslation",
+      true
+    ],
+    [
+      "fieldName",
+      fieldName
+    ],
+    [
+      "arguments",
+      $$arguments
+    ]
+  ]);
+}
+
+globalThis.describe("DcbCommandTopicEntryPoint Route 0 (InboundTranslation)", () => {
+  globalThis.test("routes an __inboundTranslation payload to the slice's receive and encodes the outcome", async () => {
+    let event = inboundEvent("EpInboundTestPlugin_EpInboundTest", "EUR");
+    let outcome = await routeInbound(event);
+    let s = Stdlib_Option.getOr(JSON.stringify(outcome), "<unserializable>");
+    globalThis.expect(s.includes("CommandRejected")).toBe(true);
+    globalThis.expect(s.includes("Unsupported currency")).toBe(true);
+  });
+});
+
+export {
+  routeInbound,
+  inboundEvent,
+}
+/* routeInbound Not a pure module */

package/tests/EpInboundTestSlice.res

@@ -0,0 +1,19 @@
+// Minimal InboundTranslationSlice spec fixture for the DCB entry-point Route 0
+// routing test (DcbInboundTranslationRoutingTest). Hand-written — not a plugin
+// component, so no folder-based ppx; only the fields
+// InboundTranslationSlice_Callback.Make reads at runtime are provided.
+
+let name = "EpInboundTest"
+let moduleUrl = "ep-inbound-test://spec"
+
+@schema
+type externalInput = {
+  sku: string,
+  currency: string,
+}
+
+@schema
+type command = AddThing({thingId: string})
+
+let targetName = "AddThing"
+let externalSystem: option<string> = Some("TestFeed")

package/tests/EpInboundTestSlice.res.mjs

@@ -0,0 +1,31 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as S from "sury/src/S.res.mjs";
+
+let externalInputSchema = S.schema(s => ({
+  sku: s.m(S.string),
+  currency: s.m(S.string)
+}));
+
+let commandSchema = S.schema(s => ({
+  TAG: "AddThing",
+  thingId: s.m(S.string)
+}));
+
+let name = "EpInboundTest";
+
+let moduleUrl = "ep-inbound-test://spec";
+
+let targetName = "AddThing";
+
+let externalSystem = "TestFeed";
+
+export {
+  name,
+  moduleUrl,
+  externalInputSchema,
+  commandSchema,
+  targetName,
+  externalSystem,
+}
+/* externalInputSchema Not a pure module */

package/tests/EpInboundTestSliceTranslation.res

@@ -0,0 +1,13 @@
+// Translation fixture paired with EpInboundTestSlice. Rejects non-USD input so the
+// routing test exercises the receive reject path — no command is published, so the
+// test needs neither SQS nor DynamoDB.
+
+module Spec = EpInboundTestSlice
+open Spec
+
+let moduleUrl = "ep-inbound-test://translation"
+
+let translate = (input: externalInput): result<array<(string, command)>, string> =>
+  input.currency !== "USD"
+    ? Error("Unsupported currency: " ++ input.currency)
+    : Ok([(input.sku, AddThing({thingId: input.sku}))])

package/tests/EpInboundTestSliceTranslation.res.mjs

@@ -0,0 +1,33 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+
+function translate(input) {
+  if (input.currency !== "USD") {
+    return {
+      TAG: "Error",
+      _0: "Unsupported currency: " + input.currency
+    };
+  } else {
+    return {
+      TAG: "Ok",
+      _0: [[
+          input.sku,
+          {
+            TAG: "AddThing",
+            thingId: input.sku
+          }
+        ]]
+    };
+  }
+}
+
+let Spec;
+
+let moduleUrl = "ep-inbound-test://translation";
+
+export {
+  Spec,
+  moduleUrl,
+  translate,
+}
+/* No side effect */

package/src/adapter/Runtime/HeartbeatEntryPoint.mjs

@@ -1,38 +0,0 @@
-// Heartbeat Lambda handler.
-// Publishes a Heartbeat(timeout) command to the PluginExtensionPoint CommandTopic.
-// Triggered by CloudWatch Events on a schedule.
-
-import { reverseConvertToJsonOrThrow } from "sury/src/S.res.mjs";
-import { makeQueueRef } from "./HandlerFactoryHelpers.mjs";
-import { uuid } from "@reventlessdev/reventless-core/src/Message.res.mjs";
-import { name as pluginExtensionPointName, commandSchema } from "@reventlessdev/reventless-infra/src/types/PluginExtensionPointSpec.res.mjs";
-import { publishJsons as sqsPublishJsons } from "@reventlessdev/reventless-aws/src/adapter/CommandTopic/CommandTopicChannel_SQS_Runtime.res.mjs";
-
-// === Initialize eagerly at module load (Lambda cold start) ===
-
-const epQueueUrl = process.env["EP_QUEUE_URL"] || "";
-const pluginId = process.env["PLUGIN_ID"] || "";
-const timeout = parseInt(process.env["HEARTBEAT_TIMEOUT"], 10) || 10;
-
-const publishJsons = sqsPublishJsons(makeQueueRef(epQueueUrl), "SQS_FIFO");
-
-// === Exported handler ===
-
-export async function handler(_event, _context) {
-  const msgId = uuid();
-  const commandJson = reverseConvertToJsonOrThrow({ TAG: "Heartbeat", _0: timeout }, commandSchema);
-  const message = {
-    id: pluginId,
-    meta: {
-      service: pluginExtensionPointName,
-      time: new Date().toISOString(),
-      ip: "",
-      user: "Heartbeat",
-      msgId,
-      correlationId: msgId,
-    },
-    commandJson,
-  };
-  await publishJsons([message]);
-  return "";
-}

package/src/adapter/Runtime/PluginExtensionPointEntryPoint.mjs

@@ -1,127 +0,0 @@
-// PluginExtensionPoint Lambda entry point.
-// All imports are framework packages — no user modules needed.
-// Handles Heartbeat, Cloner, and other plugin-level extension point commands.
-
-import {
-  patchSpecId,
-  makeQueueRef,
-  scanByTableName,
-  log,
-  runEffect,
-  setRequestId,
-  extractMetaField,
-  extractSentTimestamp,
-  extractRetryCount,
-} from "./HandlerFactoryHelpers.mjs";
-import { sendMessage } from "@reventlessdev/reventless-aws/src/plugin/runtime/Util_PluginMessage_Runtime.res.mjs";
-import * as PluginExtensionPointSpec from "@reventlessdev/reventless-infra/src/types/PluginExtensionPointSpec.res.mjs";
-import { Make as pluginEPPluginMake } from "@reventlessdev/reventless-core/src/plugin/connect/PluginExtensionPoint_Plugin.res.mjs";
-import { Make as extensionPointCallbackMake } from "@reventlessdev/reventless-core/src/components/ExtensionPoint/ExtensionPoint_Callback.res.mjs";
-import { Make as commandTopicCallbackMake } from "@reventlessdev/reventless-core/src/components/CommandTopic/CommandTopic_Callback.res.mjs";
-import { handleQueueEvent, publishJsons as sqsPublishJsons } from "@reventlessdev/reventless-aws/src/adapter/CommandTopic/CommandTopicChannel_SQS_Runtime.res.mjs";
-import { createSchedule as cwCreateSchedule, deleteSchedule as cwDeleteSchedule } from "@reventlessdev/reventless-aws/src/adapter/ScheduledPublisher/ScheduledPublisher_CloudWatchEvents_Runtime.res.mjs";
-
-function buildHandler() {
-  const configStr = process.env["HANDLER_CONFIG"] || "{}";
-  const config = JSON.parse(configStr);
-
-  const patchedSpec = patchSpecId(PluginExtensionPointSpec);
-
-  // Reconstruct runtimeOps — only sendMessageToChannel is used by this
-  // Lambda's incoming-command path (ForwardCommand). Cross-plugin
-  // subscribe / unsubscribe directives were retired in Phase 3 Step 3.
-  const runtimeOps = {
-    messagePublish: { sendMessageToChannel: sendMessage },
-  };
-
-  // Instantiate Plugin EP mapping. updateApiSchema and manageSubscriptions are
-  // admin-only hooks; this Lambda only handles incoming commands (Heartbeat,
-  // ForwardCommand) so they stay undefined here.
-  //
-  // `environment` prefixes the disconnect schedule's EventBridge rule name, so it
-  // must be stable across deploys and unique per stack. The stack name is both;
-  // AWS_LAMBDA_FUNCTION_NAME is neither — it carries a content hash, so replacing
-  // this Lambda would orphan every outstanding rule the previous generation
-  // created. EventCollectorEntryPoint instantiates the same EP module and must
-  // agree, or one Lambda creates rules the other cannot delete.
-  const environment = process.env["Environment"] || "unknown";
-  const pluginModule = pluginEPPluginMake({
-    runtimeOps,
-    environment,
-    updateApiSchema: undefined,
-    manageSubscriptions: undefined,
-  });
-  const mappingsModule = { mappings: [pluginModule.Mapping] };
-
-  // Reconstruct publishToAggregates. The deploy-side builder writes
-  // HANDLER_CONFIG.publishToAggregates as { aggregateName: envVarName }
-  // (see PluginExtensionPointRuntime_Builder.res), so iterate accordingly.
-  const publishToAggregates = {};
-  for (const [aggName, envVarName] of Object.entries(config.publishToAggregates || {})) {
-    const queueUrl = process.env[envVarName] || "";
-    publishToAggregates[aggName] = sqsPublishJsons(makeQueueRef(queueUrl), "SQS_FIFO");
-  }
-
-  // Reconstruct queryEngine
-  const queryEngine = {
-    scan: (readModelName, filterConfigs, limit) => scanByTableName(config.pluginReadModelTableName, filterConfigs, limit),
-    query: async () => { throw new Error("QueryEngine.query not available in bundled Plugin EP handler"); },
-  };
-
-  // Reconstruct scheduler
-  const scheduler = {
-    createSchedule: cwCreateSchedule(config.schedulerRoleArn),
-    deleteSchedule: cwDeleteSchedule,
-  };
-
-  // CommandTopic resources for scheduler targets
-  const commandTopicResources = config.schedulerQueueArn !== ""
-    ? [{
-        name: config.schedulerQueueName,
-        id: config.schedulerQueueName,
-        urn: config.schedulerQueueArn,
-        service: "unknown",
-        resourceInfo: "NoInfo",
-        role: "",
-        region: "",
-        resourceType: "",
-        configuration: {},
-        tags: {},
-      }]
-    : [];
-
-  const invalidNameChars = /[^.\-_a-zA-Z0-9]/g;
-  const resourceNaming = {
-    validateName: (n) => n.replace(invalidNameChars, "_"),
-    urnName: (arn) => { const parts = arn.split(":"); return parts[5] || "unknown"; },
-  };
-
-  const callbackConfig = { publishToAggregates, commandTopicResources, scheduler, queryEngine, resourceNaming };
-  const callback = extensionPointCallbackMake(callbackConfig)(patchedSpec)(mappingsModule);
-  const commandTopicCallback = commandTopicCallbackMake(patchedSpec)({
-    Spec: patchedSpec,
-    commandsHandler: callback.handleIncomingCommands,
-  });
-
-  return {
-    sqsHandler: handleQueueEvent(makeQueueRef(config.queueUrl), commandTopicCallback.handleJsonCommands),
-    comp: `ExtensionPoint(${patchedSpec.name})`,
-  };
-}
-
-const { sqsHandler, comp } = buildHandler();
-
-export async function handler(event, context) {
-  setRequestId(context?.awsRequestId);
-  const records = event.Records || [];
-
-  log.debug("processing " + records.length.toString() + " record(s)", { comp: "PluginExtensionPointRuntime" });
-  await runEffect(sqsHandler(event, context), {
-    correlationId: extractMetaField(records, "correlationId"),
-    causationId: extractMetaField(records, "causationId"),
-    comp,
-    timestamp: extractSentTimestamp(records),
-    retryCount: extractRetryCount(records),
-  });
-  return "";
-}