@reventlessdev/reventless-aws 3.0.0-alpha.206 → 3.0.0-alpha.208

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.208 (2026-07-13)
+
+### Bug Fixes
+
+* **admin:** materialise ApiSchemaPush Source.Id at runtime (part 2) ([e64eeae](https://github.com/ReventlessDev/reventless-core/commit/e64eeae9fd08c03dcadf600aac733840790772e4)), closes [#9](https://github.com/ReventlessDev/reventless-core/issues/9) [#10](https://github.com/ReventlessDev/reventless-core/issues/10)
+
+
+# 3.0.0-alpha.207 (2026-07-13)
+
+### Bug Fixes
+
+* **admin:** materialise ApiSchemaPush SideEffect Source at runtime ([57a61d9](https://github.com/ReventlessDev/reventless-core/commit/57a61d98fa11dfe3de188cc299c89abdeea41457))
+
+
 # 3.0.0-alpha.206 (2026-07-13)
 
 **Note:** Version bump only for package @reventlessdev/reventless-aws

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.206",
+  "version": "3.0.0-alpha.208",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -8,16 +8,16 @@
     "@aws-sdk/client-cloudfront": "3.970.0",
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
-    "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.21",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.27",
-    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.50",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.7",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.15",
+    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.50",
+    "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.21",
     "@reventlessdev/rescript-uuid": "1.1.0-alpha.15",
     "@reventlessdev/reventless-core": "3.0.0-alpha.164",
-    "@reventlessdev/reventless-infra": "3.0.0-alpha.98",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.28",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.26",
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.28",
+    "@reventlessdev/reventless-infra": "3.0.0-alpha.98",
     "@reventlessdev/reventless-spec": "3.0.0-alpha.76"
   },
   "devDependencies": {

package/src/Platform.res.mjs

@@ -1287,9 +1287,9 @@ function MakeWithConfig(Config) {
     ]).apply(param => {
       AdminApiSchemaPushHandler.make("AdminApiSchemaPush", [{
           Source: {
-            name: ApiFragmentRegistrySpec$ReventlessCore.name,
-            Id: Id$Reventless.$$String,
-            eventSchema: ApiFragmentRegistrySpec$ReventlessCore.eventSchema
+            name: ApiSchemaPush$ReventlessAws.Source.name,
+            Id: ApiSchemaPush$ReventlessAws.Source.Id,
+            eventSchema: ApiSchemaPush$ReventlessAws.Source.eventSchema
           },
           moduleUrl: ApiSchemaPush$ReventlessAws.moduleUrl,
           execute: ApiSchemaPush$ReventlessAws.execute
@@ -2707,9 +2707,9 @@ function Make($star) {
     ]).apply(param => {
       AdminApiSchemaPushHandler.make("AdminApiSchemaPush", [{
           Source: {
-            name: ApiFragmentRegistrySpec$ReventlessCore.name,
-            Id: Id$Reventless.$$String,
-            eventSchema: ApiFragmentRegistrySpec$ReventlessCore.eventSchema
+            name: ApiSchemaPush$ReventlessAws.Source.name,
+            Id: ApiSchemaPush$ReventlessAws.Source.Id,
+            eventSchema: ApiSchemaPush$ReventlessAws.Source.eventSchema
           },
           moduleUrl: ApiSchemaPush$ReventlessAws.moduleUrl,
           execute: ApiSchemaPush$ReventlessAws.execute

package/src/adapter/Api/ApiSchemaPush.res

@@ -14,7 +14,32 @@
 // is loaded via dynamic import so no @aws-sdk / provider code is statically captured
 // beyond what the SideEffectHandler Lambda already bundles (runtime-purity — see
 // reference_pulumi_leaks_into_lambda_runtime_graph).
-module Source = ReventlessCore.ApiFragmentRegistrySpec
+module Spec = ReventlessCore.ApiFragmentRegistrySpec
+
+// Source is built EXPLICITLY rather than aliasing/including the spec. SideEffectHandler_Callback
+// reads Source.{name,eventSchema,Id.schema} reflectively off this module's compiled export at
+// Lambda cold start, but the spec uses these only at the TYPE level, so ReScript dead-shakes
+// them: a bare `module Source = Spec` alias erases the whole binding to `let Source;`, and even
+// the spec's own @@reventless.spec-injected `module Id` compiles to `let Id;` (undefined) — the
+// cross-module runtime reflection is invisible to ReScript's optimiser (deploy-time is fine
+// because Platform.res hand-wires these values). Both surfaced on deploy as "Cannot read
+// properties of undefined (reading 'eventSchema' / 'schema')". Forwarding name/eventSchema (real
+// spec exports) and re-binding Id (String — the singleton registry id, matching Platform.res's
+// hand-wiring) materialises all three, while the type aliases keep full transparency for the
+// pattern match below.
+module Source = {
+  type event = Spec.event
+  type fragmentSnapshotEntry = Spec.fragmentSnapshotEntry
+  // `include` (not `module Id = Reventless.Id.String`) — a bare module alias compiles to
+  // `Id: undefined` in the Source record (Id is only type-projected via Source.Id.t), and
+  // SideEffectHandler_Callback's `Source.Id.schema` reflective read crashes at cold start.
+  // `include` materialises the Id module's runtime values into the record.
+  module Id = {
+    include Reventless.Id.String
+  }
+  let name = Spec.name
+  let eventSchema = Spec.eventSchema
+}
 
 let moduleUrl: string = %raw(`import.meta.url`)
 

package/src/adapter/Api/ApiSchemaPush.res.mjs

@@ -1,5 +1,31 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
+import * as Id$Reventless from "@reventlessdev/reventless-spec/src/types/Id.res.mjs";
+import * as ApiFragmentRegistrySpec$ReventlessCore from "@reventlessdev/reventless-core/src/admin/ApiFragmentRegistry/ApiFragmentRegistrySpec.res.mjs";
+
+let Id_schema = Id$Reventless.$$String.schema;
+
+let Id_make = Id$Reventless.$$String.make;
+
+let Id_makeFromString = Id$Reventless.$$String.makeFromString;
+
+let Id_toString = Id$Reventless.$$String.toString;
+
+let Id_cmp = Id$Reventless.$$String.cmp;
+
+let Id = {
+  schema: Id_schema,
+  make: Id_make,
+  makeFromString: Id_makeFromString,
+  toString: Id_toString,
+  cmp: Id_cmp
+};
+
+let Source = {
+  Id: Id,
+  name: ApiFragmentRegistrySpec$ReventlessCore.name,
+  eventSchema: ApiFragmentRegistrySpec$ReventlessCore.eventSchema
+};
 
 let moduleUrl = import.meta.url;
 
@@ -26,9 +52,10 @@ async function execute(_id, _meta, event, _queryEngine) {
   return await pushApiSchema(jsSnapshot);
 }
 
-let Source;
+let Spec;
 
 export {
+  Spec,
   Source,
   moduleUrl,
   pushApiSchema,

package/tests/ApiSchemaPushTest.res

@@ -0,0 +1,32 @@
+// Regression guard for the ApiSchemaPush SideEffect "Source erasure" deploy-only bug.
+//
+// SideEffectHandler_Callback.Make reads Source.{name,eventSchema,Id} reflectively off
+// the imported ApiSchemaPush module at Lambda cold start. ApiSchemaPush only uses Source
+// at the TYPE level, so a bare `module Source = …` alias gets dead-shaken by ReScript to
+// `let Source;` (undefined) — crashing the handler with "Cannot read properties of
+// undefined (reading 'eventSchema')" and hanging the deploy waiter. The `include` in
+// ApiSchemaPush.res materialises Source's runtime values. These assertions dereference
+// exactly the fields the runtime reads, so a regression (alias reintroduced) fails here
+// instead of only on a live deploy.
+
+open JestGlobals
+
+describe("ApiSchemaPush SideEffect Source (runtime materialisation)", () => {
+  testSync("Source.name is the registry aggregate name", () => {
+    expect(ApiSchemaPush.Source.name)->toBe("ApiFragmentRegistry")
+  })
+
+  testSync("Source.eventSchema is a live schema — extractAllVariantNames succeeds", () => {
+    // Mirrors SideEffectHandler_Callback.Make: throws if Source is erased to undefined.
+    let tags = Reventless.DcbTag.extractAllVariantNames(ApiSchemaPush.Source.eventSchema)
+    expect(tags)->toContain("ApiSchemaComputed")
+  })
+
+  testSync("Source.Id is a live module — the reflective id round-trip does not crash", () => {
+    // SideEffectHandler_Callback reads `Source.Id.schema` on the id-bearing registry events.
+    // A bare `module Id` alias compiles to `Id: undefined` in the Source record, so any access
+    // (makeFromString/toString/schema) throws "reading 'schema'"/undefined on a regression.
+    let id = "registry"->ApiSchemaPush.Source.Id.makeFromString
+    expect(id->ApiSchemaPush.Source.Id.toString)->toBe("registry")
+  })
+})

package/tests/ApiSchemaPushTest.res.mjs

@@ -0,0 +1,20 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as DcbTag$Reventless from "@reventlessdev/reventless-spec/src/components/DcbTag.res.mjs";
+import * as ApiSchemaPush$ReventlessAws from "../src/adapter/Api/ApiSchemaPush.res.mjs";
+
+globalThis.describe("ApiSchemaPush SideEffect Source (runtime materialisation)", () => {
+  globalThis.test("Source.name is the registry aggregate name", () => {
+    globalThis.expect(ApiSchemaPush$ReventlessAws.Source.name).toBe("ApiFragmentRegistry");
+  });
+  globalThis.test("Source.eventSchema is a live schema — extractAllVariantNames succeeds", () => {
+    let tags = DcbTag$Reventless.extractAllVariantNames(ApiSchemaPush$ReventlessAws.Source.eventSchema);
+    globalThis.expect(tags).toContain("ApiSchemaComputed");
+  });
+  globalThis.test("Source.Id is a live module — the reflective id round-trip does not crash", () => {
+    let id = ApiSchemaPush$ReventlessAws.Source.Id.makeFromString("registry");
+    globalThis.expect(ApiSchemaPush$ReventlessAws.Source.Id.toString(id)).toBe("registry");
+  });
+});
+
+/*  Not a pure module */