@reventlessdev/reventless-aws 3.0.0-alpha.183 → 3.0.0-alpha.184

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.184 (2026-07-08)
+
+### Bug Fixes
+
+* **reventless-aws:** exclude internal rows from Platform_Plugins connection scan ([df14af2](https://github.com/ReventlessDev/reventless-core/commit/df14af2cbd70d49062f2afc03418cdbf18d151d6))
+
+
 # 3.0.0-alpha.183 (2026-07-08)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.183",
+  "version": "3.0.0-alpha.184",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -11,7 +11,7 @@
     "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.20",
     "@reventlessdev/rescript-effect": "0.1.0-alpha.25",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.6",
-    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.46",
+    "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.47",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.14",
     "@reventlessdev/rescript-uuid": "1.1.0-alpha.14",
     "@reventlessdev/reventless-core": "3.0.0-alpha.145",

package/src/adapter/QueryDb/QueryDbResolvers_AppSync.res

@@ -57,6 +57,17 @@ export function response(ctx) {
 }
 `->Pulumi.Input.make
 
+/** The discriminator attribute whose absence marks an internal bookkeeping row for a
+    read model whose physical DynamoDB table co-hosts rows written outside the projection.
+    Only the Plugins admin RM has this: its table also holds `deploy-schema:*` /
+    `plugin-info:*` / `deploy-schema-hash:*` rows (Platform.res preResolversSchemaHook)
+    that carry no `name`. Returning `Some(attr)` makes the Connection Scan emit an
+    `attribute_exists(#attr)` filter so those rows never reach the non-null GraphQL schema.
+    `name` is the already-capitalized read-model name (spec name, e.g. "Plugins").
+    See docs/plans/platform-plugins-admin-connection-null-rows.md. */
+let internalRowRequiredAttr = (name: string): option<string> =>
+  name == "Plugins" ? Some("name") : None
+
 let make: ReventlessCore.QueryDb_Adapter.resolversMaker<api, role> = (
   ~name: string,
   ~api: api,
@@ -217,6 +228,15 @@ let make: ReventlessCore.QueryDb_Adapter.resolversMaker<api, role> = (
       )->Array.forEach(msg => log.warn(~comp="QueryDbResolvers_AppSync", msg))
     | None => ()
     }
+    // The Plugins admin RM's DynamoDB table co-hosts deploy-time infra rows
+    // (`deploy-schema:<name>`, `plugin-info:<name>`, `deploy-schema-hash:<apiId>`)
+    // written directly by the platform (Platform.res preResolversSchemaHook), not by
+    // the projection. Those rows carry no `name` attribute, so an unfiltered Scan
+    // resolves `name: String!` to null → non-null violation that nulls the entire
+    // Platform_PluginConnection. Exclude them with an `attribute_exists(#name)` filter
+    // (prefix-agnostic: real plugin rows always carry `name`, internal rows never do).
+    // See docs/plans/platform-plugins-admin-connection-null-rows.md.
+    let requireAttribute = internalRowRequiredAttr(name)
     let resolverAll = makeQueryResolver(
       ~resolverName=fieldNameForAll->String.capitalize,
       ~field=fieldNameForAll->Pulumi.Input.make,
@@ -226,6 +246,7 @@ let make: ReventlessCore.QueryDb_Adapter.resolversMaker<api, role> = (
           ~filterFields=filterFieldNames,
           ~rangeFields=rangeFieldNames,
           ~sortFields=sortFieldNames,
+          ~requireAttribute?,
         )
       } else {
         Resolver.Functions.listAllItems

package/src/adapter/QueryDb/QueryDbResolvers_AppSync.res.mjs

@@ -58,6 +58,12 @@ export function response(ctx) {
 `;
 }
 
+function internalRowRequiredAttr(name) {
+  if (name === "Plugins") {
+    return "name";
+  }
+}
+
 function make(name, api, apiRole, dataSourceName, indexes, subIdField, idResolverConfigs, idsResolverConfigs, param, opts) {
   let name$1 = Stdlib_String.capitalize(name);
   let registryEntry = Plugin_Helpers$ReventlessCore.queryFieldNamesRegistry[name$1];
@@ -100,7 +106,8 @@ function make(name, api, apiRole, dataSourceName, indexes, subIdField, idResolve
       ).concat(Stdlib_Array.filterMap(indexes, param => param.subIdField));
       GraphQL_FragmentGenerator$ReventlessCore.validateScanSortAlignment(stateSchemaOpt, name$1, knownSortFields).forEach(msg => log.warn("QueryDbResolvers_AppSync", undefined, msg));
     }
-    let resolverAll = makeQueryResolver(Stdlib_String.capitalize(fieldNameForAll), fieldNameForAll, connectionSpec ? AppSync_Resolver_Functions$PulumiAws.listAllItemsConnection(labelField, filterFieldNames, rangeFieldNames, sortFieldNames) : AppSync_Resolver_Functions$PulumiAws.listAllItems);
+    let requireAttribute = internalRowRequiredAttr(name$1);
+    let resolverAll = makeQueryResolver(Stdlib_String.capitalize(fieldNameForAll), fieldNameForAll, connectionSpec ? AppSync_Resolver_Functions$PulumiAws.listAllItemsConnection(labelField, filterFieldNames, rangeFieldNames, sortFieldNames, requireAttribute) : AppSync_Resolver_Functions$PulumiAws.listAllItems);
     let resolversByIndex = indexes.map(indexConfig => {
       let index = indexConfig.index;
       let stripLeadingBy = s => {
@@ -238,6 +245,7 @@ export {
   log,
   queryInterceptorConfig,
   interceptorCode,
+  internalRowRequiredAttr,
   make,
 }
 /* log Not a pure module */

package/tests/QueryDbResolvers_AppSyncTest.res

@@ -0,0 +1,40 @@
+open JestGlobals
+
+// Regression guard for docs/plans/platform-plugins-admin-connection-null-rows.md:
+// the Plugins admin RM shares its DynamoDB table with internal bookkeeping rows
+// (`deploy-schema:*`, `plugin-info:*`, `deploy-schema-hash:*`) that carry no `name`.
+// The auto-generated Connection Scan must exclude them, or `name: String!` resolves
+// to null and nulls the entire Platform_PluginConnection ("No data" on the page).
+
+// `Pulumi.Input.make` is `%identity`, so a generated resolver's `Pulumi.Input.t<string>`
+// IS the underlying JS string — recover it with Obj.magic for assertion.
+let codeOf = (input: Pulumi.Input.t<string>): string => Obj.magic(input)
+
+describe("QueryDbResolvers_AppSync.internalRowRequiredAttr", () => {
+  testSync("Plugins RM requires the `name` discriminator", () => {
+    expect(QueryDbResolvers_AppSync.internalRowRequiredAttr("Plugins"))->toEqual(Some("name"))
+  })
+
+  testSync("ordinary read models require nothing (unchanged behaviour)", () => {
+    expect(QueryDbResolvers_AppSync.internalRowRequiredAttr("Products"))->toEqual(None)
+    expect(QueryDbResolvers_AppSync.internalRowRequiredAttr("Orders"))->toEqual(None)
+  })
+})
+
+describe("AppSync_Resolver_Retrying.Functions.listAllItemsConnection", () => {
+  testSync("with ~requireAttribute emits an attribute_exists filter that excludes internal rows", () => {
+    let code =
+      AppSync_Resolver_Retrying.Functions.listAllItemsConnection(
+        ~labelField="name",
+        ~requireAttribute="name",
+      )->codeOf
+    expect(code->String.includes("attribute_exists(#name)"))->toBe(true)
+    expect(code->String.includes("names['#name'] = 'name'"))->toBe(true)
+  })
+
+  testSync("without ~requireAttribute emits no attribute_exists filter (default read models unchanged)", () => {
+    let code =
+      AppSync_Resolver_Retrying.Functions.listAllItemsConnection(~labelField="name")->codeOf
+    expect(code->String.includes("attribute_exists"))->toBe(false)
+  })
+})

package/tests/QueryDbResolvers_AppSyncTest.res.mjs

@@ -0,0 +1,35 @@
+// Generated by ReScript, PLEASE EDIT WITH CARE
+
+import * as AppSync_Resolver_Functions$PulumiAws from "@reventlessdev/rescript-pulumi-aws/src/AppSync/AppSync_Resolver_Functions.res.mjs";
+import * as QueryDbResolvers_AppSync$ReventlessAws from "../src/adapter/QueryDb/QueryDbResolvers_AppSync.res.mjs";
+
+function codeOf(input) {
+  return input;
+}
+
+globalThis.describe("QueryDbResolvers_AppSync.internalRowRequiredAttr", () => {
+  globalThis.test("Plugins RM requires the `name` discriminator", () => {
+    globalThis.expect(QueryDbResolvers_AppSync$ReventlessAws.internalRowRequiredAttr("Plugins")).toEqual("name");
+  });
+  globalThis.test("ordinary read models require nothing (unchanged behaviour)", () => {
+    globalThis.expect(QueryDbResolvers_AppSync$ReventlessAws.internalRowRequiredAttr("Products")).toEqual(undefined);
+    globalThis.expect(QueryDbResolvers_AppSync$ReventlessAws.internalRowRequiredAttr("Orders")).toEqual(undefined);
+  });
+});
+
+globalThis.describe("AppSync_Resolver_Retrying.Functions.listAllItemsConnection", () => {
+  globalThis.test("with ~requireAttribute emits an attribute_exists filter that excludes internal rows", () => {
+    let code = AppSync_Resolver_Functions$PulumiAws.listAllItemsConnection("name", undefined, undefined, undefined, "name");
+    globalThis.expect(code.includes("attribute_exists(#name)")).toBe(true);
+    globalThis.expect(code.includes("names['#name'] = 'name'")).toBe(true);
+  });
+  globalThis.test("without ~requireAttribute emits no attribute_exists filter (default read models unchanged)", () => {
+    let code = AppSync_Resolver_Functions$PulumiAws.listAllItemsConnection("name", undefined, undefined, undefined, undefined);
+    globalThis.expect(code.includes("attribute_exists")).toBe(false);
+  });
+});
+
+export {
+  codeOf,
+}
+/*  Not a pure module */