@reventlessdev/reventless-aws 3.0.0-alpha.182 → 3.0.0-alpha.183

package/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# 3.0.0-alpha.183 (2026-07-08)
+
+### Bug Fixes
+
+* **reventless-aws:** stop admin-base schema clobber of split-mode DomainApi ([afce85f](https://github.com/ReventlessDev/reventless-core/commit/afce85fa57474735cea3dcb1c2a151c2d8804f0e))
+
+
 # 3.0.0-alpha.182 (2026-07-07)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reventlessdev/reventless-aws",
-  "version": "3.0.0-alpha.182",
+  "version": "3.0.0-alpha.183",
   "description": "AWS adapters for Reventless",
   "license": "Apache-2.0",
   "dependencies": {
@@ -9,16 +9,16 @@
     "sury": "11.0.0-alpha.4",
     "uuid": "^13.0.0",
     "@reventlessdev/rescript-aws-sdk": "2.2.0-alpha.20",
+    "@reventlessdev/rescript-effect": "0.1.0-alpha.25",
     "@reventlessdev/rescript-jest": "1.0.0-alpha.6",
     "@reventlessdev/rescript-pulumi-aws": "2.4.0-alpha.46",
-    "@reventlessdev/rescript-effect": "0.1.0-alpha.25",
     "@reventlessdev/rescript-pulumi-pulumi": "2.3.0-alpha.14",
     "@reventlessdev/rescript-uuid": "1.1.0-alpha.14",
-    "@reventlessdev/reventless-core": "3.0.0-alpha.144",
+    "@reventlessdev/reventless-core": "3.0.0-alpha.145",
     "@reventlessdev/reventless-infra": "3.0.0-alpha.90",
     "@reventlessdev/reventless-interop": "3.0.0-alpha.24",
-    "@reventlessdev/reventless-spec": "3.0.0-alpha.68",
-    "@reventlessdev/reventless-postgres": "3.0.0-alpha.8"
+    "@reventlessdev/reventless-postgres": "3.0.0-alpha.9",
+    "@reventlessdev/reventless-spec": "3.0.0-alpha.68"
   },
   "devDependencies": {
     "rescript": "^12.3.0",

package/src/Platform.res

@@ -689,37 +689,56 @@ module MakeWithConfig = (
     //   - split mode: platformApi from splitApiOutputsRef
     //   - unified mode / not-yet-populated: domainApi
     preAdminResolversSchemaHook: (~adminBarrier) => {
-      let targetApi = switch splitApiOutputsRef.contents {
-      | Some({platformApi}) => platformApi
-      | None => domainApi
+      // The admin-base SDL stitches AdminApi.baseFragment with an EMPTY plugin
+      // list, and startSchemaCreation REPLACES the whole schema. In split mode
+      // the admin schema belongs on the PlatformApi ONLY — the DomainApi carries
+      // plugin fields (emptyBaseFragment). If we pushed the admin-base-only SDL
+      // to the DomainApi it would wipe every plugin field, leaving exactly the
+      // admin-base set (the alpha 2026-07-08 clobber). So in split mode we push
+      // ONLY when the PlatformApi is known; if the ref is not yet populated we
+      // SKIP (never fall back to domainApi). Unified mode legitimately shares one
+      // API, so an unpopulated ref there means domainApi.
+      let targetApiOpt = switch (Config.splitApi, splitApiOutputsRef.contents) {
+      | (_, Some({platformApi})) => Some(platformApi)
+      | (false, None) => Some(domainApi)
+      | (true, None) => None
       }
-      let adminBaseFragment = AppSync_Adapter.injectAwsAuthAll(
-        ReventlessCore.AdminApi.baseFragment(~cloner=Config.cloner),
-        ~group="Admin",
-      )
-      let sdl = ReventlessCore.GraphQL_Stitcher.stitch(
-        ~baseFragment=adminBaseFragment,
-        ~pluginFragments=[],
-      )->AppSync_Adapter.stampSharedIamTypes
-      (targetApi, adminBarrier)
-      ->Pulumi.Output.all2
-      ->Pulumi.Output.flatMap(((api, _)) =>
-        api.id->Pulumi.Output.flatMap(apiId => {
-          log.info(~comp="preAdminResolversSchemaHook", `Pushing admin schema to ${apiId}`)
-          let client = AppSync_Adapter.getClient()
-          client
-          ->AppSync_Adapter.startSchemaCreationRetrying({apiId, definition: sdl})
-          ->Promise.then(async _ => {
-            log.info(
-              ~comp="preAdminResolversSchemaHook",
-              "startSchemaCreation called, waiting for ACTIVE",
-            )
-            await AppSync_Adapter.waitForSchemaActive(client, apiId)
-            log.info(~comp="preAdminResolversSchemaHook", "schema is ACTIVE")
+      switch targetApiOpt {
+      | None =>
+        log.error(
+          ~comp="preAdminResolversSchemaHook",
+          "split mode but the PlatformApi is not available at hook time — SKIPPING the admin schema push to avoid clobbering the DomainApi (pushing admin-base here would wipe every plugin field)",
+        )
+        adminBarrier
+      | Some(targetApi) =>
+        let adminBaseFragment = AppSync_Adapter.injectAwsAuthAll(
+          ReventlessCore.AdminApi.baseFragment(~cloner=Config.cloner),
+          ~group="Admin",
+        )
+        let sdl = ReventlessCore.GraphQL_Stitcher.stitch(
+          ~baseFragment=adminBaseFragment,
+          ~pluginFragments=[],
+        )->AppSync_Adapter.stampSharedIamTypes
+        (targetApi, adminBarrier)
+        ->Pulumi.Output.all2
+        ->Pulumi.Output.flatMap(((api, _)) =>
+          api.id->Pulumi.Output.flatMap(apiId => {
+            log.info(~comp="preAdminResolversSchemaHook", `Pushing admin schema to ${apiId}`)
+            let client = AppSync_Adapter.getClient()
+            client
+            ->AppSync_Adapter.startSchemaCreationRetrying({apiId, definition: sdl})
+            ->Promise.then(async _ => {
+              log.info(
+                ~comp="preAdminResolversSchemaHook",
+                "startSchemaCreation called, waiting for ACTIVE",
+              )
+              await AppSync_Adapter.waitForSchemaActive(client, apiId)
+              log.info(~comp="preAdminResolversSchemaHook", "schema is ACTIVE")
+            })
+            ->Pulumi.Output.fromPromise
           })
-          ->Pulumi.Output.fromPromise
-        })
-      )
+        )
+      }
     },
 
     // Accumulate fragments across independent plugin deployments: each plugin
@@ -957,26 +976,44 @@ module MakeWithConfig = (
                   ~sdl=s,
                   ~typeName="Subscription",
                 )
+              // Identity-aware drift check (not a bare count): the live schema is
+              // "intact" only when it is a SUPERSET of every root field we would
+              // push. Comparing name SETS heals equal-cardinality drift and field
+              // *swaps* — an admin-base clobber that leaves the DomainApi with the
+              // SAME number of root fields but the WRONG ones (admin-base instead
+              // of plugin fields) has a matching count yet is missing every
+              // expected plugin field, so a count test would wrongly skip.
+              let missingFields = ReventlessCore.GraphQL_Stitcher.missingRootFields(
+                ~expectedSdl=sdl,
+                ~liveSdl,
+              )
               let skipPush = switch storedHash {
               | Some(prev) if prev == currentHash =>
-                let expected = countRoots(sdl)
-                let live = countRoots(liveSdl)
                 if liveSdl == "" {
                   log.info(
                     ~comp="preResolversSchemaHook",
                     `hash matches but live schema could not be introspected — forcing repair push (check appsync:GetIntrospectionSchema permission)`,
                   )
                   false
-                } else if live < expected {
+                } else if missingFields->Array.length > 0 {
                   log.info(
                     ~comp="preResolversSchemaHook",
-                    `hash matches but live schema drifted (${live->Int.toString} root field(s) live vs ${expected->Int.toString} expected) — forcing repair push`,
+                    `hash matches but live schema is missing ${missingFields
+                      ->Array.length
+                      ->Int.toString} expected root field(s) (e.g. ${missingFields
+                      ->Array.slice(~start=0, ~end=5)
+                      ->Array.join(", ")}) — forcing repair push`,
                   )
                   false
                 } else {
                   log.info(
                     ~comp="preResolversSchemaHook",
-                    `SDL unchanged (hash ${currentHash->String.slice(~start=0, ~end=12)}…) and live schema intact (${live->Int.toString} root fields); skipping push`,
+                    `SDL unchanged (hash ${currentHash->String.slice(
+                        ~start=0,
+                        ~end=12,
+                      )}…) and live schema is a superset of the expected root fields (${countRoots(
+                        liveSdl,
+                      )->Int.toString} live); skipping push`,
                   )
                   true
                 }

package/src/Platform.res.mjs

@@ -645,23 +645,12 @@ function MakeWithConfig(Config) {
           let client = AppSync_Adapter$ReventlessAws.getClient();
           let liveSdl = await AppSync_Adapter$ReventlessAws.getIntrospectionSdl(client, apiId);
           let countRoots = s => (GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Mutation") + GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Query") | 0) + GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Subscription") | 0;
-          let skipPush;
-          if (storedHash !== undefined && storedHash === currentHash) {
-            let expected = countRoots(sdl);
-            let live = countRoots(liveSdl);
-            if (liveSdl === "") {
-              log.info("preResolversSchemaHook", undefined, `hash matches but live schema could not be introspected — forcing repair push (check appsync:GetIntrospectionSchema permission)`);
-              skipPush = false;
-            } else if (live < expected) {
-              log.info("preResolversSchemaHook", undefined, `hash matches but live schema drifted (` + live.toString() + ` root field(s) live vs ` + expected.toString() + ` expected) — forcing repair push`);
-              skipPush = false;
-            } else {
-              log.info("preResolversSchemaHook", undefined, `SDL unchanged (hash ` + currentHash.slice(0, 12) + `…) and live schema intact (` + live.toString() + ` root fields); skipping push`);
-              skipPush = true;
-            }
-          } else {
-            skipPush = false;
-          }
+          let missingFields = GraphQL_Stitcher$ReventlessCore.missingRootFields(sdl, liveSdl);
+          let skipPush = storedHash !== undefined && storedHash === currentHash ? (
+              liveSdl === "" ? (log.info("preResolversSchemaHook", undefined, `hash matches but live schema could not be introspected — forcing repair push (check appsync:GetIntrospectionSchema permission)`), false) : (
+                  missingFields.length !== 0 ? (log.info("preResolversSchemaHook", undefined, `hash matches but live schema is missing ` + missingFields.length.toString() + ` expected root field(s) (e.g. ` + missingFields.slice(0, 5).join(", ") + `) — forcing repair push`), false) : (log.info("preResolversSchemaHook", undefined, `SDL unchanged (hash ` + currentHash.slice(0, 12) + `…) and live schema is a superset of the expected root fields (` + countRoots(liveSdl).toString() + ` live); skipping push`), true)
+                )
+            ) : false;
           if (!skipPush) {
             if (GraphQL_Stitcher$ReventlessCore.isCatastrophicSchemaShrink(liveSdl, sdl, deploySchemaShrinkThreshold)) {
               return log.error("preResolversSchemaHook", undefined, `ABORTED schema push for ` + apiId + `: stitched SDL (` + countRoots(sdl).toString() + ` root field(s)) would catastrophically shrink the live schema (` + countRoots(liveSdl).toString() + ` root field(s), threshold ` + deploySchemaShrinkThreshold.toString() + `) — refusing to clobber resolvers (likely a stale concurrent-deploy scan)`);
@@ -692,24 +681,30 @@ function MakeWithConfig(Config) {
   };
   let hooks_preAdminResolversSchemaHook = adminBarrier => {
     let match = splitApiOutputsRef.contents;
-    let targetApi = match !== undefined ? match.platformApi : domainApi;
-    let adminBaseFragment = AppSync_Adapter$ReventlessAws.injectAwsAuthAll(AdminApi$ReventlessCore.baseFragment(Config.cloner), "Admin", undefined);
-    let sdl = AppSync_Adapter$ReventlessAws.stampSharedIamTypes(GraphQL_Stitcher$ReventlessCore.stitch(adminBaseFragment, []));
-    return Output$Pulumi.flatMap(Pulumi.all([
-      targetApi,
-      adminBarrier
-    ]), param => Output$Pulumi.flatMap(param[0].id, apiId => {
-      log.info("preAdminResolversSchemaHook", undefined, `Pushing admin schema to ` + apiId);
-      let client = AppSync_Adapter$ReventlessAws.getClient();
-      return AppSync_Adapter$ReventlessAws.startSchemaCreationRetrying(client, {
-        apiId: apiId,
-        definition: sdl
-      }).then(async () => {
-        log.info("preAdminResolversSchemaHook", undefined, "startSchemaCreation called, waiting for ACTIVE");
-        await AppSync_Adapter$ReventlessAws.waitForSchemaActive(client, apiId, undefined, undefined);
-        return log.info("preAdminResolversSchemaHook", undefined, "schema is ACTIVE");
-      });
-    }));
+    let targetApiOpt = match !== undefined ? match.platformApi : (
+        Config.splitApi ? undefined : domainApi
+      );
+    if (targetApiOpt !== undefined) {
+      let adminBaseFragment = AppSync_Adapter$ReventlessAws.injectAwsAuthAll(AdminApi$ReventlessCore.baseFragment(Config.cloner), "Admin", undefined);
+      let sdl = AppSync_Adapter$ReventlessAws.stampSharedIamTypes(GraphQL_Stitcher$ReventlessCore.stitch(adminBaseFragment, []));
+      return Output$Pulumi.flatMap(Pulumi.all([
+        targetApiOpt,
+        adminBarrier
+      ]), param => Output$Pulumi.flatMap(param[0].id, apiId => {
+        log.info("preAdminResolversSchemaHook", undefined, `Pushing admin schema to ` + apiId);
+        let client = AppSync_Adapter$ReventlessAws.getClient();
+        return AppSync_Adapter$ReventlessAws.startSchemaCreationRetrying(client, {
+          apiId: apiId,
+          definition: sdl
+        }).then(async () => {
+          log.info("preAdminResolversSchemaHook", undefined, "startSchemaCreation called, waiting for ACTIVE");
+          await AppSync_Adapter$ReventlessAws.waitForSchemaActive(client, apiId, undefined, undefined);
+          return log.info("preAdminResolversSchemaHook", undefined, "schema is ACTIVE");
+        });
+      }));
+    }
+    log.error("preAdminResolversSchemaHook", undefined, "split mode but the PlatformApi is not available at hook time — SKIPPING the admin schema push to avoid clobbering the DomainApi (pushing admin-base here would wipe every plugin field)");
+    return adminBarrier;
   };
   let hooks_inboundAppSyncResolverHook = param => InboundTranslationResolvers_AppSync$ReventlessAws.make(resolveHookedApi(), param.runtime, param.fieldNames, param.opts);
   let hooks_dcbAppSyncResolverHook = param => CommandGeneratorResolvers_AppSync$ReventlessAws.makeDcb(resolveHookedApi(), param.runtime, param.fieldNames, param.tags, param.opts);
@@ -1876,23 +1871,12 @@ function Make($star) {
           let client = AppSync_Adapter$ReventlessAws.getClient();
           let liveSdl = await AppSync_Adapter$ReventlessAws.getIntrospectionSdl(client, apiId);
           let countRoots = s => (GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Mutation") + GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Query") | 0) + GraphQL_Stitcher$ReventlessCore.countRootTypeFields(s, "Subscription") | 0;
-          let skipPush;
-          if (storedHash !== undefined && storedHash === currentHash) {
-            let expected = countRoots(sdl);
-            let live = countRoots(liveSdl);
-            if (liveSdl === "") {
-              log.info("preResolversSchemaHook", undefined, `hash matches but live schema could not be introspected — forcing repair push (check appsync:GetIntrospectionSchema permission)`);
-              skipPush = false;
-            } else if (live < expected) {
-              log.info("preResolversSchemaHook", undefined, `hash matches but live schema drifted (` + live.toString() + ` root field(s) live vs ` + expected.toString() + ` expected) — forcing repair push`);
-              skipPush = false;
-            } else {
-              log.info("preResolversSchemaHook", undefined, `SDL unchanged (hash ` + currentHash.slice(0, 12) + `…) and live schema intact (` + live.toString() + ` root fields); skipping push`);
-              skipPush = true;
-            }
-          } else {
-            skipPush = false;
-          }
+          let missingFields = GraphQL_Stitcher$ReventlessCore.missingRootFields(sdl, liveSdl);
+          let skipPush = storedHash !== undefined && storedHash === currentHash ? (
+              liveSdl === "" ? (log.info("preResolversSchemaHook", undefined, `hash matches but live schema could not be introspected — forcing repair push (check appsync:GetIntrospectionSchema permission)`), false) : (
+                  missingFields.length !== 0 ? (log.info("preResolversSchemaHook", undefined, `hash matches but live schema is missing ` + missingFields.length.toString() + ` expected root field(s) (e.g. ` + missingFields.slice(0, 5).join(", ") + `) — forcing repair push`), false) : (log.info("preResolversSchemaHook", undefined, `SDL unchanged (hash ` + currentHash.slice(0, 12) + `…) and live schema is a superset of the expected root fields (` + countRoots(liveSdl).toString() + ` live); skipping push`), true)
+                )
+            ) : false;
           if (!skipPush) {
             if (GraphQL_Stitcher$ReventlessCore.isCatastrophicSchemaShrink(liveSdl, sdl, deploySchemaShrinkThreshold)) {
               return log.error("preResolversSchemaHook", undefined, `ABORTED schema push for ` + apiId + `: stitched SDL (` + countRoots(sdl).toString() + ` root field(s)) would catastrophically shrink the live schema (` + countRoots(liveSdl).toString() + ` root field(s), threshold ` + deploySchemaShrinkThreshold.toString() + `) — refusing to clobber resolvers (likely a stale concurrent-deploy scan)`);
@@ -1923,24 +1907,28 @@ function Make($star) {
   };
   let hooks_preAdminResolversSchemaHook = adminBarrier => {
     let match = splitApiOutputsRef.contents;
-    let targetApi = match !== undefined ? match.platformApi : domainApi;
-    let adminBaseFragment = AppSync_Adapter$ReventlessAws.injectAwsAuthAll(AdminApi$ReventlessCore.baseFragment(false), "Admin", undefined);
-    let sdl = AppSync_Adapter$ReventlessAws.stampSharedIamTypes(GraphQL_Stitcher$ReventlessCore.stitch(adminBaseFragment, []));
-    return Output$Pulumi.flatMap(Pulumi.all([
-      targetApi,
-      adminBarrier
-    ]), param => Output$Pulumi.flatMap(param[0].id, apiId => {
-      log.info("preAdminResolversSchemaHook", undefined, `Pushing admin schema to ` + apiId);
-      let client = AppSync_Adapter$ReventlessAws.getClient();
-      return AppSync_Adapter$ReventlessAws.startSchemaCreationRetrying(client, {
-        apiId: apiId,
-        definition: sdl
-      }).then(async () => {
-        log.info("preAdminResolversSchemaHook", undefined, "startSchemaCreation called, waiting for ACTIVE");
-        await AppSync_Adapter$ReventlessAws.waitForSchemaActive(client, apiId, undefined, undefined);
-        return log.info("preAdminResolversSchemaHook", undefined, "schema is ACTIVE");
-      });
-    }));
+    let targetApiOpt = match !== undefined ? match.platformApi : undefined;
+    if (targetApiOpt !== undefined) {
+      let adminBaseFragment = AppSync_Adapter$ReventlessAws.injectAwsAuthAll(AdminApi$ReventlessCore.baseFragment(false), "Admin", undefined);
+      let sdl = AppSync_Adapter$ReventlessAws.stampSharedIamTypes(GraphQL_Stitcher$ReventlessCore.stitch(adminBaseFragment, []));
+      return Output$Pulumi.flatMap(Pulumi.all([
+        targetApiOpt,
+        adminBarrier
+      ]), param => Output$Pulumi.flatMap(param[0].id, apiId => {
+        log.info("preAdminResolversSchemaHook", undefined, `Pushing admin schema to ` + apiId);
+        let client = AppSync_Adapter$ReventlessAws.getClient();
+        return AppSync_Adapter$ReventlessAws.startSchemaCreationRetrying(client, {
+          apiId: apiId,
+          definition: sdl
+        }).then(async () => {
+          log.info("preAdminResolversSchemaHook", undefined, "startSchemaCreation called, waiting for ACTIVE");
+          await AppSync_Adapter$ReventlessAws.waitForSchemaActive(client, apiId, undefined, undefined);
+          return log.info("preAdminResolversSchemaHook", undefined, "schema is ACTIVE");
+        });
+      }));
+    }
+    log.error("preAdminResolversSchemaHook", undefined, "split mode but the PlatformApi is not available at hook time — SKIPPING the admin schema push to avoid clobbering the DomainApi (pushing admin-base here would wipe every plugin field)");
+    return adminBarrier;
   };
   let hooks_inboundAppSyncResolverHook = param => InboundTranslationResolvers_AppSync$ReventlessAws.make(resolveHookedApi(), param.runtime, param.fieldNames, param.opts);
   let hooks_dcbAppSyncResolverHook = param => CommandGeneratorResolvers_AppSync$ReventlessAws.makeDcb(resolveHookedApi(), param.runtime, param.fieldNames, param.tags, param.opts);