@revenexx/studio-integrations 3.0.1 → 3.0.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @revenexx/studio-integrations
 
+## 3.0.3
+
+### Patch Changes
+
+- 0ae03e4: A connection test the service refuses because a secret was left blank while the server or another setting changed no longer reads as a failed connection: the credential's detail view marks the secret's field with the reason and puts the cursor there, as it does for a refused save. The service no longer sends a stored secret to a server it was not entered for, so the secret has to be entered again.
+  
+  A save that makes the service drop a credential's consent (other settings on an OAuth credential) now says that the credential has to be reconnected, and no longer runs a connection test that could only fail.
+
+## 3.0.2
+
+### Patch Changes
+
+- 1c65e26: A run started from the editor in waiting mode that fails now says "Sync run failed", as promised, instead of passing on the service's own "Workflow execution failed.".
+- 7c148a6: "Keep editing" in the question about leaving unsaved work is readable in every host, the cockpit included. Under `@revenexx/studio` 0.2.2 and 0.2.3 the design system painted the outline variant's white face over the label, so the fix in PO-415 only showed in the playground. The answer is now a plain filled button and still holds the keyboard when the question opens. The design-system peer moves to `^0.2.10`, the version the cockpit runs.
+- 9277849: A step test that ends on the node's error output is announced as failed — "Test of “Fetch orders” failed" — with the node's own message under it, such as "unauthorized access" when a service refuses the token. Before, it got the same green "Test run finished" as a step that worked, and the reason stood only in the output's JSON. The notice names the step because the answer can arrive after you have moved to another one. A node that ends on its error output without a message is still announced as failed, and the notice says it gave no reason (PO-651).
+
 ## 3.0.1
 
 ### Patch Changes

package/dist/module.json

@@ -1,7 +1,7 @@
 {
   "name": "@revenexx/studio-integrations",
   "configKey": "studioIntegrations",
-  "version": "3.0.1",
+  "version": "3.0.3",
   "builder": {
     "@nuxt/module-builder": "1.0.3",
     "unbuild": "unknown"

package/dist/runtime/components/Integrations/CredentialDetailDialog.vue

@@ -134,6 +134,12 @@ async function runTest() {
     const payload = buildConfigPayload();
     const edited = credentialEditDiffers(fieldsOf(props.type), payload, props.credential.public_config ?? {});
     const result = await test(props.credential.id, edited ? payload : void 0);
+    if (result.refusal) {
+      if (opening !== viewOpening) return;
+      saveRefusal.value = result.refusal;
+      void focusFirstRefusedField();
+      return;
+    }
     if (result.recorded !== false) {
       await load(true);
       emit("changed");
@@ -156,11 +162,13 @@ async function save() {
   const payload = buildConfigPayload();
   const edited = credentialEditDiffers(fieldsOf(props.type), payload, props.credential.public_config ?? {});
   try {
-    await update(id, { name: form.name.trim(), config: payload });
+    const wasConnected = props.credential.status !== "needs_reauth";
+    const updated = await update(id, { name: form.name.trim(), config: payload });
+    const lostConsent = wasConnected && updated.status === "needs_reauth";
     emit("changed");
     emit("update:open", false);
-    toast.success(t("integration.credentials.toast.updated"));
-    if (edited) void testSaved(id);
+    toast.success(t(lostConsent ? "integration.credentials.toast.updatedReconnect" : "integration.credentials.toast.updated"));
+    if (edited && !lostConsent) void testSaved(id);
   } catch (e) {
     saveRefusal.value = e;
     void focusFirstRefusedField();

package/dist/runtime/components/Integrations/NodeInspector.vue

@@ -886,6 +886,17 @@ function toggleTestInput() {
   if (!testInputOpen.value && !testInputDraft.value) testInputDraft.value = defaultTestInput();
   testInputOpen.value = !testInputOpen.value;
 }
+function errorOutputTaken(branch, ports) {
+  if (!branch) return null;
+  if (branch === "error") return branch;
+  return ports.some((p) => p.name === branch && p.kind === "error") ? branch : null;
+}
+function errorOutputMessage(outputs, port) {
+  const error = outputs[port];
+  if (!error || typeof error !== "object") return null;
+  const message = error.message;
+  return typeof message === "string" ? message.trim() || null : null;
+}
 async function runTestStep() {
   const wn = draftNode.value;
   if (!wn || testRunning.value) return;
@@ -920,12 +931,20 @@ async function runTestStep() {
       }
     );
     testLogs.value = res.logs ?? [];
-    testOutputs.value = {
-      ...testOutputs.value,
-      [wn.id]: res.outputs && typeof res.outputs === "object" ? res.outputs : {}
-    };
+    const outputs = res.outputs && typeof res.outputs === "object" ? res.outputs : {};
+    testOutputs.value = { ...testOutputs.value, [wn.id]: outputs };
     outputView.value = "json";
-    toast.success(t("integration.nodeInspector.toast.testRunFinished"));
+    const nodeManifest = findManifest(wn.nodeSlug, wn.nodeVersion);
+    const failedOn = errorOutputTaken(res.branch, portsForNode(wn, nodeManifest, props.dynamicOutputs?.[wn.id]));
+    if (failedOn) {
+      const name = resolveDisplayName(wn.name) || resolveLocalized(nodeManifest?.name) || wn.nodeSlug;
+      toast.error(t("integration.nodeInspector.toast.testRunFailed", { name }), {
+        description: errorOutputMessage(outputs, failedOn) ?? t("integration.nodeInspector.toast.testRunFailedNoMessage"),
+        duration: 8e3
+      });
+    } else {
+      toast.success(t("integration.nodeInspector.toast.testRunFinished"));
+    }
   } catch (e) {
     const body = e.body;
     testError.value = body?.error?.message ?? body?.message ?? e?.message ?? t("integration.nodeInspector.output.test.runFailed");

package/dist/runtime/components/Integrations/WorkflowIconView.d.vue.ts

@@ -4,7 +4,7 @@ type __VLS_Props = {
     size?: number;
 };
 declare const _default: import("vue").DefineComponent<__VLS_Props, {}, {}, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, {}, string, import("vue").PublicProps, Readonly<__VLS_Props> & Readonly<{}>, {
-    icon: WorkflowIcon | null;
     size: number;
+    icon: WorkflowIcon | null;
 }, {}, {}, {}, string, import("vue").ComponentProvideOptions, false, {}, any>;
 export default _default;

package/dist/runtime/components/Integrations/WorkflowIconView.vue.d.ts

@@ -4,7 +4,7 @@ type __VLS_Props = {
     size?: number;
 };
 declare const _default: import("vue").DefineComponent<__VLS_Props, {}, {}, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, {}, string, import("vue").PublicProps, Readonly<__VLS_Props> & Readonly<{}>, {
-    icon: WorkflowIcon | null;
     size: number;
+    icon: WorkflowIcon | null;
 }, {}, {}, {}, string, import("vue").ComponentProvideOptions, false, {}, any>;
 export default _default;

package/dist/runtime/composables/useIntegrationsCredentials.d.ts

@@ -1,4 +1,5 @@
 import type { Credential } from '../types/integrations.js';
+import { IntegrationsApiError } from '../utils/apiError.js';
 /**
  * Typed, per-tenant credential instances, backed by the Integrations service
  * (`/api/v1/credentials`). Secret field values are NEVER returned — the list
@@ -32,6 +33,12 @@ export interface CredentialTestResult {
      * test of an edit that tried values other than the stored ones (PO-535).
      */
     recorded?: boolean;
+    /**
+     * The refusal the service answered instead of testing, held as it arrived: values it
+     * would not try as given — a stored secret kept for a changed server (PO-765). A form
+     * marks the fields it names, as it does for a refused save.
+     */
+    refusal?: IntegrationsApiError;
 }
 export declare function useIntegrationsCredentials(): {
     credentials: any;

package/dist/runtime/composables/useIntegrationsCredentials.js

@@ -65,7 +65,8 @@ export function useIntegrationsCredentials() {
       );
       return res?.ok === false ? res : { ok: true, message: res?.message, recorded: res?.recorded };
     } catch (e) {
-      return { ok: false, error: errorReason(e, t("integration.credentials.error.testFailed")) };
+      const refusal = e instanceof IntegrationsApiError && e.status === 422 ? e : void 0;
+      return { ok: false, error: errorReason(e, t("integration.credentials.error.testFailed")), refusal };
     }
   }
   async function oauthAuthorizeUrl(id) {

package/dist/runtime/i18n/messages/de.json

@@ -198,7 +198,7 @@
   "integration.credentials.list.action.reconnect.aria": "{name} erneut verbinden",
   "integration.credentials.list.dialog.action.back": "Zurück",
   "integration.credentials.list.dialog.description.create": "Wählen Sie einen Typ und geben Sie die Zugangsdaten ein.",
-  "integration.credentials.list.dialog.description.edit": "Aktualisieren Sie die Zugangsdaten. Lassen Sie Secret-Felder leer, um den aktuellen Wert zu behalten.",
+  "integration.credentials.list.dialog.description.edit": "Aktualisieren Sie die Zugangsdaten. Lassen Sie Secret-Felder leer, um den aktuellen Wert zu behalten — das geht nicht, wenn sich der Server oder eine andere Angabe ändert.",
   "integration.credentials.list.dialog.field.name.placeholder": "z. B. Produktions-SMTP",
   "integration.credentials.list.empty": "Noch keine Zugangsdaten — mit „{action}“ das erste System verbinden.",
   "integration.credentials.list.head.title": "Zugangsdaten · Revenexx Cockpit",
@@ -294,6 +294,7 @@
   "integration.credentials.toast.created": "Zugangsdaten erstellt",
   "integration.credentials.toast.deleted": "Zugangsdaten gelöscht",
   "integration.credentials.toast.updated": "Zugangsdaten aktualisiert",
+  "integration.credentials.toast.updatedReconnect": "Zugangsdaten aktualisiert — verbinden Sie sie neu, um sie wieder zu nutzen",
   "integration.credentials.typePicker.empty": "Kein Zugangsdatentyp entspricht „{query}“.",
   "integration.credentials.typePicker.search.aria": "Nach einer App suchen",
   "integration.credentials.typePicker.search.placeholder": "Nach einer App suchen…",
@@ -818,6 +819,8 @@
   "integration.nodeInspector.toast.samplePinned": "Beispielausgabe angeheftet",
   "integration.nodeInspector.toast.secretCopied": "Secret kopiert",
   "integration.nodeInspector.toast.secretCopyFailed": "Secret konnte nicht kopiert werden",
+  "integration.nodeInspector.toast.testRunFailed": "Test von „{name}“ fehlgeschlagen",
+  "integration.nodeInspector.toast.testRunFailedNoMessage": "Der Schritt endete am Fehlerausgang, ohne einen Grund zu nennen.",
   "integration.nodeInspector.toast.testRunFinished": "Testlauf abgeschlossen",
   "integration.nodeInspector.toast.webhookUrlCopied": "Webhook-URL kopiert",
   "integration.nodeInspector.toast.webhookUrlCopyFailed": "URL konnte nicht kopiert werden",

package/dist/runtime/i18n/messages/en.json

@@ -198,7 +198,7 @@
   "integration.credentials.list.action.reconnect.aria": "Reconnect {name}",
   "integration.credentials.list.dialog.action.back": "Back",
   "integration.credentials.list.dialog.description.create": "Pick a type and fill in its access data.",
-  "integration.credentials.list.dialog.description.edit": "Update the credential. Leave secret fields blank to keep the current value.",
+  "integration.credentials.list.dialog.description.edit": "Update the credential. Leave secret fields blank to keep the current value — not possible when the server or any other setting changes.",
   "integration.credentials.list.dialog.field.name.placeholder": "e.g. Production SMTP",
   "integration.credentials.list.empty": "No credentials yet — hit “{action}” to connect your first system.",
   "integration.credentials.list.head.title": "Credentials · Revenexx Cockpit",
@@ -294,6 +294,7 @@
   "integration.credentials.toast.created": "Credential created",
   "integration.credentials.toast.deleted": "Credential deleted",
   "integration.credentials.toast.updated": "Credential updated",
+  "integration.credentials.toast.updatedReconnect": "Credential updated — reconnect it to use it again",
   "integration.credentials.typePicker.empty": "No credential type matches “{query}”.",
   "integration.credentials.typePicker.search.aria": "Search for an app",
   "integration.credentials.typePicker.search.placeholder": "Search for an app…",
@@ -818,6 +819,8 @@
   "integration.nodeInspector.toast.samplePinned": "Sample output pinned",
   "integration.nodeInspector.toast.secretCopied": "Secret copied",
   "integration.nodeInspector.toast.secretCopyFailed": "Could not copy the secret",
+  "integration.nodeInspector.toast.testRunFailed": "Test of “{name}” failed",
+  "integration.nodeInspector.toast.testRunFailedNoMessage": "The step ended on its error output without saying why.",
   "integration.nodeInspector.toast.testRunFinished": "Test run finished",
   "integration.nodeInspector.toast.webhookUrlCopied": "Webhook URL copied",
   "integration.nodeInspector.toast.webhookUrlCopyFailed": "Could not copy the URL",

package/dist/runtime/pages/integrations/workflows/[id].vue

@@ -234,6 +234,10 @@ function answerLeave(leave) {
   leaveDecision?.(leave);
   leaveDecision = null;
 }
+function focusStay(event) {
+  event.preventDefault();
+  event.target?.querySelector('[data-leave-answer="stay"]')?.focus();
+}
 let leavingOnPurpose = false;
 async function leaveTo(path) {
   leavingOnPurpose = true;
@@ -339,6 +343,10 @@ function extractRunId(res) {
   }
   return null;
 }
+function bodyRunId(e) {
+  if (!(e instanceof IntegrationsApiError)) return null;
+  return extractRunId(e.body?.run);
+}
 function asRunObject(res) {
   if (!res || typeof res !== "object" || Array.isArray(res)) return null;
   const o = res;
@@ -353,12 +361,12 @@ function viewRunFromModal(id2) {
 function isRefusal(e) {
   if (!(e instanceof IntegrationsApiError)) return false;
   if (e.status < 400 || e.status >= 500 || e.status === 408) return false;
-  return extractRunId(e.body?.run) === null;
+  return bodyRunId(e) === null;
 }
 function syncErrorMessage(e) {
   if (e instanceof IntegrationsApiError) {
     if (e.status === 504) return t("integration.editor.run.error.syncTimeout");
-    if (e.status === 422 && e.body?.status === "failed") return t("integration.editor.run.error.syncFailed");
+    if (e.status === 422 && bodyRunId(e) !== null) return t("integration.editor.run.error.syncFailed");
   }
   return errorReason(e, t("integration.editor.run.error.syncFailed"));
 }
@@ -418,9 +426,7 @@ async function run(mode) {
       runObject.value = asRunObject(syncResponse.value);
     } catch (e) {
       await reportRunFailure(e, syncErrorMessage);
-      if (e instanceof IntegrationsApiError) {
-        runModalRunId.value = extractRunId(e.body?.run);
-      }
+      runModalRunId.value = bodyRunId(e);
     } finally {
       syncLoading.value = false;
       void loadRuns(1);
@@ -1368,29 +1374,24 @@ async function confirmDeactivate() {
 
     <!-- Leaving the workflow with unsaved work.
          Staying is the default in the only sense that decides anything: it holds the
-         focus when the dialog opens, so Enter or Space keeps the work. That is what
-         `AlertDialogCancel` is for — the dialog focuses its cancel element, and with
-         none declared it focuses the first tabbable button instead, which was
-         "Discard and leave". A breadcrumb click followed by Enter then threw away the
-         afternoon this dialog exists to protect.
-         `as-child` so the studio's own Button is that element rather than a second one
-         beside it. Escape means the same thing, through `update:open`; a click beside
-         the dialog does nothing at all, which an alert dialog is entitled to.
+         focus when the dialog opens, so Enter or Space keeps the work — `focusStay`
+         puts it there. Escape means the same thing, through `update:open`; a click
+         beside the dialog does nothing at all, which an alert dialog is entitled to.
 
-         The class list on that Button is the price of `as-child`: `AlertDialogCancel`
-         applies the outline variant to whatever it renders, and every dialog in this
-         module draws the answer on the right as a filled one. So the two variants meet
-         on one element and `tailwind-merge` decides between them per group — which it
-         cannot do where the outline variant names a group the default one does not, and
-         those are the five that have to be said here. Left to itself the merge produced
-         a background from the outline variant and a text colour from the default, which
-         resolve to the same colour in this theme: the label was invisible until hovered
-         (PO-415). Nothing marks this answer as the one holding the keyboard otherwise —
-         `focus-visible` does not match after the click that opened the dialog. -->
+         The answer on the right is a plain filled Button, as in every other dialog in
+         this module, and deliberately not wrapped in `AlertDialogCancel`. The cancel
+         adds its own variant to whatever it renders, so two variants met on one
+         element, and the design system paints a button's face as a background image
+         over its background colour: no class written here decides what is seen. Under
+         `@revenexx/studio` 0.2.2 and 0.2.3 the outline variant painted a white face
+         over the label, and the answer that keeps the work was unreadable in the
+         cockpit (PO-415, PO-598). Nothing marks this answer as the one holding the
+         keyboard otherwise — `focus-visible` does not match after the click that
+         opened the dialog. -->
     <AlertDialog :open="leaveOpen" @update:open="(v) => {
   if (!v) answerLeave(false);
 }">
-      <AlertDialogContent>
+      <AlertDialogContent @open-auto-focus="focusStay">
         <AlertDialogHeader>
           <AlertDialogTitle>{{ t("integration.editor.leave.dialog.title") }}</AlertDialogTitle>
           <AlertDialogDescription>
@@ -1401,14 +1402,9 @@ async function confirmDeactivate() {
           <Button variant="outline" @click="answerLeave(true)">
             {{ t("integration.editor.leave.dialog.discard") }}
           </Button>
-          <AlertDialogCancel as-child>
-            <Button
-              class="border-transparent bg-primary text-primary-foreground hover:bg-primary/90 hover:text-primary-foreground dark:border-transparent dark:bg-primary dark:hover:bg-primary/90"
-              @click="answerLeave(false)"
-            >
-              {{ t("integration.editor.leave.dialog.stay") }}
-            </Button>
-          </AlertDialogCancel>
+          <Button data-leave-answer="stay" @click="answerLeave(false)">
+            {{ t("integration.editor.leave.dialog.stay") }}
+          </Button>
         </AlertDialogFooter>
       </AlertDialogContent>
     </AlertDialog>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@revenexx/studio-integrations",
-  "version": "3.0.1",
+  "version": "3.0.3",
   "type": "module",
   "description": "Integration Studio (core: workflows, node editor, runs, schedules, credentials, secrets, audit) as a standalone, publishable Nuxt module.",
   "repository": {
@@ -34,7 +34,7 @@
   },
   "peerDependencies": {
     "@dagrejs/dagre": "^3.0.0",
-    "@revenexx/studio": "^0.2.3",
+    "@revenexx/studio": "^0.2.10",
     "@tiptap/core": "^3.28.0",
     "@tiptap/extension-document": "^3.28.0",
     "@tiptap/extension-history": "^3.28.0",