@revenexx/studio-integrations 2.8.1 → 2.9.0

package/dist/runtime/i18n/messages/en.json

@@ -77,7 +77,13 @@
   "integration.canvas.node.badge.loopBody": "Loop — nothing is wired to Item yet, so nothing repeats | Loop — repeats the one step wired to Item, once per element | Loop — repeats the {n} steps wired to Item, once per element",
   "integration.canvas.node.badge.noBuiltCode": "Version {version} is not ready to use — this step cannot be tested",
   "integration.canvas.node.badge.repeats": "Repeats — runs once per element of {iterators} | Repeats — runs once per element of each of the {n} loops it sits inside: {iterators}",
+  "integration.canvas.node.handle.converging": "Converging input: the branch that arrives is handed on as the input",
+  "integration.canvas.node.handle.convergingKeyed": "Branches of one split arrive together, each under the step it ends in",
   "integration.canvas.node.handle.input": "Input",
+  "integration.canvas.node.handle.merger": "Merger: waits for every branch and hands each one on under the step it ends in",
+  "integration.canvas.node.handle.splitter": "Splitter: all branches run",
+  "integration.canvas.node.handle.virtualConverging": "Converging input, drawn only: whichever of these branches arrives",
+  "integration.canvas.node.handle.virtualMerger": "Merger, drawn only: waits for every branch",
   "integration.canvas.node.meta.versionTitle": "Version {version}",
   "integration.canvas.node.note.heading": "Note",
   "integration.canvas.node.port.outputFallback": "out",
@@ -385,6 +391,14 @@
   "integration.editor.clipboard.error.read": "Could not read the clipboard",
   "integration.editor.clipboard.error.write": "Could not write to the clipboard",
   "integration.editor.clipboard.toast.copied": "Node copied | {n} nodes copied",
+  "integration.editor.connection.refused.copied": "{n} connection between the copies was left out because it would cross a loop's boundary. | {n} connections between the copies were left out because they would cross a loop's boundary.",
+  "integration.editor.connection.refused.copiedTitle": "Copied without some connections",
+  "integration.editor.connection.refused.cycle": "{source} already runs after {target}, so this connection would close a cycle.",
+  "integration.editor.connection.refused.cycleUnnamed": "This would close a cycle: a step would run after itself.",
+  "integration.editor.connection.refused.loopBoundary": "{inside} is inside the loop {loop}; only its Item output may lead into the loop's steps.",
+  "integration.editor.connection.refused.loopBoundaryItem": "{outside} is reached from outside the loop {loop} too, so the loop's Item output cannot lead to it.",
+  "integration.editor.connection.refused.loopBoundaryOut": "{inside} is inside the loop {loop}, and {outside} is reached from outside it too; only its Done output may lead out of the loop.",
+  "integration.editor.connection.refused.title": "Connection not possible",
   "integration.editor.deactivate.dialog.cancel": "Cancel",
   "integration.editor.deactivate.dialog.confirm": "Save as paused",
   "integration.editor.deactivate.dialog.description.paused": "paused",
@@ -581,14 +595,23 @@
   "integration.nodeConfig.expression.picker.filterPlaceholder": "Filter…",
   "integration.nodeConfig.expression.pill.inputPath": "Input · {rest}",
   "integration.nodeConfig.expression.pill.inputPayload": "Input payload",
+  "integration.nodeConfig.expression.pill.runId": "Run ID",
+  "integration.nodeConfig.expression.pill.runUrl": "Run link",
   "integration.nodeConfig.expression.pill.triggerPath": "Trigger · {rest}",
   "integration.nodeConfig.expression.pill.triggerPayload": "Trigger payload",
   "integration.nodeConfig.expression.pill.variable": "Variable · {path}",
+  "integration.nodeConfig.expression.pill.workflowId": "Workflow ID",
+  "integration.nodeConfig.expression.pill.workflowName": "Workflow name",
   "integration.nodeConfig.expression.preview.missTitle": "Parts of this expression have no sample data yet",
   "integration.nodeConfig.expression.suggestion.heading.input": "INPUT",
   "integration.nodeConfig.expression.suggestion.heading.nodeOutputs": "NODE OUTPUTS",
+  "integration.nodeConfig.expression.suggestion.heading.run": "RUN",
   "integration.nodeConfig.expression.suggestion.heading.variables": "VARIABLES",
   "integration.nodeConfig.expression.suggestion.inputPayload": "input payload",
+  "integration.nodeConfig.expression.suggestion.runId": "run ID",
+  "integration.nodeConfig.expression.suggestion.runUrl": "run link",
+  "integration.nodeConfig.expression.suggestion.workflowId": "workflow ID",
+  "integration.nodeConfig.expression.suggestion.workflowName": "workflow name",
   "integration.nodeConfig.expression.toggle.off": "Back to the regular control (clears the expression)",
   "integration.nodeConfig.expression.toggle.on": "Map this value from a previous step instead",
   "integration.nodeConfig.expression.useFit": "Use:",
@@ -990,10 +1013,14 @@
   "integration.runs.response.title.starting": "Starting run",
   "integration.runs.response.title.sync": "Run response",
   "integration.runs.response.title.unconfirmed": "Start not confirmed",
+  "integration.runs.skip.deadEnd": "Skipped: dead end",
+  "integration.runs.skip.deadEndBranch": "Skipped: dead end in branch {branch}",
+  "integration.runs.skip.plain": "Skipped",
   "integration.runs.status.cancelled": "cancelled",
   "integration.runs.status.failed": "failed",
   "integration.runs.status.queued": "queued",
   "integration.runs.status.running": "running",
+  "integration.runs.status.skipped": "skipped",
   "integration.runs.status.succeeded": "succeeded",
   "integration.runs.table.column.duration": "Duration",
   "integration.runs.table.column.id": "ID",
@@ -1393,5 +1420,13 @@
   "integration.nodeVersions.badge.offered": "Offered",
   "integration.nodeVersions.badge.notBuilt": "Not built",
   "integration.nodeVersions.action.retire": "Retire",
-  "integration.nodeVersions.action.restore": "Restore"
+  "integration.nodeVersions.action.restore": "Restore",
+  "integration.editor.connection.joinRule.title": "This will not save",
+  "integration.editor.connection.joinRule.crossing": "The connection from node “{from}” (output {output}) to node “{to}” joins two paths that must run separately. Delete this connection or lead it to a node on the same path.",
+  "integration.editor.connection.joinRule.mergerAcrossSplitters": "Paths that split at different places come together in node “{step}”. First bring the paths of each split together in a node of their own.",
+  "integration.editor.connection.joinRule.splitterBypassed": "Paths that split earlier lead to node “{step}” – and one connection also goes around that split. Delete this extra connection.",
+  "integration.editor.connection.joinRule.undecomposable": "Paths that always run and paths that run only under a certain condition come together in node “{step}”. Bring these paths together in separate nodes.",
+  "integration.editor.unsavable.dialog.back": "Back to the editor",
+  "integration.editor.unsavable.dialog.description": "This workflow is currently invalid. It can’t be saved like this. Please fix these errors first:",
+  "integration.editor.unsavable.dialog.title": "Can’t save this workflow"
 }

package/dist/runtime/pages/integrations/schedules.vue

@@ -140,7 +140,7 @@ const columns = computed(() => [
               <Clock :size="14" />
             </div>
             <div class="min-w-0">
-              <div class="font-medium text-sm truncate">{{ e.workflowName }}</div>
+              <div class="font-medium text-sm truncate" :title="e.workflowName">{{ e.workflowName }}</div>
             </div>
           </div>
         </template>

package/dist/runtime/pages/integrations/workflows/[id].vue

@@ -45,6 +45,7 @@ import { isTerminalRun, unwrapRun } from "../../../utils/runEnvelope";
 import { findingsSummary, groupFindingsByNode, nodeDisplayLabel } from "../../../utils/validationFindings";
 import { payloadFieldsFromBlob } from "../../../data/payloadForm";
 import { eventTopicOf } from "../../../data/eventTrigger";
+import { isShapeIssue, saveRefusalLines } from "../../../data/saveRefusal";
 import WorkflowIconView from "../../../components/Integrations/WorkflowIconView.vue";
 import { DEFAULT_RUN_DIRECTION, DEFAULT_RUN_SORT } from "../../../utils/runFeedQuery";
 import { keepOpenBeside } from "../../../utils/dialog";
@@ -114,6 +115,12 @@ onMounted(() => {
 });
 const deactivationOpen = ref(false);
 const deactivationIssues = ref([]);
+const unsavableOpen = ref(false);
+const unsavableLines = ref([]);
+function showUnsavable(issues, blob) {
+  unsavableLines.value = saveRefusalLines(issues, blob.nodes, blob.edges, blob.triggers);
+  unsavableOpen.value = true;
+}
 const { load: loadCredentials, needsReauth } = useIntegrationsCredentials();
 onMounted(() => {
   void loadCredentials();
@@ -795,7 +802,9 @@ async function save() {
     settleBuildStatus();
   } catch (e) {
     const issues = apiValidationIssues(e);
-    if (issues.length && workflow.value.active) {
+    if (issues.some((i) => isShapeIssue(i.path))) {
+      showUnsavable(issues, payloadBlob(d));
+    } else if (issues.length && workflow.value.active) {
       const nodes = workflow.value.blob.nodes;
       deactivationIssues.value = issues.map((i) => {
         const m = /^blob\.nodes\.(\d+)\b/.exec(i.path);
@@ -832,7 +841,9 @@ async function confirmDeactivate() {
     settleBuildStatus();
   } catch (e) {
     deactivationOpen.value = false;
-    saveError.value = errorReason(e, t("integration.editor.save.error.generic"));
+    const issues = apiValidationIssues(e);
+    if (issues.length) showUnsavable(issues, payloadBlob(d));
+    else saveError.value = errorReason(e, t("integration.editor.save.error.generic"));
   } finally {
     saving.value = false;
   }
@@ -1139,7 +1150,7 @@ async function confirmDeactivate() {
             :draft="draft?.blob ?? null"
             :run-busy="saving || running || syncLoading || waitingForBuild"
             :run-saves="isDirty"
-            :overlay-open="settingsOpen || duplicateOpen || importOpen || !!exporter?.open || deleteOpen || syncOpen || runPayloadOpen || deactivationOpen || leaveOpen"
+            :overlay-open="settingsOpen || duplicateOpen || importOpen || !!exporter?.open || deleteOpen || syncOpen || runPayloadOpen || deactivationOpen || unsavableOpen || leaveOpen"
             @change="onChange"
             @run="runFromEditor"
             @toggle-active="onToggleActive"
@@ -1433,5 +1444,29 @@ async function confirmDeactivate() {
         </AlertDialogFooter>
       </AlertDialogContent>
     </AlertDialog>
+
+    <!-- A save refused whatever `active` says: nothing to offer but going back. -->
+    <AlertDialog :open="unsavableOpen" @update:open="(v) => {
+  if (!v) unsavableOpen = false;
+}">
+      <AlertDialogContent>
+        <AlertDialogHeader>
+          <AlertDialogTitle>{{ t("integration.editor.unsavable.dialog.title") }}</AlertDialogTitle>
+          <AlertDialogDescription>{{ t("integration.editor.unsavable.dialog.description") }}</AlertDialogDescription>
+        </AlertDialogHeader>
+        <ul class="max-h-48 space-y-0.5 overflow-y-auto rounded-md border border-red-500/20 bg-red-500/5 px-3 py-2 text-sm text-red-800">
+          <li v-for="(line, i) in unsavableLines" :key="i" class="flex gap-1.5">
+            <span class="select-none text-red-500">•</span>
+            <span v-if="'key' in line">{{ t(line.key, line.params) }}</span>
+            <span v-else><span v-if="line.where" class="font-medium">{{ line.where }}:</span> {{ line.message }}</span>
+          </li>
+        </ul>
+        <AlertDialogFooter>
+          <Button variant="outline" @click="unsavableOpen = false">
+            {{ t("integration.editor.unsavable.dialog.back") }}
+          </Button>
+        </AlertDialogFooter>
+      </AlertDialogContent>
+    </AlertDialog>
   </IntegrationsLayout>
 </template>

package/dist/runtime/types/integrations.d.ts

@@ -696,11 +696,20 @@ export interface WorkflowRunNodeStep {
 export interface RunStepRow {
     node_id: string;
     node_slug: string;
-    activity_type: string;
+    activity_type?: string | null;
     status: string;
-    attempt: number;
-    scheduled_event_id: number | null;
-    duration_ms: number | null;
+    attempt?: number | null;
+    scheduled_event_id?: number | null;
+    duration_ms?: number | null;
+    /** Why a `skipped` step was skipped. Open-ended: unknown values are legal. */
+    skip_reason?: string | null;
+    /** `dead_end` only: the 1-based number of the splitter's branch that delivered nothing, in connection order. */
+    dead_end_branch?: number | null;
+    /** `dead_end` only: the splitter (node and output port) whose branch was a dead end. */
+    dead_end_splitter?: {
+        node_id: string;
+        port: string;
+    } | null;
     branch?: string | null;
     error?: string | null;
     input?: unknown;

package/dist/runtime/utils/skippedStep.d.ts

@@ -0,0 +1,39 @@
+import type { RunStepRow } from '../types/integrations.js';
+/**
+ * Why a run step was skipped (PO-750, from the worker's PO-502).
+ *
+ * A step the run never reached because a branch delivered nothing is reported as
+ * a synthetic row: `status: 'skipped'`, `skip_reason: 'dead_end'`, and the number
+ * of the splitter's branch that was the dead end. The reason list is open — the
+ * worker may name more later — so anything but `dead_end` reads as a plain skip
+ * rather than being shown raw or hidden.
+ */
+export type SkipReason = {
+    kind: 'dead_end';
+    branch: number | null;
+} | {
+    kind: 'plain';
+};
+type StepLike = Pick<RunStepRow, 'status' | 'skip_reason' | 'dead_end_branch'>;
+/** A step that never ran. Case-insensitive, like the rest of the status vocabulary. */
+export declare function isSkippedStep(step: Pick<RunStepRow, 'status'>): boolean;
+/** The reason a step was skipped, or null for a step that ran. */
+export declare function skipReason(step: StepLike): SkipReason | null;
+/**
+ * The message key and parameters that say why a step was skipped, or null for a
+ * step that ran or was skipped for a reason this studio does not name (the status
+ * badge already says "skipped" then).
+ */
+export declare function skipReasonMessage(step: StepLike): {
+    key: string;
+    params: Record<string, number>;
+} | null;
+/** Nodes a run actually executed — a skipped step is on the list but did not run. */
+export declare function executedNodeIds(steps: ReadonlyArray<Pick<RunStepRow, 'node_id' | 'status'>>): Set<string>;
+/**
+ * A step's status as its badge says it. A skipped step is a step's state, not a
+ * run's, so it is not among the run words `runStatusLabel` translates — and without
+ * this the badge printed the raw `SKIPPED` in a German studio (review of #297).
+ */
+export declare function stepStatusLabel(status: string | null | undefined): string;
+export {};

package/dist/runtime/utils/skippedStep.js

@@ -0,0 +1,22 @@
+import { useIntegrationsT } from "../composables/useIntegrationsT.js";
+import { runStatusLabel } from "./statusStyle.js";
+export function isSkippedStep(step) {
+  return String(step.status ?? "").toLowerCase() === "skipped";
+}
+export function skipReason(step) {
+  if (!isSkippedStep(step)) return null;
+  if (step.skip_reason !== "dead_end") return { kind: "plain" };
+  const n = step.dead_end_branch;
+  return { kind: "dead_end", branch: typeof n === "number" && Number.isInteger(n) && n >= 1 ? n : null };
+}
+export function skipReasonMessage(step) {
+  const reason = skipReason(step);
+  if (reason?.kind !== "dead_end") return null;
+  return reason.branch === null ? { key: "integration.runs.skip.deadEnd", params: {} } : { key: "integration.runs.skip.deadEndBranch", params: { branch: reason.branch } };
+}
+export function executedNodeIds(steps) {
+  return new Set(steps.filter((s) => !isSkippedStep(s)).map((s) => s.node_id));
+}
+export function stepStatusLabel(status) {
+  return isSkippedStep({ status: status ?? "" }) ? useIntegrationsT()("integration.runs.status.skipped") : runStatusLabel(status);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@revenexx/studio-integrations",
-  "version": "2.8.1",
+  "version": "2.9.0",
   "type": "module",
   "description": "Integration Studio (core: workflows, node editor, runs, schedules, credentials, secrets, audit) as a standalone, publishable Nuxt module.",
   "repository": {