@revenexx/studio-integrations 0.5.1 → 0.6.0

package/dist/runtime/components/Integrations/NodeConfigField.vue

@@ -8,11 +8,14 @@ import {
   Select,
   SelectContent,
   SelectItem,
+  SelectSeparator,
   SelectTrigger,
   SelectValue,
   Switch,
   Textarea
 } from "@revenexx/studio";
+import { resolveLocalized } from "../../utils/localize";
+import { credentialState } from "../../utils/credentialState";
 const props = defineProps({
   field: { type: Object, required: true },
   config: { type: Object, required: true },
@@ -22,23 +25,19 @@ const props = defineProps({
   staticKeys: { type: Array, required: false },
   depth: { type: Number, required: false },
   variables: { type: Object, required: false },
-  upstreamOutputs: { type: Array, required: false }
+  upstreamOutputs: { type: Array, required: false },
+  refused: { type: String, required: false }
 });
 const emit = defineEmits(["set"]);
 const value = computed(() => props.config[props.field.key]);
 function write(v) {
   emit("set", props.field.key, v);
 }
-function labelText(v) {
-  if (!v) return "";
-  return typeof v === "string" ? v : v.en ?? Object.values(v)[0] ?? "";
-}
 const exprHint = "${{ \u2026 }}";
-const descriptionText = computed(() => labelText(props.field.description));
+const descriptionText = computed(() => resolveLocalized(props.field.description));
 function isEmpty(v) {
   return v === void 0 || v === null || v === "" || Array.isArray(v) && v.length === 0;
 }
-const requiredMissing = computed(() => !!props.field.required && isEmpty(value.value));
 const formatError = computed(() => {
   const v = value.value;
   if (isEmpty(v)) return null;
@@ -60,7 +59,8 @@ const formatError = computed(() => {
   }
   return null;
 });
-const invalid = computed(() => !!formatError.value);
+const fieldError = computed(() => formatError.value ?? props.refused ?? null);
+const invalid = computed(() => !!fieldError.value);
 const constraintHint = computed(() => {
   const val = props.field.validation;
   if (!val) return "";
@@ -75,7 +75,7 @@ const constraintHint = computed(() => {
   }
   return "";
 });
-const { credentials, load: loadCredentials } = useIntegrationsCredentials();
+const { credentials, loaded: credentialsLoaded, load: loadCredentials } = useIntegrationsCredentials();
 onMounted(() => {
   void loadCredentials();
 });
@@ -95,11 +95,36 @@ function credsForField(field) {
   }
   return list;
 }
-function credNeedsReauth(id) {
-  return credentials.value.some((c) => c.id === id && c.status === "needs_reauth");
+const bound = computed(() => {
+  const id = value.value;
+  const c = typeof id === "string" && id ? credentials.value.find((x) => x.id === id) : void 0;
+  return c ? { credential: c, state: credentialState(c) } : null;
+});
+const credOptions = computed(
+  () => credsForField(props.field).map((c) => ({ credential: c, state: credentialState(c) }))
+);
+const UNKNOWN_CREDENTIAL = "Unknown credential \u2014 pick again";
+function credTriggerLabel(field) {
+  const label = resolveLocalized(field.label);
+  if (bound.value) return `${label}: ${bound.value.credential.name}, ${bound.value.state.label}`;
+  if (value.value && credentialsLoaded.value) return `${label}: ${UNKNOWN_CREDENTIAL}`;
+  return label;
 }
 const credCreateOpen = ref(false);
 const sftpImportOpen = ref(false);
+const CRED_ACTION_NEW = "__action_new_credential__";
+const CRED_ACTION_SFTP = "__action_import_sftp__";
+function onCredentialSelect(v) {
+  if (v === CRED_ACTION_NEW) {
+    credCreateOpen.value = true;
+    return;
+  }
+  if (v === CRED_ACTION_SFTP) {
+    sftpImportOpen.value = true;
+    return;
+  }
+  write(v);
+}
 function acceptsSftp(field) {
   const t = field.credentialType;
   return t === "revenexx:sftp" || Array.isArray(t) && t.includes("revenexx:sftp");
@@ -230,8 +255,18 @@ function setArrayItemField(index, fieldKey, v) {
 <template>
   <div class="space-y-1.5">
     <div class="flex items-center justify-between gap-2">
-      <Label class="text-mono text-muted-foreground">
-        {{ labelText(field.label) }}<span v-if="field.required" class="text-rose-500" title="Required"> *</span>
+      <!-- The label carries the fault as well as the control does. Only a few
+           of the widget types below are a bare input that can take a red
+           border, so a credential picker or a switch at fault would otherwise
+           be marked only by the sentence underneath.
+
+           No `for`: which control this heads depends on the field's type — one
+           of a dozen branches, some of them a group rather than a single
+           element. Each branch instead carries the same text as its own name,
+           without the required marker, which is a state and not part of a
+           name. -->
+      <Label class="text-mono" :class="invalid ? 'text-rose-600' : 'text-muted-foreground'">
+        {{ resolveLocalized(field.label) }}<span v-if="field.required" class="text-rose-500" title="Required"> *</span>
       </Label>
       <div class="flex shrink-0 items-center gap-1.5">
         <div v-if="isObjectField && !showExpression" class="flex items-center rounded border border-black/[0.08] bg-white p-px">
@@ -274,11 +309,6 @@ function setArrayItemField(index, fieldKey, v) {
         </span>
       </div>
     </div>
-    <!-- inline help (boolean uses its description as the toggle label instead) -->
-    <p v-if="descriptionText && field.type !== 'boolean'" class="text-sm text-muted-foreground leading-snug">
-      {{ descriptionText }}
-    </p>
-
     <!-- object / plain-array fields: JSON editor (expressions stay usable
          inside string values). Wins over expressionAllowed — an object value
          in a text input would render as [object Object]. -->
@@ -291,11 +321,12 @@ function setArrayItemField(index, fieldKey, v) {
 
     <template v-else-if="isJsonField">
       <Textarea
+        :aria-label="resolveLocalized(field.label)"
         :model-value="jsonDraft"
         :rows="8"
         spellcheck="false"
-        class="font-mono text-xs"
-        :placeholder="labelText(field.placeholder) || '{ }'"
+        class="rounded-md border border-black/[0.08] ring-0 shadow-none bg-white font-mono text-xs"
+        :placeholder="resolveLocalized(field.placeholder) || '{ }'"
         @update:model-value="(v) => writeJson(String(v))"
       />
       <p v-if="jsonError" class="text-sm text-amber-600">{{ jsonError }}</p>
@@ -304,20 +335,25 @@ function setArrayItemField(index, fieldKey, v) {
     <!-- object field in key/value mode -->
     <div v-else-if="isObjectField && objectMode === 'form'" class="space-y-1.5">
       <div v-for="(row, idx) in kvRows" :key="idx" class="flex items-center gap-1.5">
+        <!-- A repeating row has no room for visible labels, so each control
+             names itself and says which row of which field it belongs to. -->
         <Input
+          :aria-label="`${resolveLocalized(field.label)} \u2014 key of row ${idx + 1}`"
           :model-value="row.key"
           placeholder="key"
-          class="h-7 w-[38%] bg-white font-mono text-sm"
+          class="h-7 w-[38%] rounded-md border border-black/[0.08] ring-0 shadow-none bg-white text-sm"
           @update:model-value="(v) => setKvRow(idx, { key: String(v) })"
         />
         <Input
+          :aria-label="`${resolveLocalized(field.label)} \u2014 value of row ${idx + 1}`"
           :model-value="row.value"
           placeholder="value"
-          class="h-7 min-w-0 flex-1 bg-white text-sm"
+          class="h-7 min-w-0 flex-1 rounded-md border border-black/[0.08] ring-0 shadow-none bg-white text-sm"
           @update:model-value="(v) => setKvRow(idx, { value: String(v) })"
         />
         <button
           type="button"
+          :aria-label="`Remove row ${idx + 1} of ${resolveLocalized(field.label)}`"
           class="flex size-6 shrink-0 items-center justify-center rounded text-muted-foreground transition hover:text-rose-600"
           @click="removeKvRow(idx)"
         >
@@ -340,9 +376,11 @@ function setArrayItemField(index, fieldKey, v) {
     <IntegrationsExpressionInput
       v-else-if="showExpression"
       :model-value="typeof value === 'string' ? value : ''"
-      :placeholder="labelText(field.placeholder)"
+      :placeholder="resolveLocalized(field.placeholder)"
       :variables="variables"
       :upstream-outputs="upstreamOutputs"
+      :invalid="invalid"
+      :label="resolveLocalized(field.label)"
       @update:model-value="(v) => write(v)"
     />
 
@@ -363,18 +401,21 @@ function setArrayItemField(index, fieldKey, v) {
     <IntegrationsExpressionInput
       v-else-if="field.type === 'expression' || field.expressionAllowed"
       :model-value="value"
-      :placeholder="labelText(field.placeholder)"
+      :placeholder="resolveLocalized(field.placeholder)"
       :variables="variables"
       :upstream-outputs="upstreamOutputs"
+      :invalid="invalid"
+      :label="resolveLocalized(field.label)"
       @update:model-value="(v) => write(v)"
     />
 
     <!-- plain string (no expressions) -->
     <Input
       v-else-if="field.type === 'string'"
+      :aria-label="resolveLocalized(field.label)"
       :model-value="value ?? ''"
-      :placeholder="labelText(field.placeholder)"
-      class="h-8 text-sm bg-white"
+      :placeholder="resolveLocalized(field.placeholder)"
+      class="h-8 rounded-md border border-black/[0.08] ring-0 shadow-none text-sm bg-white"
       :class="invalid ? 'border-rose-400 focus-visible:ring-rose-400/40' : ''"
       @update:model-value="(v) => write(v)"
     />
@@ -382,9 +423,10 @@ function setArrayItemField(index, fieldKey, v) {
     <!-- number -->
     <Input
       v-else-if="field.type === 'number'"
+      :aria-label="resolveLocalized(field.label)"
       type="number"
       :model-value="value ?? ''"
-      class="h-8 text-sm bg-white"
+      class="h-8 rounded-md border border-black/[0.08] ring-0 shadow-none text-sm bg-white"
       :class="invalid ? 'border-rose-400 focus-visible:ring-rose-400/40' : ''"
       @update:model-value="(v) => write(v === '' ? null : Number(v))"
     />
@@ -392,11 +434,13 @@ function setArrayItemField(index, fieldKey, v) {
     <!-- boolean -->
     <div v-else-if="field.type === 'boolean'" class="flex items-center gap-2 pt-1">
       <Switch
+        :aria-label="resolveLocalized(field.label)"
+        class="data-[state=unchecked]:bg-slate-300"
         :model-value="Boolean(value)"
         @update:model-value="(v) => write(v)"
       />
       <span class="text-sm text-muted-foreground">
-        {{ labelText(field.description) }}
+        {{ resolveLocalized(field.description) }}
       </span>
     </div>
 
@@ -419,18 +463,18 @@ function setArrayItemField(index, fieldKey, v) {
       :model-value="value ?? ''"
       @update:model-value="(v) => write(v)"
     >
-      <SelectTrigger class="h-8 text-sm bg-white">
-        <SelectValue :placeholder="labelText(field.placeholder) || 'Pick one'" />
+      <SelectTrigger :aria-label="resolveLocalized(field.label)" size="sm" class="h-8 w-full rounded-md border border-black/[0.08] ring-0 shadow-none text-sm bg-white">
+        <SelectValue :placeholder="resolveLocalized(field.placeholder) || 'Pick one'" />
       </SelectTrigger>
       <SelectContent>
         <SelectItem v-for="opt in field.options ?? []" :key="String(opt.value)" :value="String(opt.value)">
-          {{ labelText(opt.label) }}
+          {{ resolveLocalized(opt.label) }}
         </SelectItem>
       </SelectContent>
     </Select>
 
     <!-- multiselect — pill toggles for now -->
-    <div v-else-if="field.type === 'multiselect'" class="flex flex-wrap gap-1">
+    <div v-else-if="field.type === 'multiselect'" role="group" :aria-label="resolveLocalized(field.label)" class="flex flex-wrap gap-1">
       <button
         v-for="opt in field.options ?? []"
         :key="String(opt.value)"
@@ -443,7 +487,7 @@ function setArrayItemField(index, fieldKey, v) {
   write(has ? current.filter((v) => v !== opt.value) : [...current, opt.value]);
 }"
       >
-        {{ labelText(opt.label) }}
+        {{ resolveLocalized(opt.label) }}
       </button>
     </div>
 
@@ -453,7 +497,7 @@ function setArrayItemField(index, fieldKey, v) {
       :model-value="value ?? ''"
       @update:model-value="(v) => write(v)"
     >
-      <SelectTrigger class="h-8 text-sm bg-white">
+      <SelectTrigger :aria-label="resolveLocalized(field.label)" size="sm" class="h-8 w-full rounded-md border border-black/[0.08] ring-0 shadow-none text-sm bg-white">
         <SelectValue placeholder="Pick a secret" />
       </SelectTrigger>
       <SelectContent>
@@ -461,44 +505,82 @@ function setArrayItemField(index, fieldKey, v) {
       </SelectContent>
     </Select>
 
-    <!-- credentials-ref — pick a credential of the required type -->
+    <!-- credentials-ref — pick a credential of the required type. Compact:
+         creating and importing live INSIDE the picker as action rows; no
+         Manage link (it navigated out of the editor mid-edit). -->
     <template v-else-if="field.type === 'credentials-ref'">
       <Select
         :model-value="value ?? ''"
-        @update:model-value="(v) => write(v)"
+        @update:model-value="(v) => onCredentialSelect(v)"
       >
-        <SelectTrigger class="h-8 text-sm bg-white">
-          <SelectValue placeholder="Pick a credential" />
+        <SelectTrigger :aria-label="credTriggerLabel(field)" size="sm" class="h-8 w-full rounded-md border border-black/[0.08] ring-0 shadow-none text-sm bg-white">
+          <!-- The trigger renders the bound credential itself instead of letting
+               `SelectValue` echo the chosen row. Left to itself it shows that row's
+               `textContent`, which glues the name and the state pill into one word —
+               "Revenexx APIConnected". Rendering it here keeps the pill a pill, and
+               the placeholder has to be drawn by hand because a slot replaces the
+               fallback that would otherwise show it. -->
+          <SelectValue placeholder="Pick a credential">
+            <span v-if="bound" class="flex min-w-0 items-center gap-1.5">
+              <span class="min-w-0 truncate">{{ bound.credential.name }}</span>
+              <!-- No `title` on this badge: `SelectValue` renders itself with
+                   `pointer-events: none`, so nothing inside it is ever hovered and a
+                   tooltip here would be a reason nobody can reach. A failed test's
+                   reason is prose beneath the field instead. -->
+              <span
+                class="shrink-0 rounded-full border px-1.5 py-px text-[10px] font-medium"
+                :class="bound.state.toneClass"
+              >
+                {{ bound.state.label }}
+              </span>
+            </span>
+            <!-- A stored id the tenant's credentials no longer contain: the
+                 credential was deleted, and the field would otherwise look untouched
+                 while the workflow still runs into the dead reference. `loaded`
+                 keeps the wait before the first response out of it. -->
+            <span v-else-if="value && credentialsLoaded" class="text-rose-600">{{ UNKNOWN_CREDENTIAL }}</span>
+            <span v-else class="text-muted-foreground">Pick a credential</span>
+          </SelectValue>
         </SelectTrigger>
         <SelectContent>
-          <SelectItem v-for="c in credsForField(field)" :key="c.id" :value="c.id">
+          <!-- The state comes from `credentialState`, the same derivation the
+               credentials table and the detail dialog use. This picker used to read
+               `status` alone and call everything that was not `needs_reauth`
+               "Connected" — including a credential nobody had ever tested, which is
+               a pass claimed for a test that never ran. -->
+          <SelectItem v-for="o in credOptions" :key="o.credential.id" :value="o.credential.id">
             <span class="flex items-center gap-1.5">
-              <span class="size-1.5 shrink-0 rounded-full" :class="c.status === 'needs_reauth' ? 'bg-amber-500' : 'bg-emerald-500'" />
-              <span class="min-w-0 truncate">{{ c.name }}</span>
-              <span v-if="c.status === 'needs_reauth'" class="shrink-0 text-[10px] text-amber-600">reconnect</span>
+              <span class="min-w-0 truncate">{{ o.credential.name }}</span>
+              <!-- `title` carries why a failed test failed, the way the credentials
+                   table does it. Without it "Failed" is a verdict with no appeal. A
+                   row is a real hit target, unlike the closed trigger above. -->
+              <span
+                class="shrink-0 rounded-full border px-1.5 py-px text-[10px] font-medium"
+                :class="o.state.toneClass"
+                :title="o.state.message ?? void 0"
+              >{{ o.state.label }}</span>
             </span>
           </SelectItem>
+          <div v-if="!credOptions.length" class="px-2 py-1.5 text-sm text-muted-foreground">
+            No credentials yet.
+          </div>
+          <SelectSeparator />
+          <SelectItem :value="CRED_ACTION_NEW" class="font-medium text-violet-600 data-[highlighted]:text-violet-700">
+            New credential
+          </SelectItem>
+          <SelectItem v-if="acceptsSftp(field)" :value="CRED_ACTION_SFTP" class="font-medium text-violet-600 data-[highlighted]:text-violet-700">
+            Import existing Revenue Cloud SFTP account
+          </SelectItem>
         </SelectContent>
       </Select>
-      <p v-if="credNeedsReauth(value)" class="text-sm text-amber-600">
+      <!-- What the state has to add, as text rather than as a tooltip — the shape
+           the detail dialog uses beneath its own badge. -->
+      <p v-if="bound?.state.key === 'needs_reauth'" class="text-sm text-amber-600">
         This credential needs reconnect.
       </p>
-      <div class="flex items-center gap-3">
-        <button type="button" class="text-sm font-medium text-violet-600 hover:underline" @click="credCreateOpen = true">
-          + New credential
-        </button>
-        <button
-          v-if="acceptsSftp(field)"
-          type="button"
-          class="text-sm font-medium text-violet-600 hover:underline"
-          @click="sftpImportOpen = true"
-        >
-          Import SFTP account
-        </button>
-        <NuxtLink to="/integrations/credentials" class="text-sm text-muted-foreground hover:underline">
-          Manage →
-        </NuxtLink>
-      </div>
+      <p v-else-if="bound?.state.key === 'failed' && bound.state.message" class="text-sm break-words text-rose-600">
+        Last test failed: {{ bound.state.message }}
+      </p>
       <IntegrationsCredentialCreateDialog
         v-model:open="credCreateOpen"
         :credential-type="field.credentialType"
@@ -524,6 +606,7 @@ function setArrayItemField(index, fieldKey, v) {
           </span>
           <button
             type="button"
+            :aria-label="`Remove item ${idx + 1} of ${resolveLocalized(field.label)}`"
             class="flex size-5 items-center justify-center rounded text-muted-foreground hover:text-rose-600"
             @click="removeArrayItem(idx)"
           >
@@ -536,11 +619,14 @@ function setArrayItemField(index, fieldKey, v) {
           class="space-y-1"
         >
           <Label class="text-mono text-muted-foreground">
-            {{ labelText(sub.label) }}
+            {{ resolveLocalized(sub.label) }}
           </Label>
+          <!-- The label above repeats per item, so it cannot own an id; the
+               input carries its own name including the item number. -->
           <Input
+            :aria-label="`${resolveLocalized(sub.label)} of item ${idx + 1}`"
             :model-value="item[sub.key] ?? ''"
-            :placeholder="labelText(sub.placeholder)"
+            :placeholder="resolveLocalized(sub.placeholder)"
             class="h-7 text-sm bg-white"
             :class="sub.type === 'expression' ? 'font-mono' : ''"
             @update:model-value="(v) => setArrayItemField(idx, sub.key, v)"
@@ -562,9 +648,10 @@ function setArrayItemField(index, fieldKey, v) {
     <!-- fallback: JSON textarea for complex types -->
     <Textarea
       v-else
+      :aria-label="resolveLocalized(field.label)"
       :model-value="value === void 0 ? '' : JSON.stringify(value, null, 2)"
       rows="3"
-      class="text-sm font-mono bg-white"
+      class="rounded-md border border-black/[0.08] ring-0 shadow-none text-sm font-mono bg-white"
       @update:model-value="(v) => {
   try {
     write(v ? JSON.parse(String(v)) : void 0);
@@ -573,12 +660,18 @@ function setArrayItemField(index, fieldKey, v) {
 }"
     />
 
-    <!-- validation feedback: hard error, else soft required hint, else constraint hint -->
-    <p v-if="formatError" class="text-sm text-rose-600">
-      {{ formatError }}
+    <!-- inline help BELOW the control, quiet — same pattern as the Settings
+         tab (boolean uses its description as the toggle label instead) -->
+    <p v-if="descriptionText && field.type !== 'boolean'" class="text-xs text-muted-foreground leading-snug">
+      {{ descriptionText }}
     </p>
-    <p v-else-if="requiredMissing" class="text-sm text-amber-600">
-      Required
+
+    <!-- validation feedback: the error (local format violation, else what the
+         last save refused), otherwise the constraint hint. A required field the
+         user has simply not reached yet says nothing beyond the * on its
+         label — the nagging would outnumber the help. -->
+    <p v-if="fieldError" class="text-sm text-rose-600">
+      {{ fieldError }}
     </p>
     <p v-else-if="constraintHint" class="text-sm text-muted-foreground">
       {{ constraintHint }}

package/dist/runtime/components/Integrations/NodeConfigField.vue.d.ts

@@ -14,6 +14,8 @@ type __VLS_Props = {
         output: string;
         fields?: string[];
     }>;
+    /** Why the last save refused this setting, if it did. */
+    refused?: string;
 };
 declare const _default: import("vue").DefineComponent<__VLS_Props, {}, {}, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, {
     set: (key: string, value: unknown) => any;

package/dist/runtime/components/Integrations/NodeInspector.d.vue.ts

@@ -20,6 +20,12 @@ type __VLS_Props = {
     dynamicOutputs?: Record<string, NodeManifestOutput[]>;
     /** Workflow id — enables sampling real values from the latest run. */
     workflowId?: number | string;
+    /**
+     * Config key → why the LAST SAVE refused it. Not live validation: the server
+     * is the only judge, so a fix shows once it is saved. Absent for a node the
+     * last save had no complaint about.
+     */
+    refusedFields?: Record<string, string>;
 };
 declare const _default: import("vue").DefineComponent<__VLS_Props, {}, {}, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, {
     close: () => any;