@rev-net/core-v6 0.0.73 → 0.0.74

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rev-net/core-v6",
-  "version": "0.0.73",
+  "version": "0.0.74",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
   "dependencies": {
     "@bananapus/721-hook-v6": "^0.0.55",
     "@bananapus/buyback-hook-v6": "^0.0.51",
-    "@bananapus/core-v6": "^0.0.60",
+    "@bananapus/core-v6": "^0.0.64",
     "@bananapus/ownable-v6": "^0.0.28",
     "@bananapus/permission-ids-v6": "^0.0.27",
     "@bananapus/router-terminal-v6": "^0.0.49",

package/script/Deploy.s.sol

@@ -6,7 +6,6 @@ import {
     BuybackDeployment,
     BuybackDeploymentLib
 } from "@bananapus/buyback-hook-v6/script/helpers/BuybackDeploymentLib.sol";
-import {CoreDeployment, CoreDeploymentLib} from "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
 import {SuckerDeployment, SuckerDeploymentLib} from "@bananapus/suckers-v6/script/helpers/SuckerDeploymentLib.sol";
 import {
     RouterTerminalDeployment,
@@ -44,6 +43,7 @@ import {JB721InitTiersConfig} from "@bananapus/721-hook-v6/src/structs/JB721Init
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
 import {REVBaseline721HookConfig} from "../src/structs/REVBaseline721HookConfig.sol";
 import {REV721TiersHookFlags} from "../src/structs/REV721TiersHookFlags.sol";
+import {CoreDeployment, CoreDeploymentLib} from "./helpers/CoreDeploymentLib.sol";
 
 struct FeeProjectConfig {
     REVConfig configuration;
@@ -426,7 +426,7 @@ contract DeployScript is Script, Sphinx {
                 }
             }
             if (!_foundExisting) {
-                feeProjectId = core.projects.createFor(safeAddress());
+                feeProjectId = core.projects.createFor{value: core.projects.creationFee()}(safeAddress());
             }
         }
 

package/script/helpers/CoreDeploymentLib.sol

@@ -0,0 +1,172 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.28;
+
+import {stdJson} from "forge-std/Script.sol";
+import {Vm} from "forge-std/Vm.sol";
+
+import {JBController} from "@bananapus/core-v6/src/JBController.sol";
+import {JBDirectory} from "@bananapus/core-v6/src/JBDirectory.sol";
+import {JBFeelessAddresses} from "@bananapus/core-v6/src/JBFeelessAddresses.sol";
+import {JBFundAccessLimits} from "@bananapus/core-v6/src/JBFundAccessLimits.sol";
+import {JBMultiTerminal} from "@bananapus/core-v6/src/JBMultiTerminal.sol";
+import {JBPermissions} from "@bananapus/core-v6/src/JBPermissions.sol";
+import {JBPrices} from "@bananapus/core-v6/src/JBPrices.sol";
+import {JBProjects} from "@bananapus/core-v6/src/JBProjects.sol";
+import {JBRulesets} from "@bananapus/core-v6/src/JBRulesets.sol";
+import {JBSplits} from "@bananapus/core-v6/src/JBSplits.sol";
+import {JBTerminalStore} from "@bananapus/core-v6/src/JBTerminalStore.sol";
+import {JBTokens} from "@bananapus/core-v6/src/JBTokens.sol";
+
+import {SphinxConstants, NetworkInfo} from "@sphinx-labs/contracts/contracts/foundry/SphinxConstants.sol";
+
+struct CoreDeployment {
+    JBPermissions permissions;
+    JBProjects projects;
+    JBDirectory directory;
+    JBSplits splits;
+    JBRulesets rulesets;
+    JBController controller;
+    JBMultiTerminal terminal;
+    JBTerminalStore terminalStore;
+    JBPrices prices;
+    JBFeelessAddresses feeless;
+    JBFundAccessLimits fundAccess;
+    JBTokens tokens;
+    address trustedForwarder;
+}
+
+library CoreDeploymentLib {
+    address internal constant VM_ADDRESS = address(uint160(uint256(keccak256("hevm cheat code"))));
+    // forge-lint: disable-next-line(screaming-snake-case-const)
+    Vm internal constant vm = Vm(VM_ADDRESS);
+    string internal constant PROJECT_NAME = "nana-core-v6";
+
+    function getDeployment(string memory path) internal returns (CoreDeployment memory deployment) {
+        uint256 chainId = block.chainid;
+
+        SphinxConstants sphinxConstants = new SphinxConstants();
+        NetworkInfo[] memory networks = sphinxConstants.getNetworkInfoArray();
+
+        for (uint256 i; i < networks.length; i++) {
+            if (networks[i].chainId == chainId) return getDeployment({path: path, networkName: networks[i].name});
+        }
+
+        revert("ChainID is not (currently) supported by Sphinx.");
+    }
+
+    function getDeployment(
+        string memory path,
+        string memory networkName
+    )
+        internal
+        returns (CoreDeployment memory deployment)
+    {
+        deployment.permissions = JBPermissions(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBPermissions"
+            })
+        );
+
+        deployment.projects = JBProjects(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBProjects"
+            })
+        );
+
+        deployment.directory = JBDirectory(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBDirectory"
+            })
+        );
+
+        deployment.splits = JBSplits(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBSplits"
+            })
+        );
+
+        deployment.rulesets = JBRulesets(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBRulesets"
+            })
+        );
+
+        deployment.controller = JBController(
+            _tryGetDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBController"
+            })
+        );
+
+        deployment.terminal = JBMultiTerminal(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBMultiTerminal"
+            })
+        );
+
+        deployment.terminalStore = JBTerminalStore(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBTerminalStore"
+            })
+        );
+
+        deployment.prices = JBPrices(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBPrices"
+            })
+        );
+
+        deployment.feeless = JBFeelessAddresses(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBFeelessAddresses"
+            })
+        );
+
+        deployment.fundAccess = JBFundAccessLimits(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBFundAccessLimits"
+            })
+        );
+
+        deployment.tokens = JBTokens(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBTokens"
+            })
+        );
+
+        deployment.trustedForwarder = _getDeploymentAddress({
+            path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "ERC2771Forwarder"
+        });
+    }
+
+    function _getDeploymentAddress(
+        string memory path,
+        string memory projectName,
+        string memory networkName,
+        string memory contractName
+    )
+        internal
+        view
+        returns (address)
+    {
+        string memory deploymentJson =
+        // forge-lint: disable-next-line(unsafe-cheatcode)
+        vm.readFile(string.concat(path, projectName, "/", networkName, "/", contractName, ".json"));
+        return stdJson.readAddress({json: deploymentJson, key: ".address"});
+    }
+
+    function _tryGetDeploymentAddress(
+        string memory path,
+        string memory projectName,
+        string memory networkName,
+        string memory contractName
+    )
+        internal
+        returns (address)
+    {
+        string memory filePath = string.concat(path, projectName, "/", networkName, "/", contractName, ".json");
+        // forge-lint: disable-next-line(unsafe-cheatcode)
+        if (!vm.exists(filePath)) return address(0);
+        // forge-lint: disable-next-line(unsafe-cheatcode)
+        return stdJson.readAddress({json: vm.readFile(filePath), key: ".address"});
+    }
+}

package/src/REVDeployer.sol

@@ -64,6 +64,7 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IERC721Receiver {
     error REVDeployer_AutoIssuanceBeneficiaryZeroAddress(uint256 stageIndex, uint256 autoIssuanceIndex);
     error REVDeployer_CashOutsCantBeTurnedOffCompletely(uint256 cashOutTaxRate, uint256 maxCashOutTaxRate);
     error REVDeployer_MustHaveSplits(uint256 stageIndex, uint256 splitPercent);
+    error REVDeployer_ProjectCreationFeeNotNeeded(uint256 revnetId, uint256 value);
     error REVDeployer_RulesetDoesNotAllowDeployingSuckers(uint256 revnetId);
     error REVDeployer_StagesRequired(uint256 stageCount);
     error REVDeployer_StageTimesMustIncrease(uint256 stageIndex, uint256 previousStageStart, uint256 effectiveStart);
@@ -492,6 +493,7 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IERC721Receiver {
         REVCroptopAllowedPost[] calldata allowedPosts
     )
         external
+        payable
         override
         returns (uint256, IJB721TiersHook hook)
     {
@@ -499,7 +501,11 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IERC721Receiver {
         bool shouldDeployNewRevnet = revnetId == 0;
 
         // If the caller is deploying a new revnet, reserve its project ID before deriving hook/sucker config.
-        if (shouldDeployNewRevnet) revnetId = PROJECTS.createFor(address(this));
+        if (shouldDeployNewRevnet) {
+            revnetId = PROJECTS.createFor{value: msg.value}(address(this));
+        } else if (msg.value != 0) {
+            revert REVDeployer_ProjectCreationFeeNotNeeded({revnetId: revnetId, value: msg.value});
+        }
 
         // Deploy the revnet with the specified tiered ERC-721 hook and croptop posting criteria.
         hook = _deploy721RevnetFor({
@@ -524,11 +530,16 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IERC721Receiver {
         REVSuckerDeploymentConfig calldata suckerDeploymentConfiguration
     )
         external
+        payable
         override
         returns (uint256, IJB721TiersHook hook)
     {
         bool shouldDeployNewRevnet = revnetId == 0;
-        if (shouldDeployNewRevnet) revnetId = PROJECTS.createFor(address(this));
+        if (shouldDeployNewRevnet) {
+            revnetId = PROJECTS.createFor{value: msg.value}(address(this));
+        } else if (msg.value != 0) {
+            revert REVDeployer_ProjectCreationFeeNotNeeded({revnetId: revnetId, value: msg.value});
+        }
 
         // Deploy the revnet (project, rulesets, ERC-20, suckers, etc.).
         (bytes32 encodedConfigurationHash, REVOwnerRevnetInit memory ownerInit) = _deployRevnetFor({

package/src/interfaces/IREVDeployer.sol

@@ -156,6 +156,7 @@ interface IREVDeployer {
         REVCroptopAllowedPost[] memory allowedPosts
     )
         external
+        payable
         returns (uint256, IJB721TiersHook hook);
 
     /// @notice Deploy a revnet with a default empty tiered ERC-721 hook.
@@ -173,6 +174,7 @@ interface IREVDeployer {
         REVSuckerDeploymentConfig memory suckerDeploymentConfiguration
     )
         external
+        payable
         returns (uint256, IJB721TiersHook hook);
 
     /// @notice Deploy new suckers for an existing revnet.