@rev-net/core-v6 0.0.56 → 0.0.57

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rev-net/core-v6",
-  "version": "0.0.56",
+  "version": "0.0.57",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,14 +26,14 @@
     "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'revnet-core-v6'"
   },
   "dependencies": {
-    "@bananapus/721-hook-v6": "^0.0.50",
-    "@bananapus/buyback-hook-v6": "^0.0.46",
-    "@bananapus/core-v6": "^0.0.53",
-    "@bananapus/ownable-v6": "^0.0.24",
+    "@bananapus/721-hook-v6": "^0.0.51",
+    "@bananapus/buyback-hook-v6": "^0.0.47",
+    "@bananapus/core-v6": "^0.0.54",
+    "@bananapus/ownable-v6": "^0.0.25",
     "@bananapus/permission-ids-v6": "^0.0.25",
-    "@bananapus/router-terminal-v6": "^0.0.43",
-    "@bananapus/suckers-v6": "^0.0.46",
-    "@croptop/core-v6": "^0.0.42",
+    "@bananapus/router-terminal-v6": "^0.0.44",
+    "@bananapus/suckers-v6": "^0.0.47",
+    "@croptop/core-v6": "^0.0.48",
     "@openzeppelin/contracts": "5.6.1",
     "@uniswap/permit2": "github:Uniswap/permit2#cc56ad0f3439c502c246fc5cfcc3db92bb8b7219"
   },

package/src/REVDeployer.sol

@@ -79,12 +79,6 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IERC721Receiver {
     /// @dev 30 days, in seconds.
     uint256 public constant override CASH_OUT_DELAY = 2_592_000;
 
-    /// @notice The cash out fee (as a fraction out of `JBConstants.MAX_FEE`).
-    /// Cashout fees are paid to the revnet with the `FEE_REVNET_ID`.
-    /// @dev Fees are charged on cashouts if the cash out tax rate is greater than 0%.
-    /// @dev When suckers withdraw funds, they do not pay cash out fees.
-    uint256 public constant override FEE = 25; // 2.5%
-
     /// @notice The default Uniswap pool fee tier used when auto-configuring buyback pools.
     /// @dev 10_000 = 1%. This is the standard fee tier for most project token pairs.
     uint24 public constant DEFAULT_BUYBACK_POOL_FEE = 10_000;

package/src/REVOwner.sol

@@ -9,6 +9,7 @@ import {IJBRulesetDataHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetDa
 import {IJBTerminal} from "@bananapus/core-v6/src/interfaces/IJBTerminal.sol";
 import {JBCashOuts} from "@bananapus/core-v6/src/libraries/JBCashOuts.sol";
 import {JBConstants} from "@bananapus/core-v6/src/libraries/JBConstants.sol";
+import {JBFees} from "@bananapus/core-v6/src/libraries/JBFees.sol";
 import {JBAccountingContext} from "@bananapus/core-v6/src/structs/JBAccountingContext.sol";
 import {JBAfterCashOutRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterCashOutRecordedContext.sol";
 import {JBBeforeCashOutRecordedContext} from "@bananapus/core-v6/src/structs/JBBeforeCashOutRecordedContext.sol";
@@ -46,15 +47,6 @@ contract REVOwner is IJBRulesetDataHook, IJBCashOutHook, IJBPeerChainAdjustedAcc
     error REVOwner_CashOutDelayNotFinished(uint256 cashOutDelay, uint256 blockTimestamp);
     error REVOwner_Unauthorized(address caller, address expectedCaller);
 
-    //*********************************************************************//
-    // ------------------------- public constants ------------------------ //
-    //*********************************************************************//
-
-    /// @notice The cash out fee (as a fraction out of `JBConstants.MAX_FEE`).
-    /// @dev Cashout fees are paid to the revnet with the `FEE_REVNET_ID`.
-    /// @dev When suckers withdraw funds, they do not pay cash out fees.
-    uint256 public constant FEE = 25; // 2.5%
-
     //*********************************************************************//
     // --------------- public immutable stored properties ---------------- //
     //*********************************************************************//
@@ -219,7 +211,7 @@ contract REVOwner is IJBRulesetDataHook, IJBCashOutHook, IJBPeerChainAdjustedAcc
         // a better price. This is by design.
         // Micro cash outs (< 40 wei at 2.5% fee) round feeCashOutCount to zero, bypassing the fee.
         // Economically insignificant: the gas cost of the transaction far exceeds the bypassed fee. No fix needed.
-        uint256 feeCashOutCount = mulDiv({x: context.cashOutCount, y: FEE, denominator: JBConstants.MAX_FEE});
+        uint256 feeCashOutCount = JBFees.standardFeeAmountFrom(context.cashOutCount);
         uint256 nonFeeCashOutCount = context.cashOutCount - feeCashOutCount;
 
         // Compute the gross (effective-surplus) reclaim and fee amounts. The bonding curve uses cross-chain effective

package/src/interfaces/IREVDeployer.sol

@@ -119,10 +119,6 @@ interface IREVDeployer {
     /// @return The directory contract.
     function DIRECTORY() external view returns (IJBDirectory);
 
-    /// @notice The cash out fee as a fraction out of `JBConstants.MAX_FEE`.
-    /// @return The fee value.
-    function FEE() external view returns (uint256);
-
     /// @notice The Juicebox project ID of the revnet that receives cash out fees.
     /// @return The fee revnet ID.
     function FEE_REVNET_ID() external view returns (uint256);