@rev-net/core-v6 0.0.41 → 0.0.43

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rev-net/core-v6",
-  "version": "0.0.41",
+  "version": "0.0.43",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -28,7 +28,7 @@
   "dependencies": {
     "@bananapus/721-hook-v6": "0.0.43",
     "@bananapus/buyback-hook-v6": "0.0.37",
-    "@bananapus/core-v6": "0.0.39",
+    "@bananapus/core-v6": "0.0.42",
     "@bananapus/ownable-v6": "0.0.24",
     "@bananapus/permission-ids-v6": "0.0.22",
     "@bananapus/router-terminal-v6": "0.0.36",

package/src/REVLoans.sol

@@ -465,13 +465,11 @@ contract REVLoans is ERC721, ERC2771Context, JBPermissioned, Ownable, IREVLoans
             revert REVLoans_LoanExpired(timeSinceLoanCreated, LOAN_LIQUIDATION_DURATION);
         }
 
-        // Get a reference to the amount prepaid for the full loan. This is an app-level loan fee, so keep it
-        // floor-rounded instead of applying the protocol fee helper's dust minimum.
-        uint256 prepaid = JBFees.feeAmountFromFloor({amountBeforeFee: loan.amount, feePercent: loan.prepaidFeePercent});
+        // Get a reference to the amount prepaid for the full loan.
+        uint256 prepaid = JBFees.feeAmountFrom({amountBeforeFee: loan.amount, feePercent: loan.prepaidFeePercent});
 
-        // This source fee ramps with elapsed time. Use the floor-rounded fee helper so a one-second elapsed window
-        // with zero fee percent stays free instead of inheriting the protocol fee helper's anti-dust minimum.
-        uint256 fullSourceFeeAmount = JBFees.feeAmountFromFloor({
+        // This source fee ramps with elapsed time.
+        uint256 fullSourceFeeAmount = JBFees.feeAmountFrom({
             amountBeforeFee: loan.amount - prepaid,
             feePercent: mulDiv({
                 x: timeSinceLoanCreated - loan.prepaidDuration,
@@ -1014,11 +1012,10 @@ contract REVLoans is ERC721, ERC2771Context, JBPermissioned, Ownable, IREVLoans
         // Keep a reference to the fee terminal.
         IJBTerminal feeTerminal = DIRECTORY.primaryTerminalOf({projectId: REV_ID, token: loan.source.token});
 
-        // Get the amount of additional fee to take for REV. This is an app-level loan fee, not the terminal's
-        // protocol fee, so keep it floor-rounded instead of applying the protocol fee helper's dust minimum.
+        // Get the amount of additional fee to take for REV.
         uint256 revFeeAmount = address(feeTerminal) == address(0)
             ? 0
-            : JBFees.feeAmountFromFloor({amountBeforeFee: addedBorrowAmount, feePercent: REV_PREPAID_FEE_PERCENT});
+            : JBFees.feeAmountFrom({amountBeforeFee: addedBorrowAmount, feePercent: REV_PREPAID_FEE_PERCENT});
 
         // Try to pay the REV fee. If it fails, revFeeAmount is zeroed so the borrower receives it instead.
         if (revFeeAmount > 0) {
@@ -1235,11 +1232,8 @@ contract REVLoans is ERC721, ERC2771Context, JBPermissioned, Ownable, IREVLoans
         // Make sure the minimum borrow amount is met.
         if (borrowAmount < minBorrowAmount) revert REVLoans_UnderMinBorrowAmount(minBorrowAmount, borrowAmount);
 
-        // Get the amount of additional fee to take for the revnet issuing the loan. This is an app-level loan fee,
-        // not the terminal's protocol fee, so keep it floor-rounded instead of applying the protocol fee helper's dust
-        // minimum.
-        uint256 sourceFeeAmount =
-            JBFees.feeAmountFromFloor({amountBeforeFee: borrowAmount, feePercent: prepaidFeePercent});
+        // Get the amount of additional fee to take for the revnet issuing the loan.
+        uint256 sourceFeeAmount = JBFees.feeAmountFrom({amountBeforeFee: borrowAmount, feePercent: prepaidFeePercent});
 
         // Borrow the amount.
         _adjust({

package/src/structs/REVStageConfig.sol

@@ -15,9 +15,10 @@ import {REVAutoIssuance} from "./REVAutoIssuance.sol";
 /// @custom:member splits The split recipients for this stage's production allocation.
 /// @custom:member initialIssuance Tokens per unit of base currency at stage start (18-decimal fixed point).
 /// @custom:member issuanceCutFrequency Seconds between each issuance reduction. Should be >= 24 hours.
-/// @custom:member issuanceCutPercent How much issuance decreases each period, out of 1,000,000,000. 0 = no decay.
-/// @custom:member cashOutTaxRate The tax on cash outs, out of 10,000. 0 = no tax (full reclaim). Higher = more tax
-/// retained by the treasury.
+/// @custom:member issuanceCutPercent How much issuance decreases each period, out of
+/// `JBConstants.MAX_WEIGHT_CUT_PERCENT`. 0 = no decay.
+/// @custom:member cashOutTaxRate The tax on cash outs, out of `JBConstants.MAX_CASH_OUT_TAX_RATE`. 0 = no tax (full
+/// reclaim). Higher = more tax retained by the treasury.
 /// @custom:member extraMetadata Additional metadata bits passed to hooks for stage-specific behavior.
 struct REVStageConfig {
     uint48 startsAtOrAfter;