@rev-net/core-v6 0.0.11 → 0.0.13

package/src/REVLoans.sol

@@ -59,6 +59,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     error REVLoans_InvalidPrepaidFeePercent(uint256 prepaidFeePercent, uint256 min, uint256 max);
     error REVLoans_InvalidTerminal(address terminal, uint256 revnetId);
     error REVLoans_LoanExpired(uint256 timeSinceLoanCreated, uint256 loanLiquidationDuration);
+    error REVLoans_LoanIdOverflow();
     error REVLoans_NewBorrowAmountGreaterThanLoanAmount(uint256 newBorrowAmount, uint256 loanAmount);
     error REVLoans_NoMsgValueAllowed();
     error REVLoans_NotEnoughCollateral();
@@ -70,6 +71,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     error REVLoans_SourceMismatch();
     error REVLoans_Unauthorized(address caller, address owner);
     error REVLoans_UnderMinBorrowAmount(uint256 minBorrowAmount, uint256 borrowAmount);
+    error REVLoans_ZeroBorrowAmount();
     error REVLoans_ZeroCollateralLoanIsInvalid();
 
     //*********************************************************************//
@@ -93,7 +95,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     uint256 public constant override MIN_PREPAID_FEE_PERCENT = 25; // 2.5%
 
     //*********************************************************************//
-    // -------------------- private constant properties ------------------ //
+    // ------------------------ private constants ------------------------ //
     //*********************************************************************//
 
     /// @notice Just a kind reminder to our readers.
@@ -255,7 +257,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     /// @param amount The amount being paid off.
     /// @return sourceFeeAmount The source fee amount for the loan.
     function determineSourceFeeAmount(REVLoan memory loan, uint256 amount) public view returns (uint256) {
-        return _determineSourceFeeAmount(loan, amount);
+        return _determineSourceFeeAmount({loan: loan, amount: amount});
     }
 
     /// @notice The revnet ID for the loan with the provided loan ID.
@@ -416,8 +418,10 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         // If the loan period has passed the prepaid time frame, take a fee.
         if (timeSinceLoanCreated <= loan.prepaidDuration) return 0;
 
-        // If the loan period has reached or passed the liquidation time frame, do not allow loan management.
-        if (timeSinceLoanCreated >= LOAN_LIQUIDATION_DURATION) {
+        // If the loan period has passed the liquidation time frame, do not allow loan management.
+        // Uses `>` (not `>=`) so the exact boundary second is still repayable — the liquidation path
+        // uses `<=`, and matching `>=` here would create a 1-second window where neither path is available.
+        if (timeSinceLoanCreated > LOAN_LIQUIDATION_DURATION) {
             revert REVLoans_LoanExpired(timeSinceLoanCreated, LOAN_LIQUIDATION_DURATION);
         }
 
@@ -426,15 +430,15 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
 
         uint256 fullSourceFeeAmount = JBFees.feeAmountFrom({
             amountBeforeFee: loan.amount - prepaid,
-            feePercent: mulDiv(
-                timeSinceLoanCreated - loan.prepaidDuration,
-                JBConstants.MAX_FEE,
-                LOAN_LIQUIDATION_DURATION - loan.prepaidDuration
-            )
+            feePercent: mulDiv({
+                x: timeSinceLoanCreated - loan.prepaidDuration,
+                y: JBConstants.MAX_FEE,
+                denominator: LOAN_LIQUIDATION_DURATION - loan.prepaidDuration
+            })
         });
 
         // Calculate the source fee amount for the amount being paid off.
-        return mulDiv(fullSourceFeeAmount, amount, loan.amount);
+        return mulDiv({x: fullSourceFeeAmount, y: amount, denominator: loan.amount});
     }
 
     /// @notice Generate a ID for a loan given a revnet ID and a loan number within that revnet.
@@ -461,9 +465,8 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     /// @dev Each source's `totalBorrowedFrom` is stored in the source token's native decimals (e.g. 6 for USDC,
     /// 18 for ETH). Before aggregation, each amount is normalized to the target `decimals` to prevent mixed-decimal
     /// arithmetic errors. For cross-currency sources, the normalized amount is then converted via the price feed.
-    /// @dev Callers should ensure the price feed has sufficient precision for the target `decimals`. Inverse price
-    /// feeds may truncate to zero at low decimal counts (e.g. a feed returning 1e21 at 6 decimals inverts to
-    /// mulDiv(1e6, 1e6, 1e21) = 0), which would cause a division-by-zero in the price conversion.
+    /// @dev Inverse price feeds may truncate to zero at low decimal counts (e.g. a feed returning 1e21 at 6 decimals
+    /// inverts to mulDiv(1e6, 1e6, 1e21) = 0). Sources with a zero price are skipped to prevent division-by-zero.
     /// @param revnetId The ID of the revnet to check for borrowed assets from.
     /// @param decimals The decimals the resulting fixed point value will include.
     /// @param currency The currency the resulting value will be in terms of.
@@ -519,7 +522,12 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
                     decimals: decimals
                 });
 
-                borrowedAmount += mulDiv(normalizedTokens, 10 ** decimals, pricePerUnit);
+                // If the price feed returns zero, skip this source to avoid a division-by-zero panic
+                // that would DoS all loan operations. This intentionally understates total debt for
+                // the affected source — an acceptable tradeoff vs. blocking every borrow/repay.
+                if (pricePerUnit == 0) continue;
+
+                borrowedAmount += mulDiv({x: normalizedTokens, y: 10 ** decimals, denominator: pricePerUnit});
             }
         }
     }
@@ -529,6 +537,8 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     //*********************************************************************//
 
     /// @notice Open a loan by borrowing from a revnet.
+    /// @dev The caller must first grant BURN_TOKENS permission to this contract via JBPermissions.setPermissionsFor().
+    /// This is required because collateral posting burns the caller's tokens through the controller.
     /// @dev Collateral tokens are permanently burned when the loan is created. They are re-minted to the borrower
     /// only upon repayment. If the loan expires (after LOAN_LIQUIDATION_DURATION), the collateral is permanently
     /// lost and cannot be recovered.
@@ -558,7 +568,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         if (collateralCount == 0) revert REVLoans_ZeroCollateralLoanIsInvalid();
 
         // Make sure the source terminal is registered in the directory for this revnet.
-        if (!DIRECTORY.isTerminalOf(revnetId, IJBTerminal(address(source.terminal)))) {
+        if (!DIRECTORY.isTerminalOf({projectId: revnetId, terminal: IJBTerminal(address(source.terminal))})) {
             revert REVLoans_InvalidTerminal(address(source.terminal), revnetId);
         }
 
@@ -579,17 +589,23 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
 
         // Set the loan's values.
         loan.source = source;
-        loan.createdAt = uint40(block.timestamp);
+        loan.createdAt = uint48(block.timestamp);
+        // forge-lint: disable-next-line(unsafe-typecast)
         loan.prepaidFeePercent = uint16(prepaidFeePercent);
-        loan.prepaidDuration = uint32(mulDiv(prepaidFeePercent, LOAN_LIQUIDATION_DURATION, MAX_PREPAID_FEE_PERCENT));
+        loan.prepaidDuration =
+            uint32(mulDiv({x: prepaidFeePercent, y: LOAN_LIQUIDATION_DURATION, denominator: MAX_PREPAID_FEE_PERCENT}));
 
         // Get the amount of the loan.
         uint256 borrowAmount = _borrowAmountFrom({loan: loan, revnetId: revnetId, collateralCount: collateralCount});
 
+        // Revert if the bonding curve returns zero to prevent creating zero-amount loans.
+        if (borrowAmount == 0) revert REVLoans_ZeroBorrowAmount();
+
         // Make sure the minimum borrow amount is met.
         if (borrowAmount < minBorrowAmount) revert REVLoans_UnderMinBorrowAmount(minBorrowAmount, borrowAmount);
 
         // Get the amount of additional fee to take for the revnet issuing the loan.
+        // Fee rounding may leave a few wei of dust — economically insignificant relative to gas costs.
         uint256 sourceFeeAmount = JBFees.feeAmountFrom({amountBeforeFee: borrowAmount, feePercent: prepaidFeePercent});
 
         // Borrow the amount.
@@ -634,6 +650,9 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     /// @param startingLoanId The ID of the loan to start iterating from.
     /// @param count The amount of loans iterate over since the last liquidated loan.
     function liquidateExpiredLoansFrom(uint256 revnetId, uint256 startingLoanId, uint256 count) external override {
+        // Prevent cross-revnet accounting corruption: loan numbers must stay within the revnet's ID namespace.
+        if (startingLoanId + count > _ONE_TRILLION) revert REVLoans_LoanIdOverflow();
+
         // Iterate over the desired number of loans to check for liquidation.
         for (uint256 i; i < count; i++) {
             // Get a reference to the next loan ID.
@@ -794,7 +813,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         if (repayBorrowAmount == 0 && collateralCountToReturn == 0) revert REVLoans_NothingToRepay();
 
         // Keep a reference to the fee that'll be taken.
-        uint256 sourceFeeAmount = _determineSourceFeeAmount(loan, repayBorrowAmount);
+        uint256 sourceFeeAmount = _determineSourceFeeAmount({loan: loan, amount: repayBorrowAmount});
 
         // Add the fee to the repay amount.
         repayBorrowAmount += sourceFeeAmount;
@@ -927,8 +946,8 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         internal
     {
         // Register the source if this is the first time its being used for this revnet.
-        // Note: Sources are only appended, never removed. This is acceptable because the number of distinct
-        // (terminal, token) pairs per revnet is practically bounded.
+        // Note: Sources are only appended, never removed. Gas accumulation from iteration is bounded
+        // because the number of distinct (terminal, token) pairs per revnet is practically small (~5-20).
         if (!isLoanSourceOf[revnetId][loan.source.terminal][loan.source.token]) {
             isLoanSourceOf[revnetId][loan.source.terminal][loan.source.token] = true;
             _loanSourcesOf[revnetId].push(REVLoanSource({token: loan.source.token, terminal: loan.source.terminal}));
@@ -994,6 +1013,9 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         }
 
         // Transfer the remaining balance to the borrower.
+        // Note: In extreme fee configurations the subtraction could theoretically underflow, but the
+        // protocol fee (2.5%) and source fee (capped at prepaidFeePercent) are both small fractions of
+        // the borrowed amount, so `netAmountPaidOut` will always exceed their sum in practice.
         _transferFrom({
             from: address(this),
             to: beneficiary,
@@ -1034,7 +1056,9 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         if (newCollateralCount > type(uint112).max) {
             revert REVLoans_OverflowAlert(newCollateralCount, type(uint112).max);
         }
+        // forge-lint: disable-next-line(unsafe-typecast)
         loan.amount = uint112(newBorrowAmount);
+        // forge-lint: disable-next-line(unsafe-typecast)
         loan.collateral = uint112(newCollateralCount);
 
         // INTERACTIONS: Execute external calls with pre-computed deltas.
@@ -1063,16 +1087,17 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
             });
         }
 
-        // If there is a source fee, pay it.
+        // If there is a source fee, pay it. Wrapped in try-catch so a reverting source terminal
+        // cannot block all loan operations (matching the REV fee pattern above).
         if (sourceFeeAmount > 0) {
-            // Increase the allowance for the beneficiary.
+            // Increase the allowance for the source terminal.
             uint256 payValue = _beforeTransferTo({
                 to: address(loan.source.terminal), token: loan.source.token, amount: sourceFeeAmount
             });
 
-            // Pay the fee.
-            // slither-disable-next-line unused-return
-            loan.source.terminal.pay{value: payValue}({
+            // Pay the fee. If it fails, reclaim the allowance and give the amount back to the borrower.
+            // slither-disable-next-line unused-return,arbitrary-send-eth
+            try loan.source.terminal.pay{value: payValue}({
                 projectId: revnetId,
                 token: loan.source.token,
                 amount: sourceFeeAmount,
@@ -1080,7 +1105,18 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
                 minReturnedTokens: 0,
                 memo: "Fee from loan",
                 metadata: bytes(abi.encodePacked(REV_ID))
-            });
+            }) {}
+            catch (bytes memory) {
+                // If the fee can't be processed, decrease the ERC-20 allowance and return the amount
+                // to the beneficiary instead.
+                if (loan.source.token != JBConstants.NATIVE_TOKEN) {
+                    IERC20(loan.source.token)
+                        .safeDecreaseAllowance({
+                            spender: address(loan.source.terminal), requestedDecrease: sourceFeeAmount
+                        });
+                }
+                _transferFrom({from: address(this), to: beneficiary, token: loan.source.token, amount: sourceFeeAmount});
+            }
         }
     }
 
@@ -1093,7 +1129,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
     function _beforeTransferTo(address to, address token, uint256 amount) internal returns (uint256) {
         // If the token is the native token, no allowance needed.
         if (token == JBConstants.NATIVE_TOKEN) return amount;
-        IERC20(token).safeIncreaseAllowance(to, amount);
+        IERC20(token).safeIncreaseAllowance({spender: to, value: amount});
         return 0;
     }
 
@@ -1342,7 +1378,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         }
 
         // If there's sufficient approval, transfer normally.
-        if (IERC20(token).allowance(address(from), address(this)) >= amount) {
+        if (IERC20(token).allowance({owner: address(from), spender: address(this)}) >= amount) {
             return IERC20(token).safeTransferFrom({from: from, to: to, value: amount});
         }
 
@@ -1350,6 +1386,7 @@ contract REVLoans is ERC721, ERC2771Context, Ownable, IREVLoans {
         if (amount > type(uint160).max) revert REVLoans_OverflowAlert(amount, type(uint160).max);
 
         // Otherwise, attempt to use the `permit2` method.
+        // forge-lint: disable-next-line(unsafe-typecast)
         PERMIT2.transferFrom({from: from, to: to, amount: uint160(amount), token: token});
     }
 

package/src/interfaces/IREVDeployer.sol

@@ -8,7 +8,6 @@ import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";
 import {IJBProjects} from "@bananapus/core-v6/src/interfaces/IJBProjects.sol";
 import {IJBBuybackHookRegistry} from "@bananapus/buyback-hook-v6/src/interfaces/IJBBuybackHookRegistry.sol";
-import {IJBRulesetDataHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetDataHook.sol";
 import {JBRulesetConfig} from "@bananapus/core-v6/src/structs/JBRulesetConfig.sol";
 import {JBTerminalConfig} from "@bananapus/core-v6/src/structs/JBTerminalConfig.sol";
 import {IJBSuckerRegistry} from "@bananapus/suckers-v6/src/interfaces/IJBSuckerRegistry.sol";
@@ -182,52 +181,55 @@ interface IREVDeployer {
     /// @param revnetId The ID of the revnet whose tokens should be burned.
     function burnHeldTokensOf(uint256 revnetId) external;
 
-    /// @notice Deploy a revnet, or initialize an existing Juicebox project as a revnet.
+    /// @notice Deploy a revnet with a tiered ERC-721 hook and optional croptop posting support.
+    /// @dev Every revnet gets a 721 hook — pass an empty config if no tiers are needed initially.
     /// @param revnetId The ID of the Juicebox project to initialize. Send 0 to deploy a new revnet.
     /// @param configuration Core revnet configuration.
     /// @param terminalConfigurations The terminals to set up for the revnet.
     /// @param suckerDeploymentConfiguration The suckers to set up for cross-chain token transfers.
+    /// @param tiered721HookConfiguration How to set up the tiered ERC-721 hook for the revnet.
+    /// @param allowedPosts Restrictions on which croptop posts are allowed on the revnet's ERC-721 tiers.
     /// @return The ID of the newly created or initialized revnet.
+    /// @return hook The tiered ERC-721 hook that was deployed for the revnet.
     function deployFor(
         uint256 revnetId,
         REVConfig memory configuration,
         JBTerminalConfig[] memory terminalConfigurations,
-        REVSuckerDeploymentConfig memory suckerDeploymentConfiguration
-    )
-        external
-        returns (uint256);
-
-    /// @notice Deploy new suckers for an existing revnet.
-    /// @param revnetId The ID of the revnet to deploy suckers for.
-    /// @param suckerDeploymentConfiguration The suckers to set up for the revnet.
-    /// @return suckers The addresses of the deployed suckers.
-    function deploySuckersFor(
-        uint256 revnetId,
-        REVSuckerDeploymentConfig calldata suckerDeploymentConfiguration
+        REVSuckerDeploymentConfig memory suckerDeploymentConfiguration,
+        REVDeploy721TiersHookConfig memory tiered721HookConfiguration,
+        REVCroptopAllowedPost[] memory allowedPosts
     )
         external
-        returns (address[] memory suckers);
+        returns (uint256, IJB721TiersHook hook);
 
-    /// @notice Deploy a revnet with tiered ERC-721s and optional croptop posting support.
+    /// @notice Deploy a revnet with a default empty tiered ERC-721 hook.
+    /// @dev Convenience overload — constructs an empty 721 config internally and delegates to the 6-arg version.
     /// @param revnetId The ID of the Juicebox project to initialize. Send 0 to deploy a new revnet.
     /// @param configuration Core revnet configuration.
     /// @param terminalConfigurations The terminals to set up for the revnet.
     /// @param suckerDeploymentConfiguration The suckers to set up for cross-chain token transfers.
-    /// @param tiered721HookConfiguration How to set up the tiered ERC-721 hook.
-    /// @param allowedPosts Restrictions on which croptop posts are allowed on the revnet's ERC-721 tiers.
     /// @return The ID of the newly created or initialized revnet.
     /// @return hook The tiered ERC-721 hook that was deployed for the revnet.
-    function deployWith721sFor(
+    function deployFor(
         uint256 revnetId,
-        REVConfig calldata configuration,
+        REVConfig memory configuration,
         JBTerminalConfig[] memory terminalConfigurations,
-        REVSuckerDeploymentConfig memory suckerDeploymentConfiguration,
-        REVDeploy721TiersHookConfig memory tiered721HookConfiguration,
-        REVCroptopAllowedPost[] memory allowedPosts
+        REVSuckerDeploymentConfig memory suckerDeploymentConfiguration
     )
         external
         returns (uint256, IJB721TiersHook hook);
 
+    /// @notice Deploy new suckers for an existing revnet.
+    /// @param revnetId The ID of the revnet to deploy suckers for.
+    /// @param suckerDeploymentConfiguration The suckers to set up for the revnet.
+    /// @return suckers The addresses of the deployed suckers.
+    function deploySuckersFor(
+        uint256 revnetId,
+        REVSuckerDeploymentConfig calldata suckerDeploymentConfiguration
+    )
+        external
+        returns (address[] memory suckers);
+
     /// @notice Change a revnet's split operator. Only the current split operator can call this.
     /// @param revnetId The ID of the revnet.
     /// @param newSplitOperator The new split operator's address.

package/src/structs/REV721TiersHookFlags.sol

@@ -6,6 +6,7 @@ pragma solidity ^0.8.0;
 /// @custom:member noNewTiersWithOwnerMinting A flag indicating if new tiers with owner minting are forbidden.
 /// @custom:member preventOverspending A flag indicating if payments exceeding the price of minted NFTs should be
 /// prevented.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REV721TiersHookFlags {
     bool noNewTiersWithReserves;
     bool noNewTiersWithVotes;

package/src/structs/REVAutoIssuance.sol

@@ -4,6 +4,7 @@ pragma solidity ^0.8.0;
 /// @custom:member chainId The ID of the chain on which the mint should be honored.
 /// @custom:member count The number of tokens that should be minted.
 /// @custom:member beneficiary The address that will receive the minted tokens.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVAutoIssuance {
     uint32 chainId;
     uint104 count;

package/src/structs/REVBaseline721HookConfig.sol

@@ -15,6 +15,7 @@ import {REV721TiersHookFlags} from "./REV721TiersHookFlags.sol";
 /// @custom:member reserveBeneficiary The default reserve beneficiary for the NFT collection.
 /// @custom:member flags A set of flags that configure the 721 hook. Omits `issueTokensForSplits` since revnets
 /// always force it to `false`.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVBaseline721HookConfig {
     string name;
     string symbol;

package/src/structs/REVConfig.sol

@@ -9,6 +9,7 @@ import {REVStageConfig} from "./REVStageConfig.sol";
 /// @custom:member splitOperator The address that will receive the token premint and initial production split,
 /// and who is allowed to change who the operator is. Only the operator can replace itself after deployment.
 /// @custom:member stageConfigurations The periods of changing constraints.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVConfig {
     REVDescription description;
     uint32 baseCurrency;

package/src/structs/REVCroptopAllowedPost.sol

@@ -10,6 +10,7 @@ pragma solidity ^0.8.0;
 /// @custom:member maximumSplitPercent The maximum split percent (out of JBConstants.SPLITS_TOTAL_PERCENT) that a
 /// poster can set. 0 means splits are not allowed.
 /// @custom:member allowedAddresses A list of addresses that are allowed to post on the category through Croptop.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVCroptopAllowedPost {
     uint24 category;
     uint104 minimumPrice;

package/src/structs/REVDeploy721TiersHookConfig.sol

@@ -5,21 +5,20 @@ import {REVBaseline721HookConfig} from "./REVBaseline721HookConfig.sol";
 
 /// @custom:member baseline721HookConfiguration The baseline config.
 /// @custom:member salt The salt to base the collection's address on.
-/// @custom:member splitOperatorCanAdjustTiers A flag indicating if the revnet's split operator can add tiers and remove
-/// tiers if
-/// the tier is allowed to be removed
-/// @custom:member splitOperatorCanUpdateMetadata A flag indicating if the revnet's split operator can update the 721's
-/// metadata.
-/// @custom:member splitOperatorCanMint A flag indicating if the revnet's split operator can mint 721's from tiers that
-/// allow it.
-/// @custom:member splitOperatorCanIncreaseDiscountPercent A flag indicating if the revnet's split operator can increase
-/// the
-/// discount of a tier.
+/// @custom:member preventSplitOperatorAdjustingTiers A flag indicating if the revnet's split operator should be
+/// prevented from adding tiers and removing tiers that are allowed to be removed.
+/// @custom:member preventSplitOperatorUpdatingMetadata A flag indicating if the revnet's split operator should be
+/// prevented from updating the 721's metadata.
+/// @custom:member preventSplitOperatorMinting A flag indicating if the revnet's split operator should be prevented from
+/// minting 721's from tiers that allow it.
+/// @custom:member preventSplitOperatorIncreasingDiscountPercent A flag indicating if the revnet's split operator should
+/// be prevented from increasing the discount of a tier.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVDeploy721TiersHookConfig {
     REVBaseline721HookConfig baseline721HookConfiguration;
     bytes32 salt;
-    bool splitOperatorCanAdjustTiers;
-    bool splitOperatorCanUpdateMetadata;
-    bool splitOperatorCanMint;
-    bool splitOperatorCanIncreaseDiscountPercent;
+    bool preventSplitOperatorAdjustingTiers;
+    bool preventSplitOperatorUpdatingMetadata;
+    bool preventSplitOperatorMinting;
+    bool preventSplitOperatorIncreasingDiscountPercent;
 }

package/src/structs/REVDescription.sol

@@ -6,6 +6,7 @@ pragma solidity ^0.8.0;
 /// @custom:member uri The metadata URI containing revnet's info.
 /// @custom:member salt Revnets deployed across chains by the same address with the same salt will have the same
 /// address.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVDescription {
     string name;
     string ticker;

package/src/structs/REVLoan.sol

@@ -9,6 +9,7 @@ import {REVLoanSource} from "./REVLoanSource.sol";
 /// @custom:member prepaidFeePercent The percentage of the loan's fees that were prepaid.
 /// @custom:member prepaidDuration The duration that the loan was prepaid for.
 /// @custom:member source The source of the loan.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVLoan {
     uint112 amount;
     uint112 collateral;

package/src/structs/REVLoanSource.sol

@@ -5,6 +5,7 @@ import {IJBPayoutTerminal} from "@bananapus/core-v6/src/interfaces/IJBPayoutTerm
 
 /// @custom:member token The token that is being loaned.
 /// @custom:member terminal The terminal that the loan is being made from.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVLoanSource {
     address token;
     IJBPayoutTerminal terminal;

package/src/structs/REVStageConfig.sol

@@ -21,6 +21,7 @@ import {REVAutoIssuance} from "./REVAutoIssuance.sol";
 /// cashed out. This rate is out of 10_000 (JBConstants.MAX_CASH_OUT_TAX_RATE). 0% corresponds to no tax when cashing
 /// out.
 /// @custom:member extraMetadata Extra info to attach set into this stage that may affect hooks.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVStageConfig {
     uint48 startsAtOrAfter;
     REVAutoIssuance[] autoIssuances;

package/src/structs/REVSuckerDeploymentConfig.sol

@@ -5,6 +5,7 @@ import {JBSuckerDeployerConfig} from "@bananapus/suckers-v6/src/structs/JBSucker
 
 /// @custom:member deployerConfigurations The information for how to suck tokens to other chains.
 /// @custom:member salt The salt to use for creating suckers so that they use the same address across chains.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct REVSuckerDeploymentConfig {
     JBSuckerDeployerConfig[] deployerConfigurations;
     bytes32 salt;