@rev-net/core-v6 0.0.1 → 0.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@rev-net/core-v6",
-    "version": "0.0.1",
+    "version": "0.0.2",
     "license": "MIT",
     "repository": {
         "type": "git",
@@ -18,8 +18,8 @@
     "dependencies": {
         "@bananapus/721-hook-v6": "^0.0.2",
         "@bananapus/buyback-hook-v6": "^0.0.1",
-        "@bananapus/core-v6": "^0.0.3",
-        "@bananapus/permission-ids-v6": "^0.0.1",
+        "@bananapus/core-v6": "^0.0.4",
+        "@bananapus/permission-ids-v6": "^0.0.2",
         "@bananapus/suckers-v6": "^0.0.1",
         "@bananapus/swap-terminal-v6": "^0.0.2",
         "@croptop/core-v6": "^0.0.3",

package/src/REVDeployer.sol

@@ -528,20 +528,19 @@ contract REVDeployer is ERC2771Context, IREVDeployer, IJBRulesetDataHook, IJBCas
         uint256[] memory customSplitOperatorPermissionIndexes = _extraOperatorPermissions[revnetId];
 
         // Make the array that merges the default and custom operator permissions.
-        allOperatorPermissions = new uint256[](9 + customSplitOperatorPermissionIndexes.length);
+        allOperatorPermissions = new uint256[](8 + customSplitOperatorPermissionIndexes.length);
         allOperatorPermissions[0] = JBPermissionIds.SET_SPLIT_GROUPS;
         allOperatorPermissions[1] = JBPermissionIds.SET_BUYBACK_POOL;
         allOperatorPermissions[2] = JBPermissionIds.SET_BUYBACK_TWAP;
         allOperatorPermissions[3] = JBPermissionIds.SET_PROJECT_URI;
         allOperatorPermissions[4] = JBPermissionIds.ADD_PRICE_FEED;
         allOperatorPermissions[5] = JBPermissionIds.SUCKER_SAFETY;
-        allOperatorPermissions[6] = JBPermissionIds.ADD_SWAP_TERMINAL_POOL;
-        allOperatorPermissions[7] = JBPermissionIds.SET_BUYBACK_HOOK;
-        allOperatorPermissions[8] = JBPermissionIds.SET_SWAP_TERMINAL;
+        allOperatorPermissions[6] = JBPermissionIds.SET_BUYBACK_HOOK;
+        allOperatorPermissions[7] = JBPermissionIds.SET_ROUTER_TERMINAL;
 
         // Copy the custom permissions into the array.
         for (uint256 i; i < customSplitOperatorPermissionIndexes.length; i++) {
-            allOperatorPermissions[9 + i] = customSplitOperatorPermissionIndexes[i];
+            allOperatorPermissions[8 + i] = customSplitOperatorPermissionIndexes[i];
         }
     }
 

package/test/TestPR29_SwapTerminalPermission.t.sol

@@ -28,9 +28,8 @@ import {JB721TiersHookStore} from "@bananapus/721-hook-v6/src/JB721TiersHookStor
 import {JBAddressRegistry} from "@bananapus/address-registry-v6/src/JBAddressRegistry.sol";
 import {IJBAddressRegistry} from "@bananapus/address-registry-v6/src/interfaces/IJBAddressRegistry.sol";
 
-/// @notice Tests for PR #29: fix/l27-swap-terminal-permission
-/// Verifies that ADD_SWAP_TERMINAL_POOL (permission ID 26) is included in the default
-/// split operator permissions. The fix adds this as the 7th default permission.
+/// @notice Tests for default operator permissions including SET_ROUTER_TERMINAL.
+/// Verifies that all default split operator permissions are granted correctly.
 contract TestPR29_SwapTerminalPermission is TestBaseWorkflow, JBTest {
     bytes32 REV_DEPLOYER_SALT = "REVDeployer";
 
@@ -145,7 +144,7 @@ contract TestPR29_SwapTerminalPermission is TestBaseWorkflow, JBTest {
         });
     }
 
-    /// @notice Verify the split operator has SET_BUYBACK_HOOK and SET_SWAP_TERMINAL permissions.
+    /// @notice Verify the split operator has SET_BUYBACK_HOOK and SET_ROUTER_TERMINAL permissions.
     function test_splitOperator_hasRegistryPermissions() public view {
         bool hasBuybackHook = jbPermissions()
             .hasPermission({
@@ -158,31 +157,30 @@ contract TestPR29_SwapTerminalPermission is TestBaseWorkflow, JBTest {
             });
         assertTrue(hasBuybackHook, "Split operator should have SET_BUYBACK_HOOK permission");
 
-        bool hasSwapTerminal = jbPermissions()
+        bool hasRouterTerminal = jbPermissions()
             .hasPermission({
                 operator: multisig(),
                 account: address(REV_DEPLOYER),
                 projectId: TEST_REVNET_ID,
-                permissionId: JBPermissionIds.SET_SWAP_TERMINAL,
+                permissionId: JBPermissionIds.SET_ROUTER_TERMINAL,
                 includeRoot: false,
                 includeWildcardProjectId: false
             });
-        assertTrue(hasSwapTerminal, "Split operator should have SET_SWAP_TERMINAL permission");
+        assertTrue(hasRouterTerminal, "Split operator should have SET_ROUTER_TERMINAL permission");
     }
 
-    /// @notice Verify all 9 default permissions are present for the split operator.
+    /// @notice Verify all 8 default permissions are present for the split operator.
     function test_allDefaultPermissionsPresent() public view {
-        // All 9 default permissions that should be granted
-        uint256[9] memory expectedPermissions = [
+        // All 8 default permissions that should be granted
+        uint256[8] memory expectedPermissions = [
             uint256(JBPermissionIds.SET_SPLIT_GROUPS),
             uint256(JBPermissionIds.SET_BUYBACK_POOL),
             uint256(JBPermissionIds.SET_BUYBACK_TWAP),
             uint256(JBPermissionIds.SET_PROJECT_URI),
             uint256(JBPermissionIds.ADD_PRICE_FEED),
             uint256(JBPermissionIds.SUCKER_SAFETY),
-            uint256(JBPermissionIds.ADD_SWAP_TERMINAL_POOL),
             uint256(JBPermissionIds.SET_BUYBACK_HOOK),
-            uint256(JBPermissionIds.SET_SWAP_TERMINAL)
+            uint256(JBPermissionIds.SET_ROUTER_TERMINAL)
         ];
 
         for (uint256 i = 0; i < expectedPermissions.length; i++) {