@rettangoli/vt 1.0.3 → 1.0.5

package/README.md

@@ -21,6 +21,7 @@ Behavior split:
 - `--concurrency <number>`
 - `--timeout <ms>`
 - `--wait-event <name>`
+- `--isolation <fast|strict>`
 - `--folder <path>` (repeatable)
 - `--group <section-key>` (repeatable)
 - `--item <spec-path>` (repeatable)
@@ -69,7 +70,7 @@ rtgl vt report --group components-basic
 rtgl vt report --item components/forms/login
 ```
 
-Everything else in capture is internal and intentionally not user-configurable.
+Other capture tuning remains internal and intentionally not user-configurable.
 
 ## Config
 
@@ -85,6 +86,7 @@ vt:
   concurrency: 4
   timeout: 30000
   waitEvent: vt:ready
+  isolationMode: strict
   viewport:
     id: desktop
     width: 1280
@@ -99,6 +101,8 @@ Notes:
 - `vt.sections` is required.
 - `vt.service` is optional. When set, VT starts the command before capture, waits for `vt.url`, then stops it after capture.
 - when `vt.service` is omitted and `vt.url` is set, VT expects that URL to already be running.
+- `vt.isolationMode` is optional: `fast` or `strict`. Default is `fast`.
+- `strict` uses a fresh browser context per captured spec and is recommended for real app routes or IndexedDB-backed state.
 - Section page keys are derived as `kebab-case(title)` for flat sections and group `items[].title`.
 - Derived section page keys must be unique case-insensitively.
 - `vt.viewport` supports object or array; each viewport requires `id`, `width`, `height`.
@@ -142,15 +146,15 @@ Screenshot naming:
 A pre-built Docker image with `rtgl` and Playwright browsers is available:
 
 ```bash
-docker pull han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.10
+docker pull han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.12
 ```
 
 Run commands against a local project:
 
 ```bash
-docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.10 rtgl vt screenshot
-docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.10 rtgl vt report
-docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.10 rtgl vt accept
+docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.12 rtgl vt screenshot
+docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.12 rtgl vt report
+docker run --rm -v "$(pwd):/workspace" han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.12 rtgl vt accept
 ```
 
 Note:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rettangoli/vt",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "Rettangoli Visual Testing",
   "type": "module",
   "repository": {

package/src/capture/playwright-runner.js

@@ -56,15 +56,11 @@ export class PlaywrightRunner {
     this.envVarPrefix = envVarPrefix;
     this.envVars = collectEnvVars(this.envVarPrefix);
     this.sharedContext = null;
-    this.sharedPage = null;
-    this.sharedRegisteredReadyEvents = new Set();
   }
 
   async initialize() {
     if (this.isolationMode === "fast") {
       this.sharedContext = await this.createContext();
-      this.sharedPage = await this.sharedContext.newPage();
-      await this.configurePage(this.sharedPage);
     }
   }
 
@@ -72,8 +68,6 @@ export class PlaywrightRunner {
     if (this.sharedContext) {
       await this.sharedContext.close();
       this.sharedContext = null;
-      this.sharedPage = null;
-      this.sharedRegisteredReadyEvents.clear();
     }
   }
 
@@ -83,8 +77,6 @@ export class PlaywrightRunner {
     }
     await this.dispose();
     this.sharedContext = await this.createContext();
-    this.sharedPage = await this.sharedContext.newPage();
-    await this.configurePage(this.sharedPage);
   }
 
   async createContext() {
@@ -138,32 +130,13 @@ export class PlaywrightRunner {
     });
   }
 
-  async acquireSession() {
-    if (this.isolationMode === "strict") {
-      const context = await this.createContext();
-      const page = await context.newPage();
-      await this.configurePage(page);
-      return {
-        page,
-        resetSession: async () => 0,
-        registeredReadyEvents: new Set(),
-        cleanup: async () => {
-          await context.close();
-        },
-      };
+  async clearOriginRuntimeState(page) {
+    if (!page || page.isClosed()) {
+      return;
     }
 
-    if (!this.sharedContext) {
-      this.sharedContext = await this.createContext();
-    }
-    if (!this.sharedPage || this.sharedPage.isClosed()) {
-      this.sharedPage = await this.sharedContext.newPage();
-      await this.configurePage(this.sharedPage);
-    }
-    const resetSession = async () => {
-      const resetStart = nowMs();
-      // Clear origin-scoped runtime state before switching away.
-      await this.sharedPage.evaluate(async () => {
+    try {
+      await page.evaluate(async () => {
         try {
           localStorage.clear();
         } catch {}
@@ -183,18 +156,48 @@ export class PlaywrightRunner {
           }
         } catch {}
       });
-      await this.sharedPage.goto("about:blank", { waitUntil: "domcontentloaded" });
+    } catch {}
+  }
+
+  async acquireSession() {
+    if (this.isolationMode === "strict") {
+      const context = await this.createContext();
+      const page = await context.newPage();
+      await this.configurePage(page);
+      return {
+        page,
+        resetSession: async () => 0,
+        registeredReadyEvents: new Set(),
+        cleanup: async () => {
+          await context.close();
+        },
+      };
+    }
+
+    if (!this.sharedContext) {
+      this.sharedContext = await this.createContext();
+    }
+
+    const page = await this.sharedContext.newPage();
+    await this.configurePage(page);
+
+    const resetSession = async () => {
+      const resetStart = nowMs();
       await this.sharedContext.clearCookies();
       await this.sharedContext.clearPermissions();
-      await this.configurePage(this.sharedPage);
       return nowMs() - resetStart;
     };
 
     return {
-      page: this.sharedPage,
+      page,
       resetSession,
-      registeredReadyEvents: this.sharedRegisteredReadyEvents,
-      cleanup: async () => {},
+      registeredReadyEvents: new Set(),
+      cleanup: async () => {
+        await this.clearOriginRuntimeState(page);
+        if (!page.isClosed()) {
+          await page.close();
+        }
+      },
     };
   }
 

package/src/cli/generate-options.js

@@ -11,6 +11,7 @@ export function resolveGenerateOptions(options = {}, configData = {}) {
     concurrency: cliConcurrency,
     timeout: cliTimeout,
     waitEvent: cliWaitEvent,
+    isolation: cliIsolation,
     folder: cliFolder,
     group: cliGroup,
     item: cliItem,
@@ -20,6 +21,7 @@ export function resolveGenerateOptions(options = {}, configData = {}) {
 
   const waitEvent = cliWaitEvent ?? configData.waitEvent;
   const timeout = cliTimeout ?? configData.timeout ?? 30000;
+  const isolationMode = cliIsolation ?? configData.isolationMode ?? "fast";
   const selectors = normalizeSelectors({
     folder: cliFolder,
     group: cliGroup,
@@ -52,7 +54,7 @@ export function resolveGenerateOptions(options = {}, configData = {}) {
     screenshotWaitTime: 0,
     waitStrategy: waitEvent ? "event" : "load",
     workerCount: cliConcurrency ?? configData.concurrency ?? undefined, // adaptive worker planning
-    isolationMode: "fast",
+    isolationMode,
     navigationTimeout: timeout,
     readyTimeout: timeout,
     screenshotTimeout: timeout,
@@ -84,6 +86,11 @@ export function resolveGenerateOptions(options = {}, configData = {}) {
       throw new Error(`Invalid waitEvent: expected a non-empty string, got ${typeof resolvedOptions.waitEvent}.`);
     }
   }
+  if (!["fast", "strict"].includes(resolvedOptions.isolationMode)) {
+    throw new Error(
+      `Invalid isolation: expected "fast" or "strict", got "${resolvedOptions.isolationMode}".`,
+    );
+  }
   if (resolvedOptions.configUrl !== undefined && resolvedOptions.configUrl !== null) {
     if (typeof resolvedOptions.configUrl !== "string" || resolvedOptions.configUrl.trim().length === 0) {
       throw new Error(`Invalid url: expected a non-empty string, got ${typeof resolvedOptions.configUrl}.`);

package/src/validation.js

@@ -112,7 +112,6 @@ const LEGACY_CAPTURE_FIELDS = {
   waitSelector: true,
   waitStrategy: true,
   workerCount: true,
-  isolationMode: true,
   navigationTimeout: true,
   readyTimeout: true,
   screenshotTimeout: true,
@@ -557,6 +556,7 @@ export function validateVtConfig(vtConfig, sourcePath = "rettangoli.config.yaml"
   validateOptionalNumber(vtConfig.concurrency, "vt.concurrency", { integer: true, min: 1 });
   validateOptionalNumber(vtConfig.timeout, "vt.timeout", { integer: true, min: 1 });
   validateOptionalString(vtConfig.waitEvent, "vt.waitEvent");
+  validateOptionalEnum(vtConfig.isolationMode, "vt.isolationMode", ["fast", "strict"]);
   normalizeViewportField(vtConfig.viewport, "vt.viewport");
   validateOptionalNumber(vtConfig.colorThreshold, "vt.colorThreshold", { min: 0, max: 1 });
   validateOptionalNumber(vtConfig.diffThreshold, "vt.diffThreshold", { min: 0, max: 100 });