@reticlehq/browser 3.8.0 → 3.8.2

package/dist/actions/action-report.js

@@ -10,13 +10,15 @@ export function visibleCanvases(doc) {
     const height = doc.defaultView?.innerHeight ?? 0;
     let count = 0;
     for (const canvas of doc.querySelectorAll(CANVAS_SELECTOR)) {
-        if (isReticleUi(canvas))
+        if (isReticleUi(canvas)) {
             continue;
+        }
         const box = canvas.getBoundingClientRect();
         const sized = box.width > 0 && box.height > 0;
         const onScreen = box.bottom > 0 && box.right > 0 && box.top < height && box.left < width;
-        if (sized && onScreen)
+        if (sized && onScreen) {
             count += 1;
+        }
     }
     return count;
 }
@@ -27,22 +29,28 @@ export function anchorOf(el) {
     if (testid !== undefined) {
         out.testid = testid;
         const shared = elementsMatching({ by: QueryBy.TESTID, value: testid }).length;
-        if (1 < shared)
+        if (1 < shared) {
             out.testidOf = shared;
+        }
     }
     const component = info?.componentStack[0];
-    if (component !== undefined)
+    if (component !== undefined) {
         out.component = component;
-    if (info?.source !== undefined)
+    }
+    if (info?.source !== undefined) {
         out.source = info.source;
+    }
     const role = getRole(el);
     const name = getAccessibleName(el);
-    if (role.length > 0)
+    if (role.length > 0) {
         out.role = role;
-    if (name.length > 0)
+    }
+    if (name.length > 0) {
         out.name = name;
-    if (isSensitiveField(el))
+    }
+    if (isSensitiveField(el)) {
         out.secret = true;
+    }
     if (role.length > 0 && name.length > 0) {
         const same = elementsMatching({ by: QueryBy.ROLE, value: role, name });
         const at = same.indexOf(el);
@@ -63,25 +71,35 @@ export const result = (ref, action, effect, settled, settleReason, anchor, warni
         settleReason,
         effect,
     };
-    if (anchor.testid !== undefined)
+    if (anchor.testid !== undefined) {
         base.testid = anchor.testid;
-    if (anchor.testidOf !== undefined)
+    }
+    if (anchor.testidOf !== undefined) {
         base.testidOf = anchor.testidOf;
-    if (anchor.component !== undefined)
+    }
+    if (anchor.component !== undefined) {
         base.component = anchor.component;
-    if (anchor.source !== undefined)
+    }
+    if (anchor.source !== undefined) {
         base.source = anchor.source;
-    if (anchor.role !== undefined)
+    }
+    if (anchor.role !== undefined) {
         base.role = anchor.role;
-    if (anchor.name !== undefined)
+    }
+    if (anchor.name !== undefined) {
         base.name = anchor.name;
-    if (anchor.nth !== undefined)
+    }
+    if (anchor.nth !== undefined) {
         base.nth = anchor.nth;
-    if (anchor.of !== undefined)
+    }
+    if (anchor.of !== undefined) {
         base.of = anchor.of;
-    if (anchor.secret !== undefined)
+    }
+    if (anchor.secret !== undefined) {
         base.secret = anchor.secret;
-    if (warning !== undefined)
+    }
+    if (warning !== undefined) {
         base.warning = warning;
+    }
     return base;
 };

package/dist/actions/actions-dom.d.ts

@@ -1,4 +1,6 @@
 import type { ActionTarget } from '../dom/realm.js';
+import { ClickButton } from '@reticlehq/core';
+import { type ModifierFlags } from './actions-press.js';
 interface ClickGeometry {
     occluded: boolean;
     occludedBy: string | null;
@@ -9,11 +11,17 @@ interface ClickGeometry {
 }
 export declare const NO_GEOMETRY: ClickGeometry;
 export declare function mouseEventFor(el: Element, type: string, init?: MouseEventInit): MouseEvent;
+export interface ClickInput {
+    modifiers: ModifierFlags;
+    button: ClickButton;
+}
+export declare const PLAIN_CLICK: ClickInput;
+export declare function clickInputOf(args: Record<string, unknown>): ClickInput;
 export declare function fireClickSequence(el: ActionTarget, hold?: {
     ms: number;
     sleep: (ms: number) => Promise<void>;
     now: () => number;
-}, detail?: number): Promise<{
+}, detail?: number, input?: ClickInput): Promise<{
     prevented: boolean;
     heldMs: number;
 }>;

package/dist/actions/actions-dom.js

@@ -4,6 +4,8 @@ import { getAccessibleName, getRole } from '../dom/a11y.js';
 import { hitTestOccluder } from '../dom/occlusion.js';
 import { nativeFrame } from '../timers/native/native-timers.js';
 import { asSyntheticInput } from './synthetic/synthetic-input.js';
+import { ClickButton, clickButtonFromArgs } from '@reticlehq/core';
+import { pressModifiers } from './actions-press.js';
 export const NO_GEOMETRY = {
     occluded: false,
     occludedBy: null,
@@ -20,7 +22,22 @@ function pointerEventFor(el, type, init) {
 }
 const BUTTON_HELD = 1;
 const BUTTON_RELEASED = 0;
-function fireAt(el, type, at, buttons, related, detail = 0) {
+export const PLAIN_CLICK = {
+    modifiers: { metaKey: false, ctrlKey: false, shiftKey: false, altKey: false },
+    button: ClickButton.LEFT,
+};
+const BUTTON_CODES = {
+    [ClickButton.LEFT]: { button: 0, bit: 1 },
+    [ClickButton.RIGHT]: { button: 2, bit: 2 },
+    [ClickButton.MIDDLE]: { button: 1, bit: 4 },
+};
+export function clickInputOf(args) {
+    return {
+        modifiers: pressModifiers(args),
+        button: clickButtonFromArgs(args) ?? ClickButton.LEFT,
+    };
+}
+function fireAt(el, type, at, buttons, related, detail = 0, input = PLAIN_CLICK) {
     const init = {
         bubbles: !(type.endsWith('enter') || type.endsWith('leave')),
         cancelable: true,
@@ -30,31 +47,42 @@ function fireAt(el, type, at, buttons, related, detail = 0) {
         screenX: at.x,
         screenY: at.y,
         buttons,
-        button: 0,
+        button: BUTTON_CODES[input.button].button,
+        ...input.modifiers,
         ...(related !== undefined ? { relatedTarget: related } : {}),
     };
     return el.dispatchEvent(type.startsWith('pointer')
         ? pointerEventFor(el, type, { ...init, pointerId: 1, isPrimary: true })
         : mouseEventFor(el, type, init));
 }
-export async function fireClickSequence(el, hold, detail) {
+export async function fireClickSequence(el, hold, detail, input = PLAIN_CLICK) {
     const doc = el.ownerDocument;
     const from = doc.activeElement ?? doc.body;
     const at = centreOf(el);
     const d = detail ?? 0;
-    asSyntheticInput(() => fireAt(el, 'pointerdown', at, BUTTON_HELD, from, d));
-    asSyntheticInput(() => fireAt(el, 'mousedown', at, BUTTON_HELD, undefined, d));
-    if (el.tabIndex >= 0 && 'function' === typeof el.focus)
+    const held = BUTTON_CODES[input.button].bit;
+    const isLeft = ClickButton.LEFT === input.button;
+    let notPrevented = true;
+    asSyntheticInput(() => fireAt(el, 'pointerdown', at, held, from, d, input));
+    asSyntheticInput(() => fireAt(el, 'mousedown', at, held, undefined, d, input));
+    if (ClickButton.RIGHT === input.button) {
+        notPrevented = asSyntheticInput(() => fireAt(el, 'contextmenu', at, held, undefined, d, input));
+    }
+    if (el.tabIndex >= 0 && 'function' === typeof el.focus) {
         el.focus();
+    }
     let heldMs = 0;
     if (hold !== undefined && hold.ms > 0) {
         const startedAt = hold.now();
         await hold.sleep(hold.ms);
         heldMs = hold.now() - startedAt;
     }
-    asSyntheticInput(() => fireAt(el, 'pointerup', at, BUTTON_RELEASED, from, d));
-    asSyntheticInput(() => fireAt(el, 'mouseup', at, BUTTON_RELEASED, undefined, d));
-    const notPrevented = asSyntheticInput(() => fireAt(el, 'click', at, BUTTON_RELEASED, undefined, d));
+    asSyntheticInput(() => fireAt(el, 'pointerup', at, BUTTON_RELEASED, from, d, input));
+    asSyntheticInput(() => fireAt(el, 'mouseup', at, BUTTON_RELEASED, undefined, d, input));
+    const clicked = asSyntheticInput(() => fireAt(el, isLeft ? 'click' : 'auxclick', at, BUTTON_RELEASED, undefined, d, input));
+    if (ClickButton.RIGHT !== input.button) {
+        notPrevented = clicked;
+    }
     return { prevented: !notPrevented, heldMs };
 }
 function isMeasurable(rect) {
@@ -62,8 +90,9 @@ function isMeasurable(rect) {
 }
 export function isOffViewport(el, rect) {
     const win = el.ownerDocument.defaultView;
-    if (null === win)
+    if (null === win) {
         return false;
+    }
     const cx = rect.left + rect.width / 2;
     const cy = rect.top + rect.height / 2;
     return cx < 0 || cy < 0 || cx > win.innerWidth || cy > win.innerHeight;
@@ -76,23 +105,27 @@ function hitTest(el, rect) {
 }
 function nameOf(el) {
     const testid = readTestId(el);
-    if (testid !== null && testid.length > 0)
+    if (testid !== null && testid.length > 0) {
         return `[data-testid="${testid}"]`;
+    }
     const name = getAccessibleName(el).trim();
     return name.length > 0 ? `${getRole(el)} "${name.slice(0, 40)}"` : el.tagName.toLowerCase();
 }
 function hasNoSize(el) {
-    if (typeof el.getClientRects !== 'function')
+    if (typeof el.getClientRects !== 'function') {
         return false;
+    }
     const rects = Array.from(el.getClientRects());
     return rects.length > 0 && rects.every((r) => 0 === r.width || 0 === r.height);
 }
 export function clickGeometry(el) {
-    if (typeof el.getBoundingClientRect !== 'function')
+    if (typeof el.getBoundingClientRect !== 'function') {
         return NO_GEOMETRY;
+    }
     let rect = el.getBoundingClientRect();
-    if (!isMeasurable(rect))
+    if (!isMeasurable(rect)) {
         return hasNoSize(el) ? { ...NO_GEOMETRY, noSize: true } : NO_GEOMETRY;
+    }
     let scrolledIntoView = false;
     if (isOffViewport(el, rect) && 'function' === typeof el.scrollIntoView) {
         el.scrollIntoView({ block: 'center', inline: 'center' });
@@ -109,15 +142,17 @@ export function firePointerNonBubbling(el, type, relatedTarget = null) {
     asSyntheticInput(() => el.dispatchEvent(pointerEventFor(el, type, { bubbles: false, cancelable: true, relatedTarget })));
 }
 function makeDataTransfer(data) {
-    if (typeof DataTransfer !== 'function')
+    if (typeof DataTransfer !== 'function') {
         return null;
+    }
     const dt = new DataTransfer();
     const entries = Array.isArray(data) ? data : data !== undefined ? [data] : [];
     for (const entry of entries) {
         if ('object' === typeof entry && entry !== null) {
             const e = entry;
-            if ('string' === typeof e.mime && 'string' === typeof e.value)
+            if ('string' === typeof e.mime && 'string' === typeof e.value) {
                 dt.setData(e.mime, e.value);
+            }
         }
     }
     return dt;
@@ -174,8 +209,9 @@ export async function dragElement(source, target, data) {
     if ('function' === typeof DragEvent) {
         const dataTransfer = makeDataTransfer(data);
         const init = { bubbles: true, cancelable: true };
-        if (dataTransfer !== null)
+        if (dataTransfer !== null) {
             init.dataTransfer = dataTransfer;
+        }
         source.dispatchEvent(new DragEvent('dragstart', init));
         await nativeFrame();
         dest.dispatchEvent(new DragEvent('dragenter', init));
@@ -190,8 +226,9 @@ export async function fireTapSequence(el, hold) {
     const touches = touchListFor(el);
     firePointerTouch(el, 'pointerdown');
     asSyntheticInput(() => el.dispatchEvent(makeTouchEvent('touchstart', touches)));
-    if (el.tabIndex >= 0 && 'function' === typeof el.focus)
+    if (el.tabIndex >= 0 && 'function' === typeof el.focus) {
         el.focus();
+    }
     let heldMs = 0;
     if (hold !== undefined && hold.ms > 0) {
         const started = hold.now();
@@ -214,8 +251,9 @@ function firePointerTouch(el, type) {
     })));
 }
 function touchListFor(el) {
-    if ('function' !== typeof Touch || 'function' !== typeof el.getBoundingClientRect)
+    if ('function' !== typeof Touch || 'function' !== typeof el.getBoundingClientRect) {
         return [];
+    }
     const rect = el.getBoundingClientRect();
     try {
         return [
@@ -251,10 +289,12 @@ const POPUP_ROLES = new Set(['menu', 'menubar', 'listbox', 'dialog', 'alertdialo
 const CLOSED_STATE = 'closed';
 export function assertNotLeaving(el) {
     for (let up = el.parentElement; up !== null; up = up.parentElement) {
-        if (CLOSED_STATE !== up.getAttribute('data-state'))
+        if (CLOSED_STATE !== up.getAttribute('data-state')) {
             continue;
-        if (!POPUP_ROLES.has(up.getAttribute('role') ?? ''))
+        }
+        if (!POPUP_ROLES.has(up.getAttribute('role') ?? '')) {
             continue;
+        }
         throw new Error(`'${up.getAttribute('role') ?? 'popup'}' holding this element is closing (data-state="closed"), ` +
             'so a person could not click it: look again once it has gone and act on what is open');
     }

package/dist/actions/actions.js

@@ -1,11 +1,13 @@
-import { ActionType, ActionWarning, clampHoldMs, DANGEROUS_ACTION_CONFIRM_ARG, ElementState, NATIVE_INPUT_ARG, SettleReason, } from '@reticlehq/core';
-import { isHiddenNativeOption } from '../dom/query.js';
+import { ActionType, ActionWarning, clampHoldMs, clickInputProblem, DANGEROUS_ACTION_CONFIRM_ARG, ElementState, NATIVE_INPUT_ARG, SettleReason, } from '@reticlehq/core';
+import { isHiddenNativeOption } from '../dom/query-finders.js';
 import { isReticleUi } from '../dom/dom-ignore.js';
 import { asSyntheticInput } from './synthetic/synthetic-input.js';
 import { echoRef, refs } from '../dom/addressing/refs.js';
 import { requiresDangerousConfirmation, assertOutwardAllowed, assertPaymentEntryAllowed, submitControlFor, } from './danger-context.js';
 import { assertEditable, assertNotRichText, isAutofillSafeTarget, setNativeValue, } from './value-input.js';
-import { isVisible, getStates } from '../dom/a11y.js';
+import { getRole, getStates } from '../dom/a11y.js';
+import { isVisible } from '../dom/visibility.js';
+import { selectInCombobox } from './select-combobox.js';
 import { elementHasHoverHandlers } from '../registry/stores/adapters.js';
 import { isActionTarget, isForm, isInput, isSelect, isTextArea, } from '../dom/realm.js';
 import { asSettleBudget, nativeSetTimeout, settle } from '../timers/native/native-timers.js';
@@ -19,10 +21,12 @@ function asString(value, fallback = '') {
 }
 function requireElement(ref) {
     const el = refs.resolve(ref);
-    if (null === el)
+    if (null === el) {
         throw new Error(`ref '${echoRef(ref)}' no longer resolves to an element`);
-    if (!isActionTarget(el))
+    }
+    if (!isActionTarget(el)) {
         throw new Error(`ref '${echoRef(ref)}' is not an HTML or SVG element`);
+    }
     return el;
 }
 const FILL_LIKE = new Set([
@@ -51,8 +55,9 @@ const GENERIC_ACTION_ARG_KEYS = new Set([
 function assertUploadArgs(args) {
     const keys = Object.keys(args);
     const dropped = keys.filter((k) => !UPLOAD_ARG_KEYS.has(k) && !GENERIC_ACTION_ARG_KEYS.has(k));
-    if (0 === dropped.length && keys.some((k) => UPLOAD_ARG_KEYS.has(k)))
+    if (0 === dropped.length && keys.some((k) => UPLOAD_ARG_KEYS.has(k))) {
         return;
+    }
     const detail = 0 === dropped.length
         ? 'no file was described'
         : `upload does not read ${dropped.join(', ')}, so it would be dropped`;
@@ -70,10 +75,12 @@ function assertActionAllowed(el, action, args) {
         (action === ActionType.PRESS && 'Enter' === pressKey(args));
     const dragTarget = action === ActionType.DRAG ? refs.resolve(dragTargetRef(args)) : null;
     const submitter = action === ActionType.PRESS && 'Enter' === pressKey(args) ? submitControlFor(el) : null;
-    if (canTrigger)
+    if (canTrigger) {
         assertOutwardAllowed([el, submitter, isActionTarget(dragTarget) ? dragTarget : null]);
-    if (action === ActionType.FILL || action === ActionType.TYPE)
+    }
+    if (action === ActionType.FILL || action === ActionType.TYPE) {
         assertPaymentEntryAllowed(el);
+    }
     const sourceDangerous = requiresDangerousConfirmation(el) ||
         (submitter !== null && requiresDangerousConfirmation(submitter));
     const targetDangerous = isActionTarget(dragTarget) && requiresDangerousConfirmation(dragTarget);
@@ -87,12 +94,13 @@ function assertActionAllowed(el, action, args) {
     }
 }
 function optionValueFor(options, named) {
-    if (options.some((option) => option.value === named))
+    if (options.some((option) => option.value === named)) {
         return named;
+    }
     const byLabel = options.filter((option) => option.label.trim() === named.trim());
     return 1 === byLabel.length ? (byLabel[0]?.value ?? named) : named;
 }
-import { NO_GEOMETRY, fireClickSequence, fireTapSequence, clickGeometry, firePointer, firePointerNonBubbling, dragElement, mouseEventFor, assertNotLeaving, } from './actions-dom.js';
+import { NO_GEOMETRY, fireClickSequence, fireTapSequence, clickGeometry, firePointer, firePointerNonBubbling, dragElement, mouseEventFor, assertNotLeaving, clickInputOf, } from './actions-dom.js';
 import { scrollFrom } from './scroll.js';
 import { clickHitsNoControl } from './click-target.js';
 function enabledOf(el) {
@@ -106,14 +114,15 @@ function valueOf(el) {
 }
 function activeRef(el) {
     const active = el.ownerDocument.activeElement;
-    if (null === active || active === el.ownerDocument.body)
+    if (null === active || active === el.ownerDocument.body) {
         return null;
+    }
     return refs.refFor(active);
 }
 async function dispatchFor(el, action, args) {
     if (ActionType.CLICK === action) {
         const hold = clampHoldMs(args['holdMs']);
-        return await fireClickSequence(el, 0 === hold ? undefined : { ms: hold, sleep, now: () => Date.now() });
+        return await fireClickSequence(el, 0 === hold ? undefined : { ms: hold, sleep, now: () => Date.now() }, undefined, clickInputOf(args));
     }
     if (ActionType.TAP === action) {
         const hold = clampHoldMs(args['holdMs']);
@@ -124,15 +133,27 @@ async function dispatchFor(el, action, args) {
 export const ZOOM_NEEDS_REAL_BROWSER_MSG = 'cannot zoom from inside the page — CSS zoom changes how it LOOKS without changing the layout ' +
     'viewport, visualViewport or media queries, so a layout that breaks at 200% would be reported as ' +
     'checked and passing. Drive a real browser (reticle drive <url>, or reticle_lease) and zoom there.';
+function isAriaCombobox(el) {
+    return 'combobox' === getRole(el) || 'listbox' === el.getAttribute('aria-haspopup');
+}
+const SELECT_ON_COMBOBOX_MSG = (tag) => `cannot select on a <${tag}> — it is an ARIA combobox, not a native <select>. ` +
+    'Click the combobox to open it, then click the option with { role: "option", name: "<label>" }.';
 function asFiniteNumber(raw) {
     return 'number' === typeof raw && Number.isFinite(raw) ? raw : undefined;
 }
 async function dispatchOther(el, action, args) {
     switch (action) {
-        case ActionType.DBLCLICK:
-            await fireClickSequence(el, undefined, 1);
-            await fireClickSequence(el, undefined, 2);
-            return !asSyntheticInput(() => el.dispatchEvent(mouseEventFor(el, 'dblclick', { bubbles: true, cancelable: true, detail: 2 })));
+        case ActionType.DBLCLICK: {
+            const input = clickInputOf(args);
+            await fireClickSequence(el, undefined, 1, input);
+            await fireClickSequence(el, undefined, 2, input);
+            return !asSyntheticInput(() => el.dispatchEvent(mouseEventFor(el, 'dblclick', {
+                bubbles: true,
+                cancelable: true,
+                detail: 2,
+                ...input.modifiers,
+            })));
+        }
         case ActionType.HOVER: {
             const doc = el.ownerDocument;
             const from = doc.activeElement ?? doc.body;
@@ -143,8 +164,9 @@ async function dispatchOther(el, action, args) {
             firePointer(el, 'pointermove', from);
             const moved = el.dispatchEvent(mouseEventFor(el, 'mousemove', { bubbles: true, cancelable: true }));
             const holdMs = clampHoldMs(args['holdMs']);
-            if (holdMs > 0)
+            if (holdMs > 0) {
                 await sleep(holdMs);
+            }
             return !moved;
         }
         case ActionType.FOCUS:
@@ -168,8 +190,9 @@ async function dispatchOther(el, action, args) {
                         'To empty a field on purpose use the `clear` action, or fill with an explicit "".');
                 }
                 assertEditable(el, 'fill');
-                if (!isAutofillSafeTarget(el))
+                if (!isAutofillSafeTarget(el)) {
                     el.focus();
+                }
                 return setNativeValue(el, args['value']);
             }
             assertNotRichText(el, 'fill');
@@ -205,6 +228,12 @@ async function dispatchOther(el, action, args) {
                 el.dispatchEvent(new Event('change', { bubbles: true }));
                 return false;
             }
+            if (isAriaCombobox(el)) {
+                if (typeof args['value'] !== 'string') {
+                    throw new Error("select requires a string `value` — pass it nested, as args: { value: '…' }.");
+                }
+                return await selectInCombobox(el, args['value'], (target) => fireClickSequence(target), SELECT_ON_COMBOBOX_MSG(el.tagName.toLowerCase()));
+            }
             throw new Error(`cannot select on a <${el.tagName.toLowerCase()}>`);
         case ActionType.CHECK:
         case ActionType.UNCHECK: {
@@ -221,8 +250,9 @@ async function dispatchOther(el, action, args) {
             if ('radio' === el.type && action === ActionType.UNCHECK) {
                 throw new Error('cannot uncheck a radio button — a real user could not; select another radio in the group');
             }
-            if (alreadyAtCheckedState(el, action))
+            if (alreadyAtCheckedState(el, action)) {
                 return false;
+            }
             const event = mouseEventFor(el, 'click', {
                 bubbles: true,
                 cancelable: true,
@@ -233,25 +263,29 @@ async function dispatchOther(el, action, args) {
         }
         case ActionType.SUBMIT: {
             const form = isForm(el) ? el : el.closest('form');
-            if (null === form)
+            if (null === form) {
                 throw new Error('no form to submit');
+            }
             form.requestSubmit();
             return false;
         }
         case ActionType.PRESS: {
             const mods = pressModifiers(args);
             const combo = pressKeys(args);
-            if (combo.length > 0)
+            if (combo.length > 0) {
                 return await pressCombo(el, combo, mods, clampHoldMs(args['holdMs']));
+            }
             const key = pressKey(args);
             const code = pressCode(args, key);
             const down = asSyntheticInput(() => el.dispatchEvent(keyboardEvent('keydown', { key, code, bubbles: true, cancelable: true, ...mods })));
             closeModalOnEscape(el, key, down);
-            if (down)
+            if (down) {
                 dispatchKeypress(el, key, code, mods);
+            }
             const hold = clampHoldMs(args['holdMs']);
-            if (hold > 0)
+            if (hold > 0) {
                 await holdKey(el, key, code, mods, hold);
+            }
             asSyntheticInput(() => el.dispatchEvent(keyboardEvent('keyup', { key, code, bubbles: true, ...mods })));
             return !down;
         }
@@ -277,8 +311,9 @@ async function dispatchOther(el, action, args) {
             if (true === args['__base64']) {
                 const bin = atob(rawContent);
                 const arr = new Uint8Array(bin.length);
-                for (let i = 0; i < bin.length; i++)
+                for (let i = 0; i < bin.length; i++) {
                     arr[i] = bin.charCodeAt(i);
+                }
                 fileBody = arr.buffer.slice(0);
             }
             const file = new File([fileBody], asString(args['name'], 'file.txt'), {
@@ -293,8 +328,9 @@ async function dispatchOther(el, action, args) {
         }
         case ActionType.DRAG: {
             const toRef = dragTargetRef(args);
-            if ('' === toRef)
+            if ('' === toRef) {
                 return await dragElement(el, null, args['data']);
+            }
             const resolved = refs.resolve(toRef);
             if (!isActionTarget(resolved)) {
                 throw new Error(`drag target '${echoRef(toRef)}' did not resolve to an element — pass a ref from ` +
@@ -308,11 +344,19 @@ async function dispatchOther(el, action, args) {
 }
 export async function executeAction(ref, action, args = {}) {
     const named = 0 < ref.length;
+    if (ActionType.CLICK === action || ActionType.DBLCLICK === action) {
+        const problem = clickInputProblem(action, args);
+        if (problem !== undefined) {
+            throw new Error(`cannot ${action}: ${problem}`);
+        }
+    }
     const el = isReflessDocumentPress(ref, action, args) ? focusedOrDocument() : requireElement(ref);
-    if (named)
+    if (named) {
         assertActionAllowed(el, action, args);
-    if (named)
+    }
+    if (named) {
         assertNotLeaving(el);
+    }
     const anchor = named ? anchorOf(el) : {};
     const visible = isVisible(el);
     const enabled = enabledOf(el);
@@ -376,15 +420,19 @@ export async function executeAction(ref, action, args = {}) {
         ...(alreadyAtValue ? { alreadyAtValue: true } : {}),
         ...canvasesOnScreen(),
     };
-    const warning = !named
-        ? ActionWarning.GLOBAL_PRESS
-        : geometry.occluded
-            ? ActionWarning.CLICK_OCCLUDED
-            : action === ActionType.HOVER && elementHasHoverHandlers(el)
-                ? ActionWarning.HOVER_NATIVE_ENTER_LEAVE
-                : hitsNoControl
-                    ? ActionWarning.CLICK_NOT_A_CONTROL
-                    : undefined;
+    let warning;
+    if (!named) {
+        warning = ActionWarning.GLOBAL_PRESS;
+    }
+    else if (geometry.occluded) {
+        warning = ActionWarning.CLICK_OCCLUDED;
+    }
+    else if (action === ActionType.HOVER && elementHasHoverHandlers(el)) {
+        warning = ActionWarning.HOVER_NATIVE_ENTER_LEAVE;
+    }
+    else if (hitsNoControl) {
+        warning = ActionWarning.CLICK_NOT_A_CONTROL;
+    }
     const done = result(ref, action, effect, settled, settleReason, anchor, warning);
     return isReticleUi(el) ? { ...done, reticleUi: true } : done;
 }
@@ -406,20 +454,27 @@ export async function executeSequence(steps) {
             settled: res.settled,
             settleReason: res.settleReason,
         };
-        if (res.testid !== undefined)
+        if (res.testid !== undefined) {
             stepBase.testid = res.testid;
-        if (res.component !== undefined)
+        }
+        if (res.component !== undefined) {
             stepBase.component = res.component;
-        if (res.role !== undefined)
+        }
+        if (res.role !== undefined) {
             stepBase.role = res.role;
-        if (res.name !== undefined)
+        }
+        if (res.name !== undefined) {
             stepBase.name = res.name;
-        if (res.source !== undefined)
+        }
+        if (res.source !== undefined) {
             stepBase.source = res.source;
-        if (res.secret !== undefined)
+        }
+        if (res.secret !== undefined) {
             stepBase.secret = res.secret;
-        if (res.warning !== undefined)
+        }
+        if (res.warning !== undefined) {
             stepBase.warning = res.warning;
+        }
         stepResults.push(stepBase);
     }
     return { ok: true, count: steps.length, effects, steps: stepResults };