@rethinkingstudio/agent-runner 0.1.0 → 0.1.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rethinkingstudio/agent-runner",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "Starts your coding agent when a job lands on your Doable Agent Desk.",
   "license": "MIT",
   "type": "module",
@@ -17,7 +17,7 @@
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/Rethinking-studio/doable-agent-runner.git"
+    "url": "git+https://github.com/zangqilong198812/doable-agent-runner.git"
   },
   "keywords": [
     "mcp",
@@ -30,6 +30,6 @@
   },
   "homepage": "https://doable.rethinking.art",
   "bugs": {
-    "url": "https://github.com/Rethinking-studio/doable-agent-runner/issues"
+    "url": "https://github.com/zangqilong198812/doable-agent-runner/issues"
   }
 }

package/src/cli.mjs

@@ -10,7 +10,7 @@
 
 import { spawnSync } from "node:child_process";
 import { writeFileSync, unlinkSync, existsSync, mkdirSync, cpSync, rmSync } from "node:fs";
-import { homedir, hostname, platform } from "node:os";
+import { homedir, hostname, platform, userInfo } from "node:os";
 import { join } from "node:path";
 import { fileURLToPath } from "node:url";
 import * as config from "./config.mjs";
@@ -63,6 +63,7 @@ function install() {
   };
 
   const path = config.save(settings);
+  checkAgentIsReachable(settings);
   const runtime = installRuntime();
   console.log(`Settings written to ${path}`);
   console.log(`Machine name: ${settings.name}`);
@@ -76,6 +77,33 @@ function install() {
   platform() === "darwin" ? installLaunchd(runtime) : installSystemd(runtime);
 }
 
+/// launchd and systemd hand a process a minimal PATH, while agent CLIs install
+/// into ~/.local/bin or a homebrew or nvm prefix. The runner starts them under a
+/// login shell for exactly that reason — but if the command still cannot be
+/// found, it is far better to say so now than to fail at 1am with nobody
+/// watching and nothing in the log but "command not found".
+function checkAgentIsReachable(settings) {
+  const command = settings.exec || "claude";
+  const binary = command.trim().split(/\s+/)[0];
+  const shell = (() => {
+    try {
+      return userInfo().shell || "/bin/zsh";
+    } catch {
+      return "/bin/zsh";
+    }
+  })();
+  const found = spawnSync(shell, ["-lc", `command -v ${binary}`], { encoding: "utf8" });
+  if (found.status === 0 && found.stdout.trim()) {
+    console.log(`Will start: ${found.stdout.trim()}`);
+  } else {
+    console.log(
+      `\nWARNING: could not find \`${binary}\` in your login shell.\n` +
+        "The runner will install, but every session it starts will fail. Either install\n" +
+        "that command, or re-run with --exec pointing at the right one."
+    );
+  }
+}
+
 /// Copies the runner somewhere stable and returns the entry point to point the
 /// service at. Without this the service would reference wherever the installer
 /// happened to run from — under npx, a cache directory with no guarantees.

package/src/watch.mjs

@@ -18,6 +18,7 @@
 // Settings come from ~/.doable/runner.json, written by `install`.
 
 import { spawn } from "node:child_process";
+import { userInfo } from "node:os";
 import * as config from "./config.mjs";
 
 const settings = config.load();
@@ -51,6 +52,17 @@ if (!token) {
 
 const log = (...a) => console.log(new Date().toISOString(), ...a);
 
+/// The user's own shell, so their profile — and the PATH it builds — applies.
+/// Read from the password database rather than $SHELL, which launchd does not
+/// set.
+function loginShell() {
+  try {
+    return userInfo().shell || process.env.SHELL || "/bin/zsh";
+  } catch {
+    return process.env.SHELL || "/bin/zsh";
+  }
+}
+
 /// True while a session is running. The desk allows one job per machine anyway,
 /// so starting a second session would only produce an agent that gets refused.
 let busy = false;
@@ -59,10 +71,18 @@ function runSession() {
   if (busy) return;
   busy = true;
   log("work on the desk — starting a session");
-  // Through a shell so `--exec` can be whatever the user's agent needs. The
-  // prompt is handed over twice — on stdin and in the environment — because
-  // CLIs disagree about which they prefer, and neither way needs quoting.
-  const child = spawn("/bin/sh", ["-c", exec], {
+  // A LOGIN shell, not a plain one. launchd and systemd hand a process a
+  // minimal PATH — /usr/bin:/bin and little else — while agent CLIs install
+  // into ~/.local/bin, a homebrew prefix, or an nvm directory. Running under
+  // the user's own shell profile is what makes `claude` resolvable at all;
+  // without it this fails with "command not found" long after anyone is
+  // watching.
+  //
+  // `--exec` stays a plain shell command so it can be whatever the user's
+  // agent needs, and the prompt is handed over twice — on stdin and in the
+  // environment — because CLIs disagree about which they prefer and neither
+  // way needs quoting.
+  const child = spawn(loginShell(), ["-lc", exec], {
     cwd,
     env: { ...process.env, DOABLE_PROMPT: PROMPT },
     stdio: ["pipe", "inherit", "inherit"],
@@ -95,6 +115,10 @@ async function announce() {
 }
 
 let version = "";
+/// Successful long polls are silent on purpose — one line every 25 seconds
+/// would bury everything worth reading. But that makes an outage and a hang
+/// look identical in the log, so recovery gets said out loud.
+let failing = false;
 
 async function watch() {
   for (;;) {
@@ -113,6 +137,11 @@ async function watch() {
         continue;
       }
 
+      if (failing) {
+        log("reconnected");
+        failing = false;
+      }
+
       const event = await res.json();
       version = event.version;
 
@@ -124,7 +153,8 @@ async function watch() {
       else log("desk changed but nothing is queued");
     } catch (e) {
       // Sleep, laptop lid, flaky wifi — none of these deserve a crash.
-      log("watch failed:", e.message, "— retrying in 15s");
+      if (!failing) log("watch failed:", e.message, "— retrying every 15s until it comes back");
+      failing = true;
       await sleep(15_000);
     }
   }