@restorecommerce/facade 0.1.43 → 0.1.44

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.1.44](https://github.com/restorecommerce/libs/compare/@restorecommerce/facade@0.1.43...@restorecommerce/facade@0.1.44) (2022-02-02)
+
+
+### Bug Fixes
+
+* **facade:** for recursive circular references (ex: attributes -> having nested attributes) ([59c2904](https://github.com/restorecommerce/libs/commit/59c29049c23ecb5f3265ea37a6757ca551023b38))
+
+
+
+
+
 ## [0.1.43](https://github.com/restorecommerce/libs/compare/@restorecommerce/facade@0.1.42...@restorecommerce/facade@0.1.43) (2022-02-02)
 
 

package/dist/gql/protos/registry.js

@@ -72,18 +72,13 @@ const recursiveEnumCheck = (typeName, enumMap, prevFieldName, traversedFields) =
                     for (let fieldName of fieldNames) {
                         let fieldType = gqlFields[fieldName].type.toString();
                         // if fieldType is not basic type, get the object and make recursive check till no more objects are found
-                        let skipLoop = false;
                         if (exports.scalarTypes.indexOf(fieldType) <= -1) {
-                            // check if fieldName already exists in the enumMap (to avoid circular reference for infinite loop)
-                            for (let [key, val] of enumMap) {
-                                const valueArray = val.split('.');
-                                // if fieldName already exists in enumMap, this field is a circular field ref
-                                // ignore it as its already traversed and enums are kept track of
-                                if (valueArray.indexOf(fieldName) > -1) {
-                                    skipLoop = true;
-                                }
+                            // check if fieldName already exists in the traversedFields (to avoid circular reference for infinite loop)
+                            if (traversedFields.indexOf(fieldName) <= -1) {
+                                traversedFields.push(fieldName);
                             }
-                            if (skipLoop) {
+                            else if (traversedFields.indexOf(fieldName) > -1) {
+                                // skip loop as this GQL type is already traversed
                                 continue;
                             }
                             if (!prevFieldName || _.isEmpty(prevFieldName)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@restorecommerce/facade",
-  "version": "0.1.43",
+  "version": "0.1.44",
   "description": "Facade for Restorecommerce microservices",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",
@@ -101,5 +101,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "2b4964c14cf0a66ecfaf1e0af2a6d88f9a47fba7"
+  "gitHead": "dd8b26367482e61ada3120acf5e96b23569580f0"
 }