@resolveio/server-lib 22.3.149 → 22.3.151

package/util/support-runner-v5.d.ts

@@ -26,6 +26,15 @@ export interface ResolveIOSupportDiagnosisFailingPath {
     data_query?: string;
     description: string;
 }
+export interface ResolveIOSupportDiagnosisBusinessProofContract {
+    issue_class: ResolveIOSupportIssueClass;
+    setup_state: string;
+    action_under_test: string;
+    expected_business_state_change: string;
+    prohibited_false_pass: string;
+    proof_artifacts: string[];
+    data_or_dom_assertion: string;
+}
 export interface ResolveIOSupportDiagnosisProofPlan {
     before: string;
     before_state_unavailable_reason?: string;
@@ -35,6 +44,7 @@ export interface ResolveIOSupportDiagnosisProofPlan {
     route?: string;
     data_assertion?: string;
     artifact_expectation?: string;
+    business_proof_contract?: ResolveIOSupportDiagnosisBusinessProofContract;
 }
 export interface ResolveIOSupportDiagnosisHint {
     id?: string;

package/util/support-runner-v5.js

@@ -225,6 +225,24 @@ function normalizeSupportDiagnosisHints(values) {
         .filter(function (entry) { return entry.id || entry.ticketNumber || entry.title || entry.reason || entry.commitSha; })
         .slice(0, 8);
 }
+function normalizeSupportDiagnosisBusinessProofContract(value, issueClassHint) {
+    var source = cleanObject(value);
+    if (!Object.keys(source).length) {
+        return undefined;
+    }
+    var issueClass = normalizeIssueClass(source.issue_class || source.issueClass || issueClassHint)
+        || normalizeIssueClass(issueClassHint)
+        || 'missing_wrong_data';
+    return {
+        issue_class: issueClass,
+        setup_state: pickText(source, ['setup_state', 'setupState', 'before', 'precondition'], 1000),
+        action_under_test: pickText(source, ['action_under_test', 'actionUnderTest', 'action', 'steps'], 1000),
+        expected_business_state_change: pickText(source, ['expected_business_state_change', 'expectedBusinessStateChange', 'expected_change', 'expectedChange', 'after'], 1000),
+        prohibited_false_pass: pickText(source, ['prohibited_false_pass', 'prohibitedFalsePass', 'false_pass', 'falsePass'], 1000),
+        proof_artifacts: cleanList(source.proof_artifacts || source.proofArtifacts || source.artifacts || source.artifact_paths || source.artifactPaths, 10, 500),
+        data_or_dom_assertion: pickText(source, ['data_or_dom_assertion', 'dataOrDomAssertion', 'data_assertion', 'dataAssertion', 'dom_assertion', 'domAssertion', 'assertion'], 1000)
+    };
+}
 function normalizeOwnerFilePath(value) {
     return cleanText(value, 500)
         .replace(/\\/g, '/')
@@ -267,6 +285,7 @@ function normalizeResolveIOSupportDiagnosisGate(value, now) {
     var failingPathSource = cleanObject(source.failing_path || source.failingPath);
     var proofPlanSource = cleanObject(source.proof_plan || source.proofPlan);
     var issueClass = normalizeIssueClass(source.issue_class || source.issueClass);
+    var businessProofContract = normalizeSupportDiagnosisBusinessProofContract(proofPlanSource.business_proof_contract || proofPlanSource.businessProofContract || source.business_proof_contract || source.businessProofContract, issueClass || source.issue_class || source.issueClass);
     var ownerFiles = cleanList(source.owner_files || source.ownerFiles, 20, 500)
         .map(normalizeOwnerFilePath)
         .filter(Boolean);
@@ -304,7 +323,8 @@ function normalizeResolveIOSupportDiagnosisGate(value, now) {
             business_assertion: pickText(proofPlanSource, ['business_assertion', 'businessAssertion', 'assertion'], 1000),
             route: pickText(proofPlanSource, ['route', 'url'], 500),
             data_assertion: pickText(proofPlanSource, ['data_assertion', 'dataAssertion', 'mongo_delta', 'mongoDelta'], 1000),
-            artifact_expectation: pickText(proofPlanSource, ['artifact_expectation', 'artifactExpectation', 'artifact', 'screenshot'], 1000)
+            artifact_expectation: pickText(proofPlanSource, ['artifact_expectation', 'artifactExpectation', 'artifact', 'screenshot'], 1000),
+            business_proof_contract: businessProofContract
         },
         similar_tickets: normalizeSupportDiagnosisHints(source.similar_tickets || source.similarTickets),
         similar_commits: normalizeSupportDiagnosisHints(source.similar_commits || source.similarCommits),
@@ -428,6 +448,33 @@ function validateResolveIOSupportDiagnosisGate(value, options) {
     if (proofPlanLooksRouteOnly(normalized.proof_plan)) {
         blockers.push('Diagnosis proof_plan cannot be route-load, screen-visible, or screenshot-only; it must name the business state/data/control change that proves the issue is fixed.');
     }
+    var proofContract = normalized.proof_plan.business_proof_contract;
+    if (!proofContract) {
+        blockers.push('Diagnosis proof_plan.business_proof_contract is required.');
+    }
+    else {
+        if (proofContract.issue_class !== normalized.issue_class) {
+            blockers.push("Diagnosis proof_plan.business_proof_contract.issue_class (".concat(proofContract.issue_class, ") must match diagnosis issue_class (").concat(normalized.issue_class, ")."));
+        }
+        if (!proofContract.setup_state) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.setup_state is required.');
+        }
+        if (!proofContract.action_under_test) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.action_under_test is required.');
+        }
+        if (!proofContract.expected_business_state_change) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.expected_business_state_change is required.');
+        }
+        if (!proofContract.prohibited_false_pass) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.prohibited_false_pass is required.');
+        }
+        if (!proofContract.proof_artifacts.length) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.proof_artifacts must include at least one required artifact.');
+        }
+        if (!proofContract.data_or_dom_assertion) {
+            blockers.push('Diagnosis proof_plan.business_proof_contract.data_or_dom_assertion is required.');
+        }
+    }
     if (!normalized.evidence.length) {
         blockers.push('Diagnosis evidence must include ticket/code/browser/log/Mongo proof.');
     }
@@ -440,13 +487,19 @@ function validateResolveIOSupportDiagnosisGate(value, options) {
     };
 }
 function buildResolveIOSupportIssueClassProbes(value) {
+    var _a;
     var validation = validateResolveIOSupportDiagnosisGate(value);
     var gate = validation.normalized || normalizeResolveIOSupportDiagnosisGate(value);
     if (!gate) {
         return [];
     }
     var route = gate.proof_plan.route || gate.issue_case.route_module;
-    var proof = gate.proof_plan.business_assertion;
+    var proofContract = gate.proof_plan.business_proof_contract;
+    var proof = (proofContract === null || proofContract === void 0 ? void 0 : proofContract.expected_business_state_change) || gate.proof_plan.business_assertion;
+    var assertion = (proofContract === null || proofContract === void 0 ? void 0 : proofContract.data_or_dom_assertion) || gate.proof_plan.data_assertion || gate.proof_plan.after;
+    var artifacts = ((_a = proofContract === null || proofContract === void 0 ? void 0 : proofContract.proof_artifacts) === null || _a === void 0 ? void 0 : _a.length)
+        ? " Required artifacts: ".concat(proofContract.proof_artifacts.join(', '), ".")
+        : '';
     var common = {
         issue_class: gate.issue_class,
         probe_type: 'issue_class_probe',
@@ -484,7 +537,9 @@ function buildResolveIOSupportIssueClassProbes(value) {
         }
     };
     var selected = map[gate.issue_class];
-    return [__assign(__assign({}, common), { objective: "Issue-class probe for ".concat(gate.issue_class, ": ").concat(gate.issue_case.customer_complaint), action: selected.action, expected_evidence: selected.expected })];
+    return [__assign(__assign({}, common), { objective: "Issue-class probe for ".concat(gate.issue_class, ": ").concat(gate.issue_case.customer_complaint), action: proofContract
+                ? "".concat(proofContract.action_under_test, " ").concat(selected.action)
+                : selected.action, expected_evidence: "".concat(selected.expected).concat(assertion ? " Assertion: ".concat(assertion, ".") : '').concat(artifacts).trim() })];
 }
 function hashResolveIOSupportV5Evidence(value) {
     var raw = typeof value === 'string' ? value : JSON.stringify(value || {});
@@ -561,6 +616,16 @@ function decideResolveIOSupportV5RepeatedFailureStop(input) {
             reason: 'support_v5_ping_pong_failure_loop'
         };
     }
+    if (managerDecision.action === 'park_repeated_failure' && managerDecision.newEvidence) {
+        return {
+            shouldStop: false,
+            repeatedCount: managerDecision.sameFailureCount,
+            failureClass: failureClass,
+            blockerFingerprint: blockerFingerprint,
+            evidenceHash: evidenceHash,
+            reason: 'support_v5_retry_allowed_changed_evidence_hash'
+        };
+    }
     if (managerDecision.action === 'park_repeated_failure') {
         return {
             shouldStop: true,
@@ -730,6 +795,9 @@ function applyResolveIOSupportDiagnosisGateToMicrotasks(bundle, diagnosisGate) {
     }
     var ownerFiles = gate.owner_files;
     var probes = buildResolveIOSupportIssueClassProbes(gate);
+    var proofContract = gate.proof_plan.business_proof_contract;
+    var businessProof = (proofContract === null || proofContract === void 0 ? void 0 : proofContract.expected_business_state_change) || gate.proof_plan.business_assertion;
+    var businessAssertion = (proofContract === null || proofContract === void 0 ? void 0 : proofContract.data_or_dom_assertion) || gate.proof_plan.data_assertion || gate.proof_plan.after;
     var now = isoNow();
     var diagnosisMicrotaskId = ((_a = (bundle.supportV5MicrotaskLedger || [])
         .find(function (task) { return task.type === 'diagnosis_gate'; })) === null || _a === void 0 ? void 0 : _a.microtaskId)
@@ -740,10 +808,10 @@ function applyResolveIOSupportDiagnosisGateToMicrotasks(bundle, diagnosisGate) {
             return __assign(__assign({}, task), { status: validation.valid ? 'pass' : 'needs_repair', blocker: validation.valid ? '' : validation.blockers.join(' | '), updatedAt: now });
         }
         if (task.lane === 'build' && /repair|product_repair|build_repair/i.test(String(task.type || ''))) {
-            return __assign(__assign({}, task), { targetFiles: ownerFiles, contextRefs: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.contextRefs || [])), false), ['supportV5DiagnosisGate', 'owner_files'], false))), selfGate: "Repair only the diagnosed owner files unless you revise the diagnosis with new evidence. Owner files: ".concat(ownerFiles.join(', '), "."), acceptanceProof: gate.proof_plan.business_assertion, dependsOn: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.dependsOn || [])), false), [diagnosisMicrotaskId], false))), updatedAt: now });
+            return __assign(__assign({}, task), { targetFiles: ownerFiles, contextRefs: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.contextRefs || [])), false), ['supportV5DiagnosisGate', 'owner_files'], false))), selfGate: "Repair only the diagnosed owner files unless you revise the diagnosis with new evidence. Owner files: ".concat(ownerFiles.join(', '), "."), acceptanceProof: businessProof, dependsOn: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.dependsOn || [])), false), [diagnosisMicrotaskId], false))), updatedAt: now });
         }
         if (task.lane === 'qa' && task.type === 'qa_row') {
-            return __assign(__assign({}, task), { contextRefs: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.contextRefs || [])), false), ['supportV5DiagnosisGate', 'proof_plan'], false))), selfGate: ((_a = probes[0]) === null || _a === void 0 ? void 0 : _a.action) || task.selfGate, acceptanceProof: gate.proof_plan.business_assertion || task.acceptanceProof, targetFiles: ownerFiles, updatedAt: now });
+            return __assign(__assign({}, task), { contextRefs: Array.from(new Set(__spreadArray(__spreadArray([], __read((task.contextRefs || [])), false), ['supportV5DiagnosisGate', 'proof_plan'], false))), selfGate: ((_a = probes[0]) === null || _a === void 0 ? void 0 : _a.action) || task.selfGate, acceptanceProof: businessProof || task.acceptanceProof, targetFiles: ownerFiles, updatedAt: now });
         }
         return task;
     });
@@ -754,9 +822,9 @@ function applyResolveIOSupportDiagnosisGateToMicrotasks(bundle, diagnosisGate) {
                     "Accepted hypothesis: ".concat(gate.accepted_hypothesis.statement),
                     "Owner files: ".concat(ownerFiles.join(', '))
                 ].filter(Boolean).join(' | '), updatedAt: now }), qa: __assign(__assign({}, bundle.supportV5LaneMemory.qa), { activeQaRow: {
-                    workflow: gate.proof_plan.business_assertion,
+                    workflow: (proofContract === null || proofContract === void 0 ? void 0 : proofContract.action_under_test) || gate.proof_plan.action,
                     route: gate.proof_plan.route || gate.issue_case.route_module,
-                    assertion: gate.proof_plan.after,
+                    assertion: businessAssertion,
                     status: 'pending'
                 }, updatedAt: now }) }) });
 }
@@ -1231,7 +1299,7 @@ function buildResolveIOSupportV5DiagnoseFirstPrompt(lines) {
     ].filter(Boolean);
 }
 function buildResolveIOSupportV5MicrotaskPrompt(input) {
-    var _a, _b, _c;
+    var _a, _b, _c, _d, _e, _f;
     var activeMicrotask = selectResolveIOSupportV5ActiveMicrotask(input.bundle.supportV5MicrotaskLedger || [], input.bundle.supportV5ActiveMicrotaskId);
     var diagnosisValidation = validateResolveIOSupportDiagnosisGate(input.bundle.supportV5DiagnosisGate);
     var diagnosisGate = diagnosisValidation.normalized || input.bundle.supportV5DiagnosisGate;
@@ -1277,10 +1345,11 @@ function buildResolveIOSupportV5MicrotaskPrompt(input) {
             name: 'root_cause_first_diagnosis_contract',
             text: [
                 'Before any product-code repair, produce strict JSON only:',
-                '{"support_diagnosis_gate":{"issue_case":{"customer_complaint":"","expected_result":"","observed_result":"","route_module":"","account_customer_context":"","reproduction_status":"reproduced|blocked|classified","reproduction_blocker":""},"issue_class":"no_op_submit|missing_wrong_data|filter_query_mismatch|invoice_pdf_export|upload_import|route_auth_hydration|slow_query_performance","accepted_hypothesis":{"statement":"","falsifiable_test":"","evidence":[""]},"rejected_alternatives":[""],"failing_path":{"frontend":"","backend":"","shared_library":"","data_query":"","description":""},"owner_files":["small/exact/file.ts"],"proof_plan":{"before":"","before_state_unavailable_reason":"","action":"","after":"","business_assertion":"","route":"","data_assertion":"","artifact_expectation":""},"similar_tickets":[],"similar_commits":[],"evidence":[{"type":"ticket|browser|mongo|log|code|commit|qa|other","summary":"","artifactPath":""}],"status":"passed"}}',
+                '{"support_diagnosis_gate":{"issue_case":{"customer_complaint":"","expected_result":"","observed_result":"","route_module":"","account_customer_context":"","reproduction_status":"reproduced|blocked|classified","reproduction_blocker":""},"issue_class":"no_op_submit|missing_wrong_data|filter_query_mismatch|invoice_pdf_export|upload_import|route_auth_hydration|slow_query_performance","accepted_hypothesis":{"statement":"","falsifiable_test":"","evidence":[""]},"rejected_alternatives":[""],"failing_path":{"frontend":"","backend":"","shared_library":"","data_query":"","description":""},"owner_files":["small/exact/file.ts"],"proof_plan":{"before":"","before_state_unavailable_reason":"","action":"","after":"","business_assertion":"","route":"","data_assertion":"","artifact_expectation":"","business_proof_contract":{"issue_class":"same as diagnosis issue_class","setup_state":"","action_under_test":"","expected_business_state_change":"","prohibited_false_pass":"Route load, screenshot, scorecard, or model claim alone is not acceptance.","proof_artifacts":["browser trace/screenshot/json/mongo delta"],"data_or_dom_assertion":""}},"similar_tickets":[],"similar_commits":[],"evidence":[{"type":"ticket|browser|mongo|log|code|commit|qa|other","summary":"","artifactPath":""}],"status":"passed"}}',
                 'Owner files must be a small exact editable set, not directories, globs, generated wrappers, or broad repo areas.',
                 'The accepted hypothesis must be falsifiable and backed by evidence; prior similar tickets or commits are hints only and cannot bypass fresh diagnosis.',
-                'The proof plan must be before/action/after business proof. If before-state proof is impossible, explain exactly why in before_state_unavailable_reason.'
+                'The proof plan must be before/action/after business proof plus business_proof_contract. If before-state proof is impossible, explain exactly why in before_state_unavailable_reason.',
+                'The business_proof_contract must name the setup state, action under test, expected business state change, prohibited false pass, required artifacts, and DOM/data assertion.'
             ].join('\n')
         } : {
             name: 'diagnosis_gate_context',
@@ -1290,6 +1359,9 @@ function buildResolveIOSupportV5MicrotaskPrompt(input) {
                 "Failing path: ".concat(diagnosisGate.failing_path.description || diagnosisGate.failing_path.frontend || diagnosisGate.failing_path.backend || ''),
                 "Owner files: ".concat(diagnosisGate.owner_files.join(', ')),
                 "Business proof required: ".concat(diagnosisGate.proof_plan.business_assertion),
+                diagnosisGate.proof_plan.business_proof_contract
+                    ? "Business proof contract: ".concat((_d = diagnosisGate.proof_plan.business_proof_contract) === null || _d === void 0 ? void 0 : _d.action_under_test, " -> ").concat((_e = diagnosisGate.proof_plan.business_proof_contract) === null || _e === void 0 ? void 0 : _e.expected_business_state_change, "; assertion ").concat((_f = diagnosisGate.proof_plan.business_proof_contract) === null || _f === void 0 ? void 0 : _f.data_or_dom_assertion)
+                    : '',
                 "Before/action/after: ".concat(diagnosisGate.proof_plan.before || diagnosisGate.proof_plan.before_state_unavailable_reason, " -> ").concat(diagnosisGate.proof_plan.action, " -> ").concat(diagnosisGate.proof_plan.after)
             ].filter(Boolean).join('\n') : 'SupportDiagnosisGate is not valid. Park instead of editing product code.'
         },