@reshotdev/screenshot 0.0.1-beta.1 → 0.0.1-beta.11

package/src/commands/publish.js

@@ -15,6 +15,7 @@ const {
   getStorageMode,
   isPlatformAvailable,
 } = require("../lib/storage-providers");
+const { getLatestSuccessfulRunManifest } = require("../lib/run-manifest");
 const pkg = require("../../package.json");
 
 // Check if transactional flow should be used (R2 configured on server)
@@ -390,13 +391,13 @@ function resolveProjectContext({ settings, docSyncConfig, storageMode }) {
   if (!apiKey) {
     throw new Error(
       "No API key found. Set RESHOT_API_KEY in your environment or run `reshot auth` locally to create .reshot/settings.json.\n" +
-        "Alternatively, configure BYOS (Bring Your Own Storage) in docsync.config.json to publish without authentication.",
+        "Alternatively, configure BYOS (Bring Your Own Storage) in reshot.config.json to publish without authentication.",
     );
   }
 
   if (!projectId) {
     throw new Error(
-      "No project ID found. Set RESHOT_PROJECT_ID in your environment or ensure docsync.config.json contains _metadata.projectId.",
+      "No project ID found. Set RESHOT_PROJECT_ID in your environment or ensure reshot.config.json contains _metadata.projectId.",
     );
   }
 
@@ -487,6 +488,48 @@ function groupAssetsByScenario(assetFiles, outputBaseDir) {
   return Array.from(groups.values());
 }
 
+function collectAssetFilesFromDirectories(directories) {
+  const deduped = new Set();
+  const files = [];
+
+  for (const directory of directories) {
+    if (!directory || !fs.existsSync(directory)) continue;
+    for (const filePath of findAssetFiles(directory)) {
+      if (deduped.has(filePath)) continue;
+      deduped.add(filePath);
+      files.push(filePath);
+    }
+  }
+
+  return files;
+}
+
+function resolveManifestScopedScreenshotFiles(outputBaseDir, latestRunManifest) {
+  if (!latestRunManifest?.success) {
+    throw new Error(
+      "No successful run manifest is available. Run `reshot run` first or use `reshot publish --all-output` to publish from the full output tree.",
+    );
+  }
+
+  const scenarioDirs = (latestRunManifest.scenarios || [])
+    .filter((scenario) => scenario.success !== false)
+    .map((scenario) => scenario.outputDir)
+    .filter(Boolean);
+
+  if (scenarioDirs.length === 0) {
+    throw new Error(
+      "The latest successful run manifest does not contain any scenario output directories.",
+    );
+  }
+
+  const screenshotFiles = collectAssetFilesFromDirectories(scenarioDirs);
+  return {
+    screenshotFiles,
+    mode: "latest-run",
+    scenarioCount: scenarioDirs.length,
+  };
+}
+
 function buildContextForVariation(scenario, variationSlug) {
   const safeVariation = variationSlug || "default";
   if (!scenario || !scenario.contexts) {
@@ -539,17 +582,20 @@ function buildScenarioDefinition(scenario) {
 function buildPublishMetadata({
   projectId,
   publishSessionId,
+  tag,
   scenarioKey,
   scenarioConfig,
   variationSlug,
   contextData,
   gitInfo,
+  autoApprove = false,
 }) {
   const scenarioDefinition = buildScenarioDefinition(scenarioConfig);
 
   return {
     projectId,
     publishSessionId, // Unique ID for this CLI publish run
+    tag: tag || undefined,
     scenarioName: scenarioConfig?.name || scenarioKey,
     scenario: scenarioDefinition,
     context: {
@@ -557,6 +603,9 @@ function buildPublishMetadata({
       data: contextData,
     },
     autoCreateVisuals: true,
+    publish: {
+      autoApprove,
+    },
     git: {
       commitHash: gitInfo.commitHash,
       commitMessage: gitInfo.commitMessage,
@@ -578,6 +627,7 @@ async function publishWithTransactionalFlow(
   docSyncConfig,
   gitInfo,
   diffManifests = null,
+  { autoApprove = false } = {},
 ) {
   console.log(
     chalk.cyan("  🚀 Using transactional upload (direct to R2)...\n"),
@@ -807,7 +857,11 @@ async function publishWithTransactionalFlow(
     });
   }
 
-  // Commit each group
+  // Build all commits for batch request
+  // Vercel serverless functions have ~60s timeout; keep batches small enough to complete
+  const MAX_BATCH_SIZE = 25;
+  const commits = [];
+
   for (const { group, scenarioConfig, assets } of groupMap.values()) {
     const contextObj = buildContextForVariation(
       scenarioConfig,
@@ -816,46 +870,75 @@ async function publishWithTransactionalFlow(
     const metadata = buildPublishMetadata({
       projectId,
       publishSessionId: gitInfo.publishSessionId,
+      tag: gitInfo.tag,
       scenarioKey: group.scenarioKey,
       scenarioConfig,
       variationSlug: group.variationSlug,
       contextData: contextObj,
       gitInfo,
+      autoApprove,
     });
 
     if (metadata.cli) {
-      metadata.cli.features = ["steps", "transactional"];
+      metadata.cli.features = ["steps", "transactional", "batch"];
+    }
+
+    commits.push({ metadata, assets });
+  }
+
+  // Send in batches
+  console.log(
+    chalk.gray(`  Committing ${commits.length} scenario(s) to platform...`),
+  );
+
+  const totalBatches = Math.ceil(commits.length / MAX_BATCH_SIZE);
+  for (let i = 0; i < commits.length; i += MAX_BATCH_SIZE) {
+    const chunk = commits.slice(i, i + MAX_BATCH_SIZE);
+    const batchNum = Math.floor(i / MAX_BATCH_SIZE) + 1;
+    if (totalBatches > 1) {
+      console.log(chalk.gray(`  Batch ${batchNum}/${totalBatches}...`));
     }
 
     try {
-      const result = await apiClient.publishTransactional(apiKey, {
-        metadata,
-        assets,
+      const rawBatchResult = await apiClient.publishBatch(apiKey, {
+        commits: chunk,
+        autoApprove: autoApprove || false,
       });
+      // Unwrap API envelope: response may be { data: { results, ... } } or { results, ... }
+      const batchResult = rawBatchResult.data || rawBatchResult;
 
-      const processedCount = result?.assetsProcessed ?? assets.length;
-      console.log(
-        chalk.green(
-          `     ✔ Committed "${group.scenarioKey}" (${group.variationSlug}): ${processedCount} asset(s)`,
-        ),
-      );
-      successCount += processedCount;
+      for (const r of batchResult.results || []) {
+        if (r.status === "ok") {
+          const count = r.assetsProcessed || 0;
+          console.log(
+            chalk.green(
+              `     ✔ Committed "${r.scenario}" (${r.context}): ${count} asset(s)`,
+            ),
+          );
+          successCount += count;
 
-      // Handle skipped assets (visual limit)
-      if (result?.skippedAssets?.length > 0) {
-        for (const key of result.skippedAssets) {
-          console.log(chalk.yellow(`     ⚠ Skipped "${key}" (plan limit reached)`));
+          if (r.skippedAssets?.length > 0) {
+            for (const key of r.skippedAssets) {
+              console.log(chalk.yellow(`     ⚠ Skipped "${key}" (plan limit reached)`));
+            }
+            skippedCount += r.skippedAssets.length;
+          }
+        } else {
+          console.log(
+            chalk.red(
+              `     ✖ "${r.scenario}" (${r.context}): ${r.error || "Unknown error"}`,
+            ),
+          );
+          failCount++;
         }
-        skippedCount += result.skippedAssets.length;
       }
 
-      // Capture viewUrl from first successful response
-      if (!viewUrl && result?.viewUrl) {
-        viewUrl = result.viewUrl;
+      if (!viewUrl && batchResult.viewUrl) {
+        viewUrl = batchResult.viewUrl;
       }
     } catch (error) {
-      console.log(chalk.red(`     ✖ Commit failed: ${error.message}`));
-      failCount += assets.length;
+      console.log(chalk.red(`     ✖ Batch request failed: ${error.message}`));
+      failCount += chunk.length;
     }
   }
 
@@ -871,6 +954,7 @@ async function publishWithLegacyFlow(
   groupedAssets,
   docSyncConfig,
   gitInfo,
+  { autoApprove = false } = {},
 ) {
   let successCount = 0;
   let failCount = 0;
@@ -887,11 +971,13 @@ async function publishWithLegacyFlow(
     const metadata = buildPublishMetadata({
       projectId,
       publishSessionId: gitInfo.publishSessionId,
+      tag: gitInfo.tag,
       scenarioKey: group.scenarioKey,
       scenarioConfig,
       variationSlug: group.variationSlug,
       contextData: contextObj,
       gitInfo,
+      autoApprove,
     });
 
     if (metadata.cli) {
@@ -1167,70 +1253,6 @@ function getRecentCommits(lastCommitHash) {
   }
 }
 
-/**
- * Recursively find all markdown files matching include/exclude patterns
- */
-function findDocFiles(
-  docsRoot,
-  includePatterns = ["**/*.md", "**/*.mdx"],
-  excludePatterns = [],
-) {
-  const files = [];
-  const rootPath = path.resolve(process.cwd(), docsRoot);
-
-  if (!fs.existsSync(rootPath)) {
-    return files;
-  }
-
-  function walkDir(dir, relativePath = "") {
-    const items = fs.readdirSync(dir);
-
-    for (const item of items) {
-      const fullPath = path.join(dir, item);
-      const relativeItemPath = path
-        .join(relativePath, item)
-        .replace(/\\/g, "/");
-      const stat = fs.statSync(fullPath);
-
-      // Check exclude patterns
-      const shouldExclude = excludePatterns.some((pattern) => {
-        const regex = new RegExp(
-          pattern.replace(/\*\*/g, ".*").replace(/\*/g, "[^/]*"),
-        );
-        return regex.test(relativeItemPath) || regex.test(fullPath);
-      });
-
-      if (shouldExclude) {
-        continue;
-      }
-
-      if (stat.isDirectory()) {
-        walkDir(fullPath, relativeItemPath);
-      } else if (stat.isFile()) {
-        const ext = path.extname(item).toLowerCase();
-        const matchesInclude = includePatterns.some((pattern) => {
-          const regex = new RegExp(
-            pattern.replace(/\*\*/g, ".*").replace(/\*/g, "[^/]*"),
-          );
-          return (
-            regex.test(relativeItemPath) || ext === ".md" || ext === ".mdx"
-          );
-        });
-
-        if (matchesInclude && (ext === ".md" || ext === ".mdx")) {
-          files.push({
-            fullPath,
-            relativePath: relativeItemPath,
-          });
-        }
-      }
-    }
-  }
-
-  walkDir(rootPath);
-  return files;
-}
-
 /**
  * Parse frontmatter from markdown content
  */
@@ -1268,7 +1290,18 @@ function parseFrontmatter(content) {
 }
 
 async function publishCommand(options = {}) {
-  const { tag, message, dryRun, force, video, outputJson } = options;
+  const {
+    tag,
+    message,
+    dryRun,
+    force,
+    video,
+    allOutput = false,
+    outputJson,
+    autoApprove,
+    skipReleaseDoctor = false,
+    noExit = false,
+  } = options;
 
   // Result tracking for --output-json and programmatic callers
   const publishResult = {
@@ -1277,6 +1310,7 @@ async function publishCommand(options = {}) {
     assetsSkipped: 0,
     reviewQueueItems: 0,
     viewUrl: null,
+    releaseDoctor: null,
     tag: tag || null,
     dryRun: !!dryRun,
     timestamp: new Date().toISOString(),
@@ -1294,6 +1328,10 @@ async function publishCommand(options = {}) {
     console.log(chalk.yellow("🔍 DRY RUN MODE - No assets will be uploaded\n"));
   }
 
+  if (autoApprove) {
+    console.log(chalk.cyan("  ✅ Auto-approve enabled: visuals will be approved immediately\n"));
+  }
+
   // Read config + settings (if available)
   const settings = readSettingsSafe();
   let docSyncConfig = null;
@@ -1305,6 +1343,43 @@ async function publishCommand(options = {}) {
     );
   }
 
+  if (skipReleaseDoctor) {
+    publishResult.releaseDoctor = {
+      skipped: true,
+      success: true,
+    };
+  } else if (docSyncConfig) {
+    console.log(chalk.cyan("🧪 Running release doctor before publish...\n"));
+    const { runReleaseDoctor } = require("../lib/release-doctor");
+    const releaseDoctor = await runReleaseDoctor({});
+    publishResult.releaseDoctor = {
+      skipped: false,
+      success: releaseDoctor.ok,
+      reportPath: releaseDoctor.reportPath || null,
+    };
+
+    if (!releaseDoctor.ok) {
+      console.log(chalk.red("  ✖ Release doctor failed. Fix the reported issues before publishing."));
+      if (releaseDoctor.reportPath) {
+        console.log(chalk.gray(`    Report: ${releaseDoctor.reportPath}`));
+      }
+      if (!noExit) process.exit(1);
+      return {
+        ...publishResult,
+        success: false,
+        error: "Release doctor failed",
+      };
+    }
+
+    console.log(chalk.green("  ✔ Release doctor passed\n"));
+  } else {
+    publishResult.releaseDoctor = {
+      skipped: true,
+      success: true,
+      reason: "config-unavailable",
+    };
+  }
+
   // Determine storage mode and validate configuration
   const storageConfig = docSyncConfig?.storage;
   const storageMode = getStorageMode(docSyncConfig);
@@ -1324,7 +1399,8 @@ async function publishCommand(options = {}) {
       console.log(chalk.red(`  • ${error}`));
     }
     console.log(getStorageSetupHelp(storageConfig?.type || "reshot"));
-    process.exit(1);
+    if (!noExit) process.exit(1);
+    return { ...publishResult, success: false, error: "Invalid storage configuration" };
   }
 
   // Resolve project context based on storage mode
@@ -1343,7 +1419,8 @@ async function publishCommand(options = {}) {
       );
       console.log(getStorageSetupHelp("s3"));
     }
-    process.exit(1);
+    if (!noExit) process.exit(1);
+    return { ...publishResult, success: false, error: error.message };
   }
 
   const { apiKey, projectId, storageMode: resolvedMode } = projectContext;
@@ -1368,8 +1445,6 @@ async function publishCommand(options = {}) {
   // Get feature toggles
   const features = docSyncConfig?._metadata?.features || {
     visuals: true,
-    docs: false,
-    changelog: true,
   };
 
   // Get git information
@@ -1388,7 +1463,7 @@ async function publishCommand(options = {}) {
       });
       console.log(chalk.green(`  ✔ Version tag "${tag}" created`));
       console.log(
-        chalk.gray(`    Pinned URL: cdn.reshot.dev/assets/{key}?tag=${tag}\n`),
+        chalk.gray(`    Pinned URL: cdn.reshot.dev/v1/assets/{projectId}/{visualKey}?tag=${tag}\n`),
       );
     } catch (tagError) {
       console.log(
@@ -1401,9 +1476,21 @@ async function publishCommand(options = {}) {
   if (features.visuals === true) {
     const projectRoot = process.cwd();
     const outputBaseDir = path.join(projectRoot, ".reshot", "output");
-    const screenshotFiles = fs.existsSync(outputBaseDir)
-      ? findAssetFiles(outputBaseDir)
-      : [];
+    let screenshotFiles = [];
+    let screenshotScopeLabel = "all-output";
+    if (fs.existsSync(outputBaseDir)) {
+      if (allOutput) {
+        screenshotFiles = findAssetFiles(outputBaseDir);
+      } else {
+        const latestRunManifest = getLatestSuccessfulRunManifest();
+        const manifestScoped = resolveManifestScopedScreenshotFiles(
+          outputBaseDir,
+          latestRunManifest,
+        );
+        screenshotFiles = manifestScoped.screenshotFiles;
+        screenshotScopeLabel = `${manifestScoped.mode}:${manifestScoped.scenarioCount}`;
+      }
+    }
     const screenshotGroups =
       screenshotFiles.length > 0
         ? groupAssetsByScenario(screenshotFiles, outputBaseDir)
@@ -1434,6 +1521,11 @@ async function publishCommand(options = {}) {
             ` (${screenshotFiles.length} screenshots, ${exportVideoFiles.length} videos)\n`,
         ),
       );
+      console.log(
+        chalk.gray(
+          `  Screenshot scope: ${allOutput ? "all historical output (--all-output)" : `latest successful run (${screenshotScopeLabel})`}\n`,
+        ),
+      );
 
       let successCount = 0;
       let failCount = 0;
@@ -1477,8 +1569,9 @@ async function publishCommand(options = {}) {
               projectId,
               groupedAssets,
               docSyncConfig,
-              { commitHash, commitMessage, publishSessionId },
+              { commitHash, commitMessage, publishSessionId, tag },
               diffManifests,
+              { autoApprove },
             );
             successCount = result.successCount;
             failCount = result.failCount;
@@ -1496,7 +1589,8 @@ async function publishCommand(options = {}) {
               projectId,
               groupedAssets,
               docSyncConfig,
-              { commitHash, commitMessage, publishSessionId },
+              { commitHash, commitMessage, publishSessionId, tag },
+              { autoApprove },
             );
             successCount = result.successCount;
             failCount = result.failCount;
@@ -1508,7 +1602,8 @@ async function publishCommand(options = {}) {
             projectId,
             groupedAssets,
             docSyncConfig,
-            { commitHash, commitMessage, publishSessionId },
+            { commitHash, commitMessage, publishSessionId, tag },
+            { autoApprove },
           );
           successCount = result.successCount;
           failCount = result.failCount;
@@ -1558,141 +1653,6 @@ async function publishCommand(options = {}) {
     );
   }
 
-  // Stream B: Documentation
-  if (features.docs === true) {
-    console.log(chalk.cyan("\n📚 Publishing documentation...\n"));
-
-    if (!docSyncConfig || !docSyncConfig.docs) {
-      console.log(
-        chalk.yellow(
-          "  ⚠ No docs configuration found in docsync.config.json. Skipping docs stream.",
-        ),
-      );
-    } else {
-      const docsConfig = docSyncConfig.docs;
-      const docsRoot = docsConfig.root || "./docs";
-      const includePatterns = docsConfig.include || ["**/*.md", "**/*.mdx"];
-      const excludePatterns = docsConfig.exclude || [
-        "**/node_modules/**",
-        "**/.git/**",
-      ];
-
-      const docFiles = findDocFiles(docsRoot, includePatterns, excludePatterns);
-
-      if (docFiles.length === 0) {
-        console.log(
-          chalk.yellow("  ⚠ No documentation files found to publish."),
-        );
-      } else {
-        console.log(
-          chalk.cyan(`  Found ${docFiles.length} documentation file(s)\n`),
-        );
-
-        const docsPayload = [];
-        for (const docFile of docFiles) {
-          const content = fs.readFileSync(docFile.fullPath, "utf-8");
-          const { frontmatter, content: docContent } =
-            parseFrontmatter(content);
-
-          docsPayload.push({
-            path: docFile.relativePath,
-            content: docContent,
-            frontmatter:
-              Object.keys(frontmatter).length > 0 ? frontmatter : undefined,
-            status: frontmatter.status || "draft",
-          });
-        }
-
-        // Docs publishing requires platform (no BYOS support yet)
-        if (resolvedMode === "byos") {
-          console.log(
-            chalk.yellow(
-              "  ⚠ Documentation publishing requires Reshot platform.",
-            ),
-          );
-          console.log(
-            chalk.gray(
-              "     Run 'reshot auth' to enable doc hosting with review workflow.",
-            ),
-          );
-        } else {
-          try {
-            const result = await apiClient.publishDocs(apiKey, {
-              projectId,
-              docs: docsPayload,
-            });
-            console.log(
-              chalk.green(
-                `  ✔ Published ${result.created || 0} new doc(s), updated ${
-                  result.updated || 0
-                } doc(s)`,
-              ),
-            );
-          } catch (error) {
-            console.log(
-              chalk.red(`  ✖ Failed to publish docs: ${error.message}`),
-            );
-          }
-        }
-      }
-    }
-  } else {
-    console.log(
-      chalk.yellow(
-        "  ⚠ Documentation publishing is disabled for this project.",
-      ),
-    );
-  }
-
-  // Stream C: Changelog
-  if (features.changelog === true) {
-    // Changelog requires platform (no BYOS support)
-    if (resolvedMode === "byos") {
-      console.log(chalk.cyan("\n📝 Changelog drafts...\n"));
-      console.log(
-        chalk.yellow(
-          "  ⚠ Changelog requires Reshot platform for tracking and publishing.",
-        ),
-      );
-      console.log(
-        chalk.gray("     Run 'reshot auth' to enable changelog generation."),
-      );
-    } else {
-      console.log(chalk.cyan("\n📝 Posting changelog drafts...\n"));
-      const lastPublishedHash = settings?.lastPublishedCommitHash;
-      const recentCommits = getRecentCommits(lastPublishedHash);
-
-      if (recentCommits.length > 0) {
-        try {
-          await apiClient.postChangelogDrafts(projectId, recentCommits, apiKey);
-          console.log(
-            chalk.green(
-              `  ✔ Posted ${recentCommits.length} changelog draft(s)`,
-            ),
-          );
-
-          // Update last published commit hash
-          if (settings) {
-            settings.lastPublishedCommitHash = commitHash;
-            config.writeSettings(settings);
-          }
-        } catch (error) {
-          console.log(
-            chalk.yellow(
-              `  ⚠ Failed to post changelog drafts: ${error.message}`,
-            ),
-          );
-        }
-      } else {
-        console.log(chalk.gray("  No new commits to publish"));
-      }
-    }
-  } else {
-    console.log(
-      chalk.yellow("  ⚠ Changelog publishing is disabled for this project."),
-    );
-  }
-
   // Print upgrade path for BYOS users
   if (resolvedMode === "byos") {
     console.log(chalk.cyan("\n💡 Upgrade to Reshot Platform for:"));
@@ -1700,7 +1660,7 @@ async function publishCommand(options = {}) {
     console.log(chalk.gray("   • Unbreakable URLs that never change"));
     console.log(chalk.gray("   • Version history and rollback"));
     console.log(chalk.gray("   • Team collaboration and RBAC"));
-    console.log(chalk.gray("   • Automatic changelog generation"));
+    console.log(chalk.gray("   • Drift detection and notifications"));
     console.log(chalk.gray("\n   Run 'reshot auth' to connect your project."));
   }
 
@@ -1715,7 +1675,14 @@ async function publishCommand(options = {}) {
 
   console.log();
 
-  return publishResult;
+  return {
+    ...publishResult,
+    success: publishResult.assetsFailed === 0 && publishResult.assetsProcessed > 0,
+  };
 }
 
 module.exports = publishCommand;
+module.exports.groupAssetsByScenario = groupAssetsByScenario;
+module.exports.resolveManifestScopedScreenshotFiles =
+  resolveManifestScopedScreenshotFiles;
+module.exports.collectAssetFilesFromDirectories = collectAssetFilesFromDirectories;