@reproapp/node-sdk 0.0.26 → 0.0.28

package/src/ingest/client.ts

@@ -56,6 +56,25 @@ export const kickIngestQueueDrain = (): void => {
     }
 };
 
+const isCriticalIngestEntry = (entry: LegacyEntry): boolean => (
+    entry.requestCaptureManifest !== undefined ||
+    entry.sessionCaptureManifest !== undefined ||
+    entry.request !== undefined ||
+    entry.db !== undefined ||
+    entry.trace !== undefined ||
+    entry.email !== undefined
+);
+
+const resolveBatchPriority = (
+    entries: LegacyEntry[],
+    options: EnqueueIngestOptions,
+): QueuedIngestBatch['priority'] => {
+    if (options.priority === 'high') {
+        return 'high';
+    }
+    return entries.some(isCriticalIngestEntry) ? 'high' : 'normal';
+};
+
 const resolveIngestUrl = (config: IngestClientConfig): string => {
     const envBase = typeof process !== 'undefined' ? (process as any)?.env?.REPRO_INGEST_BASE : undefined;
     const ingestBase = String(envBase || config.ingestBase || DEFAULT_INGEST_BASE).replace(/\/+$/, '');
@@ -185,7 +204,7 @@ const drainIngestQueue = async (): Promise<void> => {
             }
 
             batch.attempts += 1;
-            if (batch.attempts >= DEFAULT_QUEUE_MAX_ATTEMPTS) {
+            if (batch.attempts >= DEFAULT_QUEUE_MAX_ATTEMPTS && batch.priority !== 'high') {
                 ingestQueue.shift();
                 backoffMs = 0;
                 continue;
@@ -215,7 +234,7 @@ export const enqueueIngestEntries = (
     if (!sessionId || !Array.isArray(entries) || entries.length === 0) {
         return false;
     }
-    const priority = options.priority === 'high' ? 'high' : 'normal';
+    const priority = resolveBatchPriority(entries, options);
     const batch: QueuedIngestBatch = {
         config: { ...config },
         sessionId,
@@ -235,13 +254,16 @@ export const enqueueIngestEntries = (
     }
     if (DEFAULT_QUEUE_MAX_ITEMS > 0 && ingestQueue.length > DEFAULT_QUEUE_MAX_ITEMS) {
         while (ingestQueue.length > DEFAULT_QUEUE_MAX_ITEMS) {
-            let removeIndex = ingestQueue.length - 1;
+            let removeIndex = -1;
             for (let index = ingestQueue.length - 1; index >= 0; index -= 1) {
                 if (ingestQueue[index]?.priority !== 'high') {
                     removeIndex = index;
                     break;
                 }
             }
+            if (removeIndex === -1) {
+                break;
+            }
             ingestQueue.splice(removeIndex, 1);
         }
     }

package/test/ingest-critical-retention.test.js

@@ -0,0 +1,147 @@
+process.env.REPRO_INGEST_QUEUE_MAX_ITEMS = '3';
+
+const assert = require('assert');
+
+const originalFetch = global.fetch;
+const capturedBodies = [];
+
+global.fetch = async (_url, init = {}) => {
+    capturedBodies.push(JSON.parse(String(init.body || '{}')));
+    return {
+        ok: true,
+        status: 200,
+        json: async () => ({ ok: true }),
+        text: async () => '{"ok":true}',
+    };
+};
+
+const { enqueueIngestEntries, flushIngestQueue } = require('../dist/ingest/client');
+
+async function main() {
+    const cfg = {
+        tenantId: 'TENANT_test',
+        appId: 'APP_test',
+        appSecret: 'secret',
+        serviceName: 'critical-retention-test',
+        ingestBase: 'http://127.0.0.1:65535',
+    };
+    const sessionId = 'S_critical_retention';
+
+    for (let index = 0; index < 5; index += 1) {
+        enqueueIngestEntries(cfg, sessionId, [{
+            actionId: 'A_optional',
+            message: `optional-${index}`,
+            t: Date.now(),
+        }]);
+    }
+
+    const criticalEntries = [
+        {
+            actionId: 'A_critical',
+            request: {
+                rid: 'R_request',
+                method: 'GET',
+                url: '/critical-request',
+                status: 200,
+            },
+            t: Date.now(),
+        },
+        {
+            actionId: 'A_critical',
+            requestRid: 'R_trace',
+            trace: [{
+                t: Date.now(),
+                type: 'enter',
+                fn: 'criticalTrace',
+            }],
+            traceBatch: {
+                rid: 'R_trace',
+                index: 0,
+                total: 1,
+            },
+            t: Date.now(),
+        },
+        {
+            actionId: 'A_critical',
+            requestRid: 'R_db',
+            db: [{
+                collection: 'critical_collection',
+                op: 'findOne',
+            }],
+            t: Date.now(),
+        },
+        {
+            actionId: 'A_critical',
+            requestRid: 'R_email',
+            email: {
+                provider: 'critical-email',
+                subject: 'critical',
+            },
+            t: Date.now(),
+        },
+        {
+            actionId: 'A_critical',
+            requestRid: 'R_manifest',
+            requestCaptureManifest: {
+                scopeId: 'req:R_manifest',
+                requestRid: 'R_manifest',
+                transport: 'http',
+                expected: {
+                    backendRequest: 1,
+                    traceBatch: 0,
+                    dbChange: 0,
+                    emailEvent: 0,
+                },
+                closedAt: Date.now(),
+            },
+            t: Date.now(),
+        },
+        {
+            actionId: 'A_critical',
+            sessionCaptureManifest: {
+                mode: 'staging',
+                expected: {
+                    frontendActionDoc: 0,
+                    rrwebChunk: 0,
+                    frontendSessionEnd: 1,
+                },
+                closedAt: Date.now(),
+            },
+            t: Date.now(),
+        },
+    ];
+
+    for (const entry of criticalEntries) {
+        const enqueued = enqueueIngestEntries(cfg, sessionId, [entry]);
+        assert.strictEqual(enqueued, true, `critical event was dropped: ${JSON.stringify(Object.keys(entry))}`);
+    }
+
+    await flushIngestQueue();
+
+    const eventTypes = capturedBodies
+        .flatMap((body) => Array.isArray(body?.events) ? body.events : [])
+        .map((event) => event?.event_type)
+        .sort();
+
+    assert.deepStrictEqual(eventTypes, [
+        'backend_request',
+        'db_change',
+        'email_event',
+        'request_capture_manifest',
+        'session_capture_manifest',
+        'trace_batch',
+    ]);
+
+    // eslint-disable-next-line no-console
+    console.log('ingest critical retention OK');
+}
+
+main()
+    .catch((error) => {
+        // eslint-disable-next-line no-console
+        console.error(error);
+        process.exitCode = 1;
+    })
+    .finally(() => {
+        global.fetch = originalFetch;
+    });

package/test/ingest-critical-retry-retention.test.js

@@ -0,0 +1,57 @@
+const assert = require('assert');
+
+const originalFetch = global.fetch;
+let attempts = 0;
+
+global.fetch = async () => {
+    attempts += 1;
+    return {
+        ok: attempts > 6,
+        status: attempts > 6 ? 200 : 503,
+        json: async () => ({ ok: attempts > 6 }),
+        text: async () => attempts > 6 ? '{"ok":true}' : '{"ok":false}',
+    };
+};
+
+const { enqueueIngestEntries, flushIngestQueue } = require('../dist/ingest/client');
+
+async function main() {
+    const cfg = {
+        tenantId: 'TENANT_test',
+        appId: 'APP_test',
+        appSecret: 'secret',
+        serviceName: 'critical-retry-retention-test',
+        ingestBase: 'http://127.0.0.1:65535',
+    };
+
+    const enqueued = enqueueIngestEntries(cfg, 'S_critical_retry_retention', [{
+        actionId: 'A_critical_retry',
+        request: {
+            rid: 'R_critical_retry',
+            method: 'GET',
+            url: '/critical-retry',
+            status: 200,
+        },
+        t: Date.now(),
+    }]);
+    assert.strictEqual(enqueued, true);
+
+    for (let index = 0; index < 7; index += 1) {
+        await flushIngestQueue();
+    }
+
+    assert.strictEqual(attempts, 7, `critical batch was dropped before eventual success; attempts=${attempts}`);
+
+    // eslint-disable-next-line no-console
+    console.log('ingest critical retry retention OK');
+}
+
+main()
+    .catch((error) => {
+        // eslint-disable-next-line no-console
+        console.error(error);
+        process.exitCode = 1;
+    })
+    .finally(() => {
+        global.fetch = originalFetch;
+    });

package/test/ingest-high-priority-retention.test.js

@@ -0,0 +1,75 @@
+process.env.REPRO_INGEST_QUEUE_MAX_ITEMS = '3';
+
+const assert = require('assert');
+
+const originalFetch = global.fetch;
+const capturedBodies = [];
+
+global.fetch = async (_url, init = {}) => {
+    capturedBodies.push(JSON.parse(String(init.body || '{}')));
+    return {
+        ok: true,
+        status: 200,
+        json: async () => ({ ok: true }),
+        text: async () => '{"ok":true}',
+    };
+};
+
+const { enqueueIngestEntries, flushIngestQueue } = require('../dist/ingest/client');
+
+async function main() {
+    const cfg = {
+        tenantId: 'TENANT_test',
+        appId: 'APP_test',
+        appSecret: 'secret',
+        serviceName: 'high-priority-retention-test',
+        ingestBase: 'http://127.0.0.1:65535',
+    };
+    const sessionId = 'S_high_priority_retention';
+
+    for (let index = 0; index < 5; index += 1) {
+        const enqueued = enqueueIngestEntries(cfg, sessionId, [{
+            actionId: 'A_high_priority_retention',
+            requestRid: `R_high_priority_${index}`,
+            requestCaptureManifest: {
+                scopeId: `req:R_high_priority_${index}`,
+                requestRid: `R_high_priority_${index}`,
+                transport: 'http',
+                expected: {
+                    backendRequest: 1,
+                    traceBatch: 0,
+                    dbChange: 0,
+                    emailEvent: 0,
+                },
+                closedAt: Date.now(),
+            },
+            t: Date.now(),
+        }], { priority: 'high' });
+        assert.strictEqual(enqueued, true, `high-priority batch ${index} was dropped`);
+    }
+
+    await flushIngestQueue();
+
+    const manifests = capturedBodies
+        .flatMap((body) => Array.isArray(body?.events) ? body.events : [])
+        .filter((event) => event?.event_type === 'request_capture_manifest');
+
+    assert.strictEqual(manifests.length, 5, JSON.stringify({
+        got: manifests.length,
+        expected: 5,
+        requestIds: manifests.map((event) => event?.request_id),
+    }));
+
+    // eslint-disable-next-line no-console
+    console.log('ingest high priority retention OK');
+}
+
+main()
+    .catch((error) => {
+        // eslint-disable-next-line no-console
+        console.error(error);
+        process.exitCode = 1;
+    })
+    .finally(() => {
+        global.fetch = originalFetch;
+    });